Re: [PR] fix: Pylint errors on master [superset]
mistercrunch commented on PR #27710: URL: https://github.com/apache/superset/pull/27710#issuecomment-2024184230 The workflow at .github/workflows/superset-python-misc.yml will only run if files in `superset/**` are touched. So when dependabot / supersetbot bumps a linting lib like this we should touch a file in the folder to trigger it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] fix: Pylint errors on master [superset]
john-bodley commented on PR #27710: URL: https://github.com/apache/superset/pull/27710#issuecomment-2024136766 @betodealmeida regarding your [comment](https://github.com/apache/superset/pull/27710#issuecomment-2023952799), the only explanation I can think of is that either for the PR which bumped `pylint`: - The relevant CI checks did not run/block*. - The code in `master` had evolved between the time the CI checks ran and the PR was merged. \* Per https://github.com/apache/superset/pull/27574 we had previously identified issues were certain GitHub checks weren't marked as required. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] fix: Pylint errors on master [superset]
betodealmeida commented on PR #27710: URL: https://github.com/apache/superset/pull/27710#issuecomment-2023952799 @michael-s-molina do we know what caused this to become a problem? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] fix: Pylint errors on master [superset]
michael-s-molina merged PR #27710: URL: https://github.com/apache/superset/pull/27710 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
Re: [PR] fix: Pylint errors on master [superset]
codecov[bot] commented on PR #27710: URL: https://github.com/apache/superset/pull/27710#issuecomment-2023225296 ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/27710?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 60.03%. Comparing base [(`349e496`)](https://app.codecov.io/gh/apache/superset/commit/349e496da519f3462aa5cff2d1bd76490b04fe5d?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) to head [(`281babf`)](https://app.codecov.io/gh/apache/superset/pull/27710?dropdown=coverage=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). > Report is 3 commits behind head on master. Additional details and impacted files ```diff @@Coverage Diff @@ ## master #27710 +/- ## == - Coverage 69.77% 60.03% -9.75% == Files1911 1911 Lines 7505675060 +4 Branches 8362 8362 == - Hits5237445062-7312 - Misses 2063027946+7316 Partials 2052 2052 ``` | [Flag](https://app.codecov.io/gh/apache/superset/pull/27710/flags?src=pr=flags_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Coverage Δ | | |---|---|---| | [hive](https://app.codecov.io/gh/apache/superset/pull/27710/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `48.93% <100.00%> (?)` | | | [mysql](https://app.codecov.io/gh/apache/superset/pull/27710/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `?` | | | [postgres](https://app.codecov.io/gh/apache/superset/pull/27710/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `?` | | | [presto](https://app.codecov.io/gh/apache/superset/pull/27710/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `53.64% <100.00%> (?)` | | | [python](https://app.codecov.io/gh/apache/superset/pull/27710/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `62.75% <100.00%> (-20.17%)` | :arrow_down: | | [sqlite](https://app.codecov.io/gh/apache/superset/pull/27710/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `?` | | | [unit](https://app.codecov.io/gh/apache/superset/pull/27710/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `56.76% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset/pull/27710?dropdown=coverage=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
