[jira] [Commented] (YETUS-163) parameterize site for releases

2015-11-18 Thread Allen Wittenauer (JIRA)

[ 
https://issues.apache.org/jira/browse/YETUS-163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15011583#comment-15011583
 ] 

Allen Wittenauer commented on YETUS-163:


https://builds.apache.org/job/PreCommit-yetus-Build/104/console

{code}
HEAD is now at eb90f14 YETUS-176. hadoop: mvn site tests aren't getting run
Switched to a new branch 'master'
Branch master set up to track remote branch master from origin.
Current branch master is up to date.
Already on 'master'
Your branch is up-to-date with 'origin/master'.
Current branch master is up to date.
ERROR: YETUS-163 does not apply to master.
{code}

Argh.

> parameterize site for releases
> --
>
> Key: YETUS-163
> URL: https://issues.apache.org/jira/browse/YETUS-163
> Project: Yetus
>  Issue Type: Improvement
>  Components: website and documentation
>Affects Versions: 0.1.0
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Blocker
> Attachments: YETUS-163.0.patch, YETUS-163.1.patch, YETUS-163.2.patch
>
>
> our site needs to handle having releases, i.e. downloads and version specific 
> documentation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (YETUS-163) parameterize site for releases

2015-11-18 Thread Yetus QA (JIRA)

[ 
https://issues.apache.org/jira/browse/YETUS-163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15011645#comment-15011645
 ] 

Yetus QA commented on YETUS-163:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s 
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s 
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} rubocop {color} | {color:red} 0m 3s 
{color} | {color:red} The applied patch generated 6 new rubocop issues (total 
was 34, now 40). {color} |
| {color:red}-1{color} | {color:red} ruby-lint {color} | {color:red} 0m 1s 
{color} | {color:red} The applied patch generated 2 new ruby-lint issues (total 
was 19, now 21). {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 
0s {color} | {color:green} Patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 14m 45s {color} 
| {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.7.1 Server=1.7.1 Image:yetus/yetus:577e74f |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12772934/YETUS-163.2.patch |
| JIRA Issue | YETUS-163 |
| Optional Tests |  rubocop  ruby_lint  |
| uname | Linux f62efcab020a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed 
Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | nobuild |
| git revision | master / 6326841 |
| rubocop | v0.35.1 |
| rubocop | 
https://builds.apache.org/job/PreCommit-YETUS-Build/106/artifact/patchprocess/diff-patch-rubocop.txt
 |
| ruby-lint | v2.0.5 |
| ruby-lint | 
https://builds.apache.org/job/PreCommit-YETUS-Build/106/artifact/patchprocess/diff-patch-ruby-lint.txt
 |
| modules | C:  U:  |
| Powered by | Apache Yetus   http://yetus.apache.org |
| Console output | 
https://builds.apache.org/job/PreCommit-YETUS-Build/106/console |


This message was automatically generated.



> parameterize site for releases
> --
>
> Key: YETUS-163
> URL: https://issues.apache.org/jira/browse/YETUS-163
> Project: Yetus
>  Issue Type: Improvement
>  Components: website and documentation
>Affects Versions: 0.1.0
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Blocker
> Attachments: YETUS-163.0.patch, YETUS-163.1.patch, YETUS-163.2.patch
>
>
> our site needs to handle having releases, i.e. downloads and version specific 
> documentation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (YETUS-163) parameterize site for releases

2015-11-18 Thread Yetus QA (JIRA)

[ 
https://issues.apache.org/jira/browse/YETUS-163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15011605#comment-15011605
 ] 

Yetus QA commented on YETUS-163:


| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s 
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:blue}0{color} | {color:blue} rubocop {color} | {color:blue} 0m 0s 
{color} | {color:blue} Rubocop was not available. {color} |
| {color:blue}0{color} | {color:blue} ruby-lint {color} | {color:blue} 0m 0s 
{color} | {color:blue} Ruby-lint was not available. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 
1s {color} | {color:green} Patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 0m 4s {color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12772934/YETUS-163.2.patch |
| JIRA Issue | YETUS-163 |
| Optional Tests |  asflicense  rubocop  ruby_lint  |
| uname | Linux penates.apache.org 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT 
Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | nobuild |
| git revision | master / 6326841 |
| modules | C:  U:  |
| Powered by | Apache Yetus   http://yetus.apache.org |
| Console output | 
https://builds.apache.org/job/PreCommit-YETUS-Build/105/console |


This message was automatically generated.



> parameterize site for releases
> --
>
> Key: YETUS-163
> URL: https://issues.apache.org/jira/browse/YETUS-163
> Project: Yetus
>  Issue Type: Improvement
>  Components: website and documentation
>Affects Versions: 0.1.0
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Blocker
> Attachments: YETUS-163.0.patch, YETUS-163.1.patch, YETUS-163.2.patch
>
>
> our site needs to handle having releases, i.e. downloads and version specific 
> documentation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (YETUS-186) non-existent dockerfile should fail or fallback

2015-11-18 Thread Allen Wittenauer (JIRA)

 [ 
https://issues.apache.org/jira/browse/YETUS-186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Allen Wittenauer reassigned YETUS-186:
--

Assignee: Allen Wittenauer

> non-existent dockerfile should fail or fallback
> ---
>
> Key: YETUS-186
> URL: https://issues.apache.org/jira/browse/YETUS-186
> Project: Yetus
>  Issue Type: Bug
>  Components: Test Patch
>Reporter: Allen Wittenauer
>Assignee: Allen Wittenauer
>Priority: Blocker
>
> This is a long standing bug that I just now noticed. :(  If the 
> \-\-dockerfile param points to a file that doesn't actually exist, bad things 
> happen.  Which particular bad thing depends greatly upon what other images 
> are already installed, but the vast majority end up with a stuck container at 
> a bash prompt.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (YETUS-143) add support for JMeter

2015-11-18 Thread Allen Wittenauer (JIRA)

 [ 
https://issues.apache.org/jira/browse/YETUS-143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Allen Wittenauer updated YETUS-143:
---
Issue Type: New Feature  (was: Improvement)

> add support for JMeter
> --
>
> Key: YETUS-143
> URL: https://issues.apache.org/jira/browse/YETUS-143
> Project: Yetus
>  Issue Type: New Feature
>  Components: Test Patch
>Reporter: Kengo Seki
>Assignee: Kengo Seki
>Priority: Minor
> Fix For: 0.1.0
>
> Attachments: YETUS-143.00.patch
>
>
> It's incomplete, but it might be useful in some cases, such as a personality 
> example or to test bugzilla plugin.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (YETUS-26) rebrand for yetus

2015-11-18 Thread Allen Wittenauer (JIRA)

 [ 
https://issues.apache.org/jira/browse/YETUS-26?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Allen Wittenauer updated YETUS-26:
--
Issue Type: Improvement  (was: New Feature)

> rebrand for yetus
> -
>
> Key: YETUS-26
> URL: https://issues.apache.org/jira/browse/YETUS-26
> Project: Yetus
>  Issue Type: Improvement
>  Components: Test Patch
>Reporter: Allen Wittenauer
>Assignee: Allen Wittenauer
> Fix For: 0.1.0
>
> Attachments: YETUS-26.00.patch, YETUS-26.01.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (YETUS-77) add bugzilla support

2015-11-18 Thread Allen Wittenauer (JIRA)

 [ 
https://issues.apache.org/jira/browse/YETUS-77?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Allen Wittenauer updated YETUS-77:
--
Issue Type: New Feature  (was: Bug)

> add bugzilla support
> 
>
> Key: YETUS-77
> URL: https://issues.apache.org/jira/browse/YETUS-77
> Project: Yetus
>  Issue Type: New Feature
>  Components: Test Patch
>Reporter: Allen Wittenauer
>Assignee: Allen Wittenauer
> Fix For: 0.1.0
>
> Attachments: YETUS-77.00.patch, YETUS-77.01.patch, YETUS-77.02.patch, 
> YETUS-77.03.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (YETUS-170) hadoop mvninstall should run on parent directories of changed modules

2015-11-18 Thread Vinayakumar B (JIRA)

 [ 
https://issues.apache.org/jira/browse/YETUS-170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vinayakumar B updated YETUS-170:

Attachment: YETUS-170-02.patch

Attaching the patch making all modules in 'mvn install' execution order.

> hadoop mvninstall should run on parent directories of changed modules
> -
>
> Key: YETUS-170
> URL: https://issues.apache.org/jira/browse/YETUS-170
> Project: Yetus
>  Issue Type: Bug
>Reporter: Vinayakumar B
>Assignee: Vinayakumar B
> Attachments: YETUS-170-01.patch, YETUS-170-02.patch
>
>
> https://builds.apache.org/job/PreCommit-HDFS-Build/13397/console
> If the patch contains multiple modules changed, then mvn install is expected 
> to run in order of dependency.
> For example, if hadoop-hdfs and hadoop-hdfs-client is changed, then 
> hadoop-hdfs-client is expected to run first and then hadoop-hdfs. 
> Instead, can run mvn install on parent of both these modules. Same is done 
> for 'compile', but not for 'mvninstall'
> This Jira proposes to run mvninstall for hadoop on parent of changed modules 
> (union)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (YETUS-170) hadoop mvninstall should run on parent directories of changed modules

2015-11-18 Thread Yetus QA (JIRA)

[ 
https://issues.apache.org/jira/browse/YETUS-170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15011903#comment-15011903
 ] 

Yetus QA commented on YETUS-170:


(!) A patch to the testing environment has been detected. 
Re-executing against the patched versions to perform further tests. 
The console is at 
https://builds.apache.org/job/PreCommit-YETUS-Build/107/console in case of 
problems.


> hadoop mvninstall should run on parent directories of changed modules
> -
>
> Key: YETUS-170
> URL: https://issues.apache.org/jira/browse/YETUS-170
> Project: Yetus
>  Issue Type: Bug
>Reporter: Vinayakumar B
>Assignee: Vinayakumar B
> Attachments: YETUS-170-01.patch, YETUS-170-02.patch
>
>
> https://builds.apache.org/job/PreCommit-HDFS-Build/13397/console
> If the patch contains multiple modules changed, then mvn install is expected 
> to run in order of dependency.
> For example, if hadoop-hdfs and hadoop-hdfs-client is changed, then 
> hadoop-hdfs-client is expected to run first and then hadoop-hdfs. 
> Instead, can run mvn install on parent of both these modules. Same is done 
> for 'compile', but not for 'mvninstall'
> This Jira proposes to run mvninstall for hadoop on parent of changed modules 
> (union)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (YETUS-170) hadoop mvninstall should run on parent directories of changed modules

2015-11-18 Thread Yetus QA (JIRA)

[ 
https://issues.apache.org/jira/browse/YETUS-170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15011904#comment-15011904
 ] 

Yetus QA commented on YETUS-170:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s 
{color} | {color:blue} Precommit patch detected. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s 
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} shellcheck {color} | {color:red} 0m 0s 
{color} | {color:red} The applied patch generated 5 new shellcheck issues 
(total was 0, now 5). {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 
2s {color} | {color:green} Patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 0m 10s {color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12773068/YETUS-170-02.patch |
| JIRA Issue | YETUS-170 |
| Optional Tests |  asflicense  shellcheck  |
| uname | Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP 
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | nobuild |
| git revision | master / 6326841 |
| shellcheck | v0.3.3 (This is an old version that has serious bugs. Consider 
upgrading.) |
| shellcheck | 
https://builds.apache.org/job/PreCommit-YETUS-Build/107/artifact/patchprocess/diff-patch-shellcheck.txt
 |
| modules | C:  U:  |
| Powered by | Apache Yetus   http://yetus.apache.org |
| Console output | 
https://builds.apache.org/job/PreCommit-YETUS-Build/107/console |


This message was automatically generated.



> hadoop mvninstall should run on parent directories of changed modules
> -
>
> Key: YETUS-170
> URL: https://issues.apache.org/jira/browse/YETUS-170
> Project: Yetus
>  Issue Type: Bug
>Reporter: Vinayakumar B
>Assignee: Vinayakumar B
> Attachments: YETUS-170-01.patch, YETUS-170-02.patch
>
>
> https://builds.apache.org/job/PreCommit-HDFS-Build/13397/console
> If the patch contains multiple modules changed, then mvn install is expected 
> to run in order of dependency.
> For example, if hadoop-hdfs and hadoop-hdfs-client is changed, then 
> hadoop-hdfs-client is expected to run first and then hadoop-hdfs. 
> Instead, can run mvn install on parent of both these modules. Same is done 
> for 'compile', but not for 'mvninstall'
> This Jira proposes to run mvninstall for hadoop on parent of changed modules 
> (union)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (YETUS-189) shelldocs ignoring --skipprnorep

2015-11-18 Thread Sean Busbey (JIRA)

[ 
https://issues.apache.org/jira/browse/YETUS-189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15010450#comment-15010450
 ] 

Sean Busbey commented on YETUS-189:
---

for example, see the core page: 
http://yetus.apache.org/documentation/in-progress/precommit-apidocs/core/

includes e.g. {{generic_locate_patch}}

> shelldocs ignoring --skipprnorep
> 
>
> Key: YETUS-189
> URL: https://issues.apache.org/jira/browse/YETUS-189
> Project: Yetus
>  Issue Type: Bug
>  Components: ShellDocs
>Affects Versions: 0.1.0
>Reporter: Sean Busbey
>Priority: Critical
>
> when building our site docs for precommit via shelldocs, we pass the 
> {{--skipprnorep}} flag, but the results still contain private methods.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (YETUS-81) Publish generated apidocs on website

2015-11-18 Thread Sean Busbey (JIRA)

[ 
https://issues.apache.org/jira/browse/YETUS-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15010442#comment-15010442
 ] 

Sean Busbey commented on YETUS-81:
--

applied with whitespace=fix, filed YETUS-188 for the extra whitespace getting 
generated at all, pushed, and updated the site.

thanks for the review!

> Publish generated apidocs on website
> 
>
> Key: YETUS-81
> URL: https://issues.apache.org/jira/browse/YETUS-81
> Project: Yetus
>  Issue Type: Improvement
>  Components: Audience Annotations, Test Patch, website and 
> documentation
>Affects Versions: 0.1.0
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Critical
> Attachments: YETUS-81.0.patch, YETUS-81.1.patch
>
>
> we should publish the javadocs for the IA.Public parts of the project.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (YETUS-170) hadoop mvninstall should run on parent directories of changed modules

2015-11-18 Thread Vinayakumar B (JIRA)

 [ 
https://issues.apache.org/jira/browse/YETUS-170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vinayakumar B updated YETUS-170:

Attachment: YETUS-170-03.patch

Fixed shellcheck issues

> hadoop mvninstall should run on parent directories of changed modules
> -
>
> Key: YETUS-170
> URL: https://issues.apache.org/jira/browse/YETUS-170
> Project: Yetus
>  Issue Type: Bug
>Reporter: Vinayakumar B
>Assignee: Vinayakumar B
> Attachments: YETUS-170-01.patch, YETUS-170-02.patch, 
> YETUS-170-03.patch
>
>
> https://builds.apache.org/job/PreCommit-HDFS-Build/13397/console
> If the patch contains multiple modules changed, then mvn install is expected 
> to run in order of dependency.
> For example, if hadoop-hdfs and hadoop-hdfs-client is changed, then 
> hadoop-hdfs-client is expected to run first and then hadoop-hdfs. 
> Instead, can run mvn install on parent of both these modules. Same is done 
> for 'compile', but not for 'mvninstall'
> This Jira proposes to run mvninstall for hadoop on parent of changed modules 
> (union)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (YETUS-170) hadoop mvninstall should run on parent directories of changed modules

2015-11-18 Thread Yetus QA (JIRA)

[ 
https://issues.apache.org/jira/browse/YETUS-170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15012150#comment-15012150
 ] 

Yetus QA commented on YETUS-170:


| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s 
{color} | {color:blue} Precommit patch detected. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s 
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m 
0s {color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 
0s {color} | {color:green} Patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 0m 6s {color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12773090/YETUS-170-03.patch |
| JIRA Issue | YETUS-170 |
| Optional Tests |  asflicense  shellcheck  |
| uname | Linux penates.apache.org 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT 
Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | nobuild |
| git revision | master / 6326841 |
| shellcheck | v0.3.3 (This is an old version that has serious bugs. Consider 
upgrading.) |
| modules | C:  U:  |
| Powered by | Apache Yetus   http://yetus.apache.org |
| Console output | 
https://builds.apache.org/job/PreCommit-YETUS-Build/109/console |


This message was automatically generated.



> hadoop mvninstall should run on parent directories of changed modules
> -
>
> Key: YETUS-170
> URL: https://issues.apache.org/jira/browse/YETUS-170
> Project: Yetus
>  Issue Type: Bug
>Reporter: Vinayakumar B
>Assignee: Vinayakumar B
> Attachments: YETUS-170-01.patch, YETUS-170-02.patch, 
> YETUS-170-03.patch
>
>
> https://builds.apache.org/job/PreCommit-HDFS-Build/13397/console
> If the patch contains multiple modules changed, then mvn install is expected 
> to run in order of dependency.
> For example, if hadoop-hdfs and hadoop-hdfs-client is changed, then 
> hadoop-hdfs-client is expected to run first and then hadoop-hdfs. 
> Instead, can run mvn install on parent of both these modules. Same is done 
> for 'compile', but not for 'mvninstall'
> This Jira proposes to run mvninstall for hadoop on parent of changed modules 
> (union)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (YETUS-170) hadoop mvninstall should run on parent directories of changed modules

2015-11-18 Thread Yetus QA (JIRA)

[ 
https://issues.apache.org/jira/browse/YETUS-170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15012148#comment-15012148
 ] 

Yetus QA commented on YETUS-170:


(!) A patch to the testing environment has been detected. 
Re-executing against the patched versions to perform further tests. 
The console is at 
https://builds.apache.org/job/PreCommit-YETUS-Build/109/console in case of 
problems.


> hadoop mvninstall should run on parent directories of changed modules
> -
>
> Key: YETUS-170
> URL: https://issues.apache.org/jira/browse/YETUS-170
> Project: Yetus
>  Issue Type: Bug
>Reporter: Vinayakumar B
>Assignee: Vinayakumar B
> Attachments: YETUS-170-01.patch, YETUS-170-02.patch, 
> YETUS-170-03.patch
>
>
> https://builds.apache.org/job/PreCommit-HDFS-Build/13397/console
> If the patch contains multiple modules changed, then mvn install is expected 
> to run in order of dependency.
> For example, if hadoop-hdfs and hadoop-hdfs-client is changed, then 
> hadoop-hdfs-client is expected to run first and then hadoop-hdfs. 
> Instead, can run mvn install on parent of both these modules. Same is done 
> for 'compile', but not for 'mvninstall'
> This Jira proposes to run mvninstall for hadoop on parent of changed modules 
> (union)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (YETUS-154) Specifying help option before plugins option hides plugin-specific help messages

2015-11-18 Thread Yetus QA (JIRA)

[ 
https://issues.apache.org/jira/browse/YETUS-154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15012519#comment-15012519
 ] 

Yetus QA commented on YETUS-154:


| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s 
{color} | {color:blue} Precommit patch detected. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s 
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m 
1s {color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 
1s {color} | {color:green} Patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 0m 9s {color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12773130/YETUS-154.00.patch |
| JIRA Issue | YETUS-154 |
| Optional Tests |  asflicense  shellcheck  |
| uname | Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP 
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | nobuild |
| git revision | master / 6326841 |
| shellcheck | v0.3.3 (This is an old version that has serious bugs. Consider 
upgrading.) |
| modules | C:  U:  |
| Powered by | Apache Yetus   http://yetus.apache.org |
| Console output | 
https://builds.apache.org/job/PreCommit-YETUS-Build/111/console |


This message was automatically generated.



> Specifying help option before plugins option hides plugin-specific help 
> messages
> 
>
> Key: YETUS-154
> URL: https://issues.apache.org/jira/browse/YETUS-154
> Project: Yetus
>  Issue Type: Bug
>  Components: Test Patch
>Reporter: Kengo Seki
>Assignee: Marco Zühlke
>Priority: Trivial
> Attachments: YETUS-154.00.patch
>
>
> {{precommit/test-patch.sh --plugins=all --help}} shows all plugin options, 
> but {{precommit/test-patch.sh --help --plugins=all}} doesn't.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (YETUS-154) Specifying help option before plugins option hides plugin-specific help messages

2015-11-18 Thread Yetus QA (JIRA)

[ 
https://issues.apache.org/jira/browse/YETUS-154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15012517#comment-15012517
 ] 

Yetus QA commented on YETUS-154:


(!) A patch to the testing environment has been detected. 
Re-executing against the patched versions to perform further tests. 
The console is at 
https://builds.apache.org/job/PreCommit-YETUS-Build/111/console in case of 
problems.


> Specifying help option before plugins option hides plugin-specific help 
> messages
> 
>
> Key: YETUS-154
> URL: https://issues.apache.org/jira/browse/YETUS-154
> Project: Yetus
>  Issue Type: Bug
>  Components: Test Patch
>Reporter: Kengo Seki
>Assignee: Marco Zühlke
>Priority: Trivial
> Attachments: YETUS-154.00.patch
>
>
> {{precommit/test-patch.sh --plugins=all --help}} shows all plugin options, 
> but {{precommit/test-patch.sh --help --plugins=all}} doesn't.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (YETUS-171) patches that don't apply are not getting reported back to JIRA

2015-11-18 Thread Sean Busbey (JIRA)

[ 
https://issues.apache.org/jira/browse/YETUS-171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15012473#comment-15012473
 ] 

Sean Busbey commented on YETUS-171:
---

Sounds good. Can we incorporate the ticket for pointing folks to naming 
guidelines in the same check?

> patches that don't apply are not getting reported back to JIRA
> --
>
> Key: YETUS-171
> URL: https://issues.apache.org/jira/browse/YETUS-171
> Project: Yetus
>  Issue Type: Bug
>  Components: Test Patch
>Reporter: Allen Wittenauer
>Assignee: Allen Wittenauer
>Priority: Blocker
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (YETUS-171) patches that don't apply are not getting reported back to JIRA

2015-11-18 Thread Allen Wittenauer (JIRA)

[ 
https://issues.apache.org/jira/browse/YETUS-171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15012625#comment-15012625
 ] 

Allen Wittenauer commented on YETUS-171:


Yeah.  I was going to throw in rebasing too.

But, some good news: the more I dig into this, it looks like a case of failing 
to catch an error thrown upstream in the JIRA code.  So fixing this is easy.

HOWEVER!

I've discovered by accident that git 1.7.1 (at least that's what's on my centos 
6 VM) always returns 0 during a git apply. Want to apply a PDF to your repo? 
git apply will happily report success.

So... yeah. 


> patches that don't apply are not getting reported back to JIRA
> --
>
> Key: YETUS-171
> URL: https://issues.apache.org/jira/browse/YETUS-171
> Project: Yetus
>  Issue Type: Bug
>  Components: Test Patch
>Reporter: Allen Wittenauer
>Assignee: Allen Wittenauer
>Priority: Blocker
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (YETUS-186) non-existent dockerfile should fail or fallback

2015-11-18 Thread Allen Wittenauer (JIRA)

 [ 
https://issues.apache.org/jira/browse/YETUS-186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Allen Wittenauer updated YETUS-186:
---
Attachment: YETUS-186.00.patch

-00:
* make what we do on docker and dockerfile failure a bit more configurable. 
users can pick between any and all on continue, fallback, and fail.  See the 
doc change for more info.
* re-arranged some of the docker initialization bits around

> non-existent dockerfile should fail or fallback
> ---
>
> Key: YETUS-186
> URL: https://issues.apache.org/jira/browse/YETUS-186
> Project: Yetus
>  Issue Type: Bug
>  Components: Test Patch
>Reporter: Allen Wittenauer
>Assignee: Allen Wittenauer
>Priority: Blocker
> Attachments: YETUS-186.00.patch
>
>
> This is a long standing bug that I just now noticed. :(  If the 
> \-\-dockerfile param points to a file that doesn't actually exist, bad things 
> happen.  Which particular bad thing depends greatly upon what other images 
> are already installed, but the vast majority end up with a stuck container at 
> a bash prompt.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (YETUS-186) non-existent dockerfile should fail or fallback

2015-11-18 Thread Yetus QA (JIRA)

[ 
https://issues.apache.org/jira/browse/YETUS-186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15012415#comment-15012415
 ] 

Yetus QA commented on YETUS-186:


(!) A patch to the testing environment has been detected. 
Re-executing against the patched versions to perform further tests. 
The console is at 
https://builds.apache.org/job/PreCommit-YETUS-Build/110/console in case of 
problems.


> non-existent dockerfile should fail or fallback
> ---
>
> Key: YETUS-186
> URL: https://issues.apache.org/jira/browse/YETUS-186
> Project: Yetus
>  Issue Type: Bug
>  Components: Test Patch
>Reporter: Allen Wittenauer
>Assignee: Allen Wittenauer
>Priority: Blocker
> Attachments: YETUS-186.00.patch
>
>
> This is a long standing bug that I just now noticed. :(  If the 
> \-\-dockerfile param points to a file that doesn't actually exist, bad things 
> happen.  Which particular bad thing depends greatly upon what other images 
> are already installed, but the vast majority end up with a stuck container at 
> a bash prompt.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (YETUS-170) hadoop mvninstall should run on parent directories of changed modules

2015-11-18 Thread Yetus QA (JIRA)

[ 
https://issues.apache.org/jira/browse/YETUS-170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15012140#comment-15012140
 ] 

Yetus QA commented on YETUS-170:


| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s 
{color} | {color:blue} Precommit patch detected. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s 
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m 
0s {color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 
1s {color} | {color:green} Patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 0m 7s {color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12773090/YETUS-170-03.patch |
| JIRA Issue | YETUS-170 |
| Optional Tests |  asflicense  shellcheck  |
| uname | Linux penates.apache.org 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT 
Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | nobuild |
| git revision | master / 6326841 |
| shellcheck | v0.3.3 (This is an old version that has serious bugs. Consider 
upgrading.) |
| modules | C:  U:  |
| Powered by | Apache Yetus   http://yetus.apache.org |
| Console output | 
https://builds.apache.org/job/PreCommit-YETUS-Build/108/console |


This message was automatically generated.



> hadoop mvninstall should run on parent directories of changed modules
> -
>
> Key: YETUS-170
> URL: https://issues.apache.org/jira/browse/YETUS-170
> Project: Yetus
>  Issue Type: Bug
>Reporter: Vinayakumar B
>Assignee: Vinayakumar B
> Attachments: YETUS-170-01.patch, YETUS-170-02.patch, 
> YETUS-170-03.patch
>
>
> https://builds.apache.org/job/PreCommit-HDFS-Build/13397/console
> If the patch contains multiple modules changed, then mvn install is expected 
> to run in order of dependency.
> For example, if hadoop-hdfs and hadoop-hdfs-client is changed, then 
> hadoop-hdfs-client is expected to run first and then hadoop-hdfs. 
> Instead, can run mvn install on parent of both these modules. Same is done 
> for 'compile', but not for 'mvninstall'
> This Jira proposes to run mvninstall for hadoop on parent of changed modules 
> (union)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (YETUS-170) hadoop mvninstall should run on parent directories of changed modules

2015-11-18 Thread Yetus QA (JIRA)

[ 
https://issues.apache.org/jira/browse/YETUS-170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15012139#comment-15012139
 ] 

Yetus QA commented on YETUS-170:


(!) A patch to the testing environment has been detected. 
Re-executing against the patched versions to perform further tests. 
The console is at 
https://builds.apache.org/job/PreCommit-YETUS-Build/108/console in case of 
problems.


> hadoop mvninstall should run on parent directories of changed modules
> -
>
> Key: YETUS-170
> URL: https://issues.apache.org/jira/browse/YETUS-170
> Project: Yetus
>  Issue Type: Bug
>Reporter: Vinayakumar B
>Assignee: Vinayakumar B
> Attachments: YETUS-170-01.patch, YETUS-170-02.patch, 
> YETUS-170-03.patch
>
>
> https://builds.apache.org/job/PreCommit-HDFS-Build/13397/console
> If the patch contains multiple modules changed, then mvn install is expected 
> to run in order of dependency.
> For example, if hadoop-hdfs and hadoop-hdfs-client is changed, then 
> hadoop-hdfs-client is expected to run first and then hadoop-hdfs. 
> Instead, can run mvn install on parent of both these modules. Same is done 
> for 'compile', but not for 'mvninstall'
> This Jira proposes to run mvninstall for hadoop on parent of changed modules 
> (union)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (YETUS-171) patches that don't apply are not getting reported back to JIRA

2015-11-18 Thread Allen Wittenauer (JIRA)

[ 
https://issues.apache.org/jira/browse/YETUS-171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15012434#comment-15012434
 ] 

Allen Wittenauer commented on YETUS-171:


I think what we can do is introduce the guess patch file thing back, but 
"reverse the polarity" a bit.  If we are pretty sure it is a patch file and it 
doesn't apply, then fire off a message.  That catches a *LOT* of patch files, 
so while it won't be 100%, something is better than nothing.

> patches that don't apply are not getting reported back to JIRA
> --
>
> Key: YETUS-171
> URL: https://issues.apache.org/jira/browse/YETUS-171
> Project: Yetus
>  Issue Type: Bug
>  Components: Test Patch
>Reporter: Allen Wittenauer
>Assignee: Allen Wittenauer
>Priority: Blocker
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (YETUS-170) hadoop mvninstall should run on parent directories of changed modules

2015-11-18 Thread Sean Busbey (JIRA)

[ 
https://issues.apache.org/jira/browse/YETUS-170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15012813#comment-15012813
 ] 

Sean Busbey commented on YETUS-170:
---

{code}
+  full_ordered_hadoop_modules=
...
+  for module in $( echo "${full_ordered_hadoop_modules}" | tr ' ' '\n'); do
{code}

nit: can we make this an array?

it would look like

{code}
example=(foo
 bar
 "cats oh")
for dee in "${example[@]}"; do
  echo "${dee}"
done
{code}

{code}
+function check_module_present
+{
+  local changed_modules=${1}
+  local module_to_check=${2}
+
+  for module in $( echo "${changed_modules}" | tr ' ' '\n' ); do
+ if [[ "${module}" = "${module_to_check}" ]]; then
+   return 0;
+ fi
+  done
+  return 1;
+}
{code}

this approach won't work for module names with spaces in them. I'm not sure it 
matters for Hadoop. We should at least note the limitation. If you want to work 
around it, take the module to check as the first argument and then treat the 
rest of the arguments as the array of changed modules.

e.g.

{code}
function check_args {
  local needle=${1}
  shift
  for hay in "${@}"; do
if [[ ${needle} = "${hay}" ]]; then
  return 0
fi
  done
  return 1
}
{code}

!but! if we're not going to worry about modules with spaces in the name, then 
this function can be replaced with substring matching.

i.e.

{code}
if [[ "${passed_modules}" == *" ${module} "* ]]; then
{code}

> hadoop mvninstall should run on parent directories of changed modules
> -
>
> Key: YETUS-170
> URL: https://issues.apache.org/jira/browse/YETUS-170
> Project: Yetus
>  Issue Type: Bug
>Reporter: Vinayakumar B
>Assignee: Vinayakumar B
> Attachments: YETUS-170-01.patch, YETUS-170-02.patch, 
> YETUS-170-03.patch
>
>
> https://builds.apache.org/job/PreCommit-HDFS-Build/13397/console
> If the patch contains multiple modules changed, then mvn install is expected 
> to run in order of dependency.
> For example, if hadoop-hdfs and hadoop-hdfs-client is changed, then 
> hadoop-hdfs-client is expected to run first and then hadoop-hdfs. 
> Instead, can run mvn install on parent of both these modules. Same is done 
> for 'compile', but not for 'mvninstall'
> This Jira proposes to run mvninstall for hadoop on parent of changed modules 
> (union)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (YETUS-171) patches that don't apply are not getting reported back to JIRA

2015-11-18 Thread Sean Busbey (JIRA)

[ 
https://issues.apache.org/jira/browse/YETUS-171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15012890#comment-15012890
 ] 

Sean Busbey commented on YETUS-171:
---

+1 fine to fix shellcheck false-positive with disable before commit.

> patches that don't apply are not getting reported back to JIRA
> --
>
> Key: YETUS-171
> URL: https://issues.apache.org/jira/browse/YETUS-171
> Project: Yetus
>  Issue Type: Bug
>  Components: Test Patch
>Reporter: Allen Wittenauer
>Assignee: Allen Wittenauer
>Priority: Blocker
> Attachments: YETUS-171.00.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (YETUS-154) Specifying help option before plugins option hides plugin-specific help messages

2015-11-18 Thread JIRA

 [ 
https://issues.apache.org/jira/browse/YETUS-154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marco Zühlke updated YETUS-154:
---
Attachment: YETUS-154.00.patch

> Specifying help option before plugins option hides plugin-specific help 
> messages
> 
>
> Key: YETUS-154
> URL: https://issues.apache.org/jira/browse/YETUS-154
> Project: Yetus
>  Issue Type: Bug
>  Components: Test Patch
>Reporter: Kengo Seki
>Priority: Trivial
> Attachments: YETUS-154.00.patch
>
>
> {{precommit/test-patch.sh --plugins=all --help}} shows all plugin options, 
> but {{precommit/test-patch.sh --help --plugins=all}} doesn't.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (YETUS-171) patches that don't apply are not getting reported back to JIRA

2015-11-18 Thread Allen Wittenauer (JIRA)

 [ 
https://issues.apache.org/jira/browse/YETUS-171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Allen Wittenauer updated YETUS-171:
---
Attachment: YETUS-171.00.patch

-00:
* exit immediately if git 1.7.3 or higher isn't being used
* re-arrange jira patch downloads so that testing works better
* expand the "can't apply" message to point to contribute page, mention rebase 
or wrong branch


> patches that don't apply are not getting reported back to JIRA
> --
>
> Key: YETUS-171
> URL: https://issues.apache.org/jira/browse/YETUS-171
> Project: Yetus
>  Issue Type: Bug
>  Components: Test Patch
>Reporter: Allen Wittenauer
>Assignee: Allen Wittenauer
>Priority: Blocker
> Attachments: YETUS-171.00.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (YETUS-186) non-existent dockerfile should fail or fallback

2015-11-18 Thread Sean Busbey (JIRA)

[ 
https://issues.apache.org/jira/browse/YETUS-186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15012876#comment-15012876
 ] 

Sean Busbey commented on YETUS-186:
---

+1, fine to fix below on commit

{code}
+For example:  `--dockeronfail=continue,fail` means if the Dockerfile can't be 
found, just turn off Docker support and continue running.  
`--dockeronfail=fallback,fail` will switch to the bundled Dockerfile and then 
fail the build if docker fails to work.
+
{code}

I'm unclear on how "continue,fail" works. Should it just be "continue"?

> non-existent dockerfile should fail or fallback
> ---
>
> Key: YETUS-186
> URL: https://issues.apache.org/jira/browse/YETUS-186
> Project: Yetus
>  Issue Type: Bug
>  Components: Test Patch
>Reporter: Allen Wittenauer
>Assignee: Allen Wittenauer
>Priority: Blocker
> Attachments: YETUS-186.00.patch
>
>
> This is a long standing bug that I just now noticed. :(  If the 
> \-\-dockerfile param points to a file that doesn't actually exist, bad things 
> happen.  Which particular bad thing depends greatly upon what other images 
> are already installed, but the vast majority end up with a stuck container at 
> a bash prompt.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (YETUS-186) non-existent dockerfile should fail or fallback

2015-11-18 Thread Allen Wittenauer (JIRA)

[ 
https://issues.apache.org/jira/browse/YETUS-186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15012891#comment-15012891
 ] 

Allen Wittenauer commented on YETUS-186:


Thanks for the review!

bq. I'm unclear on how "continue,fail" works. Should it just be "continue"?

They're basically synonyms.  fail is always the last option.  I thought it was 
better long term to list both and be explicit in case we ever add a fourth.  Do 
you think we should drop fail for now?


> non-existent dockerfile should fail or fallback
> ---
>
> Key: YETUS-186
> URL: https://issues.apache.org/jira/browse/YETUS-186
> Project: Yetus
>  Issue Type: Bug
>  Components: Test Patch
>Reporter: Allen Wittenauer
>Assignee: Allen Wittenauer
>Priority: Blocker
> Attachments: YETUS-186.00.patch
>
>
> This is a long standing bug that I just now noticed. :(  If the 
> \-\-dockerfile param points to a file that doesn't actually exist, bad things 
> happen.  Which particular bad thing depends greatly upon what other images 
> are already installed, but the vast majority end up with a stuck container at 
> a bash prompt.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (YETUS-171) patches that don't apply are not getting reported back to JIRA

2015-11-18 Thread Allen Wittenauer (JIRA)

[ 
https://issues.apache.org/jira/browse/YETUS-171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15012722#comment-15012722
 ] 

Allen Wittenauer commented on YETUS-171:


OK, [~sekikn] said we needed 1.7.3 as a minimum for something else (I forget 
what), and it appears that version properly gives a 1 exit code when trying to 
patch with a PDF file.  So the docs already say 1.7.3 is the minimum, so we 
need to actually enforce that in code in order to prevent this weird edge case 
from happening and everyone (well, at least me) being confused.

> patches that don't apply are not getting reported back to JIRA
> --
>
> Key: YETUS-171
> URL: https://issues.apache.org/jira/browse/YETUS-171
> Project: Yetus
>  Issue Type: Bug
>  Components: Test Patch
>Reporter: Allen Wittenauer
>Assignee: Allen Wittenauer
>Priority: Blocker
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (YETUS-190) releasedocmaker rendering on yetus website is ugly

2015-11-18 Thread Allen Wittenauer (JIRA)
Allen Wittenauer created YETUS-190:
--

 Summary: releasedocmaker rendering on yetus website is ugly
 Key: YETUS-190
 URL: https://issues.apache.org/jira/browse/YETUS-190
 Project: Yetus
  Issue Type: Improvement
Reporter: Allen Wittenauer


No, really.  It's terrible. We should fix it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (YETUS-171) patches that don't apply are not getting reported back to JIRA

2015-11-18 Thread Kengo Seki (JIRA)

[ 
https://issues.apache.org/jira/browse/YETUS-171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15012748#comment-15012748
 ] 

Kengo Seki commented on YETUS-171:
--

bq. Kengo Seki said we needed 1.7.3 as a minimum for something else

The reason is YETUS-16 ;)

> patches that don't apply are not getting reported back to JIRA
> --
>
> Key: YETUS-171
> URL: https://issues.apache.org/jira/browse/YETUS-171
> Project: Yetus
>  Issue Type: Bug
>  Components: Test Patch
>Reporter: Allen Wittenauer
>Assignee: Allen Wittenauer
>Priority: Blocker
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (YETUS-16) test-patch needs Git 1.7.3+

2015-11-18 Thread Allen Wittenauer (JIRA)

 [ 
https://issues.apache.org/jira/browse/YETUS-16?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Allen Wittenauer resolved YETUS-16.
---
Resolution: Duplicate

> test-patch needs Git 1.7.3+
> ---
>
> Key: YETUS-16
> URL: https://issues.apache.org/jira/browse/YETUS-16
> Project: Yetus
>  Issue Type: Bug
>  Components: Test Patch
>Reporter: Kengo Seki
>Priority: Minor
>
> test-patch can run `git clean -xdf -e ...`, but -e is supported only 1.7.3+. 
> Version checking and documentation are needed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (YETUS-154) Specifying help option before plugins option hides plugin-specific help messages

2015-11-18 Thread Allen Wittenauer (JIRA)

[ 
https://issues.apache.org/jira/browse/YETUS-154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15012856#comment-15012856
 ] 

Allen Wittenauer commented on YETUS-154:


lol we collided on committing this. haha.

> Specifying help option before plugins option hides plugin-specific help 
> messages
> 
>
> Key: YETUS-154
> URL: https://issues.apache.org/jira/browse/YETUS-154
> Project: Yetus
>  Issue Type: Bug
>  Components: Test Patch
>Reporter: Kengo Seki
>Assignee: Marco Zühlke
>Priority: Trivial
> Fix For: 0.1.0
>
> Attachments: YETUS-154.00.patch
>
>
> {{precommit/test-patch.sh --plugins=all --help}} shows all plugin options, 
> but {{precommit/test-patch.sh --help --plugins=all}} doesn't.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (YETUS-186) non-existent dockerfile should fail or fallback

2015-11-18 Thread Sean Busbey (JIRA)

[ 
https://issues.apache.org/jira/browse/YETUS-186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013014#comment-15013014
 ] 

Sean Busbey commented on YETUS-186:
---

I would drop it for now. If we disable docker and bail, there's no failing 
possible.

> non-existent dockerfile should fail or fallback
> ---
>
> Key: YETUS-186
> URL: https://issues.apache.org/jira/browse/YETUS-186
> Project: Yetus
>  Issue Type: Bug
>  Components: Test Patch
>Reporter: Allen Wittenauer
>Assignee: Allen Wittenauer
>Priority: Blocker
> Attachments: YETUS-186.00.patch
>
>
> This is a long standing bug that I just now noticed. :(  If the 
> \-\-dockerfile param points to a file that doesn't actually exist, bad things 
> happen.  Which particular bad thing depends greatly upon what other images 
> are already installed, but the vast majority end up with a stuck container at 
> a bash prompt.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (YETUS-186) non-existent dockerfile should fail or fallback

2015-11-18 Thread Yetus QA (JIRA)

[ 
https://issues.apache.org/jira/browse/YETUS-186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013050#comment-15013050
 ] 

Yetus QA commented on YETUS-186:


| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s 
{color} | {color:blue} Precommit patch detected. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s 
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m 
2s {color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 
2s {color} | {color:green} Patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 0m 10s {color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12773193/YETUS-186.01.patch |
| JIRA Issue | YETUS-186 |
| Optional Tests |  asflicense  shellcheck  |
| uname | Linux proserpina.apache.org 3.13.0-36-lowlatency #63-Ubuntu SMP 
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | nobuild |
| git revision | master / 6e95a56 |
| shellcheck | v0.3.3 (This is an old version that has serious bugs. Consider 
upgrading.) |
| modules | C:  U:  |
| Powered by | Apache Yetus   http://yetus.apache.org |
| Console output | 
https://builds.apache.org/job/PreCommit-YETUS-Build/118/console |


This message was automatically generated.



> non-existent dockerfile should fail or fallback
> ---
>
> Key: YETUS-186
> URL: https://issues.apache.org/jira/browse/YETUS-186
> Project: Yetus
>  Issue Type: Bug
>  Components: Test Patch
>Reporter: Allen Wittenauer
>Assignee: Allen Wittenauer
>Priority: Blocker
> Attachments: YETUS-186.00.patch, YETUS-186.01.patch
>
>
> This is a long standing bug that I just now noticed. :(  If the 
> \-\-dockerfile param points to a file that doesn't actually exist, bad things 
> happen.  Which particular bad thing depends greatly upon what other images 
> are already installed, but the vast majority end up with a stuck container at 
> a bash prompt.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (YETUS-192) update in-progress docs for recent changes to precommit

2015-11-18 Thread Allen Wittenauer (JIRA)

[ 
https://issues.apache.org/jira/browse/YETUS-192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013047#comment-15013047
 ] 

Allen Wittenauer commented on YETUS-192:


+1

shouldn't shelldocs be getting executed during middleman publish though?

> update in-progress docs for recent changes to precommit
> ---
>
> Key: YETUS-192
> URL: https://issues.apache.org/jira/browse/YETUS-192
> Project: Yetus
>  Issue Type: Task
>  Components: website and documentation
>Affects Versions: 0.1.0
>Reporter: Sean Busbey
> Attachments: YETUS-192.0.patch
>
>
> looks like there were some changes to precommit that impact generated docs 
> that haven't been checked in on the source side.
> want to make sure what I use to update the site is what's actually in git.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (YETUS-170) hadoop mvninstall should run on parent directories of changed modules

2015-11-18 Thread Yetus QA (JIRA)

[ 
https://issues.apache.org/jira/browse/YETUS-170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013067#comment-15013067
 ] 

Yetus QA commented on YETUS-170:


| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s 
{color} | {color:blue} Precommit patch detected. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 1s 
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:blue}0{color} | {color:blue} shellcheck {color} | {color:blue} 0m 1s 
{color} | {color:blue} Shellcheck was not available. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 
2s {color} | {color:green} Patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 0m 12s {color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12773195/YETUS-170-04.patch |
| JIRA Issue | YETUS-170 |
| Optional Tests |  asflicense  shellcheck  |
| uname | Linux jenkins-ubuntu-1404-4gb-c40 3.13.0-30-generic #54-Ubuntu SMP 
Mon Jun 9 22:45:01 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | nobuild |
| git revision | master / 6e95a56 |
| modules | C:  U:  |
| Powered by | Apache Yetus   http://yetus.apache.org |
| Console output | 
https://builds.apache.org/job/PreCommit-YETUS-Build/119/console |


This message was automatically generated.



> hadoop mvninstall should run on parent directories of changed modules
> -
>
> Key: YETUS-170
> URL: https://issues.apache.org/jira/browse/YETUS-170
> Project: Yetus
>  Issue Type: Bug
>Reporter: Vinayakumar B
>Assignee: Vinayakumar B
> Attachments: YETUS-170-01.patch, YETUS-170-02.patch, 
> YETUS-170-03.patch, YETUS-170-04.patch
>
>
> https://builds.apache.org/job/PreCommit-HDFS-Build/13397/console
> If the patch contains multiple modules changed, then mvn install is expected 
> to run in order of dependency.
> For example, if hadoop-hdfs and hadoop-hdfs-client is changed, then 
> hadoop-hdfs-client is expected to run first and then hadoop-hdfs. 
> Instead, can run mvn install on parent of both these modules. Same is done 
> for 'compile', but not for 'mvninstall'
> This Jira proposes to run mvninstall for hadoop on parent of changed modules 
> (union)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (YETUS-170) hadoop mvninstall should run on parent directories of changed modules

2015-11-18 Thread Yetus QA (JIRA)

[ 
https://issues.apache.org/jira/browse/YETUS-170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013066#comment-15013066
 ] 

Yetus QA commented on YETUS-170:


(!) A patch to the testing environment has been detected. 
Re-executing against the patched versions to perform further tests. 
The console is at 
https://builds.apache.org/job/PreCommit-YETUS-Build/119/console in case of 
problems.


> hadoop mvninstall should run on parent directories of changed modules
> -
>
> Key: YETUS-170
> URL: https://issues.apache.org/jira/browse/YETUS-170
> Project: Yetus
>  Issue Type: Bug
>Reporter: Vinayakumar B
>Assignee: Vinayakumar B
> Attachments: YETUS-170-01.patch, YETUS-170-02.patch, 
> YETUS-170-03.patch, YETUS-170-04.patch
>
>
> https://builds.apache.org/job/PreCommit-HDFS-Build/13397/console
> If the patch contains multiple modules changed, then mvn install is expected 
> to run in order of dependency.
> For example, if hadoop-hdfs and hadoop-hdfs-client is changed, then 
> hadoop-hdfs-client is expected to run first and then hadoop-hdfs. 
> Instead, can run mvn install on parent of both these modules. Same is done 
> for 'compile', but not for 'mvninstall'
> This Jira proposes to run mvninstall for hadoop on parent of changed modules 
> (union)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (YETUS-171) patches that don't apply are not getting reported back to JIRA

2015-11-18 Thread Allen Wittenauer (JIRA)

 [ 
https://issues.apache.org/jira/browse/YETUS-171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Allen Wittenauer updated YETUS-171:
---
Attachment: YETUS-171-addendum.patch

addendum:

just missing a fi.

committed.

> patches that don't apply are not getting reported back to JIRA
> --
>
> Key: YETUS-171
> URL: https://issues.apache.org/jira/browse/YETUS-171
> Project: Yetus
>  Issue Type: Bug
>  Components: Test Patch
>Reporter: Allen Wittenauer
>Assignee: Allen Wittenauer
>Priority: Blocker
> Fix For: 0.1.0
>
> Attachments: YETUS-171-addendum.patch, YETUS-171.00.patch, 
> YETUS-171.01.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (YETUS-171) patches that don't apply are not getting reported back to JIRA

2015-11-18 Thread Allen Wittenauer (JIRA)

 [ 
https://issues.apache.org/jira/browse/YETUS-171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Allen Wittenauer updated YETUS-171:
---
Attachment: YETUS-171.01.patch

-01:
* rebased
* shellcheck false positive disabled

Thanks for the review!

I'll commit this version. :)

> patches that don't apply are not getting reported back to JIRA
> --
>
> Key: YETUS-171
> URL: https://issues.apache.org/jira/browse/YETUS-171
> Project: Yetus
>  Issue Type: Bug
>  Components: Test Patch
>Reporter: Allen Wittenauer
>Assignee: Allen Wittenauer
>Priority: Blocker
> Attachments: YETUS-171.00.patch, YETUS-171.01.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (YETUS-191) ruby-lint and rubocop have broken output on error

2015-11-18 Thread Allen Wittenauer (JIRA)

[ 
https://issues.apache.org/jira/browse/YETUS-191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15012991#comment-15012991
 ] 

Allen Wittenauer commented on YETUS-191:


{code}


 rubocop plugin: prepatch




 does not exist.




ruby-lint plugin: prepatch




 does not exist.
{code}

> ruby-lint and rubocop have broken output on error
> -
>
> Key: YETUS-191
> URL: https://issues.apache.org/jira/browse/YETUS-191
> Project: Yetus
>  Issue Type: Bug
>Reporter: Allen Wittenauer
>Priority: Trivial
>
> Output on console is missing exe names if they aren't installed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (YETUS-191) ruby-lint and rubocop have broken output on error

2015-11-18 Thread Allen Wittenauer (JIRA)

 [ 
https://issues.apache.org/jira/browse/YETUS-191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Allen Wittenauer updated YETUS-191:
---
Priority: Trivial  (was: Major)

> ruby-lint and rubocop have broken output on error
> -
>
> Key: YETUS-191
> URL: https://issues.apache.org/jira/browse/YETUS-191
> Project: Yetus
>  Issue Type: Bug
>Reporter: Allen Wittenauer
>Priority: Trivial
>
> Output on console is missing exe names if they aren't installed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (YETUS-163) parameterize site for releases

2015-11-18 Thread Yetus QA (JIRA)

[ 
https://issues.apache.org/jira/browse/YETUS-163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15012992#comment-15012992
 ] 

Yetus QA commented on YETUS-163:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s 
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s 
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} rubocop {color} | {color:green} 0m 3s 
{color} | {color:green} There were no new rubocop issues. {color} |
| {color:red}-1{color} | {color:red} ruby-lint {color} | {color:red} 0m 1s 
{color} | {color:red} The applied patch generated 2 new ruby-lint issues (total 
was 19, now 21). {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 
0s {color} | {color:green} Patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 0m 14s {color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.7.1 Server=1.7.1 Image:yetus/yetus:577e74f |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12773186/YETUS-163.3.patch |
| JIRA Issue | YETUS-163 |
| Optional Tests |  rubocop  ruby_lint  |
| uname | Linux 6b69bf66084f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed 
Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | nobuild |
| git revision | master / 0e3d5ef |
| rubocop | v0.35.1 |
| ruby-lint | v2.0.5 |
| ruby-lint | 
https://builds.apache.org/job/PreCommit-YETUS-Build/116/artifact/patchprocess/diff-patch-ruby-lint.txt
 |
| modules | C:  U:  |
| Powered by | Apache Yetus   http://yetus.apache.org |
| Console output | 
https://builds.apache.org/job/PreCommit-YETUS-Build/116/console |


This message was automatically generated.



> parameterize site for releases
> --
>
> Key: YETUS-163
> URL: https://issues.apache.org/jira/browse/YETUS-163
> Project: Yetus
>  Issue Type: Improvement
>  Components: website and documentation
>Affects Versions: 0.1.0
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Blocker
> Attachments: YETUS-163.0.patch, YETUS-163.1.patch, YETUS-163.2.patch, 
> YETUS-163.3.patch
>
>
> our site needs to handle having releases, i.e. downloads and version specific 
> documentation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (YETUS-191) ruby-lint and rubocop have broken output on error

2015-11-18 Thread Allen Wittenauer (JIRA)
Allen Wittenauer created YETUS-191:
--

 Summary: ruby-lint and rubocop have broken output on error
 Key: YETUS-191
 URL: https://issues.apache.org/jira/browse/YETUS-191
 Project: Yetus
  Issue Type: Bug
Reporter: Allen Wittenauer


Output on console is missing exe names if they aren't installed.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (YETUS-163) parameterize site for releases

2015-11-18 Thread Allen Wittenauer (JIRA)

[ 
https://issues.apache.org/jira/browse/YETUS-163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013005#comment-15013005
 ] 

Allen Wittenauer commented on YETUS-163:


Yup. :)

> parameterize site for releases
> --
>
> Key: YETUS-163
> URL: https://issues.apache.org/jira/browse/YETUS-163
> Project: Yetus
>  Issue Type: Improvement
>  Components: website and documentation
>Affects Versions: 0.1.0
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Blocker
> Attachments: YETUS-163.0.patch, YETUS-163.1.patch, YETUS-163.2.patch, 
> YETUS-163.3.patch
>
>
> our site needs to handle having releases, i.e. downloads and version specific 
> documentation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (YETUS-192) update in-progress docs for recent changes to precommit

2015-11-18 Thread Sean Busbey (JIRA)
Sean Busbey created YETUS-192:
-

 Summary: update in-progress docs for recent changes to precommit
 Key: YETUS-192
 URL: https://issues.apache.org/jira/browse/YETUS-192
 Project: Yetus
  Issue Type: Task
  Components: website and documentation
Affects Versions: 0.1.0
Reporter: Sean Busbey


looks like there were some changes to precommit that impact generated docs that 
haven't been checked in on the source side.

want to make sure what I use to update the site is what's actually in git.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (YETUS-192) update in-progress docs for recent changes to precommit

2015-11-18 Thread Yetus QA (JIRA)

[ 
https://issues.apache.org/jira/browse/YETUS-192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013035#comment-15013035
 ] 

Yetus QA commented on YETUS-192:


| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s 
{color} | {color:blue} Precommit patch detected. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 1s 
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 
1s {color} | {color:green} Patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 0m 7s {color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12773192/YETUS-192.0.patch |
| JIRA Issue | YETUS-192 |
| Optional Tests |  asflicense  |
| uname | Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP 
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | nobuild |
| git revision | master / 6e95a56 |
| modules | C:  U:  |
| Powered by | Apache Yetus   http://yetus.apache.org |
| Console output | 
https://builds.apache.org/job/PreCommit-YETUS-Build/117/console |


This message was automatically generated.



> update in-progress docs for recent changes to precommit
> ---
>
> Key: YETUS-192
> URL: https://issues.apache.org/jira/browse/YETUS-192
> Project: Yetus
>  Issue Type: Task
>  Components: website and documentation
>Affects Versions: 0.1.0
>Reporter: Sean Busbey
> Attachments: YETUS-192.0.patch
>
>
> looks like there were some changes to precommit that impact generated docs 
> that haven't been checked in on the source side.
> want to make sure what I use to update the site is what's actually in git.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (YETUS-192) update in-progress docs for recent changes to precommit

2015-11-18 Thread Sean Busbey (JIRA)

 [ 
https://issues.apache.org/jira/browse/YETUS-192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sean Busbey updated YETUS-192:
--
Attachment: YETUS-192.0.patch

-00

  - precommit apidoc sources that get updated by running shelldocs on current 
master.

> update in-progress docs for recent changes to precommit
> ---
>
> Key: YETUS-192
> URL: https://issues.apache.org/jira/browse/YETUS-192
> Project: Yetus
>  Issue Type: Task
>  Components: website and documentation
>Affects Versions: 0.1.0
>Reporter: Sean Busbey
> Attachments: YETUS-192.0.patch
>
>
> looks like there were some changes to precommit that impact generated docs 
> that haven't been checked in on the source side.
> want to make sure what I use to update the site is what's actually in git.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (YETUS-192) update in-progress docs for recent changes to precommit

2015-11-18 Thread Yetus QA (JIRA)

[ 
https://issues.apache.org/jira/browse/YETUS-192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013034#comment-15013034
 ] 

Yetus QA commented on YETUS-192:


(!) A patch to the testing environment has been detected. 
Re-executing against the patched versions to perform further tests. 
The console is at 
https://builds.apache.org/job/PreCommit-YETUS-Build/117/console in case of 
problems.


> update in-progress docs for recent changes to precommit
> ---
>
> Key: YETUS-192
> URL: https://issues.apache.org/jira/browse/YETUS-192
> Project: Yetus
>  Issue Type: Task
>  Components: website and documentation
>Affects Versions: 0.1.0
>Reporter: Sean Busbey
> Attachments: YETUS-192.0.patch
>
>
> looks like there were some changes to precommit that impact generated docs 
> that haven't been checked in on the source side.
> want to make sure what I use to update the site is what's actually in git.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (YETUS-186) non-existent dockerfile should fail or fallback

2015-11-18 Thread Allen Wittenauer (JIRA)

 [ 
https://issues.apache.org/jira/browse/YETUS-186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Allen Wittenauer updated YETUS-186:
---
Attachment: YETUS-186.01.patch

-01:
* changed the verbage a bit



> non-existent dockerfile should fail or fallback
> ---
>
> Key: YETUS-186
> URL: https://issues.apache.org/jira/browse/YETUS-186
> Project: Yetus
>  Issue Type: Bug
>  Components: Test Patch
>Reporter: Allen Wittenauer
>Assignee: Allen Wittenauer
>Priority: Blocker
> Attachments: YETUS-186.00.patch, YETUS-186.01.patch
>
>
> This is a long standing bug that I just now noticed. :(  If the 
> \-\-dockerfile param points to a file that doesn't actually exist, bad things 
> happen.  Which particular bad thing depends greatly upon what other images 
> are already installed, but the vast majority end up with a stuck container at 
> a bash prompt.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (YETUS-170) hadoop mvninstall should run on parent directories of changed modules

2015-11-18 Thread Vinayakumar B (JIRA)

 [ 
https://issues.apache.org/jira/browse/YETUS-170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vinayakumar B updated YETUS-170:

Attachment: YETUS-170-04.patch

Attaching the patch with fixed comments.

Added a note for not expecting 'space' in module names.
And hence just doing substring match and removed extra method.

> hadoop mvninstall should run on parent directories of changed modules
> -
>
> Key: YETUS-170
> URL: https://issues.apache.org/jira/browse/YETUS-170
> Project: Yetus
>  Issue Type: Bug
>Reporter: Vinayakumar B
>Assignee: Vinayakumar B
> Attachments: YETUS-170-01.patch, YETUS-170-02.patch, 
> YETUS-170-03.patch, YETUS-170-04.patch
>
>
> https://builds.apache.org/job/PreCommit-HDFS-Build/13397/console
> If the patch contains multiple modules changed, then mvn install is expected 
> to run in order of dependency.
> For example, if hadoop-hdfs and hadoop-hdfs-client is changed, then 
> hadoop-hdfs-client is expected to run first and then hadoop-hdfs. 
> Instead, can run mvn install on parent of both these modules. Same is done 
> for 'compile', but not for 'mvninstall'
> This Jira proposes to run mvninstall for hadoop on parent of changed modules 
> (union)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (YETUS-171) patches that don't apply are not getting reported back to JIRA

2015-11-18 Thread Yetus QA (JIRA)

[ 
https://issues.apache.org/jira/browse/YETUS-171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15012812#comment-15012812
 ] 

Yetus QA commented on YETUS-171:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s 
{color} | {color:blue} Precommit patch detected. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s 
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} shellcheck {color} | {color:red} 0m 3s 
{color} | {color:red} The applied patch generated 1 new shellcheck issues 
(total was 4, now 5). {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 
1s {color} | {color:green} Patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 0m 10s {color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12773170/YETUS-171.00.patch |
| JIRA Issue | YETUS-171 |
| Optional Tests |  asflicense  shellcheck  |
| uname | Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP 
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | nobuild |
| git revision | master / 6326841 |
| shellcheck | v0.3.3 (This is an old version that has serious bugs. Consider 
upgrading.) |
| shellcheck | 
https://builds.apache.org/job/PreCommit-YETUS-Build/112/artifact/patchprocess/diff-patch-shellcheck.txt
 |
| modules | C:  U:  |
| Powered by | Apache Yetus   http://yetus.apache.org |
| Console output | 
https://builds.apache.org/job/PreCommit-YETUS-Build/112/console |


This message was automatically generated.



> patches that don't apply are not getting reported back to JIRA
> --
>
> Key: YETUS-171
> URL: https://issues.apache.org/jira/browse/YETUS-171
> Project: Yetus
>  Issue Type: Bug
>  Components: Test Patch
>Reporter: Allen Wittenauer
>Assignee: Allen Wittenauer
>Priority: Blocker
> Attachments: YETUS-171.00.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (YETUS-171) patches that don't apply are not getting reported back to JIRA

2015-11-18 Thread Yetus QA (JIRA)

[ 
https://issues.apache.org/jira/browse/YETUS-171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15012811#comment-15012811
 ] 

Yetus QA commented on YETUS-171:


(!) A patch to the testing environment has been detected. 
Re-executing against the patched versions to perform further tests. 
The console is at 
https://builds.apache.org/job/PreCommit-YETUS-Build/112/console in case of 
problems.


> patches that don't apply are not getting reported back to JIRA
> --
>
> Key: YETUS-171
> URL: https://issues.apache.org/jira/browse/YETUS-171
> Project: Yetus
>  Issue Type: Bug
>  Components: Test Patch
>Reporter: Allen Wittenauer
>Assignee: Allen Wittenauer
>Priority: Blocker
> Attachments: YETUS-171.00.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)