[jira] [Updated] (YETUS-489) checkstyle.sh does not support checkstyle 6.14 or upper
[
https://issues.apache.org/jira/browse/YETUS-489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kengo Seki updated YETUS-489:
-
Affects Version/s: 0.4.0
> checkstyle.sh does not support checkstyle 6.14 or upper
> ---
>
> Key: YETUS-489
> URL: https://issues.apache.org/jira/browse/YETUS-489
> Project: Yetus
> Issue Type: Bug
> Components: Test Patch
>Affects Versions: 0.4.0
>Reporter: Akira Ajisaka
>Assignee: Akira Ajisaka
> Fix For: 0.5.0
>
> Attachments: YETUS-489.01.patch, YETUS-489.02.patch,
> YETUS-489.03.patch
>
>
> The output format has changed in checkstyle 6.14 by
> https://github.com/checkstyle/checkstyle/issues/2666.
> Before:
> {noformat}
> /Users/ajisaka/git/hadoop/hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/InterfaceAudience.java:0:
> error: Missing package-info.java file.
> {noformat}
> After:
> {noformat}
> [ERROR]
> /Users/ajisaka/git/hadoop/hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/InterfaceAudience.java:0:
> Missing package-info.java file. [JavadocPackage]
> {noformat}
> checkstyle.sh does not support the latter.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (YETUS-489) checkstyle.sh does not support checkstyle 6.14 or upper
[
https://issues.apache.org/jira/browse/YETUS-489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15889347#comment-15889347
]
Kengo Seki commented on YETUS-489:
--
Precommit failure seems a network issue. I locally tested with test-patch and
no problem found.
And I confirmed 03 works well with \[WARN] severity. +1 committing shortly.
> checkstyle.sh does not support checkstyle 6.14 or upper
> ---
>
> Key: YETUS-489
> URL: https://issues.apache.org/jira/browse/YETUS-489
> Project: Yetus
> Issue Type: Bug
> Components: Test Patch
>Reporter: Akira Ajisaka
>Assignee: Akira Ajisaka
> Attachments: YETUS-489.01.patch, YETUS-489.02.patch,
> YETUS-489.03.patch
>
>
> The output format has changed in checkstyle 6.14 by
> https://github.com/checkstyle/checkstyle/issues/2666.
> Before:
> {noformat}
> /Users/ajisaka/git/hadoop/hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/InterfaceAudience.java:0:
> error: Missing package-info.java file.
> {noformat}
> After:
> {noformat}
> [ERROR]
> /Users/ajisaka/git/hadoop/hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/InterfaceAudience.java:0:
> Missing package-info.java file. [JavadocPackage]
> {noformat}
> checkstyle.sh does not support the latter.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (YETUS-489) checkstyle.sh does not support checkstyle 6.14 or upper
[
https://issues.apache.org/jira/browse/YETUS-489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15888548#comment-15888548
]
Yetus QA commented on YETUS-489:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} docker {color} | {color:red} 3m
51s{color} | {color:red} Docker failed to build yetus/yetus:e4e4903. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | YETUS-489 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12855182/YETUS-489.03.patch |
| Console output |
https://builds.apache.org/job/PreCommit-YETUS-Build/539/console |
| Powered by | Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> checkstyle.sh does not support checkstyle 6.14 or upper
> ---
>
> Key: YETUS-489
> URL: https://issues.apache.org/jira/browse/YETUS-489
> Project: Yetus
> Issue Type: Bug
> Components: Test Patch
>Reporter: Akira Ajisaka
>Assignee: Akira Ajisaka
> Attachments: YETUS-489.01.patch, YETUS-489.02.patch,
> YETUS-489.03.patch
>
>
> The output format has changed in checkstyle 6.14 by
> https://github.com/checkstyle/checkstyle/issues/2666.
> Before:
> {noformat}
> /Users/ajisaka/git/hadoop/hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/InterfaceAudience.java:0:
> error: Missing package-info.java file.
> {noformat}
> After:
> {noformat}
> [ERROR]
> /Users/ajisaka/git/hadoop/hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/InterfaceAudience.java:0:
> Missing package-info.java file. [JavadocPackage]
> {noformat}
> checkstyle.sh does not support the latter.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (YETUS-489) checkstyle.sh does not support checkstyle 6.14 or upper
[
https://issues.apache.org/jira/browse/YETUS-489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15888541#comment-15888541
]
Yetus QA commented on YETUS-489:
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at
https://builds.apache.org/job/PreCommit-YETUS-Build/539/console in case of
problems.
> checkstyle.sh does not support checkstyle 6.14 or upper
> ---
>
> Key: YETUS-489
> URL: https://issues.apache.org/jira/browse/YETUS-489
> Project: Yetus
> Issue Type: Bug
> Components: Test Patch
>Reporter: Akira Ajisaka
>Assignee: Akira Ajisaka
> Attachments: YETUS-489.01.patch, YETUS-489.02.patch,
> YETUS-489.03.patch
>
>
> The output format has changed in checkstyle 6.14 by
> https://github.com/checkstyle/checkstyle/issues/2666.
> Before:
> {noformat}
> /Users/ajisaka/git/hadoop/hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/InterfaceAudience.java:0:
> error: Missing package-info.java file.
> {noformat}
> After:
> {noformat}
> [ERROR]
> /Users/ajisaka/git/hadoop/hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/InterfaceAudience.java:0:
> Missing package-info.java file. [JavadocPackage]
> {noformat}
> checkstyle.sh does not support the latter.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (YETUS-489) checkstyle.sh does not support checkstyle 6.14 or upper
[
https://issues.apache.org/jira/browse/YETUS-489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15888534#comment-15888534
]
Yetus QA commented on YETUS-489:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} docker {color} | {color:red} 5m
4s{color} | {color:red} Docker failed to build yetus/yetus:e4e4903. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | YETUS-489 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12855182/YETUS-489.03.patch |
| Console output |
https://builds.apache.org/job/PreCommit-YETUS-Build/538/console |
| Powered by | Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> checkstyle.sh does not support checkstyle 6.14 or upper
> ---
>
> Key: YETUS-489
> URL: https://issues.apache.org/jira/browse/YETUS-489
> Project: Yetus
> Issue Type: Bug
> Components: Test Patch
>Reporter: Akira Ajisaka
>Assignee: Akira Ajisaka
> Attachments: YETUS-489.01.patch, YETUS-489.02.patch,
> YETUS-489.03.patch
>
>
> The output format has changed in checkstyle 6.14 by
> https://github.com/checkstyle/checkstyle/issues/2666.
> Before:
> {noformat}
> /Users/ajisaka/git/hadoop/hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/InterfaceAudience.java:0:
> error: Missing package-info.java file.
> {noformat}
> After:
> {noformat}
> [ERROR]
> /Users/ajisaka/git/hadoop/hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/InterfaceAudience.java:0:
> Missing package-info.java file. [JavadocPackage]
> {noformat}
> checkstyle.sh does not support the latter.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (YETUS-489) checkstyle.sh does not support checkstyle 6.14 or upper
[
https://issues.apache.org/jira/browse/YETUS-489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Akira Ajisaka updated YETUS-489:
Attachment: YETUS-489.03.patch
03 patch
* handle \[WARN\] as well.
> checkstyle.sh does not support checkstyle 6.14 or upper
> ---
>
> Key: YETUS-489
> URL: https://issues.apache.org/jira/browse/YETUS-489
> Project: Yetus
> Issue Type: Bug
> Components: Test Patch
>Reporter: Akira Ajisaka
>Assignee: Akira Ajisaka
> Attachments: YETUS-489.01.patch, YETUS-489.02.patch,
> YETUS-489.03.patch
>
>
> The output format has changed in checkstyle 6.14 by
> https://github.com/checkstyle/checkstyle/issues/2666.
> Before:
> {noformat}
> /Users/ajisaka/git/hadoop/hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/InterfaceAudience.java:0:
> error: Missing package-info.java file.
> {noformat}
> After:
> {noformat}
> [ERROR]
> /Users/ajisaka/git/hadoop/hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/InterfaceAudience.java:0:
> Missing package-info.java file. [JavadocPackage]
> {noformat}
> checkstyle.sh does not support the latter.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (YETUS-489) checkstyle.sh does not support checkstyle 6.14 or upper
[
https://issues.apache.org/jira/browse/YETUS-489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15888477#comment-15888477
]
Akira Ajisaka commented on YETUS-489:
-
Thanks [~sekikn] for the review!
bq. Just one question, should we handle other severities such as \[WARN\]? Some
project other than Hadoop may change severity for messages.
Yes. I'm thinking we should handle \[WARN\] as well because a project can
change the severity easily. An example of the setting is
https://github.com/checkstyle/checkstyle/blob/checkstyle-7.6/src/test/resources/com/puppycrawl/tools/checkstyle/config-classname.xml#L10
According to
https://github.com/checkstyle/checkstyle/blob/checkstyle-7.6/src/main/java/com/puppycrawl/tools/checkstyle/api/SeverityLevel.java,
there are 4 severities in checkstyle:
* IGNORE
* INFO
* WARNING (will become WARN when printed)
* ERROR
and I'll update the patch to handle WARN and ERROR.
> checkstyle.sh does not support checkstyle 6.14 or upper
> ---
>
> Key: YETUS-489
> URL: https://issues.apache.org/jira/browse/YETUS-489
> Project: Yetus
> Issue Type: Bug
> Components: Test Patch
>Reporter: Akira Ajisaka
>Assignee: Akira Ajisaka
> Attachments: YETUS-489.01.patch, YETUS-489.02.patch
>
>
> The output format has changed in checkstyle 6.14 by
> https://github.com/checkstyle/checkstyle/issues/2666.
> Before:
> {noformat}
> /Users/ajisaka/git/hadoop/hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/InterfaceAudience.java:0:
> error: Missing package-info.java file.
> {noformat}
> After:
> {noformat}
> [ERROR]
> /Users/ajisaka/git/hadoop/hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/InterfaceAudience.java:0:
> Missing package-info.java file. [JavadocPackage]
> {noformat}
> checkstyle.sh does not support the latter.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (YETUS-489) checkstyle.sh does not support checkstyle 6.14 or upper
[
https://issues.apache.org/jira/browse/YETUS-489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15888363#comment-15888363
]
Kengo Seki commented on YETUS-489:
--
Tested on Hadoop trunk and worked fine.
Just one question, should we handle other severities such as \[WARN]? Some
project other than Hadoop may change severity for messages.
> checkstyle.sh does not support checkstyle 6.14 or upper
> ---
>
> Key: YETUS-489
> URL: https://issues.apache.org/jira/browse/YETUS-489
> Project: Yetus
> Issue Type: Bug
> Components: Test Patch
>Reporter: Akira Ajisaka
>Assignee: Akira Ajisaka
> Attachments: YETUS-489.01.patch, YETUS-489.02.patch
>
>
> The output format has changed in checkstyle 6.14 by
> https://github.com/checkstyle/checkstyle/issues/2666.
> Before:
> {noformat}
> /Users/ajisaka/git/hadoop/hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/InterfaceAudience.java:0:
> error: Missing package-info.java file.
> {noformat}
> After:
> {noformat}
> [ERROR]
> /Users/ajisaka/git/hadoop/hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/InterfaceAudience.java:0:
> Missing package-info.java file. [JavadocPackage]
> {noformat}
> checkstyle.sh does not support the latter.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
