[jira] [Commented] (YETUS-524) audience-annotations can not be used as a dependency in a gradle build
[ https://issues.apache.org/jira/browse/YETUS-524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16061327#comment-16061327 ] Yetus QA commented on YETUS-524: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 9s{color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 3s{color} | {color:green} The patch has no ill-formed XML file. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 0s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 0m 15s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=1.11.2 Server=1.11.2 Image:yetus/yetus:ca562e8 | | JIRA Issue | YETUS-524 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12874296/YETUS-524.00.patch | | Optional Tests | xml | | uname | Linux 952ebb3fee8e 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | nobuild | | git revision | master / 2113cfa | | modules | C: . U: . | | Console output | https://builds.apache.org/job/PreCommit-YETUS-Build/593/console | | Powered by | Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org | This message was automatically generated. > audience-annotations can not be used as a dependency in a gradle build > -- > > Key: YETUS-524 > URL: https://issues.apache.org/jira/browse/YETUS-524 > Project: Yetus > Issue Type: Bug > Components: Audience Annotations >Affects Versions: 0.4.0 >Reporter: Grant Henke > Fix For: 0.5.0 > > Attachments: YETUS-524.00.patch > > > The Yetus audience-annotations module uses a jdk profile in the parent > yetus-project pom to define the tool.jar to use in the dependency management > section: > {code:title=audience-annotations/pom.xml} > ... > > > > jdk.tools > jdk.tools > system > > true > > > ... > {code} > {code:title=yetus-project/pom.xml} > ... > > > jdk1.7 > > 1.7 > > > > > jdk.tools > jdk.tools > 1.7 > system > ${java.home}/../lib/tools.jar > > > > > ... > {code} > This causes issues when trying to download the maven dependency via a gradle > project because gradle does not support jdk profile activation and views > profile activation requirements as a reproducibility anti-pattern to be > avoided. ([source|https://blog.gradle.org/maven-pom-profiles]). > The issue seen in a gradle build is below: > {noformat} > > Could not resolve org.apache.yetus:audience-annotations:0.4.0. > Required by: ... > > Could not resolve org.apache.yetus:audience-annotations:0.4.0. > > Could not parse POM > https://repo1.maven.org/maven2/org/apache/yetus/audience-annotations/0.4.0/audience-annotations-0.4.0.pom > > Unable to resolve version for dependency > 'jdk.tools:jdk.tools:jar' > {noformat} > This occurs because without any default version and no jdk profile activated > jdk.tools is an invalid dependency. Given that its optional, it could simply > be ignored. However, gradle has no way to force this even if setting the > transitive = false property. > This is easily fixed by adding a default dependency when no jdk profile is > activated. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (YETUS-524) audience-annotations can not be used as a dependency in a gradle build
Grant Henke created YETUS-524: - Summary: audience-annotations can not be used as a dependency in a gradle build Key: YETUS-524 URL: https://issues.apache.org/jira/browse/YETUS-524 Project: Yetus Issue Type: Bug Components: Audience Annotations Affects Versions: 0.4.0 Reporter: Grant Henke Fix For: 0.5.0 The Yetus audience-annotations module uses a jdk profile in the parent yetus-project pom to define the tool.jar to use in the dependency management section: {code:title=audience-annotations/pom.xml} ... jdk.tools jdk.tools system true ... {code} {code:title=yetus-project/pom.xml} ... jdk1.7 1.7 jdk.tools jdk.tools 1.7 system ${java.home}/../lib/tools.jar ... {code} This causes issues when trying to download the maven dependency via a gradle project because gradle does not support jdk profile activation and views profile activation requirements as a reproducibility anti-pattern to be avoided. ([source|https://blog.gradle.org/maven-pom-profiles]). The issue seen in a gradle build is below: {noformat} > Could not resolve org.apache.yetus:audience-annotations:0.4.0. Required by: ... > Could not resolve org.apache.yetus:audience-annotations:0.4.0. > Could not parse POM https://repo1.maven.org/maven2/org/apache/yetus/audience-annotations/0.4.0/audience-annotations-0.4.0.pom > Unable to resolve version for dependency 'jdk.tools:jdk.tools:jar' {noformat} This occurs because without any default version and no jdk profile activated jdk.tools is an invalid dependency. Given that its optional, it could simply be ignored. However, gradle has no way to force this even if setting the transitive = false property. This is easily fixed by adding a default dependency when no jdk profile is activated. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (YETUS-523) create a separate tool for docker cleanup
[ https://issues.apache.org/jira/browse/YETUS-523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16061293#comment-16061293 ] Yetus QA commented on YETUS-523: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 10s{color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m 7s{color} | {color:green} The patch generated 0 new + 53 unchanged - 3 fixed = 53 total (was 56) {color} | | {color:green}+1{color} | {color:green} shelldocs {color} | {color:green} 0m 0s{color} | {color:green} There were no new shelldocs issues. {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 1s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 0m 21s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=1.11.2 Server=1.11.2 Image:yetus/yetus:ca562e8 | | JIRA Issue | YETUS-523 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12874291/YETUS-523.02.patch | | Optional Tests | shellcheck shelldocs | | uname | Linux 5122f81c7d60 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | nobuild | | git revision | master / 2113cfa | | shellcheck | v0.4.6 | | modules | C: . U: . | | Console output | https://builds.apache.org/job/PreCommit-YETUS-Build/592/console | | Powered by | Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org | This message was automatically generated. > create a separate tool for docker cleanup > - > > Key: YETUS-523 > URL: https://issues.apache.org/jira/browse/YETUS-523 > Project: Yetus > Issue Type: New Feature > Components: Test Patch >Affects Versions: 0.5.0 >Reporter: Allen Wittenauer >Assignee: Allen Wittenauer > Fix For: 0.5.0 > > Attachments: YETUS-523.00.patch, YETUS-523.01.patch, > YETUS-523.02.patch > > > ASF servers need more continual cleanup. The Yetus code is effective, but > only works if more projects actually use the sentinel mode. Until then, let's > create a tool that infra can run independently. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (YETUS-523) create a separate tool for docker cleanup
[ https://issues.apache.org/jira/browse/YETUS-523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16061292#comment-16061292 ] Yetus QA commented on YETUS-523: (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/PreCommit-YETUS-Build/592/console in case of problems. > create a separate tool for docker cleanup > - > > Key: YETUS-523 > URL: https://issues.apache.org/jira/browse/YETUS-523 > Project: Yetus > Issue Type: New Feature > Components: Test Patch >Affects Versions: 0.5.0 >Reporter: Allen Wittenauer >Assignee: Allen Wittenauer > Fix For: 0.5.0 > > Attachments: YETUS-523.00.patch, YETUS-523.01.patch, > YETUS-523.02.patch > > > ASF servers need more continual cleanup. The Yetus code is effective, but > only works if more projects actually use the sentinel mode. Until then, let's > create a tool that infra can run independently. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (YETUS-523) create a separate tool for docker cleanup
[ https://issues.apache.org/jira/browse/YETUS-523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen Wittenauer updated YETUS-523: --- Attachment: YETUS-523.02.patch -02: * disable shelldocs in main script > create a separate tool for docker cleanup > - > > Key: YETUS-523 > URL: https://issues.apache.org/jira/browse/YETUS-523 > Project: Yetus > Issue Type: New Feature > Components: Test Patch >Affects Versions: 0.5.0 >Reporter: Allen Wittenauer >Assignee: Allen Wittenauer > Fix For: 0.5.0 > > Attachments: YETUS-523.00.patch, YETUS-523.01.patch, > YETUS-523.02.patch > > > ASF servers need more continual cleanup. The Yetus code is effective, but > only works if more projects actually use the sentinel mode. Until then, let's > create a tool that infra can run independently. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (YETUS-523) create a separate tool for docker cleanup
[ https://issues.apache.org/jira/browse/YETUS-523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16061273#comment-16061273 ] Yetus QA commented on YETUS-523: (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/PreCommit-YETUS-Build/591/console in case of problems. > create a separate tool for docker cleanup > - > > Key: YETUS-523 > URL: https://issues.apache.org/jira/browse/YETUS-523 > Project: Yetus > Issue Type: New Feature > Components: Test Patch >Affects Versions: 0.5.0 >Reporter: Allen Wittenauer >Assignee: Allen Wittenauer > Fix For: 0.5.0 > > Attachments: YETUS-523.00.patch, YETUS-523.01.patch > > > ASF servers need more continual cleanup. The Yetus code is effective, but > only works if more projects actually use the sentinel mode. Until then, let's > create a tool that infra can run independently. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (YETUS-523) create a separate tool for docker cleanup
[ https://issues.apache.org/jira/browse/YETUS-523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16061274#comment-16061274 ] Yetus QA commented on YETUS-523: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 19s{color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m 8s{color} | {color:green} The patch generated 0 new + 53 unchanged - 3 fixed = 53 total (was 56) {color} | | {color:red}-1{color} | {color:red} shelldocs {color} | {color:red} 0m 0s{color} | {color:red} The patch generated 6 new + 2 unchanged - 0 fixed = 8 total (was 2) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 0s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 0m 31s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=1.11.2 Server=1.11.2 Image:yetus/yetus:ca562e8 | | JIRA Issue | YETUS-523 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12874289/YETUS-523.01.patch | | Optional Tests | shellcheck shelldocs | | uname | Linux 6fe37fcd9500 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | nobuild | | git revision | master / 2113cfa | | shellcheck | v0.4.6 | | shelldocs | https://builds.apache.org/job/PreCommit-YETUS-Build/591/artifact/patchprocess/diff-patch-shelldocs.txt | | modules | C: . U: . | | Console output | https://builds.apache.org/job/PreCommit-YETUS-Build/591/console | | Powered by | Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org | This message was automatically generated. > create a separate tool for docker cleanup > - > > Key: YETUS-523 > URL: https://issues.apache.org/jira/browse/YETUS-523 > Project: Yetus > Issue Type: New Feature > Components: Test Patch >Affects Versions: 0.5.0 >Reporter: Allen Wittenauer >Assignee: Allen Wittenauer > Fix For: 0.5.0 > > Attachments: YETUS-523.00.patch, YETUS-523.01.patch > > > ASF servers need more continual cleanup. The Yetus code is effective, but > only works if more projects actually use the sentinel mode. Until then, let's > create a tool that infra can run independently. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (YETUS-523) create a separate tool for docker cleanup
[ https://issues.apache.org/jira/browse/YETUS-523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen Wittenauer updated YETUS-523: --- Attachment: YETUS-523.01.patch -01: * fix the shellcheck errors and a typo in a comment > create a separate tool for docker cleanup > - > > Key: YETUS-523 > URL: https://issues.apache.org/jira/browse/YETUS-523 > Project: Yetus > Issue Type: New Feature > Components: Test Patch >Affects Versions: 0.5.0 >Reporter: Allen Wittenauer >Assignee: Allen Wittenauer > Fix For: 0.5.0 > > Attachments: YETUS-523.00.patch, YETUS-523.01.patch > > > ASF servers need more continual cleanup. The Yetus code is effective, but > only works if more projects actually use the sentinel mode. Until then, let's > create a tool that infra can run independently. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (YETUS-523) create a separate tool for docker cleanup
[ https://issues.apache.org/jira/browse/YETUS-523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16061199#comment-16061199 ] Yetus QA commented on YETUS-523: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 13m 2s{color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:red}-1{color} | {color:red} shellcheck {color} | {color:red} 0m 2s{color} | {color:red} The patch generated 10 new + 4 unchanged - 0 fixed = 14 total (was 4) {color} | | {color:green}+1{color} | {color:green} shelldocs {color} | {color:green} 0m 0s{color} | {color:green} There were no new shelldocs issues. {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 0s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 13m 7s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/yetus:ca562e8 | | JIRA Issue | YETUS-523 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12874276/YETUS-523.00.patch | | Optional Tests | shellcheck shelldocs | | uname | Linux 6087f1a6ef2d 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | nobuild | | git revision | master / 2113cfa | | shellcheck | v0.4.6 | | shellcheck | https://builds.apache.org/job/PreCommit-YETUS-Build/590/artifact/patchprocess/diff-patch-shellcheck.txt | | modules | C: . U: . | | Console output | https://builds.apache.org/job/PreCommit-YETUS-Build/590/console | | Powered by | Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org | This message was automatically generated. > create a separate tool for docker cleanup > - > > Key: YETUS-523 > URL: https://issues.apache.org/jira/browse/YETUS-523 > Project: Yetus > Issue Type: New Feature > Components: Test Patch >Affects Versions: 0.5.0 >Reporter: Allen Wittenauer >Assignee: Allen Wittenauer > Fix For: 0.5.0 > > Attachments: YETUS-523.00.patch > > > ASF servers need more continual cleanup. The Yetus code is effective, but > only works if more projects actually use the sentinel mode. Until then, let's > create a tool that infra can run independently. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (YETUS-523) create a separate tool for docker cleanup
[ https://issues.apache.org/jira/browse/YETUS-523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen Wittenauer updated YETUS-523: --- Attachment: YETUS-523.00.patch -00: * initial docker-cleanup command > create a separate tool for docker cleanup > - > > Key: YETUS-523 > URL: https://issues.apache.org/jira/browse/YETUS-523 > Project: Yetus > Issue Type: New Feature > Components: Test Patch >Affects Versions: 0.5.0 >Reporter: Allen Wittenauer >Assignee: Allen Wittenauer > Fix For: 0.5.0 > > Attachments: YETUS-523.00.patch > > > ASF servers need more continual cleanup. The Yetus code is effective, but > only works if more projects actually use the sentinel mode. Until then, let's > create a tool that infra can run independently. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (YETUS-523) create a separate tool for docker cleanup
[ https://issues.apache.org/jira/browse/YETUS-523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen Wittenauer reassigned YETUS-523: -- Assignee: Allen Wittenauer > create a separate tool for docker cleanup > - > > Key: YETUS-523 > URL: https://issues.apache.org/jira/browse/YETUS-523 > Project: Yetus > Issue Type: New Feature > Components: Test Patch >Affects Versions: 0.5.0 >Reporter: Allen Wittenauer >Assignee: Allen Wittenauer > Fix For: 0.5.0 > > > ASF servers need more continual cleanup. The Yetus code is effective, but > only works if more projects actually use the sentinel mode. Until then, let's > create a tool that infra can run independently. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (YETUS-522) smart-apply-patch should do more to infer author in committer mode
[ https://issues.apache.org/jira/browse/YETUS-522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16061048#comment-16061048 ] Yetus QA commented on YETUS-522: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 15m 51s{color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m 0s{color} | {color:green} There were no new shellcheck issues. {color} | | {color:green}+1{color} | {color:green} shelldocs {color} | {color:green} 0m 0s{color} | {color:green} There were no new shelldocs issues. {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 0s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 15m 54s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=1.11.2 Server=1.11.2 Image:yetus/yetus:ca562e8 | | JIRA Issue | YETUS-522 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12874239/YETUS-522.02.patch | | Optional Tests | shellcheck shelldocs | | uname | Linux 4fc9817be760 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | nobuild | | git revision | master / 2113cfa | | shellcheck | v0.4.6 | | modules | C: . U: . | | Console output | https://builds.apache.org/job/PreCommit-YETUS-Build/589/console | | Powered by | Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org | This message was automatically generated. > smart-apply-patch should do more to infer author in committer mode > -- > > Key: YETUS-522 > URL: https://issues.apache.org/jira/browse/YETUS-522 > Project: Yetus > Issue Type: New Feature > Components: Test Patch >Affects Versions: 0.1.0 >Reporter: Sean Busbey >Assignee: Akira Ajisaka > Attachments: YETUS-522.01.patch, YETUS-522.02.patch > > > In committer mode, we can guess that the user of smart-apply-patch is > planning to submit changes. In the case where the patch wasn't made with > format-patch it would be nice to do some work on behalf of the committer to > find an author. > The obvious case is when the patch is associated with a bug system, we can > get the author from the assignee and set it in a placeholder commit. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (YETUS-523) create a separate tool for docker cleanup
Allen Wittenauer created YETUS-523: -- Summary: create a separate tool for docker cleanup Key: YETUS-523 URL: https://issues.apache.org/jira/browse/YETUS-523 Project: Yetus Issue Type: New Feature Components: Test Patch Affects Versions: 0.5.0 Reporter: Allen Wittenauer Fix For: 0.5.0 ASF servers need more continual cleanup. The Yetus code is effective, but only works if more projects actually use the sentinel mode. Until then, let's create a tool that infra can run independently. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (YETUS-522) smart-apply-patch should do more to infer author in committer mode
[ https://issues.apache.org/jira/browse/YETUS-522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16060976#comment-16060976 ] Yetus QA commented on YETUS-522: (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/PreCommit-YETUS-Build/589/console in case of problems. > smart-apply-patch should do more to infer author in committer mode > -- > > Key: YETUS-522 > URL: https://issues.apache.org/jira/browse/YETUS-522 > Project: Yetus > Issue Type: New Feature > Components: Test Patch >Affects Versions: 0.1.0 >Reporter: Sean Busbey >Assignee: Akira Ajisaka > Attachments: YETUS-522.01.patch, YETUS-522.02.patch > > > In committer mode, we can guess that the user of smart-apply-patch is > planning to submit changes. In the case where the patch wasn't made with > format-patch it would be nice to do some work on behalf of the committer to > find an author. > The obvious case is when the patch is associated with a bug system, we can > get the author from the assignee and set it in a placeholder commit. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (YETUS-522) smart-apply-patch should do more to infer author in committer mode
[ https://issues.apache.org/jira/browse/YETUS-522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16060974#comment-16060974 ] Allen Wittenauer commented on YETUS-522: I'm not sure I understand why Yetus broke here. Let's re-run and see what happens. > smart-apply-patch should do more to infer author in committer mode > -- > > Key: YETUS-522 > URL: https://issues.apache.org/jira/browse/YETUS-522 > Project: Yetus > Issue Type: New Feature > Components: Test Patch >Affects Versions: 0.1.0 >Reporter: Sean Busbey >Assignee: Akira Ajisaka > Attachments: YETUS-522.01.patch, YETUS-522.02.patch > > > In committer mode, we can guess that the user of smart-apply-patch is > planning to submit changes. In the case where the patch wasn't made with > format-patch it would be nice to do some work on behalf of the committer to > find an author. > The obvious case is when the patch is associated with a bug system, we can > get the author from the assignee and set it in a placeholder commit. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (YETUS-522) smart-apply-patch should do more to infer author in committer mode
[ https://issues.apache.org/jira/browse/YETUS-522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16060693#comment-16060693 ] Yetus QA commented on YETUS-522: (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/PreCommit-YETUS-Build/588/console in case of problems. > smart-apply-patch should do more to infer author in committer mode > -- > > Key: YETUS-522 > URL: https://issues.apache.org/jira/browse/YETUS-522 > Project: Yetus > Issue Type: New Feature > Components: Test Patch >Affects Versions: 0.1.0 >Reporter: Sean Busbey >Assignee: Akira Ajisaka > Attachments: YETUS-522.01.patch, YETUS-522.02.patch > > > In committer mode, we can guess that the user of smart-apply-patch is > planning to submit changes. In the case where the patch wasn't made with > format-patch it would be nice to do some work on behalf of the committer to > find an author. > The obvious case is when the patch is associated with a bug system, we can > get the author from the assignee and set it in a placeholder commit. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (YETUS-522) smart-apply-patch should do more to infer author in committer mode
[ https://issues.apache.org/jira/browse/YETUS-522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akira Ajisaka updated YETUS-522: Attachment: YETUS-522.02.patch > smart-apply-patch should do more to infer author in committer mode > -- > > Key: YETUS-522 > URL: https://issues.apache.org/jira/browse/YETUS-522 > Project: Yetus > Issue Type: New Feature > Components: Test Patch >Affects Versions: 0.1.0 >Reporter: Sean Busbey >Assignee: Akira Ajisaka > Attachments: YETUS-522.01.patch, YETUS-522.02.patch > > > In committer mode, we can guess that the user of smart-apply-patch is > planning to submit changes. In the case where the patch wasn't made with > format-patch it would be nice to do some work on behalf of the committer to > find an author. > The obvious case is when the patch is associated with a bug system, we can > get the author from the assignee and set it in a placeholder commit. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (YETUS-522) smart-apply-patch should do more to infer author in committer mode
[ https://issues.apache.org/jira/browse/YETUS-522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akira Ajisaka updated YETUS-522: Attachment: (was: YETUS-522.02.patch) > smart-apply-patch should do more to infer author in committer mode > -- > > Key: YETUS-522 > URL: https://issues.apache.org/jira/browse/YETUS-522 > Project: Yetus > Issue Type: New Feature > Components: Test Patch >Affects Versions: 0.1.0 >Reporter: Sean Busbey >Assignee: Akira Ajisaka > Attachments: YETUS-522.01.patch > > > In committer mode, we can guess that the user of smart-apply-patch is > planning to submit changes. In the case where the patch wasn't made with > format-patch it would be nice to do some work on behalf of the committer to > find an author. > The obvious case is when the patch is associated with a bug system, we can > get the author from the assignee and set it in a placeholder commit. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (YETUS-522) smart-apply-patch should do more to infer author in committer mode
[ https://issues.apache.org/jira/browse/YETUS-522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akira Ajisaka updated YETUS-522: Attachment: YETUS-522.02.patch 02: * fixed shellcheck error > smart-apply-patch should do more to infer author in committer mode > -- > > Key: YETUS-522 > URL: https://issues.apache.org/jira/browse/YETUS-522 > Project: Yetus > Issue Type: New Feature > Components: Test Patch >Affects Versions: 0.1.0 >Reporter: Sean Busbey >Assignee: Akira Ajisaka > Attachments: YETUS-522.01.patch > > > In committer mode, we can guess that the user of smart-apply-patch is > planning to submit changes. In the case where the patch wasn't made with > format-patch it would be nice to do some work on behalf of the committer to > find an author. > The obvious case is when the patch is associated with a bug system, we can > get the author from the assignee and set it in a placeholder commit. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (YETUS-522) smart-apply-patch should do more to infer author in committer mode
[ https://issues.apache.org/jira/browse/YETUS-522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16060666#comment-16060666 ] Yetus QA commented on YETUS-522: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 12m 12s{color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:red}-1{color} | {color:red} shellcheck {color} | {color:red} 0m 0s{color} | {color:red} The patch generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2) {color} | | {color:green}+1{color} | {color:green} shelldocs {color} | {color:green} 0m 0s{color} | {color:green} There were no new shelldocs issues. {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 0s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 12m 19s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=1.13.1 Server=1.13.1 Image:yetus/yetus:ca562e8 | | JIRA Issue | YETUS-522 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12874231/YETUS-522.01.patch | | Optional Tests | shellcheck shelldocs | | uname | Linux 41002e4304fa 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | nobuild | | git revision | master / 2113cfa | | shellcheck | v0.4.6 | | shellcheck | https://builds.apache.org/job/PreCommit-YETUS-Build/587/artifact/patchprocess/diff-patch-shellcheck.txt | | modules | C: . U: . | | Console output | https://builds.apache.org/job/PreCommit-YETUS-Build/587/console | | Powered by | Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org | This message was automatically generated. > smart-apply-patch should do more to infer author in committer mode > -- > > Key: YETUS-522 > URL: https://issues.apache.org/jira/browse/YETUS-522 > Project: Yetus > Issue Type: New Feature > Components: Test Patch >Affects Versions: 0.1.0 >Reporter: Sean Busbey >Assignee: Akira Ajisaka > Attachments: YETUS-522.01.patch > > > In committer mode, we can guess that the user of smart-apply-patch is > planning to submit changes. In the case where the patch wasn't made with > format-patch it would be nice to do some work on behalf of the committer to > find an author. > The obvious case is when the patch is associated with a bug system, we can > get the author from the assignee and set it in a placeholder commit. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (YETUS-522) smart-apply-patch should do more to infer author in committer mode
[ https://issues.apache.org/jira/browse/YETUS-522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16060648#comment-16060648 ] Yetus QA commented on YETUS-522: (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/PreCommit-YETUS-Build/587/console in case of problems. > smart-apply-patch should do more to infer author in committer mode > -- > > Key: YETUS-522 > URL: https://issues.apache.org/jira/browse/YETUS-522 > Project: Yetus > Issue Type: New Feature > Components: Test Patch >Affects Versions: 0.1.0 >Reporter: Sean Busbey >Assignee: Akira Ajisaka > Attachments: YETUS-522.01.patch > > > In committer mode, we can guess that the user of smart-apply-patch is > planning to submit changes. In the case where the patch wasn't made with > format-patch it would be nice to do some work on behalf of the committer to > find an author. > The obvious case is when the patch is associated with a bug system, we can > get the author from the assignee and set it in a placeholder commit. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (YETUS-522) smart-apply-patch should do more to infer author in committer mode
[ https://issues.apache.org/jira/browse/YETUS-522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16060641#comment-16060641 ] Akira Ajisaka commented on YETUS-522: - Manually tested. Note that this functionality does not work if the user name or summary contains * or ", which are used as delimiter. > smart-apply-patch should do more to infer author in committer mode > -- > > Key: YETUS-522 > URL: https://issues.apache.org/jira/browse/YETUS-522 > Project: Yetus > Issue Type: New Feature > Components: Test Patch >Affects Versions: 0.1.0 >Reporter: Sean Busbey >Assignee: Akira Ajisaka > Attachments: YETUS-522.01.patch > > > In committer mode, we can guess that the user of smart-apply-patch is > planning to submit changes. In the case where the patch wasn't made with > format-patch it would be nice to do some work on behalf of the committer to > find an author. > The obvious case is when the patch is associated with a bug system, we can > get the author from the assignee and set it in a placeholder commit. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (YETUS-522) smart-apply-patch should do more to infer author in committer mode
[ https://issues.apache.org/jira/browse/YETUS-522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akira Ajisaka updated YETUS-522: Attachment: YETUS-522.01.patch > smart-apply-patch should do more to infer author in committer mode > -- > > Key: YETUS-522 > URL: https://issues.apache.org/jira/browse/YETUS-522 > Project: Yetus > Issue Type: New Feature > Components: Test Patch >Affects Versions: 0.1.0 >Reporter: Sean Busbey >Assignee: Akira Ajisaka > Attachments: YETUS-522.01.patch > > > In committer mode, we can guess that the user of smart-apply-patch is > planning to submit changes. In the case where the patch wasn't made with > format-patch it would be nice to do some work on behalf of the committer to > find an author. > The obvious case is when the patch is associated with a bug system, we can > get the author from the assignee and set it in a placeholder commit. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (YETUS-522) smart-apply-patch should do more to infer author in committer mode
[ https://issues.apache.org/jira/browse/YETUS-522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akira Ajisaka reassigned YETUS-522: --- Assignee: Akira Ajisaka > smart-apply-patch should do more to infer author in committer mode > -- > > Key: YETUS-522 > URL: https://issues.apache.org/jira/browse/YETUS-522 > Project: Yetus > Issue Type: New Feature > Components: Test Patch >Affects Versions: 0.1.0 >Reporter: Sean Busbey >Assignee: Akira Ajisaka > > In committer mode, we can guess that the user of smart-apply-patch is > planning to submit changes. In the case where the patch wasn't made with > format-patch it would be nice to do some work on behalf of the committer to > find an author. > The obvious case is when the patch is associated with a bug system, we can > get the author from the assignee and set it in a placeholder commit. -- This message was sent by Atlassian JIRA (v6.4.14#64029)