[jira] [Commented] (YETUS-688) convert key globals from strings to arrays

2019-02-09 Thread Yetus QA (JIRA)


[ 
https://issues.apache.org/jira/browse/YETUS-688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16764326#comment-16764326
 ] 

Yetus QA commented on YETUS-688:


| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  6m 
24s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 5 new or modified test 
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
 8s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m  
8s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m  
9s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m  
8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m  
8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green}  0m 
11s{color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} shelldocs {color} | {color:green}  0m  
3s{color} | {color:green} There were no new shelldocs issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green}  0m  
1s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m  
8s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m  
8s{color} | {color:green} precommit in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
 8s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}  9m  4s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base: 
https://builds.apache.org/job/PreCommit-YETUS-Build/937/artifact/patchprocess/Dockerfile
 |
| JIRA Issue | YETUS-688 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12958159/YETUS-688.02.patch |
| Optional Tests | dupname asflicense javac javadoc unit xml compile shellcheck 
shelldocs |
| uname | Linux 938917c821a7 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | precommit/src/main/shell/personality/yetus.sh |
| git revision | master / 9a2b130 |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_191 |
| shellcheck | v0.4.6 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-YETUS-Build/937/testReport/ |
| Max. process+thread count | 98 (vs. ulimit of 1000) |
| modules | C: precommit U: precommit |
| Console output | 
https://builds.apache.org/job/PreCommit-YETUS-Build/937/console |
| Powered by | Apache Yetus 0.10.0-SNAPSHOT http://yetus.apache.org |


This message was automatically generated.



> convert key globals from strings to arrays
> --
>
> Key: YETUS-688
> URL: https://issues.apache.org/jira/browse/YETUS-688
> Project: Yetus
>  Issue Type: Improvement
>  Components: Test Patch
>Reporter: Allen Wittenauer
>Assignee: Allen Wittenauer
>Priority: Major
> Fix For: 0.10.0
>
> Attachments: YETUS-688.00.patch, YETUS-688.01.patch, 
> YETUS-688.02.patch
>
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> In order to clean up the API for a 1.0 release, several key globals should be 
> converted from strings to arrays to fix a variety of problems that can occur 
> when those strings need spaces in them, have matching characters, etc.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (YETUS-688) convert key globals from strings to arrays

2019-02-09 Thread Yetus QA (JIRA)


[ 
https://issues.apache.org/jira/browse/YETUS-688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16764323#comment-16764323
 ] 

Yetus QA commented on YETUS-688:


(!) A patch to the testing environment has been detected. 
Re-executing against the patched versions to perform further tests. 
The console is at 
https://builds.apache.org/job/PreCommit-YETUS-Build/937/console in case of 
problems.


> convert key globals from strings to arrays
> --
>
> Key: YETUS-688
> URL: https://issues.apache.org/jira/browse/YETUS-688
> Project: Yetus
>  Issue Type: Improvement
>  Components: Test Patch
>Reporter: Allen Wittenauer
>Assignee: Allen Wittenauer
>Priority: Major
> Fix For: 0.10.0
>
> Attachments: YETUS-688.00.patch, YETUS-688.01.patch, 
> YETUS-688.02.patch
>
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> In order to clean up the API for a 1.0 release, several key globals should be 
> converted from strings to arrays to fix a variety of problems that can occur 
> when those strings need spaces in them, have matching characters, etc.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (YETUS-688) convert key globals from strings to arrays

2019-02-09 Thread Allen Wittenauer (JIRA)


[ 
https://issues.apache.org/jira/browse/YETUS-688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16764318#comment-16764318
 ] 

Allen Wittenauer commented on YETUS-688:


-02:
* fix the missing BUILDTOOL_initialize call
* rip out the _entry yetuslib routines.  yes, this is a backwards incompatible 
change, but those routines really shouldn't be getting used due to bugs

> convert key globals from strings to arrays
> --
>
> Key: YETUS-688
> URL: https://issues.apache.org/jira/browse/YETUS-688
> Project: Yetus
>  Issue Type: Improvement
>  Components: Test Patch
>Reporter: Allen Wittenauer
>Assignee: Allen Wittenauer
>Priority: Major
> Fix For: 0.10.0
>
> Attachments: YETUS-688.00.patch, YETUS-688.01.patch, 
> YETUS-688.02.patch
>
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> In order to clean up the API for a 1.0 release, several key globals should be 
> converted from strings to arrays to fix a variety of problems that can occur 
> when those strings need spaces in them, have matching characters, etc.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (YETUS-688) convert key globals from strings to arrays

2019-02-08 Thread Allen Wittenauer (JIRA)


[ 
https://issues.apache.org/jira/browse/YETUS-688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16763792#comment-16763792
 ] 

Allen Wittenauer commented on YETUS-688:


- Travis passes
- Jenkins (using precommit job) passes
- Jenkins (using mb pipeline) fails

So there must be something in the options being used.

> convert key globals from strings to arrays
> --
>
> Key: YETUS-688
> URL: https://issues.apache.org/jira/browse/YETUS-688
> Project: Yetus
>  Issue Type: Improvement
>  Components: Test Patch
>Reporter: Allen Wittenauer
>Assignee: Allen Wittenauer
>Priority: Major
> Fix For: 0.10.0
>
> Attachments: YETUS-688.00.patch, YETUS-688.01.patch
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> In order to clean up the API for a 1.0 release, several key globals should be 
> converted from strings to arrays to fix a variety of problems that can occur 
> when those strings need spaces in them, have matching characters, etc.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (YETUS-688) convert key globals from strings to arrays

2019-02-04 Thread Yetus QA (JIRA)


[ 
https://issues.apache.org/jira/browse/YETUS-688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16760481#comment-16760481
 ] 

Yetus QA commented on YETUS-688:


| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
27s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 5 new or modified test 
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
 2s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m  
7s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m  
8s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m  
8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m  
8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green}  0m 
12s{color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} shelldocs {color} | {color:green}  0m  
3s{color} | {color:green} There were no new shelldocs issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 1s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green}  0m  
1s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m  
8s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m  
9s{color} | {color:green} precommit in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
 8s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}  3m  0s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base: 
https://builds.apache.org/job/PreCommit-YETUS-Build/936/artifact/patchprocess/Dockerfile
 |
| JIRA Issue | YETUS-688 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12957583/YETUS-688.01.patch |
| Optional Tests | dupname asflicense javac javadoc unit xml compile shellcheck 
shelldocs |
| uname | Linux 337a85726ffe 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | precommit/src/main/shell/personality/yetus.sh |
| git revision | master / 3db66f6 |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_191 |
| shellcheck | v0.4.6 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-YETUS-Build/936/testReport/ |
| Max. process+thread count | 101 (vs. ulimit of 1000) |
| modules | C: precommit U: precommit |
| Console output | 
https://builds.apache.org/job/PreCommit-YETUS-Build/936/console |
| Powered by | Apache Yetus 0.10.0-SNAPSHOT http://yetus.apache.org |


This message was automatically generated.



> convert key globals from strings to arrays
> --
>
> Key: YETUS-688
> URL: https://issues.apache.org/jira/browse/YETUS-688
> Project: Yetus
>  Issue Type: Improvement
>  Components: Test Patch
>Reporter: Allen Wittenauer
>Assignee: Allen Wittenauer
>Priority: Major
> Fix For: 0.10.0
>
> Attachments: YETUS-688.00.patch, YETUS-688.01.patch
>
>
> In order to clean up the API for a 1.0 release, several key globals should be 
> converted from strings to arrays to fix a variety of problems that can occur 
> when those strings need spaces in them, have matching characters, etc.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (YETUS-688) convert key globals from strings to arrays

2019-02-04 Thread Yetus QA (JIRA)


[ 
https://issues.apache.org/jira/browse/YETUS-688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16760480#comment-16760480
 ] 

Yetus QA commented on YETUS-688:


(!) A patch to the testing environment has been detected. 
Re-executing against the patched versions to perform further tests. 
The console is at 
https://builds.apache.org/job/PreCommit-YETUS-Build/936/console in case of 
problems.


> convert key globals from strings to arrays
> --
>
> Key: YETUS-688
> URL: https://issues.apache.org/jira/browse/YETUS-688
> Project: Yetus
>  Issue Type: Improvement
>  Components: Test Patch
>Reporter: Allen Wittenauer
>Assignee: Allen Wittenauer
>Priority: Major
> Fix For: 0.10.0
>
> Attachments: YETUS-688.00.patch, YETUS-688.01.patch
>
>
> In order to clean up the API for a 1.0 release, several key globals should be 
> converted from strings to arrays to fix a variety of problems that can occur 
> when those strings need spaces in them, have matching characters, etc.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (YETUS-688) convert key globals from strings to arrays

2019-02-04 Thread Allen Wittenauer (JIRA)


[ 
https://issues.apache.org/jira/browse/YETUS-688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16760479#comment-16760479
 ] 

Allen Wittenauer commented on YETUS-688:


-01:
* rebase

> convert key globals from strings to arrays
> --
>
> Key: YETUS-688
> URL: https://issues.apache.org/jira/browse/YETUS-688
> Project: Yetus
>  Issue Type: Improvement
>  Components: Test Patch
>Reporter: Allen Wittenauer
>Assignee: Allen Wittenauer
>Priority: Major
> Fix For: 0.10.0
>
> Attachments: YETUS-688.00.patch, YETUS-688.01.patch
>
>
> In order to clean up the API for a 1.0 release, several key globals should be 
> converted from strings to arrays to fix a variety of problems that can occur 
> when those strings need spaces in them, have matching characters, etc.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (YETUS-688) convert key globals from strings to arrays

2019-02-03 Thread Yetus QA (JIRA)


[ 
https://issues.apache.org/jira/browse/YETUS-688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16759621#comment-16759621
 ] 

Yetus QA commented on YETUS-688:


| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
26s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 5 new or modified test 
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
 6s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m  
9s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m  
9s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m  
8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m  
8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green}  0m 
10s{color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} shelldocs {color} | {color:green}  0m  
4s{color} | {color:green} There were no new shelldocs issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green}  0m  
1s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m  
9s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m  
9s{color} | {color:green} precommit in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
 7s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}  3m  5s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base: 
https://builds.apache.org/job/PreCommit-YETUS-Build/934/artifact/patchprocess/Dockerfile
 |
| JIRA Issue | YETUS-688 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12957471/YETUS-688.00.patch |
| Optional Tests | dupname asflicense javac javadoc unit xml compile shellcheck 
shelldocs |
| uname | Linux 9da09dbab285 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | precommit/src/main/shell/personality/yetus.sh |
| git revision | master / bf88009 |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_191 |
| shellcheck | v0.4.6 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-YETUS-Build/934/testReport/ |
| Max. process+thread count | 100 (vs. ulimit of 1000) |
| modules | C: precommit U: precommit |
| Console output | 
https://builds.apache.org/job/PreCommit-YETUS-Build/934/console |
| Powered by | Apache Yetus 0.10.0-SNAPSHOT http://yetus.apache.org |


This message was automatically generated.



> convert key globals from strings to arrays
> --
>
> Key: YETUS-688
> URL: https://issues.apache.org/jira/browse/YETUS-688
> Project: Yetus
>  Issue Type: Improvement
>  Components: Test Patch
>Reporter: Allen Wittenauer
>Assignee: Allen Wittenauer
>Priority: Major
> Fix For: 0.10.0
>
> Attachments: YETUS-688.00.patch
>
>
> In order to clean up the API for a 1.0 release, several key globals should be 
> converted from strings to arrays to fix a variety of problems that can occur 
> when those strings need spaces in them, have matching characters, etc.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (YETUS-688) convert key globals from strings to arrays

2019-02-03 Thread Yetus QA (JIRA)


[ 
https://issues.apache.org/jira/browse/YETUS-688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16759615#comment-16759615
 ] 

Yetus QA commented on YETUS-688:


(!) A patch to the testing environment has been detected. 
Re-executing against the patched versions to perform further tests. 
The console is at 
https://builds.apache.org/job/PreCommit-YETUS-Build/934/console in case of 
problems.


> convert key globals from strings to arrays
> --
>
> Key: YETUS-688
> URL: https://issues.apache.org/jira/browse/YETUS-688
> Project: Yetus
>  Issue Type: Improvement
>  Components: Test Patch
>Reporter: Allen Wittenauer
>Assignee: Allen Wittenauer
>Priority: Major
> Fix For: 0.10.0
>
> Attachments: YETUS-688.00.patch
>
>
> In order to clean up the API for a 1.0 release, several key globals should be 
> converted from strings to arrays to fix a variety of problems that can occur 
> when those strings need spaces in them, have matching characters, etc.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)