[jira] [Commented] (YETUS-794) exclusion support
[ https://issues.apache.org/jira/browse/YETUS-794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774544#comment-16774544 ] Allen Wittenauer commented on YETUS-794: Awesome. Thanks for the review. Committing to master. > exclusion support > - > > Key: YETUS-794 > URL: https://issues.apache.org/jira/browse/YETUS-794 > Project: Yetus > Issue Type: New Feature > Components: Test Patch >Reporter: Allen Wittenauer >Assignee: Allen Wittenauer >Priority: Major > Attachments: YETUS-794.00.patch, YETUS-794.01.patch > > > Some paths in the source tree may come from 3rd parties that, for various > reasons, may fail tests. It would be useful to have a way to ignore such > paths when reporting on errors. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (YETUS-794) exclusion support
[ https://issues.apache.org/jira/browse/YETUS-794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774393#comment-16774393 ] Sean Busbey commented on YETUS-794: --- +1 > exclusion support > - > > Key: YETUS-794 > URL: https://issues.apache.org/jira/browse/YETUS-794 > Project: Yetus > Issue Type: New Feature > Components: Test Patch >Reporter: Allen Wittenauer >Assignee: Allen Wittenauer >Priority: Major > Attachments: YETUS-794.00.patch, YETUS-794.01.patch > > > Some paths in the source tree may come from 3rd parties that, for various > reasons, may fail tests. It would be useful to have a way to ignore such > paths when reporting on errors. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (YETUS-794) exclusion support
[
https://issues.apache.org/jira/browse/YETUS-794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774385#comment-16774385
]
Yetus QA commented on YETUS-794:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 6m
38s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} @author {color} | {color:blue} 0m
0s{color} | {color:blue} Skipping @author checks as author.sh has been patched.
{color} |
|| || || || {color:brown} master Compile Tests {color} ||
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m
7s{color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} shelldocs {color} | {color:green} 0m
1s{color} | {color:green} There were no new shelldocs issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
6s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 7m 4s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base:
https://builds.apache.org/job/PreCommit-YETUS-Build/945/artifact/patchprocess/Dockerfile
|
| JIRA Issue | YETUS-794 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12959656/YETUS-794.01.patch |
| Optional Tests | dupname asflicense shellcheck shelldocs |
| uname | Linux 0337fee5581b 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2
17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | precommit/src/main/shell/personality/yetus.sh |
| git revision | master / 03e367c |
| maven | version: Apache Maven 3.3.9 |
| shellcheck | v0.4.6 |
| Max. process+thread count | 46 (vs. ulimit of 1000) |
| modules | C: precommit U: precommit |
| Console output |
https://builds.apache.org/job/PreCommit-YETUS-Build/945/console |
| Powered by | Apache Yetus 0.10.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> exclusion support
> -
>
> Key: YETUS-794
> URL: https://issues.apache.org/jira/browse/YETUS-794
> Project: Yetus
> Issue Type: New Feature
> Components: Test Patch
>Reporter: Allen Wittenauer
>Assignee: Allen Wittenauer
>Priority: Major
> Attachments: YETUS-794.00.patch, YETUS-794.01.patch
>
>
> Some paths in the source tree may come from 3rd parties that, for various
> reasons, may fail tests. It would be useful to have a way to ignore such
> paths when reporting on errors.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (YETUS-794) exclusion support
[ https://issues.apache.org/jira/browse/YETUS-794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774378#comment-16774378 ] Yetus QA commented on YETUS-794: (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/PreCommit-YETUS-Build/945/console in case of problems. > exclusion support > - > > Key: YETUS-794 > URL: https://issues.apache.org/jira/browse/YETUS-794 > Project: Yetus > Issue Type: New Feature > Components: Test Patch >Reporter: Allen Wittenauer >Assignee: Allen Wittenauer >Priority: Major > Attachments: YETUS-794.00.patch, YETUS-794.01.patch > > > Some paths in the source tree may come from 3rd parties that, for various > reasons, may fail tests. It would be useful to have a way to ignore such > paths when reporting on errors. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (YETUS-794) exclusion support
[ https://issues.apache.org/jira/browse/YETUS-794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774369#comment-16774369 ] Allen Wittenauer commented on YETUS-794: That works. I feel like this is reinforcing something I've been thinking about for a while: every plugin should have it's own documentation page. On that page we could add the verbage 'this plugin will filter out results for 'excludes' or 'this plugin filters out content of --excludes only in qbt mode'. I'll upload a new patch with the new verbiage. Thanks! > exclusion support > - > > Key: YETUS-794 > URL: https://issues.apache.org/jira/browse/YETUS-794 > Project: Yetus > Issue Type: New Feature > Components: Test Patch >Reporter: Allen Wittenauer >Assignee: Allen Wittenauer >Priority: Major > Attachments: YETUS-794.00.patch > > > Some paths in the source tree may come from 3rd parties that, for various > reasons, may fail tests. It would be useful to have a way to ignore such > paths when reporting on errors. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (YETUS-794) exclusion support
[
https://issues.apache.org/jira/browse/YETUS-794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774329#comment-16774329
]
Sean Busbey commented on YETUS-794:
---
{code}
yetus_add_option "--excludes=" "File of regexs to keep project files out
of the set of changes passed to plugins."
{code}
maybe?
> exclusion support
> -
>
> Key: YETUS-794
> URL: https://issues.apache.org/jira/browse/YETUS-794
> Project: Yetus
> Issue Type: New Feature
> Components: Test Patch
>Reporter: Allen Wittenauer
>Assignee: Allen Wittenauer
>Priority: Major
> Attachments: YETUS-794.00.patch
>
>
> Some paths in the source tree may come from 3rd parties that, for various
> reasons, may fail tests. It would be useful to have a way to ignore such
> paths when reporting on errors.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (YETUS-794) exclusion support
[
https://issues.apache.org/jira/browse/YETUS-794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774268#comment-16774268
]
Allen Wittenauer commented on YETUS-794:
{code}
yetus_add_option "--excludes=" "File of regexs to disable test
detection and attempt to filter out errors"
{code}
Is this better, [~busbey]? Or any recommendations for verbage?
> exclusion support
> -
>
> Key: YETUS-794
> URL: https://issues.apache.org/jira/browse/YETUS-794
> Project: Yetus
> Issue Type: New Feature
> Components: Test Patch
>Reporter: Allen Wittenauer
>Assignee: Allen Wittenauer
>Priority: Major
> Attachments: YETUS-794.00.patch
>
>
> Some paths in the source tree may come from 3rd parties that, for various
> reasons, may fail tests. It would be useful to have a way to ignore such
> paths when reporting on errors.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (YETUS-794) exclusion support
[ https://issues.apache.org/jira/browse/YETUS-794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16772115#comment-16772115 ] Allen Wittenauer commented on YETUS-794: Yup: it's definitely not comprehensive. There's a fine line here, I think, that documentation might be the only way out. In my head, we would want the build system to fail during a compile, but we don't necessarily want the static analyzers to throw a fit because the provided source has an excess tab or an @author tag. There's also the problem that this doesn't configure every static analyzer because it's simply too hard (e.g., checkstyle, jshint, etc). If you've got a recommendation on how to change the text, I'd be very appreciative. What's written currently is like my 4th pass. haha. FWIW, I'm using this feature daily with repos that contain C, Go, Python, and bash where we have many directories of vendor-provided bits and even Linux kernel patch files. I haven't tried it with anything Java-based. It'd be great to for someone to try that out and see if anything was missed. > exclusion support > - > > Key: YETUS-794 > URL: https://issues.apache.org/jira/browse/YETUS-794 > Project: Yetus > Issue Type: New Feature > Components: Test Patch >Reporter: Allen Wittenauer >Assignee: Allen Wittenauer >Priority: Major > Attachments: YETUS-794.00.patch > > > Some paths in the source tree may come from 3rd parties that, for various > reasons, may fail tests. It would be useful to have a way to ignore such > paths when reporting on errors. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (YETUS-794) exclusion support
[
https://issues.apache.org/jira/browse/YETUS-794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16770179#comment-16770179
]
Yetus QA commented on YETUS-794:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
24s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} @author {color} | {color:blue} 0m
0s{color} | {color:blue} Skipping @author checks as author.sh has been patched.
{color} |
|| || || || {color:brown} master Compile Tests {color} ||
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m
6s{color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} shelldocs {color} | {color:green} 0m
1s{color} | {color:green} There were no new shelldocs issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
7s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 0m 51s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base:
https://builds.apache.org/job/PreCommit-YETUS-Build/944/artifact/patchprocess/Dockerfile
|
| JIRA Issue | YETUS-794 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12958990/YETUS-794.00.patch |
| Optional Tests | dupname asflicense shellcheck shelldocs |
| uname | Linux fdd58a8854c3 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2
17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | precommit/src/main/shell/personality/yetus.sh |
| git revision | master / 2923027 |
| maven | version: Apache Maven 3.3.9 |
| shellcheck | v0.4.6 |
| Max. process+thread count | 46 (vs. ulimit of 1000) |
| modules | C: precommit U: precommit |
| Console output |
https://builds.apache.org/job/PreCommit-YETUS-Build/944/console |
| Powered by | Apache Yetus 0.10.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> exclusion support
> -
>
> Key: YETUS-794
> URL: https://issues.apache.org/jira/browse/YETUS-794
> Project: Yetus
> Issue Type: New Feature
> Components: Test Patch
>Reporter: Allen Wittenauer
>Assignee: Allen Wittenauer
>Priority: Major
> Attachments: YETUS-794.00.patch
>
>
> Some paths in the source tree may come from 3rd parties that, for various
> reasons, may fail tests. It would be useful to have a way to ignore such
> paths when reporting on errors.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (YETUS-794) exclusion support
[ https://issues.apache.org/jira/browse/YETUS-794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16770177#comment-16770177 ] Yetus QA commented on YETUS-794: (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/PreCommit-YETUS-Build/944/console in case of problems. > exclusion support > - > > Key: YETUS-794 > URL: https://issues.apache.org/jira/browse/YETUS-794 > Project: Yetus > Issue Type: New Feature > Components: Test Patch >Reporter: Allen Wittenauer >Assignee: Allen Wittenauer >Priority: Major > Attachments: YETUS-794.00.patch > > > Some paths in the source tree may come from 3rd parties that, for various > reasons, may fail tests. It would be useful to have a way to ignore such > paths when reporting on errors. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (YETUS-794) exclusion support
[ https://issues.apache.org/jira/browse/YETUS-794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16770176#comment-16770176 ] Allen Wittenauer commented on YETUS-794: -00: * added a new --excludes=(file) option that provides a regex based filter for most tests * added a new exclude_paths_from_changed_files that takes the aforementioned file and strips CHANGED_FILES of those files * added docker code to pull the excludes file with us * rewrote the author plugin to use the excludes file as well as to simplify the code, fix some bugs, etc. * modifed the whitespace plugin to recognize the excludes file. One big gotcha: you cannot suffix with an anchor, otherwise whitespace won't exclude. > exclusion support > - > > Key: YETUS-794 > URL: https://issues.apache.org/jira/browse/YETUS-794 > Project: Yetus > Issue Type: New Feature > Components: Test Patch >Reporter: Allen Wittenauer >Assignee: Allen Wittenauer >Priority: Major > Attachments: YETUS-794.00.patch > > > Some paths in the source tree may come from 3rd parties that, for various > reasons, may fail tests. It would be useful to have a way to ignore such > paths when reporting on errors. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (YETUS-794) exclusion support
[ https://issues.apache.org/jira/browse/YETUS-794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767410#comment-16767410 ] Allen Wittenauer commented on YETUS-794: Note: author and whitespace do not appear to honor CHANGED_FILES. > exclusion support > - > > Key: YETUS-794 > URL: https://issues.apache.org/jira/browse/YETUS-794 > Project: Yetus > Issue Type: New Feature > Components: Test Patch >Reporter: Allen Wittenauer >Assignee: Allen Wittenauer >Priority: Major > > Some paths in the source tree may come from 3rd parties that, for various > reasons, may fail tests. It would be useful to have a way to ignore such > paths when reporting on errors. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
