[GitHub] [zookeeper] TisonKun commented on issue #1064: ZOOKEEPER-3523: Replace dummy watcher with a unified singleton
TisonKun commented on issue #1064: ZOOKEEPER-3523: Replace dummy watcher with a unified singleton URL: https://github.com/apache/zookeeper/pull/1064#issuecomment-532605133 Thanks for your help @nkalmar ! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] TisonKun commented on issue #1064: ZOOKEEPER-3523: Replace dummy watcher with a unified singleton
TisonKun commented on issue #1064: ZOOKEEPER-3523: Replace dummy watcher with a unified singleton URL: https://github.com/apache/zookeeper/pull/1064#issuecomment-532515005 Thanks for your review @hanm ! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] TisonKun commented on issue #1064: ZOOKEEPER-3523: Replace dummy watcher with a unified singleton
TisonKun commented on issue #1064: ZOOKEEPER-3523: Replace dummy watcher with a unified singleton URL: https://github.com/apache/zookeeper/pull/1064#issuecomment-531828454 Resolved conflicts. @anmolnar @nkalmar could you please take a look? I think this pull request is in mergeable state. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] TisonKun commented on issue #1064: ZOOKEEPER-3523: Replace dummy watcher with a unified singleton
TisonKun commented on issue #1064: ZOOKEEPER-3523: Replace dummy watcher with a unified singleton URL: https://github.com/apache/zookeeper/pull/1064#issuecomment-529850468 Thanks for your review @eolivelli ! @lvfangmin @hanm could you please take a look at this pull request? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] TisonKun commented on issue #1064: ZOOKEEPER-3523: Replace dummy watcher with a unified singleton
TisonKun commented on issue #1064: ZOOKEEPER-3523: Replace dummy watcher with a unified singleton URL: https://github.com/apache/zookeeper/pull/1064#issuecomment-526169527 Thanks for your review @eolivelli. Address comments. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services