[GitHub] [zookeeper] maoling commented on pull request #1390: ZOOKEEPER-3526: data inconsistency due to mistaken TRUNC caused by maxCommittedLog is much less than minCommittedLog when in readonly mode

2022-02-11 Thread GitBox


maoling commented on pull request #1390:
URL: https://github.com/apache/zookeeper/pull/1390#issuecomment-1036109761


   @Hinterwaeldlers 
   - The unit test did not work anymore, please use the `Junit5` jupiter.api
   - Please reopen your origin PRs again branch-3.5, branch-3.6, branch-3.7 
(Notice
   master and branch-3.7 use `Junit5`, branch-3.5 and branch-3.6 use `Junit4`)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [zookeeper] maoling commented on pull request #1390: ZOOKEEPER-3526: data inconsistency due to mistaken TRUNC caused by maxCommittedLog is much less than minCommittedLog when in readonly mode

2022-02-07 Thread GitBox


maoling commented on pull request #1390:
URL: https://github.com/apache/zookeeper/pull/1390#issuecomment-1032150367


   Oops, I'm looking


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [zookeeper] maoling commented on pull request #1390: ZOOKEEPER-3526: data inconsistency due to mistaken TRUNC caused by maxCommittedLog is much less than minCommittedLog when in readonly mode

2021-11-24 Thread GitBox


maoling commented on pull request #1390:
URL: https://github.com/apache/zookeeper/pull/1390#issuecomment-978833173


   @Hinterwaeldlers. Very sorry for our late, the inconsistency issue always 
has the highest priority. As you see, our reviewer has noticed this PR, I will 
nudge this PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [zookeeper] maoling commented on pull request #1390: ZOOKEEPER-3526: data inconsistency due to mistaken TRUNC caused by maxCommittedLog is much less than minCommittedLog when in readonly mode

2021-03-25 Thread GitBox


maoling commented on pull request #1390:
URL: https://github.com/apache/zookeeper/pull/1390#issuecomment-807928587


   @ztzg @eolivelli  @anmolnar  @nkalmar  This is a serious bug which's related 
with the consistency, any of your guys have a cycle to review it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org