[GitHub] [zookeeper] nkalmar commented on issue #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint

2019-06-03 Thread GitBox 
nkalmar commented on issue #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint
URL: https://github.com/apache/zookeeper/pull/965#issuecomment-498239868
 
 
   I'm not sure why the maven build failed the last run? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zookeeper] nkalmar commented on issue #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint

2019-06-03 Thread GitBox 
nkalmar commented on issue #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint
URL: https://github.com/apache/zookeeper/pull/965#issuecomment-498194477
 
 
   Actually, I do have some javadoc warnings left :( 
   
   `[WARNING] Javadoc Warnings
   [WARNING] 
/Users/norbertkalmar/workspace/upstream/zookeeper2/zookeeper/zookeeper-server/src/main/java/org/apache/zookeeper/server/ServerCnxn.java:367:
 warning - Tag @see: missing '#': "dumpConnectionInfo(PrintWriter, boolean) for 
brief stats"
   [WARNING] 
/Users/norbertkalmar/workspace/upstream/zookeeper2/zookeeper/zookeeper-server/src/main/java/org/apache/zookeeper/server/ZKDatabase.java:489:
 warning - @return tag has no arguments.
   [WARNING] 
/Users/norbertkalmar/workspace/upstream/zookeeper2/zookeeper/zookeeper-server/src/main/java/org/apache/zookeeper/server/persistence/FileTxnLog.java:312:
 warning - @return tag has no arguments.
   [WARNING] 
/Users/norbertkalmar/workspace/upstream/zookeeper2/zookeeper/zookeeper-server/src/main/java/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java:509:
 warning - @return tag has no arguments.
   [WARNING] 
/Users/norbertkalmar/workspace/upstream/zookeeper2/zookeeper/zookeeper-server/src/main/java/org/apache/zookeeper/server/persistence/SnapStream.java:222:
 warning - @return tag has no arguments.
   [WARNING] 
/Users/norbertkalmar/workspace/upstream/zookeeper2/zookeeper/zookeeper-server/src/main/java/org/apache/zookeeper/server/persistence/Util.java:257:
 warning - @return tag has no arguments.
   [WARNING] 
/Users/norbertkalmar/workspace/upstream/zookeeper2/zookeeper/zookeeper-server/src/main/java/org/apache/zookeeper/server/persistence/Util.java:267:
 warning - @return tag has no arguments.
   [WARNING] 
/Users/norbertkalmar/workspace/upstream/zookeeper2/zookeeper/zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/Learner.java:80:
 warning - @return tag has no arguments.
   [WARNING] 
/Users/norbertkalmar/workspace/upstream/zookeeper2/zookeeper/zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/Leader.java:1117:
 warning - @return tag has no arguments.
   [WARNING] 
/Users/norbertkalmar/workspace/upstream/zookeeper2/zookeeper/zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/LearnerMaster.java:74:
 warning - @return tag has no arguments.
   [WARNING] 
/Users/norbertkalmar/workspace/upstream/zookeeper2/zookeeper/zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/Leader.java:246:
 warning - @param argument "qv," is not a parameter name.
   [WARNING] 
/Users/norbertkalmar/workspace/upstream/zookeeper2/zookeeper/zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/Leader.java:889:
 warning - @param argument "zxid," is not a parameter name.
   [WARNING] 
/Users/norbertkalmar/workspace/upstream/zookeeper2/zookeeper/zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/Leader.java:889:
 warning - @param argument "sid," is not a parameter name.
   [WARNING] 
/Users/norbertkalmar/workspace/upstream/zookeeper2/zookeeper/zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/LearnerHandler.java:1048:
 warning - @return tag has no arguments.
   [WARNING] 
/Users/norbertkalmar/workspace/upstream/zookeeper2/zookeeper/zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumPeer.java:1767:
 warning - @return tag has no arguments.
   [WARNING] 
/Users/norbertkalmar/workspace/upstream/zookeeper2/zookeeper/zookeeper-server/src/main/java/org/apache/zookeeper/cli/AclParser.java:36:
 warning - @return tag has no arguments.
   [WARNING] 
/Users/norbertkalmar/workspace/upstream/zookeeper2/zookeeper/zookeeper-server/src/main/java/org/apache/zookeeper/cli/CliCommand.java:75:
 warning - @return tag has no arguments.
   [WARNING] 
/Users/norbertkalmar/workspace/upstream/zookeeper2/zookeeper/zookeeper-server/src/main/java/org/apache/zookeeper/cli/CliCommand.java:83:
 warning - @return tag has no arguments.
   [WARNING] 
/Users/norbertkalmar/workspace/upstream/zookeeper2/zookeeper/zookeeper-server/src/main/java/org/apache/zookeeper/cli/CliCommand.java:91:
 warning - @return tag has no arguments.
   [WARNING] 
/Users/norbertkalmar/workspace/upstream/zookeeper2/zookeeper/zookeeper-server/src/main/java/org/apache/zookeeper/cli/CliCommand.java:116:
 warning - @return tag has no arguments.`


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zookeeper] nkalmar commented on issue #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint

2019-06-03 Thread GitBox 
nkalmar commented on issue #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint
URL: https://github.com/apache/zookeeper/pull/965#issuecomment-498191954
 
 
   That's strange indeed. I can see it and it causes build failure. I checked 
out master and applied your patch (although it doesn't even touch that class).


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zookeeper] nkalmar commented on issue #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint

2019-06-03 Thread GitBox 
nkalmar commented on issue #965: ZOOKEEPER-3409 Compile Java code with -Xdoclint
URL: https://github.com/apache/zookeeper/pull/965#issuecomment-498188536
 
 
   Why not just remove the > sing and use "smaller" on the line
   "If both flushDelay and maxMaxBatchSize are set (> 0)" ? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services