[GitHub] [zookeeper] symat commented on pull request #1356: ZOOKEEPER-3829: backward compatibility fix for rolling restart without dynamic reconfig

2020-05-29 Thread GitBox 


symat commented on pull request #1356:
URL: https://github.com/apache/zookeeper/pull/1356#issuecomment-635796433


   > What I don't understand is what does backward compatibility have to do 
here? 
   
   By backward compatibility I meant that some rolling-restart sequences that 
was working well with 3.4 are not working with 3.5 and 3.6, even if 
`reconfigEnabled=false`. When the dynamic reconfig is disabled, then we would 
assume that rolling-restarts are behaving similarly as they did before 3.5. 
   
   I think you are right, maybe this is a bad phrase here. I will try to make 
it more clear in the PR / Jira.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [zookeeper] symat commented on pull request #1356: ZOOKEEPER-3829: backward compatibility fix for rolling restart without dynamic reconfig

2020-05-26 Thread GitBox 


symat commented on pull request #1356:
URL: https://github.com/apache/zookeeper/pull/1356#issuecomment-633604783







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [zookeeper] symat commented on pull request #1356: ZOOKEEPER-3829: backward compatibility fix for rolling restart without dynamic reconfig

2020-05-22 Thread GitBox 


symat commented on pull request #1356:
URL: https://github.com/apache/zookeeper/pull/1356#issuecomment-632506926


   We had some chat on slack with @shralex and I will debug where the old 
server's configs are propagated (last seen config or last committed config) in 
the case of ZOOKEEPER-3814. I will try to avoid the update of both the 
committed / last seen config in case of disabled dynamic reconfig. I think that 
will solve ZOOKEEPER-3814.
   
   I will also create (if there isn't one) a new automated test for the 
'enablement of dynamic reconfig through rolling restart' to make sure we have 
that functionality.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [zookeeper] symat commented on pull request #1356: ZOOKEEPER-3829: backward compatibility fix for rolling restart without dynamic reconfig

2020-05-21 Thread GitBox 


symat commented on pull request #1356:
URL: https://github.com/apache/zookeeper/pull/1356#issuecomment-632163372


   well, this is a very good question. Ideally I would say it should be enabled 
with a rolling restart. I think this is how people do all static config changes 
in production if the cluster must be up all time. We definitely should create a 
test for this, I doubt it exists. But Maybe we can do this in an other PR / 
ticket.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [zookeeper] symat commented on pull request #1356: ZOOKEEPER-3829: backward compatibility fix for rolling restart without dynamic reconfig

2020-05-21 Thread GitBox 


symat commented on pull request #1356:
URL: https://github.com/apache/zookeeper/pull/1356#issuecomment-632032896


   @lvfangmin, @fpj  - I think you also might have more background knowledge 
around the dynamic-reconfig. Can you please take a look on this PR?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [zookeeper] symat commented on pull request #1356: ZOOKEEPER-3829: backward compatibility fix for rolling restart without dynamic reconfig

2020-05-19 Thread GitBox 


symat commented on pull request #1356:
URL: https://github.com/apache/zookeeper/pull/1356#issuecomment-630747049


   @shralex , @hanm please take a look if you can!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org