[GitHub] [zookeeper] vladimirivic commented on a change in pull request #953: ZOOKEEPER-3398 Learner.connectToLeader() may take too long to time-out
vladimirivic commented on a change in pull request #953: ZOOKEEPER-3398 Learner.connectToLeader() may take too long to time-out URL: https://github.com/apache/zookeeper/pull/953#discussion_r291758431 ## File path: zookeeper-docs/src/main/resources/markdown/zookeeperAdmin.md ## @@ -861,6 +862,11 @@ of servers -- that is, when deploying clusters of servers. connect and sync to a leader. Increased this value as needed, if the amount of data managed by ZooKeeper is large. +* *connectToLearnerMasterLimit* : +(No Java system property) +Amount of time, in ticks (see [tickTime](#id_tickTime)), to allow followers to +connect to the learner master after leader election. Review comment: Default value in the example config is 5. Also if the value is not specified or it's not greater than 0, then the `initLimit` value will be used instead. Will update the docs shortly. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] vladimirivic commented on a change in pull request #953: ZOOKEEPER-3398 Learner.connectToLeader() may take too long to time-out
vladimirivic commented on a change in pull request #953: ZOOKEEPER-3398 Learner.connectToLeader() may take too long to time-out URL: https://github.com/apache/zookeeper/pull/953#discussion_r291758431 ## File path: zookeeper-docs/src/main/resources/markdown/zookeeperAdmin.md ## @@ -861,6 +862,11 @@ of servers -- that is, when deploying clusters of servers. connect and sync to a leader. Increased this value as needed, if the amount of data managed by ZooKeeper is large. +* *connectToLearnerMasterLimit* : +(No Java system property) +Amount of time, in ticks (see [tickTime](#id_tickTime)), to allow followers to +connect to the learner master after leader election. Review comment: Default value in the example config is 5. Also if the value is not specified or it's not greater than 0, then the `initLimit` value will be used instead. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] vladimirivic commented on a change in pull request #953: ZOOKEEPER-3398 Learner.connectToLeader() may take too long to time-out
vladimirivic commented on a change in pull request #953: ZOOKEEPER-3398 Learner.connectToLeader() may take too long to time-out URL: https://github.com/apache/zookeeper/pull/953#discussion_r289949284 ## File path: conf/zoo_sample.cfg ## @@ -6,6 +6,9 @@ initLimit=10 # The number of ticks that can pass between # sending a request and getting an acknowledgement syncLimit=5 +# The number of ticks that followers can take +# to connect to the leader after leader election +connectToLeaderLimit=5 Review comment: I will update the pull request to reflect the suggested changes. I will be renaming connectToLeaderLimit to connectToLearnerMasterLimit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
