[notmuch] Debian packaging

2009-11-30 Thread Carl Worth
On Sun, 29 Nov 2009 11:06:34 -0700, Bdale Garbee  wrote:
> On Sun, 2009-11-29 at 08:55 -0500, Jameson Graef Rollins wrote:
> > As much as I would love to, at this point I'm not quite offering to
> > actually be maintainer of a notmuch Debian package. 
> 
> Actually, since Carl is a DD now, I've already nudged him about
> maintaining a Debian package, and offered to help.  Perhaps your work
> will provide additional motivation.  ;-)

Yes, this is great motivation. Now I just need a *little* bit more spare
time. :-)

I do appreciate all the work that people are doing as far as packaging
notmuch for Debian. My plan is to survey the various things done
already, pick one, put it in our upstream notmuch repository, and then
push a package out myself as the Debian maintainer for notmuch.

I'm a very new Debian maintainer, (in fact, this will be my first
package to maintain on my own), so I'll appreciate any help that more
experienced people can provide.

-Carl
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: 
<http://notmuchmail.org/pipermail/notmuch/attachments/20091130/9a1bba07/attachment.pgp>


[notmuch] Requires g++, and something else?

2009-11-30 Thread Carl Worth
On Tue, 1 Dec 2009 00:01:16 +, Scot Becker  wrote:
> I'm a brand new joiner to notmuch ('course so is nearly everyone).

Hi Scot, welcome to notmuch!

> I just tried compiling, and I see:
> 
> 1.  g++ is also a 'dependency' though ./configure didn't catch it.

Oh, good point. I did assume you at least had a functional compiler. But
yeah, the configure script should actually check for that I suppose.

> /usr/bin/ld: cannot find -lz
> collect2: ld returned 1 exit status
> make: *** [notmuch] Error 1

This was answered well already. It's really a packaging but of GMime,
(since *it* depends on libz, so notmuch depends on it indirectly, but
doesn't actually need to link directly with libz as GMime is instructing
us to do so here).

-Carl
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: 
<http://notmuchmail.org/pipermail/notmuch/attachments/20091130/08c68b91/attachment.pgp>


[notmuch] New, better help mode for emacs interface

2009-11-30 Thread Carl Worth
I just committed the semantics that Keith wanted for the 'x' and 'X'
bindings when viewing a thread, (that 'x' archives the thread, and 'X'
clears the "unread" tag then archives).

This is very different than the old behavior of 'x' which was simply to
kill the current buffer without changing any message tags, (that
behavior was and still is available on the 'q' keybinding).

Before I made this change, I implemented what I think is a much nicer
help system for the emacs notmuch interface. It's available on the '?'
key which is hopefully intuitive enough. Please take a look and let me
know if it's easier to learn how to use the various notmuch support
within emacs with this new help mode.

-Carl

-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: 
<http://notmuchmail.org/pipermail/notmuch/attachments/20091130/47c3b54e/attachment.pgp>


[notmuch] [PATCH] notmuch.el: Add face support to message summary and subject lines.

2009-11-30 Thread Kan-Ru Chen
Remove the underline of both message summary and subject lines.
Message summary still defaults to reverse-video, use customize to
change it to whatever you like.

Signed-off-by: Kan-Ru Chen 
---
 notmuch.el |   20 
 1 files changed, 16 insertions(+), 4 deletions(-)

diff --git a/notmuch.el b/notmuch.el
index 65473ba..730538c 100644
--- a/notmuch.el
+++ b/notmuch.el
@@ -714,9 +714,8 @@ which this thread was originally shown."
   (let ((beg (point-marker))
 (btn nil))
 (end-of-line)
-; Inverse video for subject
-(overlay-put (make-overlay beg (point)) 'face '(:inverse-video t))
-(setq btn (make-button beg (point) :type 'notmuch-button-body-toggle-type))
+(setq btn (make-button beg (point) :type 'notmuch-button-body-toggle-type
+   'face 'notmuch-show-message-summary-face))
 (forward-line 1)
 (end-of-line)
 (let ((beg-hidden (point-marker)))
@@ -739,7 +738,8 @@ which this thread was originally shown."
   (forward-line)
   (make-button (line-beginning-position) (line-end-position)
 'invisibility-spec (cons invis-spec t)
-:type 'notmuch-button-headers-toggle-type))
+:type 'notmuch-button-headers-toggle-type
+'face 'notmuch-show-message-headers-face))
 (goto-char end)
 (insert "\n")
(set-marker beg nil)
@@ -959,6 +959,18 @@ thread from that buffer can be show when done with this 
one)."
   "Notmuch search mode face used to highligh tags."
   :group 'notmuch)

+(defface notmuch-show-message-summary-face
+  '((default
+(:bold t :inverse-video t)))
+  "Notmuch show mode face used to highlight summary line."
+  :group 'notmuch)
+
+(defface notmuch-show-message-headers-face
+  '((default
+ (:bold t)))
+  "Notmuch show mode face used to highlight header lines."
+  :group 'notmuch)
+
 (defvar notmuch-tag-face-alist nil
   "List containing the tag list that need to be highlighed")

-- 
1.6.5.3



[notmuch] Requires g++, and something else?

2009-11-30 Thread da...@tethera.net
Adrian Perez de Castro wrote:

>[1  ]
>[1.1  ]
>On Tue, 1 Dec 2009 00:01:16 +, Scot wrote:

>>   CXXlib/thread.o
>>   AR lib/notmuch.a
>>   CXXnotmuch
>> /usr/bin/ld: cannot find -lz

>This is because you will need the development package for zlib, package
>name is "zlib1g-dev", once you have the devel packages listed in the
>README file plus this one you shoule be able of building NotMuch
>successfully.

For what it is worth, this should be fixed in the next release of
libgmime.

d


[notmuch] [PATCH] notmuch.el: Add face support to message summary and subject lines.

2009-11-30 Thread Aneesh Kumar K. V
On Mon, 30 Nov 2009 22:50:39 +0800, Kan-Ru Chen  wrote:
> Remove the underline of both message summary and subject lines.
> Message summary still defaults to reverse-video, use customize to
> change it to whatever you like.
> 
> Signed-off-by: Kan-Ru Chen 
> ---
>  notmuch.el |   20 
>  1 files changed, 16 insertions(+), 4 deletions(-)
> 
> diff --git a/notmuch.el b/notmuch.el
> index 65473ba..730538c 100644
> --- a/notmuch.el
> +++ b/notmuch.el
> @@ -714,9 +714,8 @@ which this thread was originally shown."
>(let ((beg (point-marker))
>  (btn nil))
>  (end-of-line)
> -; Inverse video for subject
> -(overlay-put (make-overlay beg (point)) 'face '(:inverse-video t))
> -(setq btn (make-button beg (point) :type 
> 'notmuch-button-body-toggle-type))
> +(setq btn (make-button beg (point) :type 'notmuch-button-body-toggle-type
> +   'face 'notmuch-show-message-summary-face))
>  (forward-line 1)
>  (end-of-line)
>  (let ((beg-hidden (point-marker)))
> @@ -739,7 +738,8 @@ which this thread was originally shown."
>(forward-line)
>(make-button (line-beginning-position) (line-end-position)
>  'invisibility-spec (cons invis-spec t)
> -:type 'notmuch-button-headers-toggle-type))
> +:type 'notmuch-button-headers-toggle-type
> +'face 'notmuch-show-message-headers-face))
>  (goto-char end)
>  (insert "\n")
>   (set-marker beg nil)
> @@ -959,6 +959,18 @@ thread from that buffer can be show when done with this 
> one)."
>"Notmuch search mode face used to highligh tags."
>:group 'notmuch)
> 
> +(defface notmuch-show-message-summary-face
> +  '((default
> +(:bold t :inverse-video t)))
> +  "Notmuch show mode face used to highlight summary line."
> +  :group 'notmuch)
> +
> +(defface notmuch-show-message-headers-face
> +  '((default
> + (:bold t)))
> +  "Notmuch show mode face used to highlight header lines."
> +  :group 'notmuch)
> +
>  (defvar notmuch-tag-face-alist nil
>"List containing the tag list that need to be highlighed")
> 

The subject line is already have a font face value attached.
message-header-name to show the name of the header and
message-header-subject to show the subject details.

-aneesh  


[notmuch] [PATCH] Allow empty name for thread author with vim plugin

2009-11-30 Thread Jonathan McDowell
Hi.

I've been playing with notmuch + the vim plugin and been getting "ERROR
PARSING" displayed. Turns out this is due to lines like:

thread:55334d46382493cd49226a1a20ad335f   2000-11-20 [1/1] ; New Enquiry (inbox 
unread)

where the author of the mail is empty. The simple patch below seems to
make things happier for me.

Signed-Off-By: Jonathan McDowell 

-
diff --git a/vim/plugin/notmuch.vim b/vim/plugin/notmuch.vim
index b415f50..728adaa 100644
--- a/vim/plugin/notmuch.vim
+++ b/vim/plugin/notmuch.vim
@@ -249,7 +249,7 @@ function! s:NM_cmd_search(words)
 setlocal nowrap
 endfunction
 function! s:NM_cmd_search_fmtline(line)
-let m = matchlist(a:line, '^\(thread:\S\+\)\s\([^]]\+\]\) \([^;]\+\); 
\(.*\) (\([^(]*\))$')
+let m = matchlist(a:line, '^\(thread:\S\+\)\s\([^]]\+\]\) \([^;]*\); 
\(.*\) (\([^(]*\))$')
 if !len(m)
 return 'ERROR PARSING: ' . a:line
 endif
-


J.

-- 
] http://www.earth.li/~noodles/ [] "Why 'maybe' for everything?" "I'm  [
]  PGP/GPG Key @ the.earth.li   []using fluffy logic." [
] via keyserver, web or email.  [] [
] RSA: 4096/2DA8B985[] [


[notmuch] [PATCH 2/9] Adjust autoload comments

2009-11-30 Thread James Rowe
On Sat, 28 Nov 2009 09:27:00 -0800, Keith Amidon  
wrote:
> I was interested in them because the gentoo packaging support for emacs
> includes the ability to automatically create autoloads from these
> comments for installed add-on packages that then get loaded system-wide
> when emacs is started.  

  I have to admit I played with elisp-make-autoload-file in my ebuild
initially, but came to the conclusion there wasn't a great deal of
purpose to exposing more than the main notmuch function. Mostly because
it muddies my emacs and shell autocompletion, and my laziness prevailed.
Am I missing some obviously useful things that can be done if
notmuch-{folder,search} are available directly?

  I just pushed out an update that uses it, mostly so I can see the
reaction of my work colleagues in the morning. So, it may or may not be
there by lunchtime GMT tomorrow :)

> I've my own ebuild using this functionality right now that is just
> slightly different from the one that was posted here a little while ago.
> I've been meaning to merge my version with that one but haven't gotten
> to it yet.

  Post a link! If it is better than mine I'll happily switch our
installs to it.

  If you're merging the two please look at the github version[1] as it
is significantly different from the version I originally posted, almost
entirely as a result of the helpful contributions from others.

  I had planned on posting a patch for inclusion in packaging/Gentoo per
Carl's mail[2], but the whole GPL 2 vs 3 thing made me put it on the
backburner and I haven't looked again. Might still be useful to people
unless there is going to be a "real" release soon, as then it would be
easier to push for it on bugs.gentoo.org.

1. http://github.com/JNRowe/misc-overlay/tree/master/mail-client/notmuch/
2. id:87lji1k014.fsf at yoom.home.cworth.org
-- 
Thanks,

James


[notmuch] [PATCH] notmuch-reply.c: early exit for munged Reply-To when header is not present

2009-11-30 Thread Jed Brown
This avoids erroneously calling internet_address_list_length() with a
NULL list (which was causing a gmime exception).

Signed-off-by: Jed Brown 
---
 notmuch-reply.c |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/notmuch-reply.c b/notmuch-reply.c
index 9b9e9ab..6c9118e 100644
--- a/notmuch-reply.c
+++ b/notmuch-reply.c
@@ -202,7 +202,7 @@ mailing_list_munged_reply_to (notmuch_message_t *message)

 header = notmuch_message_get_header (message, "reply-to");
 list = internet_address_list_parse_string (header);
-if (internet_address_list_length (list) != 1)
+if (list == NULL || internet_address_list_length (list) != 1)
return 0;
 address = internet_address_list_get_address (list, 0);
 if (INTERNET_ADDRESS_IS_GROUP (address))
-- 
1.6.5.3