Re: [PATCH] emacs: tree: drop repeated "of" from docstring

[David Bremner]

Kyle Meyer  writes:

> ---
>  emacs/notmuch-tree.el | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

pushed to master

d
___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH] emacs: change default for notmuch-crypto-process-mime to t

[Brian Sniffen]

Gpg is exposed to some zip bomb problems last I looked. But the worst that 
could do is fill your disk or crash your Emacs, right?  And I suspect the MIME 
library exposes similar issues in quantity. 

-- 
Brian Sniffen

> On Jul 10, 2017, at 4:42 PM, Daniel Kahn Gillmor  
> wrote:
> 
>> On Sun 2017-07-09 07:46:14 -0300, David Bremner wrote:
>> There are some cases like remote usage where this might cause
>> problems, but those users can easily customize the variable. The
>> inconvenience seems to be outweighed by the security benefit for most
>> users.
> 
> lgtm.  i'm not sure that this change is technically a "security
> benefit", though, it looks more like a "usability benefit", since the
> main use of process-crypto is likely to be decrypting messages.
> 
> for signature verification, there's some small security benefit, but
> since it's mainly exposure of interesting information to the user (as
> opposed to blocking users from doing unsafe things) it's still probably
> more on the usability side than security.
> 
> still, i think it's a good change.  If it uncovers performance problems
> on use cases that normal people care about, hopefully we can get
> examples of those use cases and get the performance problems fixed
> (rather than just encouraging those users to set the flag to nil).
> 
> --dkg
> ___
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch

___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch

Re: Emacs "notmuch CLI version mismatch"

[David Edmondson]

On Monday, 2017-07-10 at 17:40:04 -0300, David Bremner wrote:

>>> What is the output of M-x notmuch-hello-versions 
>>
>> notmuch version 0.24.2
>
> That's very suprising, since it should also print the version of notmuch
> emacs mua if it is different from the notmuch version.

Running MELPA on macOS talking over ssh to “unstable” notmuch on Debian
gives me:

notmuch version 0.24.2 (emacs mua version unknown)

which matches your expectation, I think.

dme.
-- 
Tell me sweet little lies.
___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH] emacs: change default for notmuch-crypto-process-mime to t

[Daniel Kahn Gillmor]

On Sun 2017-07-09 07:46:14 -0300, David Bremner wrote:
> There are some cases like remote usage where this might cause
> problems, but those users can easily customize the variable. The
> inconvenience seems to be outweighed by the security benefit for most
> users.

lgtm.  i'm not sure that this change is technically a "security
benefit", though, it looks more like a "usability benefit", since the
main use of process-crypto is likely to be decrypting messages.

for signature verification, there's some small security benefit, but
since it's mainly exposure of interesting information to the user (as
opposed to blocking users from doing unsafe things) it's still probably
more on the usability side than security.

still, i think it's a good change.  If it uncovers performance problems
on use cases that normal people care about, hopefully we can get
examples of those use cases and get the performance problems fixed
(rather than just encouraging those users to set the flag to nil).

 --dkg


signature.asc
Description: PGP signature
___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch

Re: Emacs "notmuch CLI version mismatch"

[David Bremner]

david wen riccardi-zhu  writes:

> Thanks so much, David.
>
>> At a guess, you are using git master of the emacs client (perhaps via
>> melpa, or via some arch git snapshot package), and a released version of
>> the notmuch binary.
>
> I am using MELPA -- does this mean I should be using git to get the
> binary?

I don't see the advantage of using melpa for notmuch. You need notmuch
binaries, and you want them to match the version of your emacs code. So
wherever you get your notmuch binaries from (whether arch, or building
from source) should also be your source of the notmuch emacs code. But
yes, if you insist on using melpa for notmuch-emacs, you should track
the git versions of the notmuch binaries (at least you should update to
current git whenever you get version mismatch messages from the emacs
client).


>> What is the output of M-x notmuch-hello-versions 
>
> notmuch version 0.24.2
>

That's very suprising, since it should also print the version of notmuch
emacs mua if it is different from the notmuch version.
___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch

Re: Emacs "notmuch CLI version mismatch"

[david wen riccardi-zhu]

Thanks so much, David.

> At a guess, you are using git master of the emacs client (perhaps via
> melpa, or via some arch git snapshot package), and a released version of
> the notmuch binary.

I am using MELPA -- does this mean I should be using git to get the
binary?

> What is the output of M-x notmuch-hello-versions 

notmuch version 0.24.2

---
dwrz|朱为文 

On 2017-07-10 18:14, David Bremner wrote:

> david wen riccardi-zhu  writes:
> 
>> I'm getting this error in Emacs after upgrading packages:
>> 
>> notmuch-logged-error: notmuch CLI version mismatch Emacs requested 
>> a newer output format than supported by the notmuch CLI.  You may 
>> need to restart Emacs or upgrade your notmuch package.
> 
> At a guess, you are using git master of the emacs client (perhaps via
> melpa, or via some arch git snapshot package), and a released version of
> the notmuch binary. 
> 
>> The message appears whenever I try to open an email. 
>> 
>> Emacs is 25.2.1, notmuch is 0.24.2. I'm on Arch Linux x86_64.
> 
> What is the output of M-x notmuch-hello-versions 
> 
>> Am I getting this error because Arch needs to update to 0.24.2-2? 
>> Should I switch to git?
> 
> 0.24.2-2 is not an upstream version of notmuch; there is a Debian
> version like that; perhaps arch has a similar versioning scheme. 
> 
>> It would also be nice if this error didn't prevent accessing 
>> messages. : )
> 
> In general this message indicates your emacs lisp components and your
> notmuch binary have drifted dangerously far apart in versions, and you
> should really fix that problem. You can still use the command line
> "notmuch search" and "notmuch show" commands for access to your mail in
> the meantime.
> 
> d___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch

Re: Emacs "notmuch CLI version mismatch"

[David Bremner]

david wen riccardi-zhu  writes:

> I'm getting this error in Emacs after upgrading packages:
>
> notmuch-logged-error: notmuch CLI version mismatch Emacs requested 
> a newer output format than supported by the notmuch CLI.  You may 
> need to restart Emacs or upgrade your notmuch package.
>

At a guess, you are using git master of the emacs client (perhaps via
melpa, or via some arch git snapshot package), and a released version of
the notmuch binary. 

> The message appears whenever I try to open an email. 
>
> Emacs is 25.2.1, notmuch is 0.24.2. I'm on Arch Linux x86_64.

What is the output of M-x notmuch-hello-versions 

> Am I getting this error because Arch needs to update to 0.24.2-2? 
> Should I switch to git?

0.24.2-2 is not an upstream version of notmuch; there is a Debian
version like that; perhaps arch has a similar versioning scheme. 

> It would also be nice if this error didn't prevent accessing 
> messages. : )

In general this message indicates your emacs lisp components and your
notmuch binary have drifted dangerously far apart in versions, and you
should really fix that problem. You can still use the command line
"notmuch search" and "notmuch show" commands for access to your mail in
the meantime.

d





signature.asc
Description: PGP signature
___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch

Emacs "notmuch CLI version mismatch"

[david wen riccardi-zhu]

I'm getting this error in Emacs after upgrading packages:

notmuch-logged-error: notmuch CLI version mismatch Emacs requested 
a newer output format than supported by the notmuch CLI.  You may 
need to restart Emacs or upgrade your notmuch package.


The message appears whenever I try to open an email. 


Emacs is 25.2.1, notmuch is 0.24.2. I'm on Arch Linux x86_64.

I've tried upgrading my OS, and restarting Emacs and the OS, but 
the error persists.


Am I getting this error because Arch needs to update to 0.24.2-2? 
Should I switch to git?


It would also be nice if this error didn't prevent accessing 
messages. : )


Many thanks!
--
dwrz|朱为文
___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch

[PATCH] emacs: tree: drop repeated "of" from docstring

[Kyle Meyer]

---
 emacs/notmuch-tree.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/emacs/notmuch-tree.el b/emacs/notmuch-tree.el
index 6812d7e9..55212626 100644
--- a/emacs/notmuch-tree.el
+++ b/emacs/notmuch-tree.el
@@ -832,7 +832,7 @@ (defun notmuch-tree-insert-forest (forest)
   (mapc 'notmuch-tree-insert-forest-thread forest))
 
 (define-derived-mode notmuch-tree-mode fundamental-mode "notmuch-tree"
-  "Major mode displaying messages (as opposed to threads) of of a notmuch 
search.
+  "Major mode displaying messages (as opposed to threads) of a notmuch search.
 
 This buffer contains the results of a \"notmuch tree\" of your
 email archives. Each line in the buffer represents a single
-- 
2.13.2

___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH] emacs: change default for notmuch-crypto-process-mime to t

[Tomi Ollila]

On Sun, Jul 09 2017, David Bremner wrote:

> There are some cases like remote usage where this might cause
> problems, but those users can easily customize the variable. The
> inconvenience seems to be outweighed by the security benefit for most
> users.
> ---

Trivial enough to LGTM codewise -- too little crypto usage for me to
comment on functionality (other that stronger crypto by default FTW)

Tomi



>  emacs/notmuch-crypto.el | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/emacs/notmuch-crypto.el b/emacs/notmuch-crypto.el
> index 0af727ef..fc2b5301 100644
> --- a/emacs/notmuch-crypto.el
> +++ b/emacs/notmuch-crypto.el
> @@ -24,7 +24,7 @@
>  (require 'epg)
>  (require 'notmuch-lib)
>  
> -(defcustom notmuch-crypto-process-mime nil
> +(defcustom notmuch-crypto-process-mime t
>"Should cryptographic MIME parts be processed?
>  
>  If this variable is non-nil signatures in multipart/signed
> @@ -40,6 +40,7 @@ providing a prefix when viewing a signed or encrypted 
> message, or
>  by providing a prefix when reloading the message in notmuch-show
>  mode."
>:type 'boolean
> +  :package-version '(notmuch . "0.25")
>:group 'notmuch-crypto)
>  
>  (defface notmuch-crypto-part-header
> -- 
> 2.13.2
>
> ___
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch
___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch