Re: Release signatures
On Sun, Feb 10 2019, David Bremner wrote: > Adam Majer writes: >> The releases are signed in a funny way. The .asc file are not detached >> signatures of the checksum, but actually contain it inside the .asc file. >> >> # gpg -v --verify notmuch-0.28.1.tar.gz.sha256.asc >> ... >> gpg: binary signature, digest algorithm SHA256, key algorithm rsa3072 >> gpg: WARNING: not a detached signature; file >> 'notmuch-0.28.1.tar.gz.sha256' was NOT verified! >> >> A much better way of signing this would have been as a detached >> signature of the tarball itself. Why sign a hash of a hash? ;) > > I'm not sure why Carl did it that way 10 years ago. Perhaps Carl > remembers? Offhand, I don't see any reason not to go with a more > standard detached signature, other than it needs someone to do the > relevant work. If I did something non-standard here it certainly wasn't intentional. I certainly would not oppose moving to a more standard (and obvious to us) means of signing the releases. -Carl signature.asc Description: PGP signature ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
emacs tree view usability improvement: notmuch-tree should indicate which message is being shown
hi all-- TIL about tree-view -- pressing 'Z' from a "notmuch-show" buffer is very nice, thanks to all who worked on this feature. I have a small usability improvement to ask for, sorry that my elisp is too weak to propose a patch. when i've hit Z, i get a split emacs view with two buffers -- one is the "notmuch-tree" buffer, and the other is a "notmuch-show" buffer. when i hit enter on a point inside the notmuch-tree buffer, the notmuch-show buffer's contents change. It would be great if the notmuch-tree buffer would maintain a specific marker indicating which message is being shown. As it stands, the highlighted row in notmuch-tree can change if i move where the point is, but don't hit enter -- so one message in notmuch-tree is highlighted, but a different message in displayed in notmuch-show. There are hints that they don't match already, of course -- the metadata about each message is likely to be different, and an astute reader can catch it. Avoiding the confusion entirely by having a distinct indicator of the shown message (e.g. maybe a "─►" to the left of the line corresponding to the message in notmuch-tree) would be pretty nice. --dkg signature.asc Description: PGP signature ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
[PATCH 3/3] python: fix threads.__str__ automethod documentation
Indent the directive properly to attach it to Threads autoclass documentation. Fixes: WARNING: don't know which module to import for autodocumenting '__str__' (try placing a "module" or "currentmodule" directive in the document, or giving an explicit module name) --- bindings/python/docs/source/threads.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bindings/python/docs/source/threads.rst b/bindings/python/docs/source/threads.rst index 4324ac82a389..46ce5be5412a 100644 --- a/bindings/python/docs/source/threads.rst +++ b/bindings/python/docs/source/threads.rst @@ -11,4 +11,4 @@ iterator and broke list(Threads()). Use `len(list(msgs))` instead. -.. automethod:: __str__ + .. automethod:: __str__ -- 2.20.1 ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
[PATCH 2/3] python: fix documentation title underline
Fix documentation build sphinx warning: filesystem.rst:18: WARNING: Title underline too short. --- bindings/python/docs/source/filesystem.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bindings/python/docs/source/filesystem.rst b/bindings/python/docs/source/filesystem.rst index 558c93de592a..13fe11946c46 100644 --- a/bindings/python/docs/source/filesystem.rst +++ b/bindings/python/docs/source/filesystem.rst @@ -15,7 +15,7 @@ Files and directories instead. :class:`Directory` -- A directory entry in the database --- +--- .. autoclass:: Directory -- 2.20.1 ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
[PATCH 1/3] python: fix documentation build with python 3.7
From: Jani Nikula
The simplistic mocking in conf.py falls short on python 3.7. Just use
unittest.mock instead.
Fixes:
Traceback (most recent call last):
File "/usr/lib/python3/dist-packages/sphinx/config.py", line 368, in
eval_config_file
execfile_(filename, namespace)
File "/usr/lib/python3/dist-packages/sphinx/util/pycompat.py", line 150, in
execfile_
exec_(code, _globals)
File "/path/to/notmuch/bindings/python/docs/source/conf.py", line 39, in
from notmuch import __VERSION__,__AUTHOR__
File "/path/to/notmuch/bindings/python/notmuch/__init__.py", line 54, in
from .database import Database
File "/path/to/notmuch/bindings/python/notmuch/database.py", line 25, in
from .globals import (
File "/path/to/notmuch/bindings/python/notmuch/globals.py", line 48, in
class NotmuchDatabaseS(Structure):
TypeError: __mro_entries__ must return a tuple
---
bindings/python/docs/source/conf.py | 13 ++---
1 file changed, 2 insertions(+), 11 deletions(-)
diff --git a/bindings/python/docs/source/conf.py
b/bindings/python/docs/source/conf.py
index 5b901c4ec4d8..8b43c5ca3f9f 100644
--- a/bindings/python/docs/source/conf.py
+++ b/bindings/python/docs/source/conf.py
@@ -13,22 +13,13 @@
import sys, os
+from unittest.mock import Mock
+
# If extensions (or modules to document with autodoc) are in another directory,
# add these directories to sys.path here. If the directory is relative to the
# documentation root, use os.path.abspath to make it absolute, like shown here.
sys.path.insert(0,os.path.abspath('../..'))
-class Mock(object):
-def __init__(self, *args, **kwargs):
-pass
-
-def __call__(self, *args, **kwargs):
-return Mock()
-
-@classmethod
-def __getattr__(self, name):
-return Mock() if name not in ('__file__', '__path__') else '/dev/null'
-
MOCK_MODULES = [
'ctypes',
]
--
2.20.1
___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch
