Re: [PATCH v2 1/3] emacs: test notmuch-show during message decryption
Daniel Kahn Gillmor writes: > We did not have a test showing what message decryption looks like > within notmuch-emacs. This change gives us a baseline for future work > on the notmuch-emacs interface. > --- > > The difference between this and the prior version of the patch is that > it updates T357-index-decryption.sh as well, to ensure all tests pass. > I don't _think_ this is gmime3 related, but I get T357-index-decryption: Testing indexing decrypted mail FAIL indexing message fails when secret key not available --- T357-index-decryption.31.expected 2019-05-03 17:57:26.701988487 + +++ T357-index-decryption.31.output 2019-05-03 17:57:26.701988487 + @@ -1,4 +1,4 @@ #notmuch-dump batch-tag:3 config,properties,tags ++encrypted +inbox +unread -- id:basic-encryp...@crypto.notmuchmail.org +encrypted +inbox +unread -- id:simple-encryp...@crypto.notmuchmail.org #= simple-encryp...@crypto.notmuchmail.org index.decryption=failure -+encrypted +inbox +unread -- id:basic-encryp...@crypto.notmuchmail.org FAIL cleartext index recovery on reindexing with stashed session keys --- T357-index-decryption.33.expected 2019-05-03 17:57:26.817988197 + +++ T357-index-decryption.33.output 2019-05-03 17:57:26.817988197 + @@ -1 +1 @@ -thread:0001 2016-12-22 [1/1] Daniel Kahn Gillmor; encrypted message (encrypted inbox unread) +thread:0002 2016-12-22 [1/1] Daniel Kahn Gillmor; encrypted message (encrypted inbox unread) Applying on top of 103c11822 d ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH v2] emacs: tree: support fold/unfold thread or sub-thread
Julien Masson writes: > > +(defcustom notmuch-tree-overlay-string " [...]" > + "String displayed at the beginning of the overlay" > + :type 'string > + :group 'notmuch-tree) I initially thought this wasn't working because the end of my line was outside the visible window in Emacs. I'm not sure if this is fixable with a sensible amount of effort. I think the docstring needs more context in order to be helpful to users. > > @@ -294,6 +309,7 @@ FUNC." > (define-key map " " 'notmuch-tree-scroll-or-next) > (define-key map (kbd "DEL") 'notmuch-tree-scroll-message-window-back) > (define-key map "e" 'notmuch-tree-resume-message) > +(define-key map "t" 'notmuch-tree-toggle-folding-thread) > map)) What do people think about the choice of 't'? It does something pretty different in notmuch-show-mode > +(defun notmuch-tree-clean-up-overlays () > + "Remove overlays not referenced to any buffer" > + (setq notmuch-tree-overlays (cl-remove-if #'overlay-buffer > notmuch-tree-overlays))) This probably my confusion, but doesn't that remove all of the non-deleted buffers? > +(defun notmuch-tree-toggle-folding-thread ( arg) > + "Fold / Unfold the current thread or sub-thread. > + > +With prefix arg (C-u) the whole thread is folded" Since this is the main entry point, I wonder if you should mention the behaviour with notmuch-tree-overlay-string here. In general we'd like at least one or two two tests for a new feature. Maybe Mark or (other) David in copy can give some suggestions for that. David ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: Support gzipped message file
David Bremner writes: > > If anyone has any other suggestions, please let me know ASAP, otherwise > I may apply the Chomsky rule of code review. Hmm. I might have misattributed the quote about silence and consent to Chomsky. Anyway I pushed the series. d ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH v2 01/15] build: drop support for gmime-2.6
Daniel Kahn Gillmor writes: > From: David Bremner > > GMime 3.0 is over 2 years old now, and 2.6 has been deprecated in > notmuch for about 1.5 years. v2 pushed to master. d ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
