Re: [PATCH 7/9] test: ruby: use much more standard Ruby idioms

2021-05-05 Thread David Bremner
Tomi Ollila  writes:
>
> I am convinced that this is good change (like all the other changes
> in this series). 
>
> Every now and then I encounter ruby code, and have seen syntax like
> `@q.search_threads.each do |t|` been used, so more exposure to that
> syntax is good thing (for everyone (IMO))
>

OK, I've applied the patch (and the others in the series). I have my
(already expressed) reservations, but I don't want to stand in the way
of progress on the ruby bindings.

d

___
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-le...@notmuchmail.org


Re: [RFE] Call `gpg --recv-keys` asynchronously

2021-05-05 Thread Steven Allen
David Bremner  writes:
> Do I misunderstand, or was this fixed in a1d6e406f6f ?

Yes, this was fixed long ago. Thanks!

- Steven


signature.asc
Description: PGP signature
___
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-le...@notmuchmail.org


Re: [PATCH] emacs: restore tag-changes and query bindings for tag hooks

2021-05-05 Thread David Bremner
Kyle Meyer  writes:

> +;; `dlet' isn't available until Emacs 28.1.  Below is a copy, with the
> +;; addition of `with-no-warnings'.
> +(defmacro notmuch-dlet (binders  body)
> +  "Like `let*' but using dynamic scoping."
> +  (declare (indent 1) (debug let))
> +  `(let (_)
> + (with-no-warnings  ; Quiet "lacks a prefix" warning.
> +   ,@(mapcar (lambda (binder)
> +`(defvar ,(if (consp binder) (car binder) binder)))
> +  binders))
> + (let* ,binders ,@body)))
> +
>  (provide 'notmuch-compat)

What do you think Jonas, is this a reasonable approach?

d
___
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-le...@notmuchmail.org


Re: Possible threading issues in nm 0.32

2021-05-05 Thread David Bremner
Michael J Gruber  writes:

> After updating to notmuch 0.32 I noticed a few strange threadings that
> went away after downgrading to 0.31.3 and reindexing. I can't pin-point
> that yet but wanted to give an early warning so you can look out for
> that, too.

I'm not aware of any threading relevant changes in 0.32, but there was a
lot of churn in the library. If you could bisect or give a reproducer
that would be great.
___
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-le...@notmuchmail.org


Possible threading issues in nm 0.32

2021-05-05 Thread Michael J Gruber
Hi there

After updating to notmuch 0.32 I noticed a few strange threadings that
went away after downgrading to 0.31.3 and reindexing. I can't pin-point
that yet but wanted to give an early warning so you can look out for
that, too.

My setup: mail is fetched with mbsync and indexed with "notmuch new"
(with afew run from pre and post hooks in move and tag mode, using the
notmuch bindings).

"Strange threadings": Unrelated mails without relevant headers
(references, in-reply-to) from different folders end up in the same
thread with nm 0.32; reindexing the thread with nm 0.31 puts them in
different threads as expected.

I am using a mix of file and db config as is usual pre 0.32 but that
should not affect threading, I think.

Michael
___
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-le...@notmuchmail.org