Test breakage on EPEL 8 with tree-outline-mode

2023-02-20 Thread Michael J Gruber
Hi there,

the test suite started to fail on EPEL 8 with the new tree-outline-mode:
```
EMACS emacs/notmuch-tree.elc

In notmuch-tree-mode:
emacs/notmuch-tree.el:1088:9:Warning: reference to free variable
`notmuch-tree-outline-enabled'

In notmuch-tree-outline--set-visibility:
emacs/notmuch-tree.el:1322:14:Warning: reference to free variable
`notmuch-tree-outline-mode'
emacs/notmuch-tree.el:1415:20:Error: Wrong number of arguments: (2 . 2), 4
make: *** [emacs/Makefile.local:87: emacs/notmuch-tree.elc] Error 1
```
Does the implementation require a specific emacs version?
EPEL 8 has emacs 26.1.

I am not going to update official notmuch packages for EPEL 8 anyways,
but others might care about older emacs. (I do provide notmuch-git
test packages for EPEL 8 so far.)

Cheers
Michael
___
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-le...@notmuchmail.org


Re: v2 of long filename diagnostics

2023-02-20 Thread David Bremner
David Bremner  writes:

> This one use a more reasonable error code. As far as showing up every
> time, it does if I use --full-scan. That is the same (for me) as
> non-email files.

series applied to master.

d
___
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-le...@notmuchmail.org


Re: [PATCH v9] emacs: notmuch-tree-outline-mode

2023-02-20 Thread David Bremner
"Jose A. Ortega Ruiz"  writes:

> On Mon, Dec 26 2022, David Bremner wrote:
>
>> Amended by db: Copy docstring to manual and edit for presentation. Add
>> two tests.
>
> Thanks for the grunt work, David.  Just a comment on a sloppy comment of
> mine below:
>
>> --- a/emacs/notmuch-tree.el
>> +++ b/emacs/notmuch-tree.el
>> @@ -1014,7 +1014,10 @@ unchanged ADDRESS if parsing fails."
>>  A message tree is another name for a single sub-thread: i.e., a
>>  message together with all its descendents."
>>(let ((msg (car tree))
>> -(replies (cadr tree)))
>> +(replies (cadr tree))
>> +;; outline level, computed from the message's depth and
>> +;; wether or not it's the first message in the tree.
>
> typo: whether

Applied to master, with that fix.

d
___
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-le...@notmuchmail.org


Re: emacs/notmuch hangs opening email

2023-02-20 Thread David Bremner
Jon Fineman  writes:

> When I try and open one specific email, I get a message of
> "Fontifying..." and then the mouse pointer turns into a watch.
>
> If I C-G it breaks out and shows the email message with a red warning
> at the top of "[some mark read tag changes may have failed]", but
> since reading the message was interrupted some/many key mappings
> aren't set, etc.
>

Is the message by chance SMIME signed? That can be fixed on the gpgsm
level. Otherwise, the only thing I can think of is to M-x edebug-defun
on notmuch-show--build-buffer, and step through it to see where it gets
stuck.

d
___
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-le...@notmuchmail.org