Re: [PATCH] Update tox.ini for python3.8 and fix pypy3.6
On Mon 15 Jun 2020 at 07:06 -0300, David Bremner wrote:
> Floris Bruynooghe writes:
>
>> [testenv]
>> deps =
>> @@ -14,3 +14,6 @@ commands = pytest --cov={envsitepackagesdir}/notmuch2
>> {posargs}
>>
>> [testenv:pypy35]
>> basepython = pypy3.5
>> +
>> +[testenv:pypy36]
>> +basepython = pypy3.6
>
> I'm not an expert, but should python 3.7 and python 3.8 have similar
> clauses? Or do they work by default?
They do work by default. But to be honest these two pypy ones are not
fully standardised and rely on me manually ensuring I have both a
pypy3.5 and pypy3.6 binary on my path. The default thing that works is
just a "pypy3" which doesn't give you any guarantees over the version
you get (other than not pypy2).
___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH] Update tox.ini for python3.8 and fix pypy3.6
Floris Bruynooghe writes: > Python 3.8 has been released for a while now, make sure we keep > supporting it correctly. > > PyPy 3.6 wasn not configured correctly. merged to origin and master d ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH] Update tox.ini for python3.8 and fix pypy3.6
Tomi Ollila writes:
> On Mon, Jun 15 2020, David Bremner wrote:
>
>> Floris Bruynooghe writes:
>>
>>> [testenv]
>>> deps =
>>> @@ -14,3 +14,6 @@ commands = pytest --cov={envsitepackagesdir}/notmuch2
>>> {posargs}
>>>
>>> [testenv:pypy35]
>>> basepython = pypy3.5
>>> +
>>> +[testenv:pypy36]
>>> +basepython = pypy3.6
>>
>> I'm not an expert, but should python 3.7 and python 3.8 have similar
>> clauses? Or do they work by default?
>
> "Python 3.6 compatible PyPy3.6 v7.3.1" in https://www.pypy.org/download.html
> hints there are not (yet) pypy3.7 nor pypy3.8
Oh sorry. I really should read better. I even knew that about pypy. OK,
no objections to the patch as is.
d
___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH] Update tox.ini for python3.8 and fix pypy3.6
On Mon, Jun 15 2020, David Bremner wrote:
> Floris Bruynooghe writes:
>
>> [testenv]
>> deps =
>> @@ -14,3 +14,6 @@ commands = pytest --cov={envsitepackagesdir}/notmuch2
>> {posargs}
>>
>> [testenv:pypy35]
>> basepython = pypy3.5
>> +
>> +[testenv:pypy36]
>> +basepython = pypy3.6
>
> I'm not an expert, but should python 3.7 and python 3.8 have similar
> clauses? Or do they work by default?
"Python 3.6 compatible PyPy3.6 v7.3.1" in https://www.pypy.org/download.html
hints there are not (yet) pypy3.7 nor pypy3.8
>
> d
Tomi
___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH] Update tox.ini for python3.8 and fix pypy3.6
Floris Bruynooghe writes:
> [testenv]
> deps =
> @@ -14,3 +14,6 @@ commands = pytest --cov={envsitepackagesdir}/notmuch2
> {posargs}
>
> [testenv:pypy35]
> basepython = pypy3.5
> +
> +[testenv:pypy36]
> +basepython = pypy3.6
I'm not an expert, but should python 3.7 and python 3.8 have similar
clauses? Or do they work by default?
d
___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch
[PATCH] Update tox.ini for python3.8 and fix pypy3.6
Python 3.8 has been released for a while now, make sure we keep
supporting it correctly.
PyPy 3.6 wasn not configured correctly.
---
bindings/python-cffi/tox.ini | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/bindings/python-cffi/tox.ini b/bindings/python-cffi/tox.ini
index 34148a11..7cf93be0 100644
--- a/bindings/python-cffi/tox.ini
+++ b/bindings/python-cffi/tox.ini
@@ -3,7 +3,7 @@ minversion = 3.0
addopts = -ra --cov=notmuch2 --cov=tests
[tox]
-envlist = py35,py36,py37,pypy35,pypy36
+envlist = py35,py36,py37,py38,pypy35,pypy36
[testenv]
deps =
@@ -14,3 +14,6 @@ commands = pytest --cov={envsitepackagesdir}/notmuch2
{posargs}
[testenv:pypy35]
basepython = pypy3.5
+
+[testenv:pypy36]
+basepython = pypy3.6
--
2.27.0
___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch
