[PATCH] contrib: pick: use the sexp parser

2013-06-02 Thread Mark Walters

Tomi Ollila  writes:

> These trivial changes look good -- is sexp already supported in show ?

At the moment sexp is not supported in show (despite that using
synchronous command so it is much easier). I posted a (not good) at
id:1354975891-24663-1-git-send-email-markwalters1009 at gmail.com and in
Austin's reply he suggested a much better way of doing is. But I never posted a
corrected version (perhaps I was waiting for the error handling stuff to
clear?).

Best wishes

Mark

>
> Tomi
>
>>
>>  contrib/notmuch-pick/notmuch-pick.el |5 ++---
>>  1 files changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/contrib/notmuch-pick/notmuch-pick.el 
>> b/contrib/notmuch-pick/notmuch-pick.el
>> index 128fabf..33905d6 100644
>> --- a/contrib/notmuch-pick/notmuch-pick.el
>> +++ b/contrib/notmuch-pick/notmuch-pick.el
>> @@ -773,8 +773,7 @@ Complete list of currently available key bindings:
>>  (save-excursion
>>(goto-char (point-max))
>>(insert string))
>> -(notmuch-json-parse-partial-list 'notmuch-pick-insert-forest-thread
>> - 'notmuch-pick-show-error
>> +(notmuch-sexp-parse-partial-list 'notmuch-pick-insert-forest-thread
>>   results-buf)
>>  
>>  (defun notmuch-pick-worker (basic-query  query-context target 
>> buffer)
>> @@ -796,7 +795,7 @@ Complete list of currently available key bindings:
>>  (if notmuch-pick-asynchronous-parser
>>  (let ((proc (start-process
>>   "notmuch-pick" buffer
>> - notmuch-command "show" "--body=false" "--format=json"
>> + notmuch-command "show" "--body=false" "--format=sexp"
>>   message-arg search-args))
>>;; Use a scratch buffer to accumulate partial output.
>>;; This buffer will be killed by the sentinel, which
>> -- 
>> 1.7.9.1
>>
>> ___
>> notmuch mailing list
>> notmuch at notmuchmail.org
>> http://notmuchmail.org/mailman/listinfo/notmuch


[PATCH] contrib: pick: use the sexp parser

2013-06-02 Thread David Bremner
Mark Walters  writes:

> This just converts notmuch-pick to use the sexp parser.
> ---

Pushed.

d


[PATCH] contrib: pick: use the sexp parser

2013-06-02 Thread Tomi Ollila
On Sat, Jun 01 2013, Mark Walters  wrote:

> This just converts notmuch-pick to use the sexp parser.
> ---

These trivial changes look good -- is sexp already supported in show ?

Tomi

>
>  contrib/notmuch-pick/notmuch-pick.el |5 ++---
>  1 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/contrib/notmuch-pick/notmuch-pick.el 
> b/contrib/notmuch-pick/notmuch-pick.el
> index 128fabf..33905d6 100644
> --- a/contrib/notmuch-pick/notmuch-pick.el
> +++ b/contrib/notmuch-pick/notmuch-pick.el
> @@ -773,8 +773,7 @@ Complete list of currently available key bindings:
>  (save-excursion
>(goto-char (point-max))
>(insert string))
> - (notmuch-json-parse-partial-list 'notmuch-pick-insert-forest-thread
> -  'notmuch-pick-show-error
> + (notmuch-sexp-parse-partial-list 'notmuch-pick-insert-forest-thread
>results-buf)
>  
>  (defun notmuch-pick-worker (basic-query  query-context target 
> buffer)
> @@ -796,7 +795,7 @@ Complete list of currently available key bindings:
>  (if notmuch-pick-asynchronous-parser
>   (let ((proc (start-process
>"notmuch-pick" buffer
> -  notmuch-command "show" "--body=false" "--format=json"
> +  notmuch-command "show" "--body=false" "--format=sexp"
>message-arg search-args))
> ;; Use a scratch buffer to accumulate partial output.
>;; This buffer will be killed by the sentinel, which
> -- 
> 1.7.9.1
>
> ___
> notmuch mailing list
> notmuch at notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch


Re: [PATCH] contrib: pick: use the sexp parser

2013-06-02 Thread David Bremner
Mark Walters markwalters1...@gmail.com writes:

 This just converts notmuch-pick to use the sexp parser.
 ---

Pushed.

d
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch


[PATCH] contrib: pick: use the sexp parser

2013-06-01 Thread Mark Walters
This just converts notmuch-pick to use the sexp parser.
---

 contrib/notmuch-pick/notmuch-pick.el |5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/contrib/notmuch-pick/notmuch-pick.el 
b/contrib/notmuch-pick/notmuch-pick.el
index 128fabf..33905d6 100644
--- a/contrib/notmuch-pick/notmuch-pick.el
+++ b/contrib/notmuch-pick/notmuch-pick.el
@@ -773,8 +773,7 @@ Complete list of currently available key bindings:
 (save-excursion
   (goto-char (point-max))
   (insert string))
-   (notmuch-json-parse-partial-list 'notmuch-pick-insert-forest-thread
-'notmuch-pick-show-error
+   (notmuch-sexp-parse-partial-list 'notmuch-pick-insert-forest-thread
 results-buf)

 (defun notmuch-pick-worker (basic-query  query-context target buffer)
@@ -796,7 +795,7 @@ Complete list of currently available key bindings:
 (if notmuch-pick-asynchronous-parser
(let ((proc (start-process
 "notmuch-pick" buffer
-notmuch-command "show" "--body=false" "--format=json"
+notmuch-command "show" "--body=false" "--format=sexp"
 message-arg search-args))
  ;; Use a scratch buffer to accumulate partial output.
   ;; This buffer will be killed by the sentinel, which
-- 
1.7.9.1



[PATCH] contrib: pick: use the sexp parser

2013-06-01 Thread Mark Walters
This just converts notmuch-pick to use the sexp parser.
---

 contrib/notmuch-pick/notmuch-pick.el |5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/contrib/notmuch-pick/notmuch-pick.el 
b/contrib/notmuch-pick/notmuch-pick.el
index 128fabf..33905d6 100644
--- a/contrib/notmuch-pick/notmuch-pick.el
+++ b/contrib/notmuch-pick/notmuch-pick.el
@@ -773,8 +773,7 @@ Complete list of currently available key bindings:
 (save-excursion
   (goto-char (point-max))
   (insert string))
-   (notmuch-json-parse-partial-list 'notmuch-pick-insert-forest-thread
-'notmuch-pick-show-error
+   (notmuch-sexp-parse-partial-list 'notmuch-pick-insert-forest-thread
 results-buf)
 
 (defun notmuch-pick-worker (basic-query optional query-context target buffer)
@@ -796,7 +795,7 @@ Complete list of currently available key bindings:
 (if notmuch-pick-asynchronous-parser
(let ((proc (start-process
 notmuch-pick buffer
-notmuch-command show --body=false --format=json
+notmuch-command show --body=false --format=sexp
 message-arg search-args))
  ;; Use a scratch buffer to accumulate partial output.
   ;; This buffer will be killed by the sentinel, which
-- 
1.7.9.1

___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch