[PATCH] emacs: Move the blank line from the bottom of the headers to the top of the body.

2012-02-04 Thread David Bremner 
On Mon, 30 Jan 2012 16:52:20 +, David Edmondson  wrote:
> The blank line doesn't really change position, but is now considered
> to be part of the body rather than part of the headers. This means
> that it is visible when the body is visible rather than when the
> headers are visible.

pushed.

d

Re: [PATCH] emacs: Move the blank line from the bottom of the headers to the top of the body.

2012-02-04 Thread David Bremner 
On Mon, 30 Jan 2012 16:52:20 +, David Edmondson d...@dme.org wrote:
 The blank line doesn't really change position, but is now considered
 to be part of the body rather than part of the headers. This means
 that it is visible when the body is visible rather than when the
 headers are visible.

pushed.

d
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH] emacs: Move the blank line from the bottom of the headers to the top of the body.

2012-01-31 Thread Dmitry Kurochkin 
On Mon, 30 Jan 2012 16:52:20 +, David Edmondson  wrote:
> The blank line doesn't really change position, but is now considered
> to be part of the body rather than part of the headers. This means
> that it is visible when the body is visible rather than when the
> headers are visible.
> ---
> 
> I'm interested in getting feedback on this.
> 
> Unless you run with `notmuch-message-headers-visible' set to `nil' or
> regularly toggle header visibility, you probably don't care.
> 

+1

Regards,
  Dmitry

>  emacs/notmuch-show.el |4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
> index 84ac624..73f73d4 100644
> --- a/emacs/notmuch-show.el
> +++ b/emacs/notmuch-show.el
> @@ -854,8 +854,6 @@ current buffer, if possible."
>  ;; compatible with the existing implementation. This just sets it
>  ;; to after the first header.
>  (notmuch-show-insert-headers headers)
> -;; Headers should include a blank line (backwards compatibility).
> -(insert "\n")
>  (save-excursion
>(goto-char content-start)
>;; If the subject of this message is the same as that of the
> @@ -870,6 +868,8 @@ current buffer, if possible."
>  (setq notmuch-show-previous-subject bare-subject)
>  
>  (setq body-start (point-marker))
> +;; A blank line between the headers and the body.
> +(insert "\n")
>  (notmuch-show-insert-body msg (plist-get msg :body) depth)
>  ;; Ensure that the body ends with a newline.
>  (unless (bolp)
> -- 
> 1.7.8.3
> 
> ___
> notmuch mailing list
> notmuch at notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH] emacs: Move the blank line from the bottom of the headers to the top of the body.

2012-01-31 Thread Tomi Ollila 
On Tue, 31 Jan 2012 10:32:12 +, David Edmondson  wrote:
> On Mon, 30 Jan 2012 21:25:19 -0800, Jameson Graef Rollins  finestructure.net> wrote:
> > On Mon, 30 Jan 2012 16:52:20 +, David Edmondson  wrote:
> > > The blank line doesn't really change position, but is now considered
> > > to be part of the body rather than part of the headers. This means
> > > that it is visible when the body is visible rather than when the
> > > headers are visible.
> > 
> > This definitely makes sense.  I rarely hide headers anymore, but I never
> > liked that the separation between the headers and the body went away
> > when the headers are hidden.  +1.
> 
> Any objections to changing this?

+1 for changing this.


Tomi

[PATCH] emacs: Move the blank line from the bottom of the headers to the top of the body.

2012-01-31 Thread David Edmondson 
On Mon, 30 Jan 2012 21:25:19 -0800, Jameson Graef Rollins  wrote:
> On Mon, 30 Jan 2012 16:52:20 +, David Edmondson  wrote:
> > The blank line doesn't really change position, but is now considered
> > to be part of the body rather than part of the headers. This means
> > that it is visible when the body is visible rather than when the
> > headers are visible.
> 
> This definitely makes sense.  I rarely hide headers anymore, but I never
> liked that the separation between the headers and the body went away
> when the headers are hidden.  +1.

Any objections to changing this?
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL:

Re: [PATCH] emacs: Move the blank line from the bottom of the headers to the top of the body.

2012-01-31 Thread David Edmondson 
On Mon, 30 Jan 2012 21:25:19 -0800, Jameson Graef Rollins 
jroll...@finestructure.net wrote:
 On Mon, 30 Jan 2012 16:52:20 +, David Edmondson d...@dme.org wrote:
  The blank line doesn't really change position, but is now considered
  to be part of the body rather than part of the headers. This means
  that it is visible when the body is visible rather than when the
  headers are visible.
 
 This definitely makes sense.  I rarely hide headers anymore, but I never
 liked that the separation between the headers and the body went away
 when the headers are hidden.  +1.

Any objections to changing this?


pgpjPnVLIrt7o.pgp
Description: PGP signature
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH] emacs: Move the blank line from the bottom of the headers to the top of the body.

2012-01-30 Thread Jameson Graef Rollins 
On Mon, 30 Jan 2012 16:52:20 +, David Edmondson  wrote:
> The blank line doesn't really change position, but is now considered
> to be part of the body rather than part of the headers. This means
> that it is visible when the body is visible rather than when the
> headers are visible.

This definitely makes sense.  I rarely hide headers anymore, but I never
liked that the separation between the headers and the body went away
when the headers are hidden.  +1.

jamie.
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL:

[PATCH] emacs: Move the blank line from the bottom of the headers to the top of the body.

2012-01-30 Thread David Edmondson 
The blank line doesn't really change position, but is now considered
to be part of the body rather than part of the headers. This means
that it is visible when the body is visible rather than when the
headers are visible.
---

I'm interested in getting feedback on this.

Unless you run with `notmuch-message-headers-visible' set to `nil' or
regularly toggle header visibility, you probably don't care.

 emacs/notmuch-show.el |4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index 84ac624..73f73d4 100644
--- a/emacs/notmuch-show.el
+++ b/emacs/notmuch-show.el
@@ -854,8 +854,6 @@ current buffer, if possible."
 ;; compatible with the existing implementation. This just sets it
 ;; to after the first header.
 (notmuch-show-insert-headers headers)
-;; Headers should include a blank line (backwards compatibility).
-(insert "\n")
 (save-excursion
   (goto-char content-start)
   ;; If the subject of this message is the same as that of the
@@ -870,6 +868,8 @@ current buffer, if possible."
 (setq notmuch-show-previous-subject bare-subject)

 (setq body-start (point-marker))
+;; A blank line between the headers and the body.
+(insert "\n")
 (notmuch-show-insert-body msg (plist-get msg :body) depth)
 ;; Ensure that the body ends with a newline.
 (unless (bolp)
-- 
1.7.8.3

[PATCH] emacs: Move the blank line from the bottom of the headers to the top of the body.

2012-01-30 Thread David Edmondson 
The blank line doesn't really change position, but is now considered
to be part of the body rather than part of the headers. This means
that it is visible when the body is visible rather than when the
headers are visible.
---

I'm interested in getting feedback on this.

Unless you run with `notmuch-message-headers-visible' set to `nil' or
regularly toggle header visibility, you probably don't care.

 emacs/notmuch-show.el |4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index 84ac624..73f73d4 100644
--- a/emacs/notmuch-show.el
+++ b/emacs/notmuch-show.el
@@ -854,8 +854,6 @@ current buffer, if possible.
 ;; compatible with the existing implementation. This just sets it
 ;; to after the first header.
 (notmuch-show-insert-headers headers)
-;; Headers should include a blank line (backwards compatibility).
-(insert \n)
 (save-excursion
   (goto-char content-start)
   ;; If the subject of this message is the same as that of the
@@ -870,6 +868,8 @@ current buffer, if possible.
 (setq notmuch-show-previous-subject bare-subject)
 
 (setq body-start (point-marker))
+;; A blank line between the headers and the body.
+(insert \n)
 (notmuch-show-insert-body msg (plist-get msg :body) depth)
 ;; Ensure that the body ends with a newline.
 (unless (bolp)
-- 
1.7.8.3

___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch