Re: [PATCH] emacs: remove useless lexically bound variable

[David Bremner]

David Bremner  writes:

> A let binding without a value is just an obfuscated way of saying
> nil, especially if you are not going to mutate the variable.

applied to master
___
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-le...@notmuchmail.org

Re: [PATCH] emacs: remove useless lexically bound variable

[Jonas Bernoulli]

+1 (I was gonna suggest the same change.)

David Bremner  writes:

> A let binding without a value is just an obfuscated way of saying
> nil, especially if you are not going to mutate the variable.
> ---
>  emacs/notmuch-tree.el | 7 +++
>  1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/emacs/notmuch-tree.el b/emacs/notmuch-tree.el
> index b288c05d..eb7ea941 100644
> --- a/emacs/notmuch-tree.el
> +++ b/emacs/notmuch-tree.el
> @@ -1001,10 +1001,9 @@ message together with all its descendents."
>  
>  (defun notmuch-tree-insert-forest-thread (forest-thread)
>"Insert a single complete thread."
> -  (let (tree-status)
> -;; Reset at the start of each main thread.
> -(setq notmuch-tree-previous-subject nil)
> -(notmuch-tree-insert-thread forest-thread 0 tree-status)))
> +  ;; Reset at the start of each main thread.
> +  (setq notmuch-tree-previous-subject nil)
> +  (notmuch-tree-insert-thread forest-thread 0 nil))
>  
>  (defun notmuch-tree-insert-forest (forest)
>"Insert a forest of threads.
> -- 
> 2.30.2
> ___
> notmuch mailing list -- notmuch@notmuchmail.org
> To unsubscribe send an email to notmuch-le...@notmuchmail.org
___
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-le...@notmuchmail.org

[PATCH] emacs: remove useless lexically bound variable

[David Bremner]

A let binding without a value is just an obfuscated way of saying
nil, especially if you are not going to mutate the variable.
---
 emacs/notmuch-tree.el | 7 +++
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/emacs/notmuch-tree.el b/emacs/notmuch-tree.el
index b288c05d..eb7ea941 100644
--- a/emacs/notmuch-tree.el
+++ b/emacs/notmuch-tree.el
@@ -1001,10 +1001,9 @@ message together with all its descendents."
 
 (defun notmuch-tree-insert-forest-thread (forest-thread)
   "Insert a single complete thread."
-  (let (tree-status)
-;; Reset at the start of each main thread.
-(setq notmuch-tree-previous-subject nil)
-(notmuch-tree-insert-thread forest-thread 0 tree-status)))
+  ;; Reset at the start of each main thread.
+  (setq notmuch-tree-previous-subject nil)
+  (notmuch-tree-insert-thread forest-thread 0 nil))
 
 (defun notmuch-tree-insert-forest (forest)
   "Insert a forest of threads.
-- 
2.30.2
___
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-le...@notmuchmail.org