[PATCH] test: Force reply to use html2text for consistency

[Tomi Ollila]

On Mon, May 07 2012, David Bremner  wrote:

> Adam Wolfe Gordon  writes:
>
>> The output of the HTML reply test in the emacs suite can vary
>> depending on which HTML renderers are installed on the machine running
>> the tests. The renderer that is always available is emacs's builtin
>> html2text function. In order to get consistency, force the test to use
>> html2text even if other renderers are available.
>
> pushed, and it seems to replicate the test results on the buildbot. If
> html2text ever gets less crappy I guess we'll have to redo the test
> data.

If html2text ever gets less crappy then we face the same problem -- users
with different emacs get different rendering output making tests fail
for some users.

Then we can do "(let ... (mm-text-html-renderer 'mm-insert-part))

to get html inserted unmodified; excerpt from test output using above:

 -> Hi,This is an HTML test message.OK?
 +> Hi,This is an HTML test message.OK?

>
> d

Tomi

Re: [PATCH] test: Force reply to use html2text for consistency

[Tomi Ollila]

On Mon, May 07 2012, David Bremner da...@tethera.net wrote:

 Adam Wolfe Gordon awg+notm...@xvx.ca writes:

 The output of the HTML reply test in the emacs suite can vary
 depending on which HTML renderers are installed on the machine running
 the tests. The renderer that is always available is emacs's builtin
 html2text function. In order to get consistency, force the test to use
 html2text even if other renderers are available.

 pushed, and it seems to replicate the test results on the buildbot. If
 html2text ever gets less crappy I guess we'll have to redo the test
 data.

If html2text ever gets less crappy then we face the same problem -- users
with different emacs get different rendering output making tests fail
for some users.

Then we can do (let ... (mm-text-html-renderer 'mm-insert-part))

to get html inserted unmodified; excerpt from test output using above:

 - Hi,This is an HTML test message.OK?
 + Hi,br /This is an bHTML/b test message.br /br /OK?


 d

Tomi
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH] test: Force reply to use html2text for consistency

[David Bremner]

Adam Wolfe Gordon  writes:

> The output of the HTML reply test in the emacs suite can vary
> depending on which HTML renderers are installed on the machine running
> the tests. The renderer that is always available is emacs's builtin
> html2text function. In order to get consistency, force the test to use
> html2text even if other renderers are available.

pushed, and it seems to replicate the test results on the buildbot. If
html2text ever gets less crappy I guess we'll have to redo the test
data.

d

[PATCH] test: Force reply to use html2text for consistency

[Adam Wolfe Gordon]

The output of the HTML reply test in the emacs suite can vary
depending on which HTML renderers are installed on the machine running
the tests. The renderer that is always available is emacs's builtin
html2text function. In order to get consistency, force the test to use
html2text even if other renderers are available.
---

As discussed on IRC, here's a patch that forces the HTML reply test to use
html2text, and adjusts the output accordingly. This should fix the test
failure on the buildbot.

 test/emacs |7 ++-
 1 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/test/emacs b/test/emacs
index a615b39..e9f954c 100755
--- a/test/emacs
+++ b/test/emacs
@@ -447,7 +447,7 @@ test_expect_equal_file OUTPUT EXPECTED
 test_begin_subtest "Reply within emacs to an html-only message"
 add_message '[content-type]="text/html"' \
'[body]="Hi,This is an HTML test message.OK?"'
-test_emacs "(let ((message-hidden-headers '()))
+test_emacs "(let ((message-hidden-headers '()) (mm-text-html-renderer 
'html2text))
(notmuch-show \"id:${gen_msg_id}\")
(notmuch-show-reply)
(test-output))"
@@ -463,10 +463,7 @@ User-Agent: Notmuch/XXX Emacs/XXX
 --text follows this line--
 Notmuch Test Suite  writes:

-> Hi,
-> This is an HTML test message.
->
-> OK?
+> Hi,This is an HTML test message.OK?
 EOF
 test_expect_equal_file OUTPUT EXPECTED

-- 
1.7.5.4

[PATCH] test: Force reply to use html2text for consistency

[Adam Wolfe Gordon]

The output of the HTML reply test in the emacs suite can vary
depending on which HTML renderers are installed on the machine running
the tests. The renderer that is always available is emacs's builtin
html2text function. In order to get consistency, force the test to use
html2text even if other renderers are available.
---

As discussed on IRC, here's a patch that forces the HTML reply test to use
html2text, and adjusts the output accordingly. This should fix the test
failure on the buildbot.

 test/emacs |7 ++-
 1 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/test/emacs b/test/emacs
index a615b39..e9f954c 100755
--- a/test/emacs
+++ b/test/emacs
@@ -447,7 +447,7 @@ test_expect_equal_file OUTPUT EXPECTED
 test_begin_subtest Reply within emacs to an html-only message
 add_message '[content-type]=text/html' \
'[body]=Hi,br /This is an bHTML/b test message.br /br 
/OK?'
-test_emacs (let ((message-hidden-headers '()))
+test_emacs (let ((message-hidden-headers '()) (mm-text-html-renderer 
'html2text))
(notmuch-show \id:${gen_msg_id}\)
(notmuch-show-reply)
(test-output))
@@ -463,10 +463,7 @@ User-Agent: Notmuch/XXX Emacs/XXX
 --text follows this line--
 Notmuch Test Suite test_su...@notmuchmail.org writes:
 
- Hi,
- This is an HTML test message.
-
- OK?
+ Hi,This is an HTML test message.OK?
 EOF
 test_expect_equal_file OUTPUT EXPECTED
 
-- 
1.7.5.4

___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH] test: Force reply to use html2text for consistency

[David Bremner]

Adam Wolfe Gordon awg+notm...@xvx.ca writes:

 The output of the HTML reply test in the emacs suite can vary
 depending on which HTML renderers are installed on the machine running
 the tests. The renderer that is always available is emacs's builtin
 html2text function. In order to get consistency, force the test to use
 html2text even if other renderers are available.

pushed, and it seems to replicate the test results on the buildbot. If
html2text ever gets less crappy I guess we'll have to redo the test
data.

d
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch