On Sun, Jul 26 2020, Jonas Bernoulli wrote:
> Hello,
>
> Please forgive me for this wall of unsolicited cleanup; I blame it
> on a mild form of ocd. I made most of these changes a few months
> ago when I was splitting the libraries into `outline-minor-mode'
> compatible sections. To do so I had to have some understanding of the
> code I was splitting up and that closer look led to me discovering
> issues and once I had ran into a bunch of issue of the same kind it
> made sense to systematically look for that kind across all elisp
> files.
>
> Well, one thing led to another and here we are with 23 cleanup
> commits, some of which are fairly big on their own. I just looked
> at very change again; everything looks to be in order.
>
> I am intentionally leaving out that one commit that actually does
> what I originally set out to do. In some cases I will need to gain
> a deeper understanding before I can finish splitting libraries into
> sections.
Series looks good to me (as far as I can tell). That one comment
indentation in id:20200726165818.400-4-jo...@bernoul.li is what popped up
in my review (I did review only diff patch, and don't know how that
actually look -- like in those spaces after do in my previous reply, those
look good to me now)
One thing that come into my minw while browsing through patches -- does
changing if's to when's accumulate any bloat -- or does byte compiler
optimize that "extra" 'progn out in (list 'if cond (cons 'progn body))).
>
> Cheers,
> Jonas
Tomi
>
> Jonas Bernoulli (23):
> emacs: Shorten long lines
> emacs: Remove excess empty lines
> emacs: Fix indentation
> emacs: Closing parenthesis go on the same line
> emacs: Only set one variable per setq form
> emacs: Use cl-incf where appropriate
> emacs: Use 'and' instead of 'when' when the return value matters
> emacs: Use 'unless' instead of 'when' and 'not'
> emacs: Use 'when' instead of 'if' when there is no ELSE part
> emacs: Use one or three lines for 'if' forms
> emacs: Extend face to window edge again
> emacs: Fix some function declarations
> emacs: No longer define notmuch-hello-mode-map as a function
> emacs: notmuch-poll: Let the user know we are polling
> emacs: Use makefile-gmake-mode in Makefile*s
> emacs: Improve doc-strings
> emacs: Autoload notmuch-jump-search only once
> emacs: Autoload notmuch-jump using an autoload cookie
> emacs: Various cosmetic changes
> emacs: Increase consistency of library headers
> Fix typos
> .dir-locals.el: Set variables for correct "shell" mode
> test: Fix indentation
>
> .dir-locals.el | 2 +-
> Makefile.global| 1 +
> Makefile.local | 2 +-
> NEWS | 2 +-
> bindings/Makefile.local| 2 +-
> bindings/python-cffi/notmuch2/__init__.py | 2 +-
> bindings/python-cffi/notmuch2/_base.py | 6 +-
> bindings/python-cffi/notmuch2/_database.py | 8 +-
> bindings/python-cffi/notmuch2/_message.py | 4 +-
> bindings/python-cffi/notmuch2/_tags.py | 8 +-
> bindings/python-cffi/tests/conftest.py | 2 +-
> bindings/python/notmuch/database.py| 12 +-
> bindings/python/notmuch/query.py | 2 +-
> compat/Makefile.local | 2 +-
> completion/Makefile.local | 2 +-
> doc/Makefile.local | 2 +-
> emacs/Makefile.local | 2 +-
> emacs/coolj.el | 24 +-
> emacs/make-deps.el | 5 +-
> emacs/notmuch-address.el | 186 -
> emacs/notmuch-company.el | 53 ++-
> emacs/notmuch-compat.el| 99 +++--
> emacs/notmuch-crypto.el| 49 ++-
> emacs/notmuch-draft.el | 24 +-
> emacs/notmuch-hello.el | 102 +++--
> emacs/notmuch-jump.el | 61 ++-
> emacs/notmuch-lib.el | 204 +-
> emacs/notmuch-maildir-fcc.el | 122 +++---
> emacs/notmuch-message.el | 3 +-
> emacs/notmuch-mua.el | 181 -
> emacs/notmuch-parser.el| 16 +-
> emacs/notmuch-print.el | 2 +-
> emacs/notmuch-query.el | 29 +-
> emacs/notmuch-show.el | 439 ++---
> emacs/notmuch-tag.el | 38 +-
> emacs/notmuch-tree.el | 189 -
> emacs/notmuch-wash.el | 109 +++--
> emacs/notmuch.el | 276 ++---
> emacs/rstdoc.el| 18 +-
> lib/Makefile.local | 2 +-
> lib/notmuch.h | 4 +-
> parse-time-string/Makefile.local | 2 +
> performanc
