[PATCH 1/3] emacs: modify help message for notmuch-search-line-faces to reflect preferred "deleted" tag name.

[David Bremner]

Jameson Graef Rollins  writes:

> No functional change here.  The help message previously referred to
> the "delete" tag, but "deleted" is now preferred, so hopefully this
> will reduce any potential confusion.

I pushed this one patch from the series.

d

Re: [PATCH 1/3] emacs: modify help message for notmuch-search-line-faces to reflect preferred deleted tag name.

[David Bremner]

Jameson Graef Rollins jroll...@finestructure.net writes:

 No functional change here.  The help message previously referred to
 the delete tag, but deleted is now preferred, so hopefully this
 will reduce any potential confusion.

I pushed this one patch from the series.

d
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH 1/3] emacs: modify help message for notmuch-search-line-faces to reflect preferred "deleted" tag name.

[Tomi Ollila]

On Mon, Apr 16 2012, Jameson Graef Rollins  
wrote:

> On Sun, Apr 15 2012, Tomi Ollila  wrote:
>> id:"1326826969-23545-1-git-send-email-jrollins at finestructure.net"
>>
>> Does just "delete" -> "deleted" change: the only question I have left
>> is that should that be left as is, this change made, or just drop
>> the "delete" coloring altogether ?
>
> Sorry, yes, I suppose this patch should still be applied.  Excludes for
> "deleted" are the default, I believe, so if we are going to refer to it
> in documentation we should probably be consistent.

That said, the following change in nmbug repository

D1326826969-23545-1-git-send-email-jrollins at finestructure.net 
needs-review
A1326826969-23545-1-git-send-email-jrollins at finestructure.net trivial

pushed.

Tomi

>
> On Sun, Apr 15 2012, Jameson Graef Rollins  
> wrote:
>> On Sun, Apr 15 2012, Mark Walters  wrote:
>>> I think the rest of the series (which provides keybindings for
>>> adding/removing the delete tag to messages/threads) is worthwhile
>>> particularly now the exclude stuff is fairly complete (feedback at the
>>> time looked positive).
>>
>> Sorry, I wish I could have purged all of these series from the list.
>> After a very protracted discussion on the topic it was decided that
>> notmuch will not support any delete tagging operations.  Users who wish
>> to do so can add support on their own:
>
> I think my reaction here was a little strong.  I'm not remembering how I
> got the impression that there was more opposition to adding delete
> keybindings than there was support.  I suppose now that excludes work so
> well one (not me) might consider revisiting the issue.
>
> jamie.
> ___
> notmuch mailing list
> notmuch at notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH 1/3] emacs: modify help message for notmuch-search-line-faces to reflect preferred "deleted" tag name.

[Tomi Ollila]

On Sun, Apr 15 2012, Jameson Graef Rollins  
wrote:

> On Sun, Apr 15 2012, Mark Walters  wrote:
>> This patch is trivially correct regardless of the rest of the
>> series. 
>>
>> I think the rest of the series (which provides keybindings for
>> adding/removing the delete tag to messages/threads) is worthwhile
>> particularly now the exclude stuff is fairly complete (feedback at the
>> time looked positive).
>
> Sorry, I wish I could have purged all of these series from the list.
> After a very protracted discussion on the topic it was decided that
> notmuch will not support any delete tagging operations.  Users who wish
> to do so can add support on their own:
>
>   id:"87sjgk2xzf.fsf at servo.finestructure.net"
>   http://notmuchmail.org/excluding/  
>
> I highly recommend *not* re-starting this discussion.  There is no
> solution that will satisfy everyone.  Just let it be.  Move on.  Nothing
> to see here.  These are not the tags you're looking for...

id:"1326826969-23545-1-git-send-email-jrollins at finestructure.net"

Does just "delete" -> "deleted" change: the only question I have left
is that should that be left as is, this change made, or just drop
the "delete" coloring altogether ?

>
> jamie.

Tomi

Re: [PATCH 1/3] emacs: modify help message for notmuch-search-line-faces to reflect preferred deleted tag name.

[Tomi Ollila]

On Mon, Apr 16 2012, Jameson Graef Rollins jroll...@finestructure.net wrote:

 On Sun, Apr 15 2012, Tomi Ollila tomi.oll...@iki.fi wrote:
 id:1326826969-23545-1-git-send-email-jroll...@finestructure.net

 Does just delete - deleted change: the only question I have left
 is that should that be left as is, this change made, or just drop
 the delete coloring altogether ?

 Sorry, yes, I suppose this patch should still be applied.  Excludes for
 deleted are the default, I believe, so if we are going to refer to it
 in documentation we should probably be consistent.

That said, the following change in nmbug repository

D1326826969-23545-1-git-send-email-jroll...@finestructure.net needs-review
A1326826969-23545-1-git-send-email-jroll...@finestructure.net trivial

pushed.

Tomi


 On Sun, Apr 15 2012, Jameson Graef Rollins jroll...@finestructure.net wrote:
 On Sun, Apr 15 2012, Mark Walters markwalters1...@gmail.com wrote:
 I think the rest of the series (which provides keybindings for
 adding/removing the delete tag to messages/threads) is worthwhile
 particularly now the exclude stuff is fairly complete (feedback at the
 time looked positive).

 Sorry, I wish I could have purged all of these series from the list.
 After a very protracted discussion on the topic it was decided that
 notmuch will not support any delete tagging operations.  Users who wish
 to do so can add support on their own:

 I think my reaction here was a little strong.  I'm not remembering how I
 got the impression that there was more opposition to adding delete
 keybindings than there was support.  I suppose now that excludes work so
 well one (not me) might consider revisiting the issue.

 jamie.
 ___
 notmuch mailing list
 notmuch@notmuchmail.org
 http://notmuchmail.org/mailman/listinfo/notmuch
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH 1/3] emacs: modify help message for notmuch-search-line-faces to reflect preferred "deleted" tag name.

[Jameson Graef Rollins]

On Sun, Apr 15 2012, Tomi Ollila  wrote:
> id:"1326826969-23545-1-git-send-email-jrollins at finestructure.net"
>
> Does just "delete" -> "deleted" change: the only question I have left
> is that should that be left as is, this change made, or just drop
> the "delete" coloring altogether ?

Sorry, yes, I suppose this patch should still be applied.  Excludes for
"deleted" are the default, I believe, so if we are going to refer to it
in documentation we should probably be consistent.

On Sun, Apr 15 2012, Jameson Graef Rollins  
wrote:
> On Sun, Apr 15 2012, Mark Walters  wrote:
>> I think the rest of the series (which provides keybindings for
>> adding/removing the delete tag to messages/threads) is worthwhile
>> particularly now the exclude stuff is fairly complete (feedback at the
>> time looked positive).
>
> Sorry, I wish I could have purged all of these series from the list.
> After a very protracted discussion on the topic it was decided that
> notmuch will not support any delete tagging operations.  Users who wish
> to do so can add support on their own:

I think my reaction here was a little strong.  I'm not remembering how I
got the impression that there was more opposition to adding delete
keybindings than there was support.  I suppose now that excludes work so
well one (not me) might consider revisiting the issue.

jamie.
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: 

[PATCH 1/3] emacs: modify help message for notmuch-search-line-faces to reflect preferred "deleted" tag name.

[Tomi Ollila]

On Sun, Apr 15 2012, Mark Walters wrote:

> On Tue, 17 Jan 2012, Jameson Graef Rollins  
> wrote:
>> No functional change here.  The help message previously referred to
>> the "delete" tag, but "deleted" is now preferred, so hopefully this
>> will reduce any potential confusion.
>
> This patch is trivially correct regardless of the rest of the
> series. 

Agreed. +1

>
> I think the rest of the series (which provides keybindings for
> adding/removing the delete tag to messages/threads) is worthwhile
> particularly now the exclude stuff is fairly complete (feedback at the
> time looked positive).
>
> Patch 2/3 needs simple but genuine rebasing as the names of the
> tagging functions have changed though. 

Why not :)

>
> Best wishes
>
> Mark

Tomi


>
>> ---
>>  emacs/notmuch.el |4 ++--
>>  1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/emacs/notmuch.el b/emacs/notmuch.el
>> index e4bca51..67ecd3a 100644
>> --- a/emacs/notmuch.el
>> +++ b/emacs/notmuch.el
>> @@ -660,12 +660,12 @@ This function advances the next thread when finished."
>>  Here is an example of how to color search results based on tags.
>>   (the following text would be placed in your ~/.emacs file):
>>  
>> - (setq notmuch-search-line-faces '((\"delete\" . (:foreground \"red\"
>> + (setq notmuch-search-line-faces '((\"deleted\" . (:foreground \"red\"
>>:background \"blue\"))
>> (\"unread\" . (:foreground \"green\"
>>  
>>  The attributes defined for matching tags are merged, with later
>> -attributes overriding earlier. A message having both \"delete\"
>> +attributes overriding earlier. A message having both \"deleted\"
>>  and \"unread\" tags with the above settings would have a green
>>  foreground and blue background."
>>:type '(alist :key-type (string) :value-type (custom-face-edit))
>> -- 
>> 1.7.7.3
>>
>> ___
>> notmuch mailing list
>> notmuch at notmuchmail.org
>> http://notmuchmail.org/mailman/listinfo/notmuch
> ___
> notmuch mailing list
> notmuch at notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH 1/3] emacs: modify help message for notmuch-search-line-faces to reflect preferred "deleted" tag name.

[Mark Walters]

On Tue, 17 Jan 2012, Jameson Graef Rollins  
wrote:
> No functional change here.  The help message previously referred to
> the "delete" tag, but "deleted" is now preferred, so hopefully this
> will reduce any potential confusion.

This patch is trivially correct regardless of the rest of the
series. 

I think the rest of the series (which provides keybindings for
adding/removing the delete tag to messages/threads) is worthwhile
particularly now the exclude stuff is fairly complete (feedback at the
time looked positive).

Patch 2/3 needs simple but genuine rebasing as the names of the
tagging functions have changed though. 

Best wishes

Mark

> ---
>  emacs/notmuch.el |4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/emacs/notmuch.el b/emacs/notmuch.el
> index e4bca51..67ecd3a 100644
> --- a/emacs/notmuch.el
> +++ b/emacs/notmuch.el
> @@ -660,12 +660,12 @@ This function advances the next thread when finished."
>  Here is an example of how to color search results based on tags.
>   (the following text would be placed in your ~/.emacs file):
>  
> - (setq notmuch-search-line-faces '((\"delete\" . (:foreground \"red\"
> + (setq notmuch-search-line-faces '((\"deleted\" . (:foreground \"red\"
> :background \"blue\"))
> (\"unread\" . (:foreground \"green\"
>  
>  The attributes defined for matching tags are merged, with later
> -attributes overriding earlier. A message having both \"delete\"
> +attributes overriding earlier. A message having both \"deleted\"
>  and \"unread\" tags with the above settings would have a green
>  foreground and blue background."
>:type '(alist :key-type (string) :value-type (custom-face-edit))
> -- 
> 1.7.7.3
>
> ___
> notmuch mailing list
> notmuch at notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH 1/3] emacs: modify help message for notmuch-search-line-faces to reflect preferred "deleted" tag name.

[Jameson Graef Rollins]

On Sun, Apr 15 2012, Mark Walters  wrote:
> This patch is trivially correct regardless of the rest of the
> series. 
>
> I think the rest of the series (which provides keybindings for
> adding/removing the delete tag to messages/threads) is worthwhile
> particularly now the exclude stuff is fairly complete (feedback at the
> time looked positive).

Sorry, I wish I could have purged all of these series from the list.
After a very protracted discussion on the topic it was decided that
notmuch will not support any delete tagging operations.  Users who wish
to do so can add support on their own:

  id:"87sjgk2xzf.fsf at servo.finestructure.net"
  http://notmuchmail.org/excluding/  

I highly recommend *not* re-starting this discussion.  There is no
solution that will satisfy everyone.  Just let it be.  Move on.  Nothing
to see here.  These are not the tags you're looking for...

jamie.
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: 

Re: [PATCH 1/3] emacs: modify help message for notmuch-search-line-faces to reflect preferred deleted tag name.

[Mark Walters]

On Tue, 17 Jan 2012, Jameson Graef Rollins jroll...@finestructure.net wrote:
 No functional change here.  The help message previously referred to
 the delete tag, but deleted is now preferred, so hopefully this
 will reduce any potential confusion.

This patch is trivially correct regardless of the rest of the
series. 

I think the rest of the series (which provides keybindings for
adding/removing the delete tag to messages/threads) is worthwhile
particularly now the exclude stuff is fairly complete (feedback at the
time looked positive).

Patch 2/3 needs simple but genuine rebasing as the names of the
tagging functions have changed though. 

Best wishes

Mark

 ---
  emacs/notmuch.el |4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)

 diff --git a/emacs/notmuch.el b/emacs/notmuch.el
 index e4bca51..67ecd3a 100644
 --- a/emacs/notmuch.el
 +++ b/emacs/notmuch.el
 @@ -660,12 +660,12 @@ This function advances the next thread when finished.
  Here is an example of how to color search results based on tags.
   (the following text would be placed in your ~/.emacs file):
  
 - (setq notmuch-search-line-faces '((\delete\ . (:foreground \red\
 + (setq notmuch-search-line-faces '((\deleted\ . (:foreground \red\
 :background \blue\))
 (\unread\ . (:foreground \green\
  
  The attributes defined for matching tags are merged, with later
 -attributes overriding earlier. A message having both \delete\
 +attributes overriding earlier. A message having both \deleted\
  and \unread\ tags with the above settings would have a green
  foreground and blue background.
:type '(alist :key-type (string) :value-type (custom-face-edit))
 -- 
 1.7.7.3

 ___
 notmuch mailing list
 notmuch@notmuchmail.org
 http://notmuchmail.org/mailman/listinfo/notmuch
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 1/3] emacs: modify help message for notmuch-search-line-faces to reflect preferred deleted tag name.

[Tomi Ollila]

On Sun, Apr 15 2012, Mark Walters wrote:

 On Tue, 17 Jan 2012, Jameson Graef Rollins jroll...@finestructure.net wrote:
 No functional change here.  The help message previously referred to
 the delete tag, but deleted is now preferred, so hopefully this
 will reduce any potential confusion.

 This patch is trivially correct regardless of the rest of the
 series. 

Agreed. +1


 I think the rest of the series (which provides keybindings for
 adding/removing the delete tag to messages/threads) is worthwhile
 particularly now the exclude stuff is fairly complete (feedback at the
 time looked positive).

 Patch 2/3 needs simple but genuine rebasing as the names of the
 tagging functions have changed though. 

Why not :)


 Best wishes

 Mark

Tomi



 ---
  emacs/notmuch.el |4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)

 diff --git a/emacs/notmuch.el b/emacs/notmuch.el
 index e4bca51..67ecd3a 100644
 --- a/emacs/notmuch.el
 +++ b/emacs/notmuch.el
 @@ -660,12 +660,12 @@ This function advances the next thread when finished.
  Here is an example of how to color search results based on tags.
   (the following text would be placed in your ~/.emacs file):
  
 - (setq notmuch-search-line-faces '((\delete\ . (:foreground \red\
 + (setq notmuch-search-line-faces '((\deleted\ . (:foreground \red\
:background \blue\))
 (\unread\ . (:foreground \green\
  
  The attributes defined for matching tags are merged, with later
 -attributes overriding earlier. A message having both \delete\
 +attributes overriding earlier. A message having both \deleted\
  and \unread\ tags with the above settings would have a green
  foreground and blue background.
:type '(alist :key-type (string) :value-type (custom-face-edit))
 -- 
 1.7.7.3

 ___
 notmuch mailing list
 notmuch@notmuchmail.org
 http://notmuchmail.org/mailman/listinfo/notmuch
 ___
 notmuch mailing list
 notmuch@notmuchmail.org
 http://notmuchmail.org/mailman/listinfo/notmuch
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 1/3] emacs: modify help message for notmuch-search-line-faces to reflect preferred deleted tag name.

[Jameson Graef Rollins]

On Sun, Apr 15 2012, Mark Walters markwalters1...@gmail.com wrote:
 This patch is trivially correct regardless of the rest of the
 series. 

 I think the rest of the series (which provides keybindings for
 adding/removing the delete tag to messages/threads) is worthwhile
 particularly now the exclude stuff is fairly complete (feedback at the
 time looked positive).

Sorry, I wish I could have purged all of these series from the list.
After a very protracted discussion on the topic it was decided that
notmuch will not support any delete tagging operations.  Users who wish
to do so can add support on their own:

  id:87sjgk2xzf@servo.finestructure.net
  http://notmuchmail.org/excluding/  

I highly recommend *not* re-starting this discussion.  There is no
solution that will satisfy everyone.  Just let it be.  Move on.  Nothing
to see here.  These are not the tags you're looking for...

jamie.


pgpFYChSlpPCH.pgp
Description: PGP signature
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 1/3] emacs: modify help message for notmuch-search-line-faces to reflect preferred deleted tag name.

[Tomi Ollila]

On Sun, Apr 15 2012, Jameson Graef Rollins jroll...@finestructure.net wrote:

 On Sun, Apr 15 2012, Mark Walters markwalters1...@gmail.com wrote:
 This patch is trivially correct regardless of the rest of the
 series. 

 I think the rest of the series (which provides keybindings for
 adding/removing the delete tag to messages/threads) is worthwhile
 particularly now the exclude stuff is fairly complete (feedback at the
 time looked positive).

 Sorry, I wish I could have purged all of these series from the list.
 After a very protracted discussion on the topic it was decided that
 notmuch will not support any delete tagging operations.  Users who wish
 to do so can add support on their own:

   id:87sjgk2xzf@servo.finestructure.net
   http://notmuchmail.org/excluding/  

 I highly recommend *not* re-starting this discussion.  There is no
 solution that will satisfy everyone.  Just let it be.  Move on.  Nothing
 to see here.  These are not the tags you're looking for...

id:1326826969-23545-1-git-send-email-jroll...@finestructure.net

Does just delete - deleted change: the only question I have left
is that should that be left as is, this change made, or just drop
the delete coloring altogether ?


 jamie.

Tomi
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 1/3] emacs: modify help message for notmuch-search-line-faces to reflect preferred deleted tag name.

[Jameson Graef Rollins]

On Sun, Apr 15 2012, Tomi Ollila tomi.oll...@iki.fi wrote:
 id:1326826969-23545-1-git-send-email-jroll...@finestructure.net

 Does just delete - deleted change: the only question I have left
 is that should that be left as is, this change made, or just drop
 the delete coloring altogether ?

Sorry, yes, I suppose this patch should still be applied.  Excludes for
deleted are the default, I believe, so if we are going to refer to it
in documentation we should probably be consistent.

On Sun, Apr 15 2012, Jameson Graef Rollins jroll...@finestructure.net wrote:
 On Sun, Apr 15 2012, Mark Walters markwalters1...@gmail.com wrote:
 I think the rest of the series (which provides keybindings for
 adding/removing the delete tag to messages/threads) is worthwhile
 particularly now the exclude stuff is fairly complete (feedback at the
 time looked positive).

 Sorry, I wish I could have purged all of these series from the list.
 After a very protracted discussion on the topic it was decided that
 notmuch will not support any delete tagging operations.  Users who wish
 to do so can add support on their own:

I think my reaction here was a little strong.  I'm not remembering how I
got the impression that there was more opposition to adding delete
keybindings than there was support.  I suppose now that excludes work so
well one (not me) might consider revisiting the issue.

jamie.


pgpRZEZLTXWxA.pgp
Description: PGP signature
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH 1/3] emacs: modify help message for notmuch-search-line-faces to reflect preferred "deleted" tag name.

[Jameson Graef Rollins]

No functional change here.  The help message previously referred to
the "delete" tag, but "deleted" is now preferred, so hopefully this
will reduce any potential confusion.
---
 emacs/notmuch.el |4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/emacs/notmuch.el b/emacs/notmuch.el
index e4bca51..67ecd3a 100644
--- a/emacs/notmuch.el
+++ b/emacs/notmuch.el
@@ -660,12 +660,12 @@ This function advances the next thread when finished."
 Here is an example of how to color search results based on tags.
  (the following text would be placed in your ~/.emacs file):

- (setq notmuch-search-line-faces '((\"delete\" . (:foreground \"red\"
+ (setq notmuch-search-line-faces '((\"deleted\" . (:foreground \"red\"
  :background \"blue\"))
(\"unread\" . (:foreground \"green\"

 The attributes defined for matching tags are merged, with later
-attributes overriding earlier. A message having both \"delete\"
+attributes overriding earlier. A message having both \"deleted\"
 and \"unread\" tags with the above settings would have a green
 foreground and blue background."
   :type '(alist :key-type (string) :value-type (custom-face-edit))
-- 
1.7.7.3

[PATCH 1/3] emacs: modify help message for notmuch-search-line-faces to reflect preferred deleted tag name.

[Jameson Graef Rollins]

No functional change here.  The help message previously referred to
the delete tag, but deleted is now preferred, so hopefully this
will reduce any potential confusion.
---
 emacs/notmuch.el |4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/emacs/notmuch.el b/emacs/notmuch.el
index e4bca51..67ecd3a 100644
--- a/emacs/notmuch.el
+++ b/emacs/notmuch.el
@@ -660,12 +660,12 @@ This function advances the next thread when finished.
 Here is an example of how to color search results based on tags.
  (the following text would be placed in your ~/.emacs file):
 
- (setq notmuch-search-line-faces '((\delete\ . (:foreground \red\
+ (setq notmuch-search-line-faces '((\deleted\ . (:foreground \red\
  :background \blue\))
(\unread\ . (:foreground \green\
 
 The attributes defined for matching tags are merged, with later
-attributes overriding earlier. A message having both \delete\
+attributes overriding earlier. A message having both \deleted\
 and \unread\ tags with the above settings would have a green
 foreground and blue background.
   :type '(alist :key-type (string) :value-type (custom-face-edit))
-- 
1.7.7.3

___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch