[PATCH 2/2] Fixed warnings for test/symbol-test.cc.

2011-11-25 Thread Amadeusz Żołnowski 
---
 test/symbol-test.cc |9 -
 1 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/test/symbol-test.cc b/test/symbol-test.cc
index 1de06ea..bfbe38f 100644
--- a/test/symbol-test.cc
+++ b/test/symbol-test.cc
@@ -1,14 +1,13 @@
 #include 
 #include 
 #include 
-main (int argc, char **argv){
+int main (){

-notmuch_database_t *notmuch
-  = notmuch_database_open ("fakedb",
-NOTMUCH_DATABASE_MODE_READ_ONLY);
+  //notmuch_database_t *notmuch =
+  notmuch_database_open ("fakedb", NOTMUCH_DATABASE_MODE_READ_ONLY);

   try{
-(void)new Xapian::WritableDatabase ("./nonexistant",   
Xapian::DB_OPEN);
+(void)new Xapian::WritableDatabase ("./nonexistant", Xapian::DB_OPEN);
   } catch (const Xapian::Error &error) {
 printf("caught %s\n",error.get_msg().c_str());
 return 0;
-- 
1.7.8.rc3

[PATCH 2/2] Fixed warnings for test/symbol-test.cc.

2011-11-25 Thread David Bremner 
On Fri, 25 Nov 2011 11:54:52 +0100, Amadeusz ?o?nowski  wrote:
> ---
> +  //notmuch_database_t *notmuch =
> +  notmuch_database_open ("fakedb", NOTMUCH_DATABASE_MODE_READ_ONLY);

Leaving commented out code in is for people without version control ;).

Shouldn't this cast to void?

>  
>try{
> -(void)new Xapian::WritableDatabase ("./nonexistant", 
> Xapian::DB_OPEN);
> +(void)new Xapian::WritableDatabase ("./nonexistant", Xapian::DB_OPEN);

This seems to be whitespace only?  I'm not against whitespace cleanup,
but please put it in seperate commits. Or am I staring past a real
change here?

d

Re: [PATCH 2/2] Fixed warnings for test/symbol-test.cc.

2011-11-25 Thread David Bremner 
On Fri, 25 Nov 2011 11:54:52 +0100, Amadeusz Żołnowski  
wrote:
> ---
> +  //notmuch_database_t *notmuch =
> +  notmuch_database_open ("fakedb", NOTMUCH_DATABASE_MODE_READ_ONLY);

Leaving commented out code in is for people without version control ;).

Shouldn't this cast to void?

>  
>try{
> -(void)new Xapian::WritableDatabase ("./nonexistant", 
> Xapian::DB_OPEN);
> +(void)new Xapian::WritableDatabase ("./nonexistant", Xapian::DB_OPEN);

This seems to be whitespace only?  I'm not against whitespace cleanup,
but please put it in seperate commits. Or am I staring past a real
change here?

d

___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH 2/2] Fixed warnings for test/symbol-test.cc.

2011-11-25 Thread Amadeusz Żołnowski 
---
 test/symbol-test.cc |9 -
 1 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/test/symbol-test.cc b/test/symbol-test.cc
index 1de06ea..bfbe38f 100644
--- a/test/symbol-test.cc
+++ b/test/symbol-test.cc
@@ -1,14 +1,13 @@
 #include 
 #include 
 #include 
-main (int argc, char **argv){
+int main (){
 
-notmuch_database_t *notmuch
-  = notmuch_database_open ("fakedb",
-NOTMUCH_DATABASE_MODE_READ_ONLY);
+  //notmuch_database_t *notmuch =
+  notmuch_database_open ("fakedb", NOTMUCH_DATABASE_MODE_READ_ONLY);
 
   try{
-(void)new Xapian::WritableDatabase ("./nonexistant",   
Xapian::DB_OPEN);
+(void)new Xapian::WritableDatabase ("./nonexistant", Xapian::DB_OPEN);
   } catch (const Xapian::Error &error) {
 printf("caught %s\n",error.get_msg().c_str());
 return 0;
-- 
1.7.8.rc3

___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch