Re: [PATCH 2/2] emacs: define, use option :disable-excludes for n-h-query-counts
Gregor Zattler writes: > Hi David, > * David Bremner [2022-01-23; 15:00]: >> David Bremner writes: >> >>> Initially only use in notmuch-hello-insert-alltags. This is a more >>> narrow resolution of [1], which (unlike [2]) does not disable exclude >>> processing for regular saved searches. >> >> I applied this series to master. > > I confirm again, the bug does not show up in my test case > from message id:877ep0kx52.fsf@len.workgroup. The test case > mail corpus (n = 1) is definitely too small to uncover the > bug David found in the first attempt to fix the bug. > Great, so hopefully I didn't break anything else this time :) d ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org
Re: [PATCH 2/2] emacs: define, use option :disable-excludes for n-h-query-counts
Hi David, * David Bremner [2022-01-23; 15:00]: > David Bremner writes: > >> Initially only use in notmuch-hello-insert-alltags. This is a more >> narrow resolution of [1], which (unlike [2]) does not disable exclude >> processing for regular saved searches. > > I applied this series to master. I confirm again, the bug does not show up in my test case from message id:877ep0kx52.fsf@len.workgroup. The test case mail corpus (n = 1) is definitely too small to uncover the bug David found in the first attempt to fix the bug. Thanks, Gregor ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org
Re: [PATCH 2/2] emacs: define, use option :disable-excludes for n-h-query-counts
David Bremner writes: > Initially only use in notmuch-hello-insert-alltags. This is a more > narrow resolution of [1], which (unlike [2]) does not disable exclude > processing for regular saved searches. I applied this series to master. d ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org
[PATCH 2/2] emacs: define, use option :disable-excludes for n-h-query-counts
Initially only use in notmuch-hello-insert-alltags. This is a more narrow resolution of [1], which (unlike [2]) does not disable exclude processing for regular saved searches. [1]: id:87wox1vovj.fsf@len.workgroup [2]: id:20220105010606.2034601-2-da...@tethera.net --- emacs/notmuch-hello.el | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el index 71e91093..581e7f3a 100644 --- a/emacs/notmuch-hello.el +++ b/emacs/notmuch-hello.el @@ -557,7 +557,8 @@ with any properties in the original saved-search. The values :show-empty-searches, :filter and :filter-count from options will be handled as specified for -`notmuch-hello-insert-searches'." +`notmuch-hello-insert-searches'. :disable-includes can be used to +turn off the default exclude processing in `notmuch-count(1)'" (with-temp-buffer (dolist (elem query-list nil) (let ((count-query (or (notmuch-saved-search-get elem :count-query) @@ -570,7 +571,11 @@ options will be handled as specified for (plist-get options :filter "\n"))) (unless (= (notmuch--call-process-region (point-min) (point-max) notmuch-command - t t nil "count" "--batch") 0) +t t nil "count" +(if (plist-get options :disable-excludes) +"--exclude=false" + "--exclude=true") +"--batch") 0) (notmuch-logged-error "notmuch count --batch failed" "Please check that the notmuch CLI is new enough to support `count @@ -917,7 +922,8 @@ following: nil :initially-hidden (not notmuch-show-all-tags-list) :hide-tags notmuch-hello-hide-tags - :filter notmuch-hello-tag-list-make-query)) + :filter notmuch-hello-tag-list-make-query + :disable-excludes t)) (defun notmuch-hello-insert-footer () "Insert the notmuch-hello footer." -- 2.34.1 ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org
