Re: [PATCH v2 0/4] Add a --body option to notmuch show

2012-07-24 Thread David Bremner 
Mark Walters markwalters1...@gmail.com writes:

 Version 2 of this patch set (version 1 at
 id:1343060241-18283-1-git-send-email-markwalters1...@gmail.com). This
 corrects the errors Austin spotted in v1, and makes it explicit that
 --body=false and --part0 are incompatible.

2/4 doesn't apply anymore to current master, and I was a bit leery of
resolving conflicts in the tests; can you rebase and resend? no need for
review of the rebased series.

d
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH v2 0/4] Add a --body option to notmuch show

2012-07-23 Thread Mark Walters 
Version 2 of this patch set (version 1 at
id:"1343060241-18283-1-git-send-email-markwalters1009 at gmail.com"). This
corrects the errors Austin spotted in v1, and makes it explicit that
--body=false and --part>0 are incompatible.


Mark Walters (4):
  cli: add --body=true|false option to notmuch-show.c
  test: add tests for the new --body=true|false option
  man: update man page for the new --body=true|false option
  schemata: update for --body=true|false option

 devel/schemata  |2 +-
 man/man1/notmuch-show.1 |   16 
 notmuch-client.h|3 ++-
 notmuch-reply.c |2 +-
 notmuch-show.c  |   30 ++
 test/json   |9 +
 6 files changed, 51 insertions(+), 11 deletions(-)

-- 
1.7.9.1

[PATCH v2 0/4] Add a --body option to notmuch show

2012-07-23 Thread Austin Clements 
LGTM.

Quoth Mark Walters on Jul 23 at  6:57 pm:
> Version 2 of this patch set (version 1 at
> id:"1343060241-18283-1-git-send-email-markwalters1009 at gmail.com"). This
> corrects the errors Austin spotted in v1, and makes it explicit that
> --body=false and --part>0 are incompatible.
> 
> 
> Mark Walters (4):
>   cli: add --body=true|false option to notmuch-show.c
>   test: add tests for the new --body=true|false option
>   man: update man page for the new --body=true|false option
>   schemata: update for --body=true|false option
> 
>  devel/schemata  |2 +-
>  man/man1/notmuch-show.1 |   16 
>  notmuch-client.h|3 ++-
>  notmuch-reply.c |2 +-
>  notmuch-show.c  |   30 ++
>  test/json   |9 +
>  6 files changed, 51 insertions(+), 11 deletions(-)
>

[PATCH v2 0/4] Add a --body option to notmuch show

2012-07-23 Thread Jameson Graef Rollins 
On Mon, Jul 23 2012, Mark Walters  wrote:
> Version 2 of this patch set (version 1 at
> id:"1343060241-18283-1-git-send-email-markwalters1009 at gmail.com"). This
> corrects the errors Austin spotted in v1, and makes it explicit that
> --body=false and --part>0 are incompatible.
>
>
> Mark Walters (4):
>   cli: add --body=true|false option to notmuch-show.c
>   test: add tests for the new --body=true|false option
>   man: update man page for the new --body=true|false option
>   schemata: update for --body=true|false option
>
>  devel/schemata  |2 +-
>  man/man1/notmuch-show.1 |   16 
>  notmuch-client.h|3 ++-
>  notmuch-reply.c |2 +-
>  notmuch-show.c  |   30 ++
>  test/json   |9 +
>  6 files changed, 51 insertions(+), 11 deletions(-)

Untested, but LGTM.

jamie.
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL:

[PATCH v2 0/4] Add a --body option to notmuch show

2012-07-23 Thread Mark Walters 
Version 2 of this patch set (version 1 at
id:1343060241-18283-1-git-send-email-markwalters1...@gmail.com). This
corrects the errors Austin spotted in v1, and makes it explicit that
--body=false and --part0 are incompatible.


Mark Walters (4):
  cli: add --body=true|false option to notmuch-show.c
  test: add tests for the new --body=true|false option
  man: update man page for the new --body=true|false option
  schemata: update for --body=true|false option

 devel/schemata  |2 +-
 man/man1/notmuch-show.1 |   16 
 notmuch-client.h|3 ++-
 notmuch-reply.c |2 +-
 notmuch-show.c  |   30 ++
 test/json   |9 +
 6 files changed, 51 insertions(+), 11 deletions(-)

-- 
1.7.9.1

___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH v2 0/4] Add a --body option to notmuch show

2012-07-23 Thread Austin Clements 
LGTM.

Quoth Mark Walters on Jul 23 at  6:57 pm:
 Version 2 of this patch set (version 1 at
 id:1343060241-18283-1-git-send-email-markwalters1...@gmail.com). This
 corrects the errors Austin spotted in v1, and makes it explicit that
 --body=false and --part0 are incompatible.
 
 
 Mark Walters (4):
   cli: add --body=true|false option to notmuch-show.c
   test: add tests for the new --body=true|false option
   man: update man page for the new --body=true|false option
   schemata: update for --body=true|false option
 
  devel/schemata  |2 +-
  man/man1/notmuch-show.1 |   16 
  notmuch-client.h|3 ++-
  notmuch-reply.c |2 +-
  notmuch-show.c  |   30 ++
  test/json   |9 +
  6 files changed, 51 insertions(+), 11 deletions(-)
 
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH v2 0/4] Add a --body option to notmuch show

2012-07-23 Thread Jameson Graef Rollins 
On Mon, Jul 23 2012, Mark Walters markwalters1...@gmail.com wrote:
 Version 2 of this patch set (version 1 at
 id:1343060241-18283-1-git-send-email-markwalters1...@gmail.com). This
 corrects the errors Austin spotted in v1, and makes it explicit that
 --body=false and --part0 are incompatible.


 Mark Walters (4):
   cli: add --body=true|false option to notmuch-show.c
   test: add tests for the new --body=true|false option
   man: update man page for the new --body=true|false option
   schemata: update for --body=true|false option

  devel/schemata  |2 +-
  man/man1/notmuch-show.1 |   16 
  notmuch-client.h|3 ++-
  notmuch-reply.c |2 +-
  notmuch-show.c  |   30 ++
  test/json   |9 +
  6 files changed, 51 insertions(+), 11 deletions(-)

Untested, but LGTM.

jamie.


pgpUPeoyOSL7D.pgp
Description: PGP signature
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch