Re: [PATCH v2 2/2] notmuch-mutt: replace extra command with notmuch thread search feature

[David Bremner]

Paul Wise  writes:

> This should be be slightly faster since it avoids forking a shell
> and is less code in and less dependencies for the script.
>
> Since String::ShellQuote isn't used elsewhere, drop mention of it.

applied to master.

d
___
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-le...@notmuchmail.org

[PATCH v2 2/2] notmuch-mutt: replace extra command with notmuch thread search feature

[Paul Wise]

This should be be slightly faster since it avoids forking a shell
and is less code in and less dependencies for the script.

Since String::ShellQuote isn't used elsewhere, drop mention of it.
---
 contrib/notmuch-mutt/README   | 2 --
 contrib/notmuch-mutt/notmuch-mutt | 9 ++---
 debian/control| 1 -
 3 files changed, 2 insertions(+), 10 deletions(-)

diff --git a/contrib/notmuch-mutt/README b/contrib/notmuch-mutt/README
index 26996c4a..c7520228 100644
--- a/contrib/notmuch-mutt/README
+++ b/contrib/notmuch-mutt/README
@@ -39,8 +39,6 @@ To *run* notmuch-mutt you will need Perl with the following 
libraries:
   (Debian package: libmail-box-perl)
 - Mail::Header 
   (Debian package: libmailtools-perl)
-- String::ShellQuote 
-  (Debian package: libstring-shellquote-perl)
 - Term::ReadLine::Gnu 
   (Debian package: libterm-readline-gnu-perl)
 
diff --git a/contrib/notmuch-mutt/notmuch-mutt 
b/contrib/notmuch-mutt/notmuch-mutt
index 1bb95ba6..48cb5594 100755
--- a/contrib/notmuch-mutt/notmuch-mutt
+++ b/contrib/notmuch-mutt/notmuch-mutt
@@ -17,7 +17,6 @@ use Getopt::Long qw(:config no_getopt_compat);
 use Mail::Header;
 use Mail::Box::Maildir;
 use Pod::Usage;
-use String::ShellQuote;
 use Term::ReadLine;
 use Digest::SHA;
 
@@ -126,13 +125,9 @@ sub thread_action($$@) {
 }
 
 $mid =~ s/ //g; # notmuch strips spaces before storing Message-Id
-$mid =~ s/"/""/g; # escape all double quote characters
-
-my $search_cmd = 'notmuch search --output=threads ' . 
shell_quote(qq{id:"$mid"});
-my $tid = `$search_cmd`;   # get thread id
-chomp($tid);
+$mid =~ s/"//g; # escape all double quote characters twice
 
-search($results_dir, $remove_dups, $tid);
+search($results_dir, $remove_dups, qq{thread:"{id:""$mid""}"});
 }
 
 sub tag_action(@) {
diff --git a/debian/control b/debian/control
index 2dcb8cc7..135eb7ce 100644
--- a/debian/control
+++ b/debian/control
@@ -227,7 +227,6 @@ Architecture: all
 Depends:
  libmail-box-perl,
  libmailtools-perl,
- libstring-shellquote-perl,
  libterm-readline-gnu-perl,
  notmuch (>= 0.4),
  ${misc:Depends},
-- 
2.39.2

___
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-le...@notmuchmail.org