[PATCH v3 00/11] contrib: pick: keybindings
On Thu, Aug 22 2013, Mark Walters wrote: > Here is the diff diff that I should have included in the previous email LGTM. > Sorry about that! > > Mark Tomi > > diff --git a/contrib/notmuch-pick/notmuch-pick.el > b/contrib/notmuch-pick/notmuch-pick.el > index 3b86a5a..37dc161 100644 > --- a/contrib/notmuch-pick/notmuch-pick.el > +++ b/contrib/notmuch-pick/notmuch-pick.el > @@ -198,7 +198,7 @@ open (if the message pane is closed it does nothing)." > (interactive) > (when (window-live-p notmuch-pick-message-window) > (with-selected-window notmuch-pick-message-window > - (funcall #',func) > + (call-interactively #',func) > > (defun notmuch-pick-button-activate ( button) >"Activate BUTTON or button at point > @@ -218,7 +218,7 @@ FUNC." >,(concat "(Close message pane and) " (documentation func t)) > (interactive) > (notmuch-pick-close-message-window) > - (funcall #',func))) > + (call-interactively #',func))) > > (defvar notmuch-pick-mode-map >(let ((map (make-sparse-keymap))) > ___ > notmuch mailing list > notmuch at notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch
[PATCH v3 00/11] contrib: pick: keybindings
Here is the diff diff that I should have included in the previous email Sorry about that! Mark diff --git a/contrib/notmuch-pick/notmuch-pick.el b/contrib/notmuch-pick/notmuch-pick.el index 3b86a5a..37dc161 100644 --- a/contrib/notmuch-pick/notmuch-pick.el +++ b/contrib/notmuch-pick/notmuch-pick.el @@ -198,7 +198,7 @@ open (if the message pane is closed it does nothing)." (interactive) (when (window-live-p notmuch-pick-message-window) (with-selected-window notmuch-pick-message-window -(funcall #',func) +(call-interactively #',func) (defun notmuch-pick-button-activate ( button) "Activate BUTTON or button at point @@ -218,7 +218,7 @@ FUNC." ,(concat "(Close message pane and) " (documentation func t)) (interactive) (notmuch-pick-close-message-window) - (funcall #',func))) + (call-interactively #',func))) (defvar notmuch-pick-mode-map (let ((map (make-sparse-keymap)))
[PATCH v3 00/11] contrib: pick: keybindings
This is v3 of this patch set. v2 is at id:1376828079-21455-1-git-send-email-markwalters1009 at gmail.com This fixes the problem pointed out by Tomi in id:m238q294je.fsf at guru.guru-group.fi : by using call-interactively rather than funcall the prefix argument gets passed on to the called function so things like ctrl-u m work (ie it prompts for sender) To answer Tomi's other question: with-current-notmuch-pick-message is not needed because it is identical to with-current-notmuch-show-message except it uses notmuch-pick-get-message-id instead of notmuch-show-get-message-id. But patch 1 of this series makes the function notmuch-show-get-message-id work in either show or pick (by doing slightly different things based on whether the major mode is show or pick). (In fact the differentiation occurs slightly lower in notmuch-show-get-prop which is called by notmuch-show-get-message-id) Best wishes Mark Mark Walters (11): contrib: pick: override notmuch-show-get-prop contrib: pick: Link in notmuch-show-pipe-message contrib: pick: Link in attachment functions straight from notmuch-show contrib: pick: Link in stash map straight from notmuch-show contrib: pick: add in to-message-window function contrib: pick: add button press helper contrib: pick: pass tab through to the message pane contrib: pick: close window function contrib: pick: make help close the message pane first contrib: pick: add in binding to view raw message contrib: pick: use close-message-pane for reply etc contrib/notmuch-pick/notmuch-pick.el | 139 +- 1 files changed, 70 insertions(+), 69 deletions(-) -- 1.7.9.1
[PATCH v3 00/11] contrib: pick: keybindings
This is v3 of this patch set. v2 is at id:1376828079-21455-1-git-send-email-markwalters1...@gmail.com This fixes the problem pointed out by Tomi in id:m238q294je@guru.guru-group.fi : by using call-interactively rather than funcall the prefix argument gets passed on to the called function so things like ctrl-u m work (ie it prompts for sender) To answer Tomi's other question: with-current-notmuch-pick-message is not needed because it is identical to with-current-notmuch-show-message except it uses notmuch-pick-get-message-id instead of notmuch-show-get-message-id. But patch 1 of this series makes the function notmuch-show-get-message-id work in either show or pick (by doing slightly different things based on whether the major mode is show or pick). (In fact the differentiation occurs slightly lower in notmuch-show-get-prop which is called by notmuch-show-get-message-id) Best wishes Mark Mark Walters (11): contrib: pick: override notmuch-show-get-prop contrib: pick: Link in notmuch-show-pipe-message contrib: pick: Link in attachment functions straight from notmuch-show contrib: pick: Link in stash map straight from notmuch-show contrib: pick: add in to-message-window function contrib: pick: add button press helper contrib: pick: pass tab through to the message pane contrib: pick: close window function contrib: pick: make help close the message pane first contrib: pick: add in binding to view raw message contrib: pick: use close-message-pane for reply etc contrib/notmuch-pick/notmuch-pick.el | 139 +- 1 files changed, 70 insertions(+), 69 deletions(-) -- 1.7.9.1 ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH v3 00/11] contrib: pick: keybindings
Here is the diff diff that I should have included in the previous email Sorry about that! Mark diff --git a/contrib/notmuch-pick/notmuch-pick.el b/contrib/notmuch-pick/notmuch-pick.el index 3b86a5a..37dc161 100644 --- a/contrib/notmuch-pick/notmuch-pick.el +++ b/contrib/notmuch-pick/notmuch-pick.el @@ -198,7 +198,7 @@ open (if the message pane is closed it does nothing). (interactive) (when (window-live-p notmuch-pick-message-window) (with-selected-window notmuch-pick-message-window -(funcall #',func) +(call-interactively #',func) (defun notmuch-pick-button-activate (optional button) Activate BUTTON or button at point @@ -218,7 +218,7 @@ FUNC. ,(concat (Close message pane and) (documentation func t)) (interactive) (notmuch-pick-close-message-window) - (funcall #',func))) + (call-interactively #',func))) (defvar notmuch-pick-mode-map (let ((map (make-sparse-keymap))) ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH v3 00/11] contrib: pick: keybindings
On Thu, Aug 22 2013, Mark Walters markwalters1...@gmail.com wrote: Here is the diff diff that I should have included in the previous email LGTM. Sorry about that! Mark Tomi diff --git a/contrib/notmuch-pick/notmuch-pick.el b/contrib/notmuch-pick/notmuch-pick.el index 3b86a5a..37dc161 100644 --- a/contrib/notmuch-pick/notmuch-pick.el +++ b/contrib/notmuch-pick/notmuch-pick.el @@ -198,7 +198,7 @@ open (if the message pane is closed it does nothing). (interactive) (when (window-live-p notmuch-pick-message-window) (with-selected-window notmuch-pick-message-window - (funcall #',func) + (call-interactively #',func) (defun notmuch-pick-button-activate (optional button) Activate BUTTON or button at point @@ -218,7 +218,7 @@ FUNC. ,(concat (Close message pane and) (documentation func t)) (interactive) (notmuch-pick-close-message-window) - (funcall #',func))) + (call-interactively #',func))) (defvar notmuch-pick-mode-map (let ((map (make-sparse-keymap))) ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
