Missing inlined message/rfc822 bodies?

2011-07-18 Thread Keith Packard 
On Mon, 18 Jul 2011 08:56:13 -0300, David Bremner  wrote:

> I'm curious if you're both solving the same problem.

I would assume so; my patch simply kludges around the problem with a
hack in the emacs code while jrollins is fixing the underlying gmime
interactions.

-- 
keith.packard at intel.com
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL:

Missing inlined message/rfc822 bodies?

2011-07-18 Thread David Bremner 
On Mon, 18 Jul 2011 01:06:05 -0700, "Keith Packard"  
wrote:
Non-text part: multipart/mixed
Non-text part: multipart/signed
> 
> I wasn't seeing anything for an inlined message/rfc822 part (as with a
> forwarded email message) and discovered that for some reason, the
> message structure wasn't as expected. The following patch appears to
> help me.

Hi Keith;

Did you have a chance to try jrollins' patches

id:"1307320169-29905-1-git-send-email-jrollins at finestructure.net"

I'm curious if you're both solving the same problem.

d
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 315 bytes
Desc: not available
URL:

Missing inlined message/rfc822 bodies?

2011-07-18 Thread Keith Packard 

I wasn't seeing anything for an inlined message/rfc822 part (as with a
forwarded email message) and discovered that for some reason, the
message structure wasn't as expected. The following patch appears to
help me.

I'm still stuck trying to use the 'v' key to display attachments from
forwarded messages; it looks like mm-dissect-buffer isn't digging into
the attached message and pulling the embedded attachments out or something.

However, I can at least view the message and save the attachments now.

diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index f96743b..402fb2c 100644
--- a/emacs/notmuch-show.el
+++ b/emacs/notmuch-show.el
@@ -519,6 +519,12 @@ current buffer, if possible."
 ;; message display.
 (insert "\n")

+;;
+;; I dunno, sometimes the message part is a single element list containing 
the plist
+;;
+(if (not inner-parts)
+  (setq inner-parts (plist-get (car message-part) :content)))
+
 ;; Show all of the parts.
 (mapc (lambda (inner-part)
(notmuch-show-insert-bodypart msg inner-part depth))


-- 
keith.packard at intel.com
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL:

Re: Missing inlined message/rfc822 bodies?

2011-07-18 Thread David Bremner 
On Mon, 18 Jul 2011 01:06:05 -0700, Keith Packard kei...@keithp.com wrote:
Non-text part: multipart/mixed
Non-text part: multipart/signed
 
 I wasn't seeing anything for an inlined message/rfc822 part (as with a
 forwarded email message) and discovered that for some reason, the
 message structure wasn't as expected. The following patch appears to
 help me.

Hi Keith;

Did you have a chance to try jrollins' patches

id:1307320169-29905-1-git-send-email-jroll...@finestructure.net

I'm curious if you're both solving the same problem.

d


pgppNfAx1MmN1.pgp
Description: PGP signature
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

Re: Missing inlined message/rfc822 bodies?

2011-07-18 Thread Keith Packard 
On Mon, 18 Jul 2011 08:56:13 -0300, David Bremner da...@tethera.net wrote:

 I'm curious if you're both solving the same problem.

I would assume so; my patch simply kludges around the problem with a
hack in the emacs code while jrollins is fixing the underlying gmime
interactions.

-- 
keith.pack...@intel.com


pgpZKxPaYd84U.pgp
Description: PGP signature
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch