Re: [PATCH 2/8] emacs: update tag-completion function

[Mark Walters]

On Sun, 08 Apr 2012, Jameson Graef Rollins jroll...@finestructure.net wrote:
 search-tags is deprecated, so we move to the more modern and
 supported search --output=tags.
 ---
  emacs/notmuch-tag.el |2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

 diff --git a/emacs/notmuch-tag.el b/emacs/notmuch-tag.el
 index 81b4b00..5240d13 100644
 --- a/emacs/notmuch-tag.el
 +++ b/emacs/notmuch-tag.el
 @@ -59,7 +59,7 @@ the messages that were tagged
 (with-output-to-string
   (with-current-buffer standard-output
 (apply 'call-process notmuch-command nil t
 -   nil search-tags search-terms)))
 +   nil search --output=tags search-terms)))

Perhaps make this 
  + nil search --output=tags --exclude=false search-terms)))

to fix the existing bug that if the message is excluded the completion
can get confused. Or I can submit that separately if you prefer.

Best wishes

Mark

 \n+ t))
  
  (defun notmuch-select-tag-with-completion (prompt rest search-terms)
 -- 
 1.7.9.1

 ___
 notmuch mailing list
 notmuch@notmuchmail.org
 http://notmuchmail.org/mailman/listinfo/notmuch
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 2/8] emacs: update tag-completion function

[Jameson Graef Rollins]

On Mon, Apr 09 2012, Mark Walters markwalters1...@gmail.com wrote:
 -  nil search-tags search-terms)))
 +  nil search --output=tags search-terms)))

 Perhaps make this 
   + nil search --output=tags --exclude=false search-terms)))

 to fix the existing bug that if the message is excluded the completion
 can get confused. Or I can submit that separately if you prefer.

Hey, Mark.  Yes, that was included as a separate patch in v1 of the
series, but now that your exclude stuff has been pushed this should be
included as well.  I'll send a patch for this now.

jamie.


pgp20FtKhon5t.pgp
Description: PGP signature
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch