Re: [PATCH v2 2/3] database: add n_d_index_file (deprecates n_d_add_message)

2017-09-18 Thread David Bremner 
Daniel Kahn Gillmor  writes:

> On Wed 2017-08-23 08:01:22 -0300, David Bremner wrote:
>> Pushed 2 and 3, but with both amended to fix whitespace errors. Please
>> _do_ adjust your settings, this is not a test ;).
>
> thanks for this push, bremner.
>
> if there are settings that need to be adjusted, i believe .dir-locals.el
> is the place to adjust them for those of us who use emacs as their text
> editor, right?  i'm happy to pick them up from there.
>
> any suggestions on what specific settings need adjustment?
>
>  --dkg

I'm not sure about an emacs-specific fix; I just rename
.git/hooks/pre-commit.sample to .git/hooks/pre-commit to enable checking
for whitespace issues before committing.

d
___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH v2 2/3] database: add n_d_index_file (deprecates n_d_add_message)

2017-09-17 Thread Daniel Kahn Gillmor 
On Wed 2017-08-23 08:01:22 -0300, David Bremner wrote:
> Pushed 2 and 3, but with both amended to fix whitespace errors. Please
> _do_ adjust your settings, this is not a test ;).

thanks for this push, bremner.

if there are settings that need to be adjusted, i believe .dir-locals.el
is the place to adjust them for those of us who use emacs as their text
editor, right?  i'm happy to pick them up from there.

any suggestions on what specific settings need adjustment?

 --dkg


signature.asc
Description: PGP signature
___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH v2 2/3] database: add n_d_index_file (deprecates n_d_add_message)

2017-08-23 Thread David Bremner 
Daniel Kahn Gillmor  writes:

> We need a way to pass parameters to the indexing functionality on the
> first index, not just on reindexing.  The obvious place is in
> notmuch_database_add_message.  But since modifying the argument list
> would break both API and ABI, we needed a new name.
>

Pushed 2 and 3, but with both amended to fix whitespace errors. Please
_do_ adjust your settings, this is not a test ;).

d

___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch