Re: emacs: honoring notmuch-show-insert-part-text/html for 'w3m renderer
On Tue, Aug 03 2021, David Bremner wrote: > can someone (TM) make a patch I can apply with git-am? sent: 20210804000241.1053748-1-...@gnu.org ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org
Re: emacs: honoring notmuch-show-insert-part-text/html for 'w3m renderer
David Edmondson writes: > On Saturday, 2021-07-31 at 00:18:45 +01, Jose Antonio Ortega Ruiz wrote: > >> Hi, >> >> notmuch-show-insert-part-text/html correctly binds shr-blocked-images to >> notmuch-show-text/html-blocked-images when using 'shr as the >> mm-text-html-renderer. However, when the latter is not shr, the >> function only binds gnus-blocked-images, which is not used by the 'w3m >> rendered. The corresponding variable to bind is in the latter case >> w3m-ignored-image-url-regexp, and something like the simple patch below >> seem to make things work, at least for me. > > Patch looks good. > > Reviewed-by: David Edmondson can someone (TM) make a patch I can apply with git-am? thanks, d ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org
Re: emacs: honoring notmuch-show-insert-part-text/html for 'w3m renderer
On Saturday, 2021-07-31 at 00:18:45 +01, Jose Antonio Ortega Ruiz wrote: > Hi, > > notmuch-show-insert-part-text/html correctly binds shr-blocked-images to > notmuch-show-text/html-blocked-images when using 'shr as the > mm-text-html-renderer. However, when the latter is not shr, the > function only binds gnus-blocked-images, which is not used by the 'w3m > rendered. The corresponding variable to bind is in the latter case > w3m-ignored-image-url-regexp, and something like the simple patch below > seem to make things work, at least for me. Patch looks good. Reviewed-by: David Edmondson > Cheers, > jao > > diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el > index 9a95eb34..0c4fc110 100644 > --- a/emacs/notmuch-show.el > +++ b/emacs/notmuch-show.el > @@ -823,7 +823,8 @@ will return nil if the CID is unknown or cannot be > retrieved." > (let ((mm-inline-text-html-with-w3m-keymap nil) > ;; FIXME: If we block an image, offer a button to load external > ;; images. > - (gnus-blocked-images notmuch-show-text/html-blocked-images)) > + (gnus-blocked-images notmuch-show-text/html-blocked-images) > + (w3m-ignored-image-url-regexp > notmuch-show-text/html-blocked-images)) >(notmuch-show-insert-part-*/* msg part content-type nth depth > button > > ;;; Functions used by notmuch-show--insert-part-text/html-shr > ___ > notmuch mailing list -- notmuch@notmuchmail.org > To unsubscribe send an email to notmuch-le...@notmuchmail.org ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org
emacs: honoring notmuch-show-insert-part-text/html for 'w3m renderer
Hi, notmuch-show-insert-part-text/html correctly binds shr-blocked-images to notmuch-show-text/html-blocked-images when using 'shr as the mm-text-html-renderer. However, when the latter is not shr, the function only binds gnus-blocked-images, which is not used by the 'w3m rendered. The corresponding variable to bind is in the latter case w3m-ignored-image-url-regexp, and something like the simple patch below seem to make things work, at least for me. Cheers, jao diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index 9a95eb34..0c4fc110 100644 --- a/emacs/notmuch-show.el +++ b/emacs/notmuch-show.el @@ -823,7 +823,8 @@ will return nil if the CID is unknown or cannot be retrieved." (let ((mm-inline-text-html-with-w3m-keymap nil) ;; FIXME: If we block an image, offer a button to load external ;; images. - (gnus-blocked-images notmuch-show-text/html-blocked-images)) + (gnus-blocked-images notmuch-show-text/html-blocked-images) + (w3m-ignored-image-url-regexp notmuch-show-text/html-blocked-images)) (notmuch-show-insert-part-*/* msg part content-type nth depth button ;;; Functions used by notmuch-show--insert-part-text/html-shr ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org
