Re: [Nouveau] [PATCH 00/10] extract dp helper functions

2012-10-22 Thread Daniel Vetter 
On Thu, Oct 18, 2012 at 09:30:01AM -0400, Alex Deucher wrote:
 On Thu, Oct 18, 2012 at 4:15 AM, Daniel Vetter daniel.vet...@ffwll.ch wrote:
  Hi all,
 
  I've frustrated myself the last few days yelling at our link training code.
  Comparing the i915 code to radeon and nouveau I've noticed the lack of a 
  nice
  set of dp helper functions. So I've started to extract a few.
 
  There's lots more that we can do I think (link configuration selection, the 
  i2c
  over aux retry stuff which diverges already between i915 and radeon, maybe 
  more
  higher level parts of the training sequence). But there the drivers diverge
  quite a bit (e.g. the link configuration is driver by different things in 
  each
  driver: coded link bw from the dp spec, link clock or required bw vs 
  avialable
  bw), so that's more work and probably best done when reworking these 
  functions
  for other reasons.
 
  I've also tried to put the new helpers a bit to use in nouveau, but due to 
  lack
  of hw that part is untested.
 
  Comments and testing highly welcome.
 
 Looks good to me.  Other than the minor change required in patch7,
 this series is:
 
 Reviewed-by: Alex Deucher alexander.deuc...@amd.com

Slurped into drm-intel-next, with all the nouveau patches and hunks
dropped (I'll pester Ben once this has landed in drm-next), as discussed
on irc. Thanks for reviewing this pile.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
___
Nouveau mailing list
Nouveau@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/nouveau

[Nouveau] [PATCH] drm/nv41/vm: fix typo in struct name

2012-10-22 Thread Marcin Slusarz 
It's a miracle it compiles at all - nv04_vm_priv does not exist
anywhere in the tree.

Signed-off-by: Marcin Slusarz marcin.slus...@gmail.com
---
Noticed when adding types to Nouveau APIs.
---
 drivers/gpu/drm/nouveau/core/subdev/vm/nv41.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/nouveau/core/subdev/vm/nv41.c 
b/drivers/gpu/drm/nouveau/core/subdev/vm/nv41.c
index 4545b0c..e41ce9b 100644
--- a/drivers/gpu/drm/nouveau/core/subdev/vm/nv41.c
+++ b/drivers/gpu/drm/nouveau/core/subdev/vm/nv41.c
@@ -67,7 +67,7 @@ nv41_vm_unmap(struct nouveau_gpuobj *pgt, u32 pte, u32 cnt)
 static int
 nv41_vm_flush(struct nouveau_vm *vm)
 {
-   struct nv04_vm_priv *priv = (void *)vm-vmm;
+   struct nv04_vmmgr_priv *priv = (void *)vm-vmm;
int ret = 0;
 
mutex_lock(nv_subdev(priv)-mutex);
-- 
1.7.12

___
Nouveau mailing list
Nouveau@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/nouveau