Re: [Nouveau] [PATCH] drm/nouveau: fix ramht wraparound
On Fri, Dec 21, 2012 at 10:15:48AM +1000, Ben Skeggs wrote: On Thu, Dec 20, 2012 at 11:37:12PM +0100, Marcin Slusarz wrote: When hash collision occurs and it's near ramht object boundary, we could read and possibly overwrite some memory after ramht object. Signed-off-by: Marcin Slusarz marcin.slus...@gmail.com Cc: sta...@vger.kernel.org --- drivers/gpu/drm/nouveau/core/core/ramht.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/core/core/ramht.c b/drivers/gpu/drm/nouveau/core/core/ramht.c index 86a6404..6da314c 100644 --- a/drivers/gpu/drm/nouveau/core/core/ramht.c +++ b/drivers/gpu/drm/nouveau/core/core/ramht.c @@ -59,7 +59,7 @@ nouveau_ramht_insert(struct nouveau_ramht *ramht, int chid, } co += 8; - if (co = nv_gpuobj(ramht)-size) + if (co + 8 nv_gpuobj(ramht)-size) I might just be really tired, but, how exactly is the original wrong? The original could even just be (co == size) and still work correctly as far as I can tell. Ah, crap, I didn't see that both hash value and ramht-size are divisible by 8. So original code is correct (although it relies on the above) and my version does not really fix anything. Marcin ___ Nouveau mailing list Nouveau@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/nouveau
[Nouveau] [Bug 58615] New: nv43 hangs with direct rendering since 3.7 rework
https://bugs.freedesktop.org/show_bug.cgi?id=58615 Priority: medium Bug ID: 58615 Assignee: nouveau@lists.freedesktop.org Summary: nv43 hangs with direct rendering since 3.7 rework QA Contact: xorg-t...@lists.x.org Severity: normal Classification: Unclassified OS: Linux (All) Reporter: rand...@mail.ru Hardware: x86 (IA32) Status: NEW Version: git Component: Driver/nouveau Product: xorg I have my nv43 back in action - and unfortunately new bugs to report. When I compiled new 3.7-rc kernel i noticed anything 3d related, even trivial/tri example from mesa/demos started to hang my X server - usually I was able to switch consoles and reboot clearly, but not always. Strangely, _indirect_ rendering worked ok! kernels 3.4.6, 3.5.7, 3.6.x - all OK. will add kernel/X log after reboot into freshly compiled nouveau kernel, now I want to attach partial bisection logs, done with mainline kernel. -- You are receiving this mail because: You are the assignee for the bug. ___ Nouveau mailing list Nouveau@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/nouveau
[Nouveau] [Bug 58615] nv43 hangs with direct rendering since 3.7 rework
https://bugs.freedesktop.org/show_bug.cgi?id=58615 --- Comment #1 from Andrew Randrianasulu rand...@mail.ru --- Created attachment 71920 -- https://bugs.freedesktop.org/attachment.cgi?id=71920action=edit nv43 bisection log [partial] -- You are receiving this mail because: You are the assignee for the bug. ___ Nouveau mailing list Nouveau@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/nouveau
[Nouveau] [Bug 58615] nv43 hangs with direct rendering since 3.7 rework
https://bugs.freedesktop.org/show_bug.cgi?id=58615 --- Comment #2 from Andrew Randrianasulu rand...@mail.ru --- Created attachment 71921 -- https://bugs.freedesktop.org/attachment.cgi?id=71921action=edit possible bad commits Unfortunately, all those commits resulted in BUG or simply black screen during boot, with completely non-working DRM. So, i can't test them. -- You are receiving this mail because: You are the assignee for the bug. ___ Nouveau mailing list Nouveau@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/nouveau
[Nouveau] [Bug 58615] nv43 hangs with direct rendering since 3.7 rework
https://bugs.freedesktop.org/show_bug.cgi?id=58615 --- Comment #3 from Andrew Randrianasulu rand...@mail.ru --- Created attachment 71922 -- https://bugs.freedesktop.org/attachment.cgi?id=71922action=edit Kernel .config This is my minimal kernel config - but bug also happens with bigger one (SMP, SLUB, tons of modules, etc). What I haven't checked - if changing ARCH from i486 to something more modern will do any good - will try this, too. -- You are receiving this mail because: You are the assignee for the bug. ___ Nouveau mailing list Nouveau@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/nouveau
[Nouveau] [Bug 58615] nv43 hangs with direct rendering since 3.7 rework
https://bugs.freedesktop.org/show_bug.cgi?id=58615 --- Comment #4 from Andrew Randrianasulu rand...@mail.ru --- Created attachment 71923 -- https://bugs.freedesktop.org/attachment.cgi?id=71923action=edit working X log This is on kernel 3.6.11. bash-4.2$ glxgears Running synchronized to the vertical refresh. The framerate should be approximately the same as the monitor refresh rate. 809 frames in 5.0 seconds = 161.695 FPS 1080 frames in 5.0 seconds = 215.978 FPS 997 frames in 5.0 seconds = 199.132 FPS 951 frames in 5.0 seconds = 189.950 FPS 988 frames in 5.0 seconds = 197.346 FPS XIO: fatal IO error 11 (Resource temporarily unavailable) on X server :0 after 16815 requests (16815 known processed) with 0 events remaining. bash-4.2$ -- You are receiving this mail because: You are the assignee for the bug. ___ Nouveau mailing list Nouveau@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/nouveau
[Nouveau] [Bug 58615] nv43 hangs with direct rendering since 3.7 rework
https://bugs.freedesktop.org/show_bug.cgi?id=58615 --- Comment #5 from Andrew Randrianasulu rand...@mail.ru --- Created attachment 71927 -- https://bugs.freedesktop.org/attachment.cgi?id=71927action=edit X log for affected kernel -- You are receiving this mail because: You are the assignee for the bug. ___ Nouveau mailing list Nouveau@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/nouveau
[Nouveau] [Bug 58615] nv43 hangs with direct rendering since 3.7 rework
https://bugs.freedesktop.org/show_bug.cgi?id=58615 --- Comment #6 from Andrew Randrianasulu rand...@mail.ru --- Created attachment 71928 -- https://bugs.freedesktop.org/attachment.cgi?id=71928action=edit dmesg after X start and launching gears Note: I switched away from X's vt shortly after black glxgears window appear - and captured this dmesg from another vt. -- You are receiving this mail because: You are the assignee for the bug. ___ Nouveau mailing list Nouveau@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/nouveau
[Nouveau] [Bug 40275] DPMS Blank screen turn into white mess
https://bugs.freedesktop.org/show_bug.cgi?id=40275 --- Comment #1 from Stefan de Konink ste...@konink.de --- Would anyone care to comment on where to start poking or what to enable to see any debug logging when this happens? -- You are receiving this mail because: You are the assignee for the bug. ___ Nouveau mailing list Nouveau@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/nouveau
