Re: [Nouveau] [PATCH] drm/nouveau/secboot/acr: Remove VLA usage

[Kees Cook]

On Fri, Jun 22, 2018 at 2:40 PM, Karol Herbst  wrote:
> Your patch is fine as it is though, because it doesn't add a new
> issue, it just showed us there is a potential one. We should keep that
> in mind and see how we want to fix that up. I can imagine that this
> might cause some issues in some places, maybe it is totally fine.

Okay, thanks! Who can take the patch into their tree?

-Kees

-- 
Kees Cook
Pixel Security
___
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau

[Nouveau] [Bug 107003] Timeout in nvkm_falcon_v1_clear_interrupt on gp104

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=107003

--- Comment #1 from Emil Andersen Lauridsen  ---
I should perhaps mention that the timeout results in the driver completely
failing to load, which makes nouveau completely useless on my card, and needs
to be explicitly blacklisted.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau

[Nouveau] [Bug 107016] Gpio error only from kernel higher as 4.x (k2000m; 0x0e73b0a2; version 80.07.40.00.02)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=107016

--- Comment #19 from atirage21  ---
(In reply to Roy from comment #1)
> To debug this, I'd like you to attach to this bug report:
> - A better description of what you're trying to do. I suspect you're trying
> to set a pstate, but please be clear about the steps that you follow to get
> the result you claim to get.
> - A copy of your video BIOS (/sys/kernel/debug/dri//vbios.rom
> - A peek of the strap register (nvapeek 0x101000)
> - A full unfiltered dmesg from kernel 4.17 after failure like you did for
> the 3.19 kernel, preferably booted with the nouveau.debug="PMU=debug"
> parameter.
> 
> (In reply to atirage21 from comment #0)
> > Maybe it is connected on your changes from 2016:
> > https://cgit.freedesktop.org/nouveau/xf86-video-nouveau/commit/
> > ?id=a24ded627e42d453546c553d609edc073f59cd57
> 
> This patch... no, this whole repository is unrelated to your problems.

nvapeek 0x101000
00101000: df40ac9a

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau

[Nouveau] [Bug 107016] Gpio error only from kernel higher as 4.x (k2000m; 0x0e73b0a2; version 80.07.40.00.02)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=107016

--- Comment #18 from atirage21  ---
(In reply to atirage21 from comment #4)
> (In reply to Karol Herbst from comment #3)
> > can you print the output of "nvapeek 0x20340 0x8" please?
> 
> Please send me exatly guide how, because command "nvapeek 0x20340 0x8" not
> found.

nvapeek 0x20340 0x8
00020340: 0360 

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau

[Nouveau] [Bug 107016] Gpio error only from kernel higher as 4.x (k2000m; 0x0e73b0a2; version 80.07.40.00.02)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=107016

--- Comment #17 from atirage21  ---
Created attachment 140333
  --> https://bugs.freedesktop.org/attachment.cgi?id=140333=edit
Nvidia xserver clocks -printscreen

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau

[Nouveau] [Bug 107016] Gpio error only from kernel higher as 4.x (k2000m; 0x0e73b0a2; version 80.07.40.00.02)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=107016

--- Comment #16 from atirage21  ---
(In reply to atirage21 from comment #15)
> Created attachment 140332 [details]
> attachment-14056-0.html
> 
> In live ubuntu 18.04 with kernel 4.15
> 
> Only boot frequency of core
> sudo cat /sys/kernel/debug/dri/0/pstate
> 
> 
> 
> 07: core 405 MHz memory 810 MHz
> 0f: core 405 MHz memory 1800 MHz
> AC: core 405 MHz memory 648 MHz
> 
> 
> 2018-06-25 14:51 GMT+00:00 Attila Tóth :
> 
> > Not truth!  I see only 405 MHz of core in newer kernel 4.x in
> >
> > /sys/kernel/debug/dri//pstate. It was first argument for me, that 
> > something is not good compared to kernel 3.19.
> >
> >
> >
> > 2018-06-25 16:25 GMT+02:00 :
> >
> >> *Comment # 13 
> >> on bug 107016  from
> >> Roy  *
> >>
> >> (In reply to atirage21 from comment #12 
> >> )> Created 
> >> attachment 140326 [details] 
> >>  [details] 
> >> 
> >> > attachment-20771-0.html
> >> >
> >> > But also is question: Why i had only 405 Mhz of core under kernel 4.x,
> >> > if under kernel 3.19 was more options to see (and same more options is
> >> > with propretiary driver):
> >> >
> >> > [4.311074] nouveau  [ CLK][:01:00.0] 07: core 270-405 MHz
> >> > memory 810 MHz
> >> > [4.311090] nouveau  [ CLK][:01:00.0] 0f: core 270-745 MHz
> >> > memory 1800 MHz
> >> > [4.311233] nouveau  [ CLK][:01:00.0] --: core 405 MHz memory 
> >> > 648
> >> > MHz
> >> >
> >>
> >> That's just reduced verbosity of the driver in newer kernels. There's no 
> >> need
> >> to report that during boot, just clutters the log. You'll find all those
> >> entries in /sys/kernel/debug/dri//pstate.
> >>



Nvidia xserver setting have clock from 135-405 and from 135 - 745 Mhz of clock
(see attachment)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau

[Nouveau] [Bug 107016] Gpio error only from kernel higher as 4.x (k2000m; 0x0e73b0a2; version 80.07.40.00.02)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=107016

--- Comment #15 from atirage21  ---
In live ubuntu 18.04 with kernel 4.15

Only boot frequency of core
sudo cat /sys/kernel/debug/dri/0/pstate



07: core 405 MHz memory 810 MHz
0f: core 405 MHz memory 1800 MHz
AC: core 405 MHz memory 648 MHz


2018-06-25 14:51 GMT+00:00 Attila Tóth :

> Not truth!  I see only 405 MHz of core in newer kernel 4.x in
>
> /sys/kernel/debug/dri//pstate. It was first argument for me, that 
> something is not good compared to kernel 3.19.
>
>
>
> 2018-06-25 16:25 GMT+02:00 :
>
>> *Comment # 13 
>> on bug 107016  from
>> Roy  *
>>
>> (In reply to atirage21 from comment #12 
>> )> Created 
>> attachment 140326  
>> [details] 
>> > attachment-20771-0.html
>> >
>> > But also is question: Why i had only 405 Mhz of core under kernel 4.x,
>> > if under kernel 3.19 was more options to see (and same more options is
>> > with propretiary driver):
>> >
>> > [4.311074] nouveau  [ CLK][:01:00.0] 07: core 270-405 MHz
>> > memory 810 MHz
>> > [4.311090] nouveau  [ CLK][:01:00.0] 0f: core 270-745 MHz
>> > memory 1800 MHz
>> > [4.311233] nouveau  [ CLK][:01:00.0] --: core 405 MHz memory 
>> > 648
>> > MHz
>> >
>>
>> That's just reduced verbosity of the driver in newer kernels. There's no need
>> to report that during boot, just clutters the log. You'll find all those
>> entries in /sys/kernel/debug/dri//pstate.
>>
>> --
>> You are receiving this mail because:
>>
>>- You reported the bug.
>>
>>
>
>
> --
> S pozdravom / Mit freundlichen Grüßen / Baráti udvozlettel / Best regards
>
> Ing. Attila Tóth, PhD.
>
> tel : +421 910 299 189 (4Ka - Slovak Republic)
>
> Please consider your environmental responsibility before printing this
> e-mail
>
>
>
>
>

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau

[Nouveau] [Bug 107016] Gpio error only from kernel higher as 4.x (k2000m; 0x0e73b0a2; version 80.07.40.00.02)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=107016

--- Comment #14 from atirage21  ---
Not truth!  I see only 405 MHz of core in newer kernel 4.x in

/sys/kernel/debug/dri//pstate. It was first argument for me,
that something is not good compared to kernel 3.19.



2018-06-25 16:25 GMT+02:00 :

> *Comment # 13  on
> bug 107016  from Roy
>  *
>
> (In reply to atirage21 from comment #12 
> )> Created 
> attachment 140326  
> [details] 
> > attachment-20771-0.html
> >
> > But also is question: Why i had only 405 Mhz of core under kernel 4.x,
> > if under kernel 3.19 was more options to see (and same more options is
> > with propretiary driver):
> >
> > [4.311074] nouveau  [ CLK][:01:00.0] 07: core 270-405 MHz
> > memory 810 MHz
> > [4.311090] nouveau  [ CLK][:01:00.0] 0f: core 270-745 MHz
> > memory 1800 MHz
> > [4.311233] nouveau  [ CLK][:01:00.0] --: core 405 MHz memory 648
> > MHz
> >
>
> That's just reduced verbosity of the driver in newer kernels. There's no need
> to report that during boot, just clutters the log. You'll find all those
> entries in /sys/kernel/debug/dri//pstate.
>
> --
> You are receiving this mail because:
>
>- You reported the bug.
>
>

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau

[Nouveau] [Bug 107016] Gpio error only from kernel higher as 4.x (k2000m; 0x0e73b0a2; version 80.07.40.00.02)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=107016

--- Comment #13 from Roy  ---
(In reply to atirage21 from comment #12)
> Created attachment 140326 [details]
> attachment-20771-0.html
> 
> But also is question: Why i had only 405 Mhz of core under kernel 4.x,
> if under kernel 3.19 was more options to see (and same more options is
> with propretiary driver):
> 
> [4.311074] nouveau  [ CLK][:01:00.0] 07: core 270-405 MHz
> memory 810 MHz
> [4.311090] nouveau  [ CLK][:01:00.0] 0f: core 270-745 MHz
> memory 1800 MHz
> [4.311233] nouveau  [ CLK][:01:00.0] --: core 405 MHz memory 648
> MHz
> 

That's just reduced verbosity of the driver in newer kernels. There's no need
to report that during boot, just clutters the log. You'll find all those
entries in /sys/kernel/debug/dri//pstate.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau

[Nouveau] [Bug 107016] Gpio error only from kernel higher as 4.x (k2000m; 0x0e73b0a2; version 80.07.40.00.02)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=107016

--- Comment #12 from atirage21  ---
But also is question: Why i had only 405 Mhz of core under kernel 4.x,
if under kernel 3.19 was more options to see (and same more options is
with propretiary driver):

[4.311074] nouveau  [ CLK][:01:00.0] 07: core 270-405 MHz
memory 810 MHz
[4.311090] nouveau  [ CLK][:01:00.0] 0f: core 270-745 MHz
memory 1800 MHz
[4.311233] nouveau  [ CLK][:01:00.0] --: core 405 MHz memory 648
MHz



2018-06-25 14:03 GMT+02:00 :

> *Comment # 10  on
> bug 107016  from Karol
> Herbst  *
>
> @atirage21:
>
> were you actually able to reclock the GPU before in a stable way? It seems 
> like
> we have to support a way of setting the voltage we don't implement yet (and
> never had).
>
> It is the first time actually seeing such a GPU, so I am not quite sure how we
> are able to get that working for now. Of course we could provide patches and
> hope it kind of works, but this would require testing from your side as well.
>
> --
> You are receiving this mail because:
>
>- You reported the bug.
>
>

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau

[Nouveau] [Bug 107016] Gpio error only from kernel higher as 4.x (k2000m; 0x0e73b0a2; version 80.07.40.00.02)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=107016

--- Comment #11 from atirage21  ---
I was not successfull in reclock the gpu. OK

2018-06-25 14:03 GMT+02:00 :

> *Comment # 10  on
> bug 107016  from Karol
> Herbst  *
>
> @atirage21:
>
> were you actually able to reclock the GPU before in a stable way? It seems 
> like
> we have to support a way of setting the voltage we don't implement yet (and
> never had).
>
> It is the first time actually seeing such a GPU, so I am not quite sure how we
> are able to get that working for now. Of course we could provide patches and
> hope it kind of works, but this would require testing from your side as well.
>
> --
> You are receiving this mail because:
>
>- You reported the bug.
>
>

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau

[Nouveau] [Bug 107016] Gpio error only from kernel higher as 4.x (k2000m; 0x0e73b0a2; version 80.07.40.00.02)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=107016

--- Comment #10 from Karol Herbst  ---
@atirage21:

were you actually able to reclock the GPU before in a stable way? It seems like
we have to support a way of setting the voltage we don't implement yet (and
never had).

It is the first time actually seeing such a GPU, so I am not quite sure how we
are able to get that working for now. Of course we could provide patches and
hope it kind of works, but this would require testing from your side as well.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau

[Nouveau] [Bug 107016] Gpio error only from kernel higher as 4.x (k2000m; 0x0e73b0a2; version 80.07.40.00.02)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=107016

--- Comment #9 from Karol Herbst  ---
(In reply to atirage21 from comment #4)
> (In reply to Karol Herbst from comment #3)
> > can you print the output of "nvapeek 0x20340 0x8" please?
> 
> Please send me exatly guide how, because command "nvapeek 0x20340 0x8" not
> found.

you would need to install envytools, but the trace is actually more helpful,
because there we could simply lookup how nvidia is doing stuff

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau