[Nouveau] [PATCH] drm/nouveau/core/memory: remove redundant assignments to variable ret
From: Colin Ian King
The variable ret is being initialized with a value that is never
read and it is being updated later with a new value. The initialization
is redundant and can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King
---
drivers/gpu/drm/nouveau/nvkm/core/memory.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/core/memory.c
b/drivers/gpu/drm/nouveau/nvkm/core/memory.c
index 4cc186262d34..38130ef272d6 100644
--- a/drivers/gpu/drm/nouveau/nvkm/core/memory.c
+++ b/drivers/gpu/drm/nouveau/nvkm/core/memory.c
@@ -140,7 +140,7 @@ nvkm_memory_new(struct nvkm_device *device, enum
nvkm_memory_target target,
{
struct nvkm_instmem *imem = device->imem;
struct nvkm_memory *memory;
- int ret = -ENOSYS;
+ int ret;
if (unlikely(target != NVKM_MEM_TARGET_INST || !imem))
return -ENOSYS;
--
2.25.0
___
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau
[Nouveau] 5.6-rc3 nouveau failure, 5.6-rc2 OK
[94.455712] [T411] nouveau :07:00.0 disp ctor failed, -12 Welcome to openSUSE Tumbleweed 20200224 - Kernel 5.6.0-rc3 (tty1) ens3s0: 192.168.10.214 ... login: I can login here but X does not start -- lspci 07:00.0 VGA compatible controller: NVIDIA Corporation TU117 [GeForce GTX 1650] (rev a1) from dmesg:- [Wed Feb 26 22:42:39 2020] nouveau :07:00.0: NVIDIA TU117 (167000a1) [Wed Feb 26 22:42:39 2020] nouveau :07:00.0: bios: version 90.17.2a.00.39 [Wed Feb 26 22:44:12 2020] nouveau :07:00.0: disp ctor failed, -12 [Wed Feb 26 22:44:12 2020] nouveau: probe of :07:00.0 failed with error -12 Another box with VGA compatible controller: NVIDIA Corporation GP107 [GeForce GTX 1050 Ti] (rev a1) boots to graphical environment with 5.6-rc3. tindog:~ # dmesg -T|grep nouveau [Mon Feb 24 12:50:16 2020] nouveau :07:00.0: NVIDIA GF106 (0c3100a1) [Mon Feb 24 12:50:16 2020] nouveau :07:00.0: bios: version 70.26.37.00.01 [Mon Feb 24 12:50:16 2020] nouveau :07:00.0: fb: 4096 MiB GDDR5 [Mon Feb 24 12:50:17 2020] nouveau :07:00.0: DRM: VRAM: 4096 MiB [Mon Feb 24 12:50:17 2020] nouveau :07:00.0: DRM: GART: 1048576 MiB [Mon Feb 24 12:50:17 2020] nouveau :07:00.0: DRM: TMDS table version 2.0 [Mon Feb 24 12:50:17 2020] nouveau :07:00.0: DRM: DCB version 4.0 [Mon Feb 24 12:50:17 2020] nouveau :07:00.0: DRM: DCB outp 00: 02000300 [Mon Feb 24 12:50:17 2020] nouveau :07:00.0: DRM: DCB outp 01: 01000302 00020030 [Mon Feb 24 12:50:17 2020] nouveau :07:00.0: DRM: DCB outp 02: 04011380 [Mon Feb 24 12:50:17 2020] nouveau :07:00.0: DRM: DCB outp 03: 08011382 00020030 [Mon Feb 24 12:50:17 2020] nouveau :07:00.0: DRM: DCB outp 04: 02022362 00020010 [Mon Feb 24 12:50:17 2020] nouveau :07:00.0: DRM: DCB conn 00: 1030 [Mon Feb 24 12:50:17 2020] nouveau :07:00.0: DRM: DCB conn 01: 0100 [Mon Feb 24 12:50:17 2020] nouveau :07:00.0: DRM: DCB conn 02: 2261 [Mon Feb 24 12:50:17 2020] nouveau :07:00.0: DRM: MM: using COPY0 for buffer copies [Mon Feb 24 12:50:17 2020] nouveau :07:00.0: DRM: allocated 1920x1080 fb: 0x6, bo 8db05e25 [Mon Feb 24 12:50:17 2020] fbcon: nouveaudrmfb (fb0) is primary device [Mon Feb 24 12:50:17 2020] nouveau :07:00.0: fb0: nouveaudrmfb frame buffer device [Mon Feb 24 12:50:17 2020] [drm] Initialized nouveau 1.3.1 20120801 for :07:00.0 on minor 0 I have tried the new firmware, result is the same. https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/commit/?id=2277987a593d54c1e922a9f25445802071015f42 Regards Sid. -- Sid Boyce ... Hamradio License G3VBV, Licensed Private Pilot Emeritus IBM/Amdahl Mainframes and Sun/Fujitsu Servers Tech Support Senior Staff Specialist, Cricket Coach Microsoft Windows Free Zone - Linux used for all Computing Tasks ___ Nouveau mailing list Nouveau@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/nouveau
Re: [Nouveau] where to report modesetting DDX bug?
> Felix Miata wrote in > https://lists.freedesktop.org/archives/nouveau/2020-February/035583.html: OS Kernel State /boot/vmlinuz timestamp >> openSUSE 15.1/kernel 4.12.14OK 2019-12-06 Fedora 31/5.3.16 kernel OK 2019-12-13 openSUSE 15.2/5.3.16 kernel OK 2019-12-31 Tumbleweed/5.4.7 kernel OK 2020-01-08 Mageia 7/5.4.10 kernel OK 2020-01-09 Mageia 8/5.4.11 kernel OK 2020-01-13 >> Debian Buster/kernel 4.19.x OK 2020-01-26 >> Tumbleweed/kernel 5.4.14bad 2020-02-02 Fedora 31/5.4.20 kernel OK 2020-02-17 Fedora 30/5.4.21 kernel OK 2020-02-19 >> Fedora 31/5.5.5 kernel bad 2020-02-19 >> openSUSE 15.2/kernel 5.3.18 bad 2020-02-21 Does this expanded timeline help any? -- Evolution as taught in public schools is religion, not science. Team OS/2 ** Reg. Linux User #211409 ** a11y rocks! Felix Miata *** http://fm.no-ip.com/ ___ Nouveau mailing list Nouveau@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/nouveau
Re: [Nouveau] where to report modesetting DDX bug?
On Fri, Feb 28, 2020 at 11:06 AM Felix Miata wrote: > Video and input drivers Subgroups and projects on gitlab does not list > modesetting > DDX, presumably because it's not packaged separately from the server. Where's > the > right place to report a modesetting DDX bug that manifests only on an NVidia > GPU? > Directly against the server https://gitlab.freedesktop.org/xorg/xserver? I don't know if anyone (from nouveau) looks at gitlab, so mailing list is probably best anyways. > > Here are some particulars: > How can I tell whether this should be reported to kernel tracker or to > freedesktop > tracker as driver or server problem? HDMI output on GT218 10de:0a65 GPU is > limited > to 1920x1200. When connected to 2560x1440 display, vttys are supported at > display's supported 1920x1080 mode, but X with modesetting DDX puts display in > unsupported mode (functionally asleep) regardless of various attempts to force > 1920x1080@60 or 1600x900@60, while with nouveau DDX, or 1920x1200 display, or > 2560x1440 display with Dual-link DVI cable, display behavior is as expected. > > openSUSE 15.1/kernel 4.12.14OK > openSUSE 15.2/kernel 5.3.18 bad > Tumbleweed/kernel 5.4.14bad > Debian Buster/kernel 4.19.x OK > Fedora 31/5.5.5 kernel bad > > http://fm.no-ip.com/Tmp/Linux/Xorg/xorg.0.log-gt218-stw-modesetting-OOR-0x1e > http://fm.no-ip.com/Tmp/Linux/Xorg/gt218-dmesg-stw.txt Those HDMI mode clocks are too high against the nominal single-link 165MHz TMDS. You can set your own maximum with nouveau.hdmimhz=300 (for example) to allow it. I believe the connectors aren't rated for that though. The commit which fixed this is commit d1084184789d677df4e9c110f38cb3f3d709195d Author: Ben Skeggs Date: Wed May 29 09:58:18 2019 +1000 drm/nouveau/kms: disallow dual-link harder if hdmi connection detected and went into v5.3. I'm not sure where this got broken... I think it would have been commit 9340d77f5327ea673a7f95f58139123d7a278243 Author: Ilia Mirkin Date: Mon Sep 3 20:57:37 2018 -0400 drm/nouveau/disp: take sink support into account for exposing 594mhz which went into v4.20, but it could also have been commit 1a0c96c075bb4517d4ce4fb6750ee0a3cf38714c Author: Ilia Mirkin Date: Tue Nov 3 21:00:11 2015 -0500 drm/nouveau/kms: allow 225/297MHz pixel clocks for HDMI on Fermi/Kepler which went into v4.5 and lines up with your timeline better, but seems like it shouldn't be handing out those high frequencies to HDMI connectors on tesla... Cheers, -ilia ___ Nouveau mailing list Nouveau@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/nouveau
[Nouveau] where to report modesetting DDX bug?
Video and input drivers Subgroups and projects on gitlab does not list modesetting DDX, presumably because it's not packaged separately from the server. Where's the right place to report a modesetting DDX bug that manifests only on an NVidia GPU? Directly against the server https://gitlab.freedesktop.org/xorg/xserver? Here are some particulars: How can I tell whether this should be reported to kernel tracker or to freedesktop tracker as driver or server problem? HDMI output on GT218 10de:0a65 GPU is limited to 1920x1200. When connected to 2560x1440 display, vttys are supported at display's supported 1920x1080 mode, but X with modesetting DDX puts display in unsupported mode (functionally asleep) regardless of various attempts to force 1920x1080@60 or 1600x900@60, while with nouveau DDX, or 1920x1200 display, or 2560x1440 display with Dual-link DVI cable, display behavior is as expected. openSUSE 15.1/kernel 4.12.14OK openSUSE 15.2/kernel 5.3.18 bad Tumbleweed/kernel 5.4.14bad Debian Buster/kernel 4.19.x OK Fedora 31/5.5.5 kernel bad http://fm.no-ip.com/Tmp/Linux/Xorg/xorg.0.log-gt218-stw-modesetting-OOR-0x1e http://fm.no-ip.com/Tmp/Linux/Xorg/gt218-dmesg-stw.txt -- Evolution as taught in public schools is religion, not science. Team OS/2 ** Reg. Linux User #211409 ** a11y rocks! Felix Miata *** http://fm.no-ip.com/ ___ Nouveau mailing list Nouveau@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/nouveau
