Re: [Nouveau] [PATCH v9 07/10] mm: Device exclusive memory access
On Fri, Jun 04, 2021 at 11:07:42AM +1000, Alistair Popple wrote:
> On Friday, 4 June 2021 12:47:40 AM AEST Peter Xu wrote:
> > External email: Use caution opening links or attachments
> >
> > On Thu, Jun 03, 2021 at 09:39:32PM +1000, Alistair Popple wrote:
> > > Reclaim won't run on the page due to the extra references from the special
> > > swap entries.
> >
> > That sounds reasonable, but I didn't find the point that stops it, probably
> > due to my limited knowledge on the reclaim code. Could you elaborate?
>
> Sure, it isn't immediately obvious but it ends up being detected at the start
> of is_page_cache_freeable() in the pageout code:
>
>
> static pageout_t pageout(struct page *page, struct address_space *mapping)
> {
>
> [...]
>
> if (!is_page_cache_freeable(page))
> return PAGE_KEEP;
I did look at pageout() but still missed this small helper indeed (while it's
so important to know..), thanks!
--
Peter Xu
___
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau
Re: [Nouveau] [RESEND 00/26] Rid W=1 warnings from GPU
On Thu, 03 Jun 2021, Daniel Vetter wrote:
> On Wed, Jun 02, 2021 at 03:32:34PM +0100, Lee Jones wrote:
> > Some off these patches have been knocking around for a while.
> >
> > Who will hoover them up please?
> >
> > This set is part of a larger effort attempting to clean-up W=1
> > kernel builds, which are currently overwhelmingly riddled with
> > niggly little warnings.
> >
> > Lee Jones (26):
> > drm/mediatek/mtk_disp_color: Strip incorrect doc and demote header
> > drm/mediatek/mtk_disp_gamma: Strip and demote non-conformant
> > kernel-doc header
> > drm/mediatek/mtk_disp_ovl: Strip and demote non-conformant header
> > drm/mediatek/mtk_disp_rdma: Strip and demote non-conformant kernel-doc
> > header
> > drm/sti/sti_hdmi_tx3g4c28phy: Provide function names for kernel-doc
> > headers
> > drm/sti/sti_hda: Provide missing function names
> > drm/sti/sti_tvout: Provide a bunch of missing function names
> > drm/sti/sti_hqvdp: Fix incorrectly named function 'sti_hqvdp_vtg_cb()'
> > drm/msm/disp/dpu1/dpu_encoder_phys_cmd: Remove unused variable
> > 'cmd_enc'
> > drm/msm/disp/dpu1/dpu_hw_interrupts: Demote a bunch of kernel-doc
> > abuses
> > drm/msm/disp/dpu1/dpu_plane: Fix a couple of naming issues
> > drm/msm/msm_gem: Demote kernel-doc abuses
> > drm/msm/dp/dp_catalog: Correctly document param 'dp_catalog'
> > drm/msm/dp/dp_link: Fix some potential doc-rot
> > drm/nouveau/nvkm/subdev/mc/tu102: Make functions called by reference
> > static
> > drm/amd/display/dc/dce/dce_transform: Remove superfluous
> > re-initialisation of DCFE_MEM_LIGHT_SLEEP_CNTL,
> > drm/xlnx/zynqmp_disp: Fix incorrectly named enum
> > 'zynqmp_disp_layer_id'
> > drm/xlnx/zynqmp_dp: Fix incorrectly name function 'zynqmp_dp_train()'
> > drm/ttm/ttm_tt: Demote non-conformant kernel-doc header
> > drm/panel/panel-raspberrypi-touchscreen: Demote kernel-doc abuse
> > drm/panel/panel-sitronix-st7701: Demote kernel-doc abuse
> > drm/vgem/vgem_drv: Standard comment blocks should not use kernel-doc
> > format
> > drm/exynos/exynos7_drm_decon: Fix incorrect naming of
> > 'decon_shadow_protect_win()'
> > drm/exynos/exynos_drm_ipp: Fix documentation for
> > 'exynos_drm_ipp_get_{caps,res}_ioctl()'
> > drm/vboxvideo/hgsmi_base: Place function names into headers
> > drm/vboxvideo/modesetting: Provide function names for prototype
> > headers
>
> Except for msm (Rob Clark promised on irc he'll pick them up for 5.14
> soon) and amd (Alex is on top of things I think) I picked them all up and
> merged into drm-misc-next.
Superstar! Thanks Daniel.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
___
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau
Re: [Nouveau] [RESEND 00/26] Rid W=1 warnings from GPU
On Wed, Jun 02, 2021 at 03:32:34PM +0100, Lee Jones wrote:
> Some off these patches have been knocking around for a while.
>
> Who will hoover them up please?
>
> This set is part of a larger effort attempting to clean-up W=1
> kernel builds, which are currently overwhelmingly riddled with
> niggly little warnings.
>
> Lee Jones (26):
> drm/mediatek/mtk_disp_color: Strip incorrect doc and demote header
> drm/mediatek/mtk_disp_gamma: Strip and demote non-conformant
> kernel-doc header
> drm/mediatek/mtk_disp_ovl: Strip and demote non-conformant header
> drm/mediatek/mtk_disp_rdma: Strip and demote non-conformant kernel-doc
> header
> drm/sti/sti_hdmi_tx3g4c28phy: Provide function names for kernel-doc
> headers
> drm/sti/sti_hda: Provide missing function names
> drm/sti/sti_tvout: Provide a bunch of missing function names
> drm/sti/sti_hqvdp: Fix incorrectly named function 'sti_hqvdp_vtg_cb()'
> drm/msm/disp/dpu1/dpu_encoder_phys_cmd: Remove unused variable
> 'cmd_enc'
> drm/msm/disp/dpu1/dpu_hw_interrupts: Demote a bunch of kernel-doc
> abuses
> drm/msm/disp/dpu1/dpu_plane: Fix a couple of naming issues
> drm/msm/msm_gem: Demote kernel-doc abuses
> drm/msm/dp/dp_catalog: Correctly document param 'dp_catalog'
> drm/msm/dp/dp_link: Fix some potential doc-rot
> drm/nouveau/nvkm/subdev/mc/tu102: Make functions called by reference
> static
> drm/amd/display/dc/dce/dce_transform: Remove superfluous
> re-initialisation of DCFE_MEM_LIGHT_SLEEP_CNTL,
> drm/xlnx/zynqmp_disp: Fix incorrectly named enum
> 'zynqmp_disp_layer_id'
> drm/xlnx/zynqmp_dp: Fix incorrectly name function 'zynqmp_dp_train()'
> drm/ttm/ttm_tt: Demote non-conformant kernel-doc header
> drm/panel/panel-raspberrypi-touchscreen: Demote kernel-doc abuse
> drm/panel/panel-sitronix-st7701: Demote kernel-doc abuse
> drm/vgem/vgem_drv: Standard comment blocks should not use kernel-doc
> format
> drm/exynos/exynos7_drm_decon: Fix incorrect naming of
> 'decon_shadow_protect_win()'
> drm/exynos/exynos_drm_ipp: Fix documentation for
> 'exynos_drm_ipp_get_{caps,res}_ioctl()'
> drm/vboxvideo/hgsmi_base: Place function names into headers
> drm/vboxvideo/modesetting: Provide function names for prototype
> headers
Except for msm (Rob Clark promised on irc he'll pick them up for 5.14
soon) and amd (Alex is on top of things I think) I picked them all up and
merged into drm-misc-next.
Thanks, Daniel
>
> .../drm/amd/display/dc/dce/dce_transform.h| 3 +-
> drivers/gpu/drm/exynos/exynos7_drm_decon.c| 2 +-
> drivers/gpu/drm/exynos/exynos_drm_ipp.c | 4 +--
> drivers/gpu/drm/mediatek/mtk_disp_color.c | 3 +-
> drivers/gpu/drm/mediatek/mtk_disp_gamma.c | 4 +--
> drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 3 +-
> drivers/gpu/drm/mediatek/mtk_disp_rdma.c | 4 +--
> .../drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 4 ---
> .../gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c | 32 +--
> drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 4 +--
> drivers/gpu/drm/msm/dp/dp_catalog.c | 2 +-
> drivers/gpu/drm/msm/dp/dp_link.c | 6 ++--
> drivers/gpu/drm/msm/msm_gem.c | 4 +--
> .../gpu/drm/nouveau/nvkm/subdev/mc/tu102.c| 6 ++--
> .../drm/panel/panel-raspberrypi-touchscreen.c | 2 +-
> drivers/gpu/drm/panel/panel-sitronix-st7701.c | 2 +-
> drivers/gpu/drm/sti/sti_hda.c | 6 ++--
> drivers/gpu/drm/sti/sti_hdmi_tx3g4c28phy.c| 4 +--
> drivers/gpu/drm/sti/sti_hqvdp.c | 2 +-
> drivers/gpu/drm/sti/sti_tvout.c | 18 +--
> drivers/gpu/drm/ttm/ttm_tt.c | 2 +-
> drivers/gpu/drm/vboxvideo/hgsmi_base.c| 19 +++
> drivers/gpu/drm/vboxvideo/modesetting.c | 20 +++-
> drivers/gpu/drm/vgem/vgem_drv.c | 2 +-
> drivers/gpu/drm/xlnx/zynqmp_disp.c| 2 +-
> drivers/gpu/drm/xlnx/zynqmp_dp.c | 2 +-
> 26 files changed, 80 insertions(+), 82 deletions(-)
>
> Cc: Adam Jackson
> Cc: Ajay Kumar
> Cc: Akshu Agarwal
> Cc: Alex Deucher
> Cc: Alistair Popple
> Cc: amd-...@lists.freedesktop.org
> Cc: AngeloGioacchino Del Regno
> Cc: Benjamin Gaignard
> Cc: Ben Skeggs
> Cc: Ben Widawsky
> Cc: Chandan Uddaraju
> Cc: Christian Koenig
> Cc: "Christian König"
> Cc: Chun-Kuang Hu
> Cc: Daniel Vetter
> Cc: David Airlie
> Cc: dri-de...@lists.freedesktop.org
> Cc: Eric Anholt
> Cc: Fabien Dessenne
> Cc: freedr...@lists.freedesktop.org
> Cc: Hans de Goede
> Cc: Harry Wentland
> Cc: Huang Rui
> Cc: Hyun Kwon
> Cc: Inki Dae
> Cc: Jagan Teki
> Cc: Joonyoung Shim
> Cc: Krishna Manikandan
> Cc: Krzysztof Kozlowski
> Cc: Kuogee Hsieh
> Cc: Kyungmin Park
> Cc: Laurent Pinchart
> Cc: Leo Li
> Cc: linaro-mm-...@lists.linaro.org
> Cc: linux-arm-ker...@lists.infradead.org
> Cc: linux-arm-...@vger.kernel.org
> Cc: linux-media...@lists.infradead.org
Re: [Nouveau] [PATCH v9 07/10] mm: Device exclusive memory access
On Thu, Jun 03, 2021 at 09:39:32PM +1000, Alistair Popple wrote: > Reclaim won't run on the page due to the extra references from the special > swap entries. That sounds reasonable, but I didn't find the point that stops it, probably due to my limited knowledge on the reclaim code. Could you elaborate? -- Peter Xu ___ Nouveau mailing list Nouveau@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/nouveau
