Re: [Nouveau] [PATCH 1/5] drm/nouveau/nvfw/acr: make wpr_generic_header_dump() static
Actually hm, I think ben will need to consider pulling these into his branch
since these don't seem to apply to drm-misc-next - so presumably they're
related to some of the work that's been getting pushed recently for GSP prep
On Fri, 2022-11-11 at 17:11 +0800, Jiapeng Chong wrote:
> This symbol is not used outside of acr.c, so marks it static.
>
> drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c:49:1: warning: no previous prototype
> for ‘wpr_generic_header_dump’.
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3023
> Reported-by: Abaci Robot
> Signed-off-by: Jiapeng Chong
> ---
> drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c
> b/drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c
> index 83a9c48bc58c..7ac90c495737 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c
> @@ -45,7 +45,7 @@ wpr_header_v1_dump(struct nvkm_subdev *subdev, const struct
> wpr_header_v1 *hdr)
> nvkm_debug(subdev, "\tstatus: %d\n", hdr->status);
> }
>
> -void
> +static void
> wpr_generic_header_dump(struct nvkm_subdev *subdev, const struct
> wpr_generic_header *hdr)
> {
> nvkm_debug(subdev, "wprGenericHeader\n");
--
Cheers,
Lyude Paul (she/her)
Software Engineer at Red Hat
Re: [Nouveau] [PATCH 1/5] drm/nouveau/nvfw/acr: make wpr_generic_header_dump() static
For the whole series:
Reviewed-by: Lyude Paul
Will push to drm-misc-next in a bit
On Fri, 2022-11-11 at 17:11 +0800, Jiapeng Chong wrote:
> This symbol is not used outside of acr.c, so marks it static.
>
> drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c:49:1: warning: no previous prototype
> for ‘wpr_generic_header_dump’.
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3023
> Reported-by: Abaci Robot
> Signed-off-by: Jiapeng Chong
> ---
> drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c
> b/drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c
> index 83a9c48bc58c..7ac90c495737 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c
> @@ -45,7 +45,7 @@ wpr_header_v1_dump(struct nvkm_subdev *subdev, const struct
> wpr_header_v1 *hdr)
> nvkm_debug(subdev, "\tstatus: %d\n", hdr->status);
> }
>
> -void
> +static void
> wpr_generic_header_dump(struct nvkm_subdev *subdev, const struct
> wpr_generic_header *hdr)
> {
> nvkm_debug(subdev, "wprGenericHeader\n");
--
Cheers,
Lyude Paul (she/her)
Software Engineer at Red Hat
Re: [Nouveau] Coverity: nouveau_dp_irq(): Null pointer dereferences
On Fri, Nov 11, 2022 at 9:16 PM Kees Cook wrote:
>
> On Fri, Nov 11, 2022 at 09:06:54PM +0100, Karol Herbst wrote:
> > On Fri, Nov 11, 2022 at 8:21 PM Kees Cook wrote:
> > >
> > > On Fri, Nov 11, 2022 at 11:13:17AM +0200, Jani Nikula wrote:
> > > > On Thu, 10 Nov 2022, coverity-bot wrote:
> > > > > Hello!
> > > > >
> > > > > This is an experimental semi-automated report about issues detected by
> > > > > Coverity from a scan of next-20221110 as part of the linux-next scan
> > > > > project:
> > > > > https://scan.coverity.com/projects/linux-next-weekly-scan
> > > > >
> > > > > You're getting this email because you were associated with the
> > > > > identified
> > > > > lines of code (noted below) that were touched by commits:
> > > > >
> > > > > Mon Aug 31 19:10:08 2020 -0400
> > > > > a0922278f83e ("drm/nouveau/kms/nv50-: Refactor and cleanup DP HPD
> > > > > handling")
> > > >
> > > > Hi Kees, this looks like a good idea, but maybe double check the Cc list
> > > > generation? I was Cc'd on four mails today that I thought were
> > > > irrelevant to me.
> > >
> > > Hi!
> > >
> > > Heh, I was recently asked to _expand_ the CC list. :)
> > >
> > > For these last pass of reports, I added a get_maintainers.pl run to the
> > > identified commit. In this instance, the commit touched:
> > >
> > > drivers/gpu/drm/nouveau/dispnv04/disp.c |6 +
> > > drivers/gpu/drm/nouveau/dispnv50/disp.c | 192
> > > ++--
> > > drivers/gpu/drm/nouveau/nouveau_connector.c | 14 ---
> > > drivers/gpu/drm/nouveau/nouveau_display.c |2
> > > drivers/gpu/drm/nouveau/nouveau_display.h |2
> > > drivers/gpu/drm/nouveau/nouveau_dp.c| 132
> > > -
> > > drivers/gpu/drm/nouveau/nouveau_encoder.h | 33 +++-
> > > 7 files changed, 244 insertions(+), 137 deletions(-)
> > >
> > > And the get_maintainers.pl rationale was:
> > >
> > > Ben Skeggs (supporter:DRM DRIVER FOR NVIDIA
> > > GEFORCE/QUADRO
> > > GPUS,commit_signer:1/1=100%,commit_signer:6/16=38%,authored:4/16=25%,added_lines:23/124=19%,removed_lines:36/152=24%)
> > > Karol Herbst (supporter:DRM DRIVER FOR NVIDIA
> > > GEFORCE/QUADRO GPUS,commit_signer:2/1=100%)
> > > Lyude Paul (supporter:DRM DRIVER FOR NVIDIA
> > > GEFORCE/QUADRO
> > > GPUS,commit_signer:9/16=56%,authored:6/16=38%,added_lines:92/124=74%,removed_lines:107/152=70%)
> > > David Airlie (maintainer:DRM DRIVERS)
> > > Daniel Vetter (maintainer:DRM DRIVERS)
> > > Ilia Mirkin
> > > (commit_signer:1/1=100%,authored:1/1=100%,added_lines:2/2=100%,removed_lines:2/2=100%)
> > > "Nathan E. Egge" (commit_signer:1/1=100%)
> > > Jani Nikula (commit_signer:6/16=38%)
> > > Dave Airlie (commit_signer:5/16=31%)
> > > Thomas Zimmermann
> > > (commit_signer:4/16=25%,authored:4/16=25%)
> > > dri-de...@lists.freedesktop.org (open list:DRM DRIVER FOR NVIDIA
> > > GEFORCE/QUADRO GPUS)
> > > nouveau@lists.freedesktop.org (open list:DRM DRIVER FOR NVIDIA
> > > GEFORCE/QUADRO GPUS)
> > >
> >
> > I'd say it's good enough to message supporters and the mailing lists
> > for at least Nouveau code, maybe even all drm drivers.
>
> i.e. leave out the commit_signer hits?
>
yes.
> > Not sure what to do about actual maintainers, but I doubt Dave and
> > Daniel want to be CCed on every Coverity report here either.
>
> I updated the CC logic based on this feedback:
> https://lore.kernel.org/linux-hardening/87h6zgfub4@kernel.org/
>
> So maybe just mailing lists?
>
That should be good enough, but maybe the DRM subsystem is big enough
so it's reasonable to add special rules. For Nouveau either way is
fine.
> --
> Kees Cook
>
Re: [Nouveau] Coverity: nouveau_dp_irq(): Null pointer dereferences
On Fri, Nov 11, 2022 at 09:06:54PM +0100, Karol Herbst wrote:
> On Fri, Nov 11, 2022 at 8:21 PM Kees Cook wrote:
> >
> > On Fri, Nov 11, 2022 at 11:13:17AM +0200, Jani Nikula wrote:
> > > On Thu, 10 Nov 2022, coverity-bot wrote:
> > > > Hello!
> > > >
> > > > This is an experimental semi-automated report about issues detected by
> > > > Coverity from a scan of next-20221110 as part of the linux-next scan
> > > > project:
> > > > https://scan.coverity.com/projects/linux-next-weekly-scan
> > > >
> > > > You're getting this email because you were associated with the
> > > > identified
> > > > lines of code (noted below) that were touched by commits:
> > > >
> > > > Mon Aug 31 19:10:08 2020 -0400
> > > > a0922278f83e ("drm/nouveau/kms/nv50-: Refactor and cleanup DP HPD
> > > > handling")
> > >
> > > Hi Kees, this looks like a good idea, but maybe double check the Cc list
> > > generation? I was Cc'd on four mails today that I thought were
> > > irrelevant to me.
> >
> > Hi!
> >
> > Heh, I was recently asked to _expand_ the CC list. :)
> >
> > For these last pass of reports, I added a get_maintainers.pl run to the
> > identified commit. In this instance, the commit touched:
> >
> > drivers/gpu/drm/nouveau/dispnv04/disp.c |6 +
> > drivers/gpu/drm/nouveau/dispnv50/disp.c | 192
> > ++--
> > drivers/gpu/drm/nouveau/nouveau_connector.c | 14 ---
> > drivers/gpu/drm/nouveau/nouveau_display.c |2
> > drivers/gpu/drm/nouveau/nouveau_display.h |2
> > drivers/gpu/drm/nouveau/nouveau_dp.c| 132
> > -
> > drivers/gpu/drm/nouveau/nouveau_encoder.h | 33 +++-
> > 7 files changed, 244 insertions(+), 137 deletions(-)
> >
> > And the get_maintainers.pl rationale was:
> >
> > Ben Skeggs (supporter:DRM DRIVER FOR NVIDIA
> > GEFORCE/QUADRO
> > GPUS,commit_signer:1/1=100%,commit_signer:6/16=38%,authored:4/16=25%,added_lines:23/124=19%,removed_lines:36/152=24%)
> > Karol Herbst (supporter:DRM DRIVER FOR NVIDIA
> > GEFORCE/QUADRO GPUS,commit_signer:2/1=100%)
> > Lyude Paul (supporter:DRM DRIVER FOR NVIDIA
> > GEFORCE/QUADRO
> > GPUS,commit_signer:9/16=56%,authored:6/16=38%,added_lines:92/124=74%,removed_lines:107/152=70%)
> > David Airlie (maintainer:DRM DRIVERS)
> > Daniel Vetter (maintainer:DRM DRIVERS)
> > Ilia Mirkin
> > (commit_signer:1/1=100%,authored:1/1=100%,added_lines:2/2=100%,removed_lines:2/2=100%)
> > "Nathan E. Egge" (commit_signer:1/1=100%)
> > Jani Nikula (commit_signer:6/16=38%)
> > Dave Airlie (commit_signer:5/16=31%)
> > Thomas Zimmermann
> > (commit_signer:4/16=25%,authored:4/16=25%)
> > dri-de...@lists.freedesktop.org (open list:DRM DRIVER FOR NVIDIA
> > GEFORCE/QUADRO GPUS)
> > nouveau@lists.freedesktop.org (open list:DRM DRIVER FOR NVIDIA
> > GEFORCE/QUADRO GPUS)
> >
>
> I'd say it's good enough to message supporters and the mailing lists
> for at least Nouveau code, maybe even all drm drivers.
i.e. leave out the commit_signer hits?
> Not sure what to do about actual maintainers, but I doubt Dave and
> Daniel want to be CCed on every Coverity report here either.
I updated the CC logic based on this feedback:
https://lore.kernel.org/linux-hardening/87h6zgfub4@kernel.org/
So maybe just mailing lists?
--
Kees Cook
Re: [Nouveau] Coverity: nouveau_dp_irq(): Null pointer dereferences
On Fri, Nov 11, 2022 at 8:21 PM Kees Cook wrote:
>
> On Fri, Nov 11, 2022 at 11:13:17AM +0200, Jani Nikula wrote:
> > On Thu, 10 Nov 2022, coverity-bot wrote:
> > > Hello!
> > >
> > > This is an experimental semi-automated report about issues detected by
> > > Coverity from a scan of next-20221110 as part of the linux-next scan
> > > project:
> > > https://scan.coverity.com/projects/linux-next-weekly-scan
> > >
> > > You're getting this email because you were associated with the identified
> > > lines of code (noted below) that were touched by commits:
> > >
> > > Mon Aug 31 19:10:08 2020 -0400
> > > a0922278f83e ("drm/nouveau/kms/nv50-: Refactor and cleanup DP HPD
> > > handling")
> >
> > Hi Kees, this looks like a good idea, but maybe double check the Cc list
> > generation? I was Cc'd on four mails today that I thought were
> > irrelevant to me.
>
> Hi!
>
> Heh, I was recently asked to _expand_ the CC list. :)
>
> For these last pass of reports, I added a get_maintainers.pl run to the
> identified commit. In this instance, the commit touched:
>
> drivers/gpu/drm/nouveau/dispnv04/disp.c |6 +
> drivers/gpu/drm/nouveau/dispnv50/disp.c | 192
> ++--
> drivers/gpu/drm/nouveau/nouveau_connector.c | 14 ---
> drivers/gpu/drm/nouveau/nouveau_display.c |2
> drivers/gpu/drm/nouveau/nouveau_display.h |2
> drivers/gpu/drm/nouveau/nouveau_dp.c| 132
> -
> drivers/gpu/drm/nouveau/nouveau_encoder.h | 33 +++-
> 7 files changed, 244 insertions(+), 137 deletions(-)
>
> And the get_maintainers.pl rationale was:
>
> Ben Skeggs (supporter:DRM DRIVER FOR NVIDIA
> GEFORCE/QUADRO
> GPUS,commit_signer:1/1=100%,commit_signer:6/16=38%,authored:4/16=25%,added_lines:23/124=19%,removed_lines:36/152=24%)
> Karol Herbst (supporter:DRM DRIVER FOR NVIDIA
> GEFORCE/QUADRO GPUS,commit_signer:2/1=100%)
> Lyude Paul (supporter:DRM DRIVER FOR NVIDIA GEFORCE/QUADRO
> GPUS,commit_signer:9/16=56%,authored:6/16=38%,added_lines:92/124=74%,removed_lines:107/152=70%)
> David Airlie (maintainer:DRM DRIVERS)
> Daniel Vetter (maintainer:DRM DRIVERS)
> Ilia Mirkin
> (commit_signer:1/1=100%,authored:1/1=100%,added_lines:2/2=100%,removed_lines:2/2=100%)
> "Nathan E. Egge" (commit_signer:1/1=100%)
> Jani Nikula (commit_signer:6/16=38%)
> Dave Airlie (commit_signer:5/16=31%)
> Thomas Zimmermann
> (commit_signer:4/16=25%,authored:4/16=25%)
> dri-de...@lists.freedesktop.org (open list:DRM DRIVER FOR NVIDIA
> GEFORCE/QUADRO GPUS)
> nouveau@lists.freedesktop.org (open list:DRM DRIVER FOR NVIDIA GEFORCE/QUADRO
> GPUS)
>
I'd say it's good enough to message supporters and the mailing lists
for at least Nouveau code, maybe even all drm drivers.
Not sure what to do about actual maintainers, but I doubt Dave and
Daniel want to be CCed on every Coverity report here either.
Karol
>
> --
> Kees Cook
>
Re: [Nouveau] Coverity: nouveau_dp_irq(): Null pointer dereferences
On Fri, Nov 11, 2022 at 11:13:17AM +0200, Jani Nikula wrote:
> On Thu, 10 Nov 2022, coverity-bot wrote:
> > Hello!
> >
> > This is an experimental semi-automated report about issues detected by
> > Coverity from a scan of next-20221110 as part of the linux-next scan
> > project:
> > https://scan.coverity.com/projects/linux-next-weekly-scan
> >
> > You're getting this email because you were associated with the identified
> > lines of code (noted below) that were touched by commits:
> >
> > Mon Aug 31 19:10:08 2020 -0400
> > a0922278f83e ("drm/nouveau/kms/nv50-: Refactor and cleanup DP HPD
> > handling")
>
> Hi Kees, this looks like a good idea, but maybe double check the Cc list
> generation? I was Cc'd on four mails today that I thought were
> irrelevant to me.
Hi!
Heh, I was recently asked to _expand_ the CC list. :)
For these last pass of reports, I added a get_maintainers.pl run to the
identified commit. In this instance, the commit touched:
drivers/gpu/drm/nouveau/dispnv04/disp.c |6 +
drivers/gpu/drm/nouveau/dispnv50/disp.c | 192
++--
drivers/gpu/drm/nouveau/nouveau_connector.c | 14 ---
drivers/gpu/drm/nouveau/nouveau_display.c |2
drivers/gpu/drm/nouveau/nouveau_display.h |2
drivers/gpu/drm/nouveau/nouveau_dp.c| 132
-
drivers/gpu/drm/nouveau/nouveau_encoder.h | 33 +++-
7 files changed, 244 insertions(+), 137 deletions(-)
And the get_maintainers.pl rationale was:
Ben Skeggs (supporter:DRM DRIVER FOR NVIDIA GEFORCE/QUADRO
GPUS,commit_signer:1/1=100%,commit_signer:6/16=38%,authored:4/16=25%,added_lines:23/124=19%,removed_lines:36/152=24%)
Karol Herbst (supporter:DRM DRIVER FOR NVIDIA
GEFORCE/QUADRO GPUS,commit_signer:2/1=100%)
Lyude Paul (supporter:DRM DRIVER FOR NVIDIA GEFORCE/QUADRO
GPUS,commit_signer:9/16=56%,authored:6/16=38%,added_lines:92/124=74%,removed_lines:107/152=70%)
David Airlie (maintainer:DRM DRIVERS)
Daniel Vetter (maintainer:DRM DRIVERS)
Ilia Mirkin
(commit_signer:1/1=100%,authored:1/1=100%,added_lines:2/2=100%,removed_lines:2/2=100%)
"Nathan E. Egge" (commit_signer:1/1=100%)
Jani Nikula (commit_signer:6/16=38%)
Dave Airlie (commit_signer:5/16=31%)
Thomas Zimmermann
(commit_signer:4/16=25%,authored:4/16=25%)
dri-de...@lists.freedesktop.org (open list:DRM DRIVER FOR NVIDIA GEFORCE/QUADRO
GPUS)
nouveau@lists.freedesktop.org (open list:DRM DRIVER FOR NVIDIA GEFORCE/QUADRO
GPUS)
--
Kees Cook
[Nouveau] [linux-next:master] BUILD REGRESSION f8f60f322f0640c8edda2942ca5f84b7a27c417a
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: f8f60f322f0640c8edda2942ca5f84b7a27c417a Add linux-next specific files for 2022 Error/Warning reports: https://lore.kernel.org/linux-mm/202210261404.b6ulzg7h-...@intel.com https://lore.kernel.org/oe-kbuild-all/202210270637.q5y7fikj-...@intel.com https://lore.kernel.org/oe-kbuild-all/202211090634.ryfkk0ws-...@intel.com https://lore.kernel.org/oe-kbuild-all/202211102047.qp7ithm4-...@intel.com https://lore.kernel.org/oe-kbuild-all/20221624.1xztuzhj-...@intel.com Error/Warning: (recently discovered and may have been fixed) arch/arm/mach-s3c/devs.c:32:10: fatal error: linux/platform_data/dma-s3c24xx.h: No such file or directory arch/x86/platform/efi/runtime-map.c:138:5: warning: no previous prototype for 'efi_get_runtime_map_size' [-Wmissing-prototypes] arch/x86/platform/efi/runtime-map.c:143:5: warning: no previous prototype for 'efi_get_runtime_map_desc_size' [-Wmissing-prototypes] arch/x86/platform/efi/runtime-map.c:148:5: warning: no previous prototype for 'efi_runtime_map_copy' [-Wmissing-prototypes] csky-linux-ld: local_object.c:(.text+0x84): undefined reference to `ipv6_icmp_error' drivers/block/zram/zram_drv.c:1857:7: warning: variable 'err' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized] drivers/block/zram/zram_drv.c:1857:7: warning: variable 'err' is used uninitialized whenever '||' condition is true [-Wsometimes-uninitialized] drivers/firmware/efi/memmap.c:57:52: warning: suggest braces around empty body in an 'if' statement [-Wempty-body] drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:4887: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:5073:24: warning: implicit conversion from 'enum ' to 'enum dc_status' [-Wenum-conversion] drivers/gpu/drm/nouveau/nvkm/engine/fifo/gf100.c:451:1: warning: no previous prototype for 'gf100_fifo_nonstall_block' [-Wmissing-prototypes] drivers/gpu/drm/nouveau/nvkm/engine/fifo/gf100.c:451:1: warning: no previous prototype for function 'gf100_fifo_nonstall_block' [-Wmissing-prototypes] drivers/gpu/drm/nouveau/nvkm/engine/fifo/runl.c:34:1: warning: no previous prototype for 'nvkm_engn_cgrp_get' [-Wmissing-prototypes] drivers/gpu/drm/nouveau/nvkm/engine/fifo/runl.c:34:1: warning: no previous prototype for function 'nvkm_engn_cgrp_get' [-Wmissing-prototypes] drivers/gpu/drm/nouveau/nvkm/engine/gr/tu102.c:210:1: warning: no previous prototype for 'tu102_gr_load' [-Wmissing-prototypes] drivers/gpu/drm/nouveau/nvkm/engine/gr/tu102.c:210:1: warning: no previous prototype for function 'tu102_gr_load' [-Wmissing-prototypes] drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c:49:1: warning: no previous prototype for 'wpr_generic_header_dump' [-Wmissing-prototypes] drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c:49:1: warning: no previous prototype for function 'wpr_generic_header_dump' [-Wmissing-prototypes] drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c:221:21: warning: variable 'loc' set but not used [-Wunused-but-set-variable] local_object.c:(.text+0x60): undefined reference to `ipv6_icmp_error' vmlinux.o: warning: objtool: __btrfs_map_block+0x1e22: unreachable instruction Unverified Error/Warning (likely false positive, please contact us if interested): drivers/gpu/drm/nouveau/nvkm/subdev/mc/ga100.c:51:1: sparse: sparse: symbol 'ga100_mc_device' was not declared. Should it be static? lib/zstd/compress/huf_compress.c:460 HUF_getIndex() warn: the 'RANK_POSITION_LOG_BUCKETS_BEGIN' macro might need parens lib/zstd/decompress/zstd_decompress_block.c:1009 ZSTD_execSequence() warn: inconsistent indenting lib/zstd/decompress/zstd_decompress_block.c:894 ZSTD_execSequenceEnd() warn: inconsistent indenting lib/zstd/decompress/zstd_decompress_block.c:942 ZSTD_execSequenceEndSplitLitBuffer() warn: inconsistent indenting lib/zstd/decompress/zstd_decompress_internal.h:206 ZSTD_DCtx_get_bmi2() warn: inconsistent indenting mm/khugepaged.c:2038 collapse_file() warn: iterator used outside loop: 'page' Error/Warning ids grouped by kconfigs: gcc_recent_errors |-- alpha-allyesconfig | |-- drivers-gpu-drm-amd-amdgpu-..-display-dc-core-dc_link_dp.c:warning:implicit-conversion-from-enum-anonymous-to-enum-dc_status | |-- drivers-gpu-drm-nouveau-nvkm-engine-fifo-gf100.c:warning:no-previous-prototype-for-gf100_fifo_nonstall_block | |-- drivers-gpu-drm-nouveau-nvkm-engine-fifo-runl.c:warning:no-previous-prototype-for-nvkm_engn_cgrp_get | |-- drivers-gpu-drm-nouveau-nvkm-engine-gr-tu102.c:warning:no-previous-prototype-for-tu102_gr_load | |-- drivers-gpu-drm-nouveau-nvkm-nvfw-acr.c:warning:no-previous-prototype-for-wpr_generic_header_dump | `-- drivers-gpu-drm-nouveau-nvkm-subdev-acr-lsfw.c:warning:variable-loc-set-but-not-used |-- alpha-randconfig-r003-2022 | |-- drivers-gpu-drm-amd-amdgpu
Re: [Nouveau] Coverity: nouveau_dp_irq(): Null pointer dereferences
On Thu, 10 Nov 2022, coverity-bot wrote:
> Hello!
>
> This is an experimental semi-automated report about issues detected by
> Coverity from a scan of next-20221110 as part of the linux-next scan project:
> https://scan.coverity.com/projects/linux-next-weekly-scan
>
> You're getting this email because you were associated with the identified
> lines of code (noted below) that were touched by commits:
>
> Mon Aug 31 19:10:08 2020 -0400
> a0922278f83e ("drm/nouveau/kms/nv50-: Refactor and cleanup DP HPD
> handling")
Hi Kees, this looks like a good idea, but maybe double check the Cc list
generation? I was Cc'd on four mails today that I thought were
irrelevant to me.
Thanks,
Jani.
>
> Coverity reported the following:
>
> *** CID 1527266: Null pointer dereferences (REVERSE_INULL)
> drivers/gpu/drm/nouveau/nouveau_dp.c:237 in nouveau_dp_irq()
> 231 struct nouveau_encoder *outp = find_encoder(connector,
> DCB_OUTPUT_DP);
> 232 struct nouveau_drm *drm = nouveau_drm(outp->base.base.dev);
> 233 struct nv50_mstm *mstm;
> 234 u64 hpd = 0;
> 235 int ret;
> 236
> vvv CID 1527266: Null pointer dereferences (REVERSE_INULL)
> vvv Null-checking "outp" suggests that it may be null, but it has already
> been dereferenced on all paths leading to the check.
> 237 if (!outp)
> 238 return;
> 239
> 240 mstm = outp->dp.mstm;
> 241 NV_DEBUG(drm, "service %s\n", connector->name);
> 242
>
> If this is a false positive, please let us know so we can mark it as
> such, or teach the Coverity rules to be smarter. If not, please make
> sure fixes get into linux-next. :) For patches fixing this, please
> include these lines (but double-check the "Fixes" first):
>
> Reported-by: coverity-bot
> Addresses-Coverity-ID: 1527266 ("Null pointer dereferences")
> Fixes: a0922278f83e ("drm/nouveau/kms/nv50-: Refactor and cleanup DP HPD
> handling")
>
> Thanks for your attention!
--
Jani Nikula, Intel Open Source Graphics Center
