[Nouveau] [Bug 91319] Nouveau driver cannot extract FCODE ROM / DCB Block from OpenFirmware Device tree

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=91319

--- Comment #17 from Ilia Mirkin  ---
(In reply to reeskm from comment #16)
> I'm having this exact same problem on kernel 4.9.49 on ppc 32-bit.
> I see that this was previously fixed. Should this be re-opened or should I
> file a new bug report?

When in doubt, file a new bug report. When not in doubt, file a new bug report.
Reports are trivial to merge but impossible to tease apart.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau

[Nouveau] [Bug 91319] Nouveau driver cannot extract FCODE ROM / DCB Block from OpenFirmware Device tree

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=91319

ree...@gmail.com changed:

   What|Removed |Added

 CC||ree...@gmail.com

--- Comment #16 from ree...@gmail.com ---
I'm having this exact same problem on kernel 4.9.49 on ppc 32-bit.
I see that this was previously fixed. Should this be re-opened or should I file
a new bug report?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau

[Nouveau] [Bug 91319] Nouveau driver cannot extract FCODE ROM / DCB Block from OpenFirmware Device tree

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=91319

Ilia Mirkin  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #15 from Ilia Mirkin  ---
This patch is in 4.3-rc6.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Nouveau mailing list
Nouveau@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/nouveau

[Nouveau] [Bug 91319] Nouveau driver cannot extract FCODE ROM / DCB Block from OpenFirmware Device tree

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=91319

--- Comment #14 from Ilia Mirkin  ---
(In reply to Peter Saisanas from comment #13)
> Do you require any more info?

Nope. Will leave this open until the fix hits mainline.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Nouveau mailing list
Nouveau@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/nouveau

[Nouveau] [Bug 91319] Nouveau driver cannot extract FCODE ROM / DCB Block from OpenFirmware Device tree

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=91319

--- Comment #13 from Peter Saisanas  ---
I can confirm that the patch works with my config which is great news.

However, the patch does not apply cleanly to vanilla 4.3-rc4, it seems to
reject parts of the patch to shadowof.c.

After manually changing shadowof.c, i.e. the parts of the patch that was
rejected, compiled and hooray, it works!

Awesome, thanks imirkin!

Do you require any more info?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Nouveau mailing list
Nouveau@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/nouveau

[Nouveau] [Bug 91319] Nouveau driver cannot extract FCODE ROM / DCB Block from OpenFirmware Device tree

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=91319

--- Comment #11 from Peter Saisanas  ---
No i didn't apply the patch, i assumed that it was already in vanilla 4.3-rc4.

Sorry, my misunderstanding.

I have tried to patch vanilla 4.3-rc4 but the patch will not apply cleanly.

Ill try to patch it manually when i get a chance.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Nouveau mailing list
Nouveau@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/nouveau

[Nouveau] [Bug 91319] Nouveau driver cannot extract FCODE ROM / DCB Block from OpenFirmware Device tree

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=91319

--- Comment #10 from Ilia Mirkin  ---
(In reply to Ilia Mirkin from comment #9)
> (In reply to Peter Saisanas from comment #8)
> > Hi,
> > I assume the patch is within 4.3-rc4?
> > 
> > If so, it still doesn't seem to extract the VBIOS via the OpenFirmware.
> > 
> > I have compiled and booted the 4.3-rc4 kernel and booted with
> > "nouveau.debug=debug,VBIOS=trace" which is attached.
> 
> Odd.
> 
> [   10.214404] nouveau :0a:00.0: bios: trying OpenFirmware...
> [   10.214499] nouveau :0a:00.0: bios: image 0 invalid
> 
> With my patch it's pretty much rigged to always accept the OF vbios. Are you
> sure you were able to apply it properly?

In fact, after my patch,

nvkm_debug(subdev, "image %d invalid\n", idx);

is in a section that should never get hit by the OF logic (since it will
specify no_pcir=true, which in turn skips the whole image validation thing).

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Nouveau mailing list
Nouveau@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/nouveau

[Nouveau] [Bug 91319] Nouveau driver cannot extract FCODE ROM / DCB Block from OpenFirmware Device tree

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=91319

--- Comment #8 from Peter Saisanas  ---
Hi,
I assume the patch is within 4.3-rc4?

If so, it still doesn't seem to extract the VBIOS via the OpenFirmware.

I have compiled and booted the 4.3-rc4 kernel and booted with
"nouveau.debug=debug,VBIOS=trace" which is attached.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Nouveau mailing list
Nouveau@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/nouveau

[Nouveau] [Bug 91319] Nouveau driver cannot extract FCODE ROM / DCB Block from OpenFirmware Device tree

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=91319

--- Comment #7 from Peter Saisanas  ---
Created attachment 118662
  --> https://bugs.freedesktop.org/attachment.cgi?id=118662=edit
4.3-rc4 dmesg with "nouveau.debug=debug,VBIOS=trace"

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Nouveau mailing list
Nouveau@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/nouveau

[Nouveau] [Bug 91319] Nouveau driver cannot extract FCODE ROM / DCB Block from OpenFirmware Device tree

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=91319

--- Comment #9 from Ilia Mirkin  ---
(In reply to Peter Saisanas from comment #8)
> Hi,
> I assume the patch is within 4.3-rc4?
> 
> If so, it still doesn't seem to extract the VBIOS via the OpenFirmware.
> 
> I have compiled and booted the 4.3-rc4 kernel and booted with
> "nouveau.debug=debug,VBIOS=trace" which is attached.

Odd.

[   10.214404] nouveau :0a:00.0: bios: trying OpenFirmware...
[   10.214499] nouveau :0a:00.0: bios: image 0 invalid

With my patch it's pretty much rigged to always accept the OF vbios. Are you
sure you were able to apply it properly?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Nouveau mailing list
Nouveau@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/nouveau

[Nouveau] [Bug 91319] Nouveau driver cannot extract FCODE ROM / DCB Block from OpenFirmware Device tree

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=91319

--- Comment #12 from Ilia Mirkin  ---
(In reply to Peter Saisanas from comment #11)
> No i didn't apply the patch, i assumed that it was already in vanilla
> 4.3-rc4.
> 
> Sorry, my misunderstanding.
> 
> I have tried to patch vanilla 4.3-rc4 but the patch will not apply cleanly.
> 
> Ill try to patch it manually when i get a chance.

Try it from the drivers/gpu directory.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Nouveau mailing list
Nouveau@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/nouveau

[Nouveau] [Bug 91319] Nouveau driver cannot extract FCODE ROM / DCB Block from OpenFirmware Device tree

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=91319

--- Comment #6 from Ilia Mirkin  ---
You can try this patch, in Ben's tree which is ~4.3-rcN :

http://cgit.freedesktop.org/~darktama/nouveau/commit/?id=5b5cc342d3154120f9bb5ca7839ab556e728c786

This worked for me, but could use more testing.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Nouveau mailing list
Nouveau@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/nouveau

[Nouveau] [Bug 91319] Nouveau driver cannot extract FCODE ROM / DCB Block from OpenFirmware Device tree

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=91319

--- Comment #3 from Peter Saisanas psaisa...@gmail.com ---
Hi,
I have managed to extract the actual Open Firmware nVidia Quadro FX4500 PCI
expansion ROM which i have attached.

The actual ROM itself seems to have a PCIR header located @ offset 0x20.

Could it be that nouveau is actually trying to read the PCIR header directly
off the XROM (which is how i assume it would be done in x86) and not via the OF
device tree for ppc arch in the newer versions of nouveau by any chance?

Regards,
Peter

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Nouveau mailing list
Nouveau@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/nouveau

[Nouveau] [Bug 91319] Nouveau driver cannot extract FCODE ROM / DCB Block from OpenFirmware Device tree

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=91319

--- Comment #4 from Peter Saisanas psaisa...@gmail.com ---
Created attachment 117271
  -- https://bugs.freedesktop.org/attachment.cgi?id=117271action=edit
OF Powermac Quadro FX4500 ROM

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Nouveau mailing list
Nouveau@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/nouveau

[Nouveau] [Bug 91319] Nouveau driver cannot extract FCODE ROM / DCB Block from OpenFirmware Device tree

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=91319

Peter Saisanas psaisa...@gmail.com changed:

   What|Removed |Added

 CC||psaisa...@gmail.com

--- Comment #1 from Peter Saisanas psaisa...@gmail.com ---
Created attachment 117085
  -- https://bugs.freedesktop.org/attachment.cgi?id=117085action=edit
dmesg log with nouveau.debug=debug,VBIOS=trace

booting kernel 4.1.2 with nouveau.debug=debug,VBIOS=trace appended on kernel
command line.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Nouveau mailing list
Nouveau@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/nouveau

[Nouveau] [Bug 91319] Nouveau driver cannot extract FCODE ROM / DCB Block from OpenFirmware Device tree

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=91319

--- Comment #2 from Ilia Mirkin imir...@alum.mit.edu ---
Aha, looks like the issue is that your VBIOS in OF does not have a PCIR
section, and the nouveau VBIOS parser has come to expect that. Going to have to
read more code to work out a proper solution to that.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Nouveau mailing list
Nouveau@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/nouveau

[Nouveau] [Bug 91319] Nouveau driver cannot extract FCODE ROM / DCB Block from OpenFirmware Device tree

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=91319

Ilia Mirkin imir...@alum.mit.edu changed:

   What|Removed |Added

 Attachment #117079|text/plain  |application/octet-stream
  mime type||

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Nouveau mailing list
Nouveau@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/nouveau