Re: [Nouveau] [PATCH] drm/nouveau: remove redundant comments listing classes

2012-10-17 Thread Ben Skeggs 
On Tue, Oct 16, 2012 at 11:45:30PM +0200, Marcin Slusarz wrote:
 Signed-off-by: Marcin Slusarz marcin.slus...@gmail.com
NACK on this one.  I did ponder doing such a thing myself when I first
added the defines for the class names too, and decided against it as
this will (at some point) become a user-facing header, and I was
planning on documenting the differences between class revisions in the
commented blocks.

Ben.

 ---
  drivers/gpu/drm/nouveau/core/include/core/class.h | 31 
 +++
  1 file changed, 4 insertions(+), 27 deletions(-)
 
 diff --git a/drivers/gpu/drm/nouveau/core/include/core/class.h 
 b/drivers/gpu/drm/nouveau/core/include/core/class.h
 index 6180ae9..5b739de 100644
 --- a/drivers/gpu/drm/nouveau/core/include/core/class.h
 +++ b/drivers/gpu/drm/nouveau/core/include/core/class.h
 @@ -1,10 +1,7 @@
  #ifndef __NOUVEAU_CLASS_H__
  #define __NOUVEAU_CLASS_H__
  
 -/* Device class
 - *
 - * 0080: NV_DEVICE
 - */
 +/* Device class */
  #define NV_DEVICE_CLASS  
 0x0080
  
  #define NV_DEVICE_DISABLE_IDENTIFY
 0x0001ULL
 @@ -30,12 +27,7 @@ struct nv_device_class {
   u64 debug0; /* as above, but *internal* ids, and *NOT* ABI */
  };
  
 -/* DMA object classes
 - *
 - * 0002: NV_DMA_FROM_MEMORY
 - * 0003: NV_DMA_TO_MEMORY
 - * 003d: NV_DMA_IN_MEMORY
 - */
 +/* DMA object classes */
  #define NV_DMA_FROM_MEMORY_CLASS 
 0x0002
  #define NV_DMA_TO_MEMORY_CLASS   
 0x0003
  #define NV_DMA_IN_MEMORY_CLASS   
 0x003d
 @@ -59,15 +51,7 @@ struct nv_dma_class {
   u64 limit;
  };
  
 -/* DMA FIFO channel classes
 - *
 - * 006b: NV03_CHANNEL_DMA
 - * 006e: NV10_CHANNEL_DMA
 - * 176e: NV17_CHANNEL_DMA
 - * 406e: NV40_CHANNEL_DMA
 - * 506e: NV50_CHANNEL_DMA
 - * 826e: NV84_CHANNEL_DMA
 - */
 +/* DMA FIFO channel classes */
  #define NV03_CHANNEL_DMA_CLASS   
 0x006b
  #define NV10_CHANNEL_DMA_CLASS   
 0x006e
  #define NV17_CHANNEL_DMA_CLASS   
 0x176e
 @@ -81,14 +65,7 @@ struct nv03_channel_dma_class {
   u64 offset;
  };
  
 -/* Indirect FIFO channel classes
 - *
 - * 506f: NV50_CHANNEL_IND
 - * 826f: NV84_CHANNEL_IND
 - * 906f: NVC0_CHANNEL_IND
 - * a06f: NVE0_CHANNEL_IND
 - */
 -
 +/* Indirect FIFO channel classes */
  #define NV50_CHANNEL_IND_CLASS   
 0x506f
  #define NV84_CHANNEL_IND_CLASS   
 0x826f
  #define NVC0_CHANNEL_IND_CLASS   
 0x906f
 -- 
 1.7.12
 
 ___
 Nouveau mailing list
 Nouveau@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/nouveau
___
Nouveau mailing list
Nouveau@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/nouveau

Re: [Nouveau] [PATCH] drm/nouveau: remove redundant comments listing classes

2012-10-17 Thread Marcin Ślusarz 
17 paź 2012 06:33, Ben Skeggs skeg...@gmail.com napisał(a):

 On Tue, Oct 16, 2012 at 11:45:30PM +0200, Marcin Slusarz wrote:
  Signed-off-by: Marcin Slusarz marcin.slus...@gmail.com
 NACK on this one.  I did ponder doing such a thing myself when I first
 added the defines for the class names too, and decided against it as
 this will (at some point) become a user-facing header, and I was
 planning on documenting the differences between class revisions in the
 commented blocks.

I'm not against documentation, of course, but right now these comments are
useless. Can't they be added with real content later?

Marcin
___
Nouveau mailing list
Nouveau@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/nouveau

[Nouveau] [PATCH] drm/nouveau: remove redundant comments listing classes

2012-10-16 Thread Marcin Slusarz 
Signed-off-by: Marcin Slusarz marcin.slus...@gmail.com
---
 drivers/gpu/drm/nouveau/core/include/core/class.h | 31 +++
 1 file changed, 4 insertions(+), 27 deletions(-)

diff --git a/drivers/gpu/drm/nouveau/core/include/core/class.h 
b/drivers/gpu/drm/nouveau/core/include/core/class.h
index 6180ae9..5b739de 100644
--- a/drivers/gpu/drm/nouveau/core/include/core/class.h
+++ b/drivers/gpu/drm/nouveau/core/include/core/class.h
@@ -1,10 +1,7 @@
 #ifndef __NOUVEAU_CLASS_H__
 #define __NOUVEAU_CLASS_H__
 
-/* Device class
- *
- * 0080: NV_DEVICE
- */
+/* Device class */
 #define NV_DEVICE_CLASS  0x0080
 
 #define NV_DEVICE_DISABLE_IDENTIFY0x0001ULL
@@ -30,12 +27,7 @@ struct nv_device_class {
u64 debug0; /* as above, but *internal* ids, and *NOT* ABI */
 };
 
-/* DMA object classes
- *
- * 0002: NV_DMA_FROM_MEMORY
- * 0003: NV_DMA_TO_MEMORY
- * 003d: NV_DMA_IN_MEMORY
- */
+/* DMA object classes */
 #define NV_DMA_FROM_MEMORY_CLASS 0x0002
 #define NV_DMA_TO_MEMORY_CLASS   0x0003
 #define NV_DMA_IN_MEMORY_CLASS   0x003d
@@ -59,15 +51,7 @@ struct nv_dma_class {
u64 limit;
 };
 
-/* DMA FIFO channel classes
- *
- * 006b: NV03_CHANNEL_DMA
- * 006e: NV10_CHANNEL_DMA
- * 176e: NV17_CHANNEL_DMA
- * 406e: NV40_CHANNEL_DMA
- * 506e: NV50_CHANNEL_DMA
- * 826e: NV84_CHANNEL_DMA
- */
+/* DMA FIFO channel classes */
 #define NV03_CHANNEL_DMA_CLASS   0x006b
 #define NV10_CHANNEL_DMA_CLASS   0x006e
 #define NV17_CHANNEL_DMA_CLASS   0x176e
@@ -81,14 +65,7 @@ struct nv03_channel_dma_class {
u64 offset;
 };
 
-/* Indirect FIFO channel classes
- *
- * 506f: NV50_CHANNEL_IND
- * 826f: NV84_CHANNEL_IND
- * 906f: NVC0_CHANNEL_IND
- * a06f: NVE0_CHANNEL_IND
- */
-
+/* Indirect FIFO channel classes */
 #define NV50_CHANNEL_IND_CLASS   0x506f
 #define NV84_CHANNEL_IND_CLASS   0x826f
 #define NVC0_CHANNEL_IND_CLASS   0x906f
-- 
1.7.12

___
Nouveau mailing list
Nouveau@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/nouveau