On Mon, Sep 25, 2023 at 12:08:36PM +0200, Andrzej Hajda wrote:
>
>
> On 22.09.2023 19:32, Kees Cook wrote:
> > Prepare for the coming implementation by GCC and Clang of the __counted_by
> > attribute. Flexible array members annotated with __counted_by can have
> > their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
> > (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
> > functions).
> >
> > As found with Coccinelle[1], add __counted_by for struct perf_series.
> >
> > [1]
> > https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci
> >
> > Cc: Jani Nikula
> > Cc: Joonas Lahtinen
> > Cc: Rodrigo Vivi
> > Cc: Tvrtko Ursulin
> > Cc: David Airlie
> > Cc: Daniel Vetter
> > Cc: Chris Wilson
> > Cc: John Harrison
> > Cc: Andi Shyti
> > Cc: Matthew Brost
> > Cc: intel-...@lists.freedesktop.org
> > Cc: dri-de...@lists.freedesktop.org
> > Signed-off-by: Kees Cook
>
> I am surprised this is the only finding in i915, I would expected more.
I'm sure there are more, but it's likely my Coccinelle pattern didn't
catch it. There are many many flexible arrays in drm. :)
$ grep -nRH '\[\];$' drivers/gpu/drm include/uapi/drm | grep -v :extern | wc -l
122
If anyone has some patterns I can add to the Coccinelle script, I can
take another pass at it.
> Anyway:
>
> Reviewed-by: Andrzej Hajda
Thank you!
-Kees
--
Kees Cook
