Re: [Nouveau] [igt-dev] [PATCH i-g-t] tests/kms_cursor_crc: Test 32x32 cursors
On Thu, 2021-03-18 at 14:39 +0200, Ville Syrjälä wrote: > On Thu, Mar 18, 2021 at 08:39:01AM +0200, Martin Peres wrote: > > On 18/03/2021 00:45, Lyude wrote: > > > From: Lyude Paul > > > > > > Since pre-nve4 only has two cursor sizes (32x32 and 64x64), we should at > > > least test both of them. > > > > This adds 36 subtests, which take about 1s in average. So the runtime is > > not significantly increased on the Intel side. > > > > It also seems that Intel should add skips or fix the kernel to support > > these 32xXX format. > > Intel hw at least does not support 32x32 cursors. We should > probably just just probe the kernel to see if it accepts the > requested cursor size, and skip the subtest if not. That > would also let us remove the i915 platform specific information > from has_nonsquare_cursors(). sgtm, will respin with these changes in just a moment > -- Sincerely, Lyude Paul (she/her) Software Engineer at Red Hat Note: I deal with a lot of emails and have a lot of bugs on my plate. If you've asked me a question, are waiting for a review/merge on a patch, etc. and I haven't responded in a while, please feel free to send me another email to check on my status. I don't bite! ___ Nouveau mailing list Nouveau@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/nouveau
Re: [Nouveau] [igt-dev] [PATCH i-g-t] tests/kms_cursor_crc: Test 32x32 cursors
On Thu, Mar 18, 2021 at 08:39:01AM +0200, Martin Peres wrote: > On 18/03/2021 00:45, Lyude wrote: > > From: Lyude Paul > > > > Since pre-nve4 only has two cursor sizes (32x32 and 64x64), we should at > > least test both of them. > > This adds 36 subtests, which take about 1s in average. So the runtime is > not significantly increased on the Intel side. > > It also seems that Intel should add skips or fix the kernel to support > these 32xXX format. Intel hw at least does not support 32x32 cursors. We should probably just just probe the kernel to see if it accepts the requested cursor size, and skip the subtest if not. That would also let us remove the i915 platform specific information from has_nonsquare_cursors(). -- Ville Syrjälä Intel ___ Nouveau mailing list Nouveau@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/nouveau
Re: [Nouveau] [igt-dev] [PATCH i-g-t] tests/kms_cursor_crc: Test 32x32 cursors
On Thu, Mar 18, 2021 at 08:39:01AM +0200, Martin Peres wrote:
> On 18/03/2021 00:45, Lyude wrote:
> > From: Lyude Paul
> >
> > Since pre-nve4 only has two cursor sizes (32x32 and 64x64), we should at
> > least test both of them.
>
> This adds 36 subtests, which take about 1s in average. So the runtime is not
> significantly increased on the Intel side.
>
> It also seems that Intel should add skips or fix the kernel to support these
> 32xXX format.
>
> @Petri, could you get someone to investigate this?
Ville, J-P?
--
Petri Latvala
>
> In the mean time, here is my:
>
> Reviewed-by: Martin Peres
>
> Martin
> >
> > Signed-off-by: Lyude Paul
> > Cc: Martin Peres
> > Cc: Ben Skeggs
> > Cc: Jeremy Cline
> > ---
> > tests/kms_cursor_crc.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tests/kms_cursor_crc.c b/tests/kms_cursor_crc.c
> > index 0be8f7f8..c70c4a8f 100644
> > --- a/tests/kms_cursor_crc.c
> > +++ b/tests/kms_cursor_crc.c
> > @@ -683,7 +683,7 @@ static void run_tests_on_pipe(data_t *data, enum pipe
> > pipe)
> > igt_fixture
> > igt_remove_fb(data->drm_fd, >fb);
> > - for (cursor_size = 64; cursor_size <= 512; cursor_size *= 2) {
> > + for (cursor_size = 32; cursor_size <= 512; cursor_size *= 2) {
> > int w = cursor_size;
> > int h = cursor_size;
> >
> ___
> igt-dev mailing list
> igt-...@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
___
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau
Re: [Nouveau] [igt-dev] [PATCH i-g-t] tests/kms_cursor_crc: Test 32x32 cursors
On 18/03/2021 00:45, Lyude wrote:
From: Lyude Paul
Since pre-nve4 only has two cursor sizes (32x32 and 64x64), we should at
least test both of them.
This adds 36 subtests, which take about 1s in average. So the runtime is
not significantly increased on the Intel side.
It also seems that Intel should add skips or fix the kernel to support
these 32xXX format.
@Petri, could you get someone to investigate this?
In the mean time, here is my:
Reviewed-by: Martin Peres
Martin
Signed-off-by: Lyude Paul
Cc: Martin Peres
Cc: Ben Skeggs
Cc: Jeremy Cline
---
tests/kms_cursor_crc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/kms_cursor_crc.c b/tests/kms_cursor_crc.c
index 0be8f7f8..c70c4a8f 100644
--- a/tests/kms_cursor_crc.c
+++ b/tests/kms_cursor_crc.c
@@ -683,7 +683,7 @@ static void run_tests_on_pipe(data_t *data, enum pipe pipe)
igt_fixture
igt_remove_fb(data->drm_fd, >fb);
- for (cursor_size = 64; cursor_size <= 512; cursor_size *= 2) {
+ for (cursor_size = 32; cursor_size <= 512; cursor_size *= 2) {
int w = cursor_size;
int h = cursor_size;
___
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau
