Re: [Numpy-discussion] Cython requirement?

2014-07-06 Thread Benjamin Root
Ok, must have missed that discussion. I don't like the reasoning, but that
boat has sailed.


On Sun, Jul 6, 2014 at 3:00 PM, Robert Kern  wrote:

> On Sun, Jul 6, 2014 at 7:40 PM, Benjamin Root  wrote:
> > When did Cython become a build requirement? I remember discussing the
> use of
> > Cython a while back, and IIRC the agreement was that both the cython code
> > and the generated C files would be included in version control so that
> > cython wouldn't be a build requirement, only a developer requirement when
> > modifying those files.
>
> It's a build requirement for building from the git checkout, but not
> the distributed source tarballs. The change was not too long ago, but
> it was discussed here.
>
> --
> Robert Kern
> ___
> NumPy-Discussion mailing list
> NumPy-Discussion@scipy.org
> http://mail.scipy.org/mailman/listinfo/numpy-discussion
>
___
NumPy-Discussion mailing list
NumPy-Discussion@scipy.org
http://mail.scipy.org/mailman/listinfo/numpy-discussion


Re: [Numpy-discussion] Cython requirement?

2014-07-06 Thread Robert Kern
On Sun, Jul 6, 2014 at 7:40 PM, Benjamin Root  wrote:
> When did Cython become a build requirement? I remember discussing the use of
> Cython a while back, and IIRC the agreement was that both the cython code
> and the generated C files would be included in version control so that
> cython wouldn't be a build requirement, only a developer requirement when
> modifying those files.

It's a build requirement for building from the git checkout, but not
the distributed source tarballs. The change was not too long ago, but
it was discussed here.

-- 
Robert Kern
___
NumPy-Discussion mailing list
NumPy-Discussion@scipy.org
http://mail.scipy.org/mailman/listinfo/numpy-discussion


Re: [Numpy-discussion] Cython requirement?

2014-07-06 Thread Daπid
On 6 July 2014 20:40, Benjamin Root  wrote:

> When did Cython become a build requirement? I remember discussing the use
> of Cython a while back, and IIRC the agreement was that both the cython
> code and the generated C files would be included in version control so that
> cython wouldn't be a build requirement, only a developer requirement when
> modifying those files.



The policy was changed to not include them in VC, but to them in the
releases, not to pollute the repository and avoid having C files not
matching the pyx, IIRC. The change was fairly recent, I was only able to
dig this email mentioning it:

http://numpy-discussion.10968.n7.nabble.com/numpy-git-master-requiring-cython-for-build-td37250.html


/David.
___
NumPy-Discussion mailing list
NumPy-Discussion@scipy.org
http://mail.scipy.org/mailman/listinfo/numpy-discussion


[Numpy-discussion] Cython requirement?

2014-07-06 Thread Benjamin Root
When did Cython become a build requirement? I remember discussing the use
of Cython a while back, and IIRC the agreement was that both the cython
code and the generated C files would be included in version control so that
cython wouldn't be a build requirement, only a developer requirement when
modifying those files.

I just did a git clean -fxd and rebase to current master, and I am getting
a message indicating that I need Cython 0.19 to build numpy (I haven't
updated cython in ages on this particular machine).

ben@tigger:~/Programs/numpy$ python setup.py install --user
Running from numpy source directory.
Cythonizing sources
Processing numpy/random/mtrand/mtrand.pyx
Traceback (most recent call last):
  File "/home/ben/Programs/numpy/tools/cythonize.py", line 199, in 
main()
  File "/home/ben/Programs/numpy/tools/cythonize.py", line 195, in main
find_process_files(root_dir)
  File "/home/ben/Programs/numpy/tools/cythonize.py", line 187, in
find_process_files
process(cur_dir, fromfile, tofile, function, hash_db)
  File "/home/ben/Programs/numpy/tools/cythonize.py", line 161, in process
processor_function(fromfile, tofile)
  File "/home/ben/Programs/numpy/tools/cythonize.py", line 59, in
process_pyx
raise Exception('Building %s requires Cython >= 0.19' % VENDOR)
Exception: Building NumPy requires Cython >= 0.19
Traceback (most recent call last):
  File "setup.py", line 251, in 
setup_package()
  File "setup.py", line 239, in setup_package
generate_cython()
  File "setup.py", line 191, in generate_cython
raise RuntimeError("Running cythonize failed!")
RuntimeError: Running cythonize failed!

Ben Root
___
NumPy-Discussion mailing list
NumPy-Discussion@scipy.org
http://mail.scipy.org/mailman/listinfo/numpy-discussion