Re: [Nutch-cvs] svn commit: r516888 - /lucene/nutch/trunk/bin/nutch

2007-03-18 Thread Sami Siren
Andrzej Bialecki wrote:
 Sami Siren wrote:
 How the code ended up in this place on Linux? The $cygwin condition
 should have prevented that, because it evaluates to true only on Cygwin,
 where this utility is required to translate the paths.

 You also changed the if syntax - before it was using the /bin/test
 utility to evaluate the expression, now it uses a shell built-in  - I'm
 not sure if these two follow the same evaluation rules on all supported
 platforms ... Please revert it to the earlier syntax.
 

 revert it so it desn't work on linux, are you sure?
   
 
 I'll make a patch and check that it works on Linux too - apparently it
 was me who botched the AND syntax in my previous commit... ;)
 

The effect of this problem was not purely cosmetic. I just realized it
disables the native libs because JAVA_LIBRARY_PATH does not get set. If
I change the if to

if [ test $cygwin -a X${JAVA_LIBRARY_PATH} != X ]; then
  JAVA_LIBRARY_PATH=`cygpath -p -w $JAVA_LIBRARY_PATH`
fi


it works, ok for me.

--
 Sami SIren


Re: [Nutch-cvs] svn commit: r516888 - /lucene/nutch/trunk/bin/nutch

2007-03-18 Thread Sami Siren
 I change the if to
 
 if [ test $cygwin -a X${JAVA_LIBRARY_PATH} != X ]; then
   JAVA_LIBRARY_PATH=`cygpath -p -w $JAVA_LIBRARY_PATH`
 fi
 
 
 it works, ok for me.
 

eh, forget that part :)

--
 Sami Siren