[jira] Updated: (NUTCH-485) Change HtmlParseFilter 's to return ParseResult object instead of Parse object

2007-05-13 Thread Gal Nitzan (JIRA)

 [ 
https://issues.apache.org/jira/browse/NUTCH-485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gal Nitzan updated NUTCH-485:
-

Attachment: NUTCH-485.200705140001.patch

Thanks Doğacan for taking the time to review the code.

I agree with your comments on the usage. I run a video search and it sure going 
to help. The ability to "discover" and add content "on the fly" to the segment 
while parsing is a functionality long awaited and it all made possible after 
NUTCH-443... :)


And yet one more update with a better description in javadoc and some fixes to 
indentation.

> Change HtmlParseFilter 's to return ParseResult object instead of Parse object
> --
>
> Key: NUTCH-485
> URL: https://issues.apache.org/jira/browse/NUTCH-485
> Project: Nutch
>  Issue Type: Improvement
>  Components: fetcher
>Affects Versions: 1.0.0
> Environment: All
>Reporter: Gal Nitzan
> Fix For: 1.0.0
>
> Attachments: NUTCH-485.200705122151.patch, 
> NUTCH-485.200705130928.patch, NUTCH-485.200705130945.patch, 
> NUTCH-485.200705131241.patch, NUTCH-485.200705140001.patch
>
>
> The current implementation of HtmlParseFilters.java doesn't allow a filter to 
> add parse objects to the ParseResult object.
> A change to the HtmlParseFilter is needed which allows the filter to return 
> ParseResult . and ofcourse a change to  HtmlParseFilters .

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (NUTCH-485) Change HtmlParseFilter 's to return ParseResult object instead of Parse object

2007-05-13 Thread Gal Nitzan (JIRA)

 [ 
https://issues.apache.org/jira/browse/NUTCH-485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gal Nitzan updated NUTCH-485:
-

Attachment: NUTCH-485.200705131241.patch

Thanks Doğacan, I missed it :( 

Thanks to all reviewers.
 
Yet another patch...

> Change HtmlParseFilter 's to return ParseResult object instead of Parse object
> --
>
> Key: NUTCH-485
> URL: https://issues.apache.org/jira/browse/NUTCH-485
> Project: Nutch
>  Issue Type: Improvement
>  Components: fetcher
>Affects Versions: 1.0.0
> Environment: All
>Reporter: Gal Nitzan
> Fix For: 1.0.0
>
> Attachments: NUTCH-485.200705122151.patch, 
> NUTCH-485.200705130928.patch, NUTCH-485.200705130945.patch, 
> NUTCH-485.200705131241.patch
>
>
> The current implementation of HtmlParseFilters.java doesn't allow a filter to 
> add parse objects to the ParseResult object.
> A change to the HtmlParseFilter is needed which allows the filter to return 
> ParseResult . and ofcourse a change to  HtmlParseFilters .

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (NUTCH-485) Change HtmlParseFilter 's to return ParseResult object instead of Parse object

2007-05-12 Thread Gal Nitzan (JIRA)

 [ 
https://issues.apache.org/jira/browse/NUTCH-485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gal Nitzan updated NUTCH-485:
-

Attachment: NUTCH-485.200705130945.patch

Yet another update with a cleaner code.

> Change HtmlParseFilter 's to return ParseResult object instead of Parse object
> --
>
> Key: NUTCH-485
> URL: https://issues.apache.org/jira/browse/NUTCH-485
> Project: Nutch
>  Issue Type: Improvement
>  Components: fetcher
>Affects Versions: 1.0.0
> Environment: All
>Reporter: Gal Nitzan
> Fix For: 1.0.0
>
> Attachments: NUTCH-485.200705122151.patch, 
> NUTCH-485.200705130928.patch, NUTCH-485.200705130945.patch
>
>
> The current implementation of HtmlParseFilters.java doesn't allow a filter to 
> add parse objects to the ParseResult object.
> A change to the HtmlParseFilter is needed which allows the filter to return 
> ParseResult . and ofcourse a change to  HtmlParseFilters .

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (NUTCH-485) Change HtmlParseFilter 's to return ParseResult object instead of Parse object

2007-05-12 Thread Gal Nitzan (JIRA)

 [ 
https://issues.apache.org/jira/browse/NUTCH-485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gal Nitzan updated NUTCH-485:
-

Attachment: NUTCH-485.200705130928.patch

Following Andrzej advice, a much cleaner code :)

Attached...

> Change HtmlParseFilter 's to return ParseResult object instead of Parse object
> --
>
> Key: NUTCH-485
> URL: https://issues.apache.org/jira/browse/NUTCH-485
> Project: Nutch
>  Issue Type: Improvement
>  Components: fetcher
>Affects Versions: 1.0.0
> Environment: All
>Reporter: Gal Nitzan
> Fix For: 1.0.0
>
> Attachments: NUTCH-485.200705122151.patch, 
> NUTCH-485.200705130928.patch
>
>
> The current implementation of HtmlParseFilters.java doesn't allow a filter to 
> add parse objects to the ParseResult object.
> A change to the HtmlParseFilter is needed which allows the filter to return 
> ParseResult . and ofcourse a change to  HtmlParseFilters .

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (NUTCH-485) Change HtmlParseFilter 's to return ParseResult object instead of Parse object

2007-05-12 Thread Gal Nitzan (JIRA)

 [ 
https://issues.apache.org/jira/browse/NUTCH-485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gal Nitzan updated NUTCH-485:
-

Attachment: NUTCH-485.200705122151.patch

Attached patch for this issue.

Comments are welcome.

This patch tuches a few plugins, please review 

Thanks,

Gal

> Change HtmlParseFilter 's to return ParseResult object instead of Parse object
> --
>
> Key: NUTCH-485
> URL: https://issues.apache.org/jira/browse/NUTCH-485
> Project: Nutch
>  Issue Type: Improvement
>  Components: fetcher
>Affects Versions: 1.0.0
> Environment: All
>Reporter: Gal Nitzan
> Fix For: 1.0.0
>
> Attachments: NUTCH-485.200705122151.patch
>
>
> The current implementation of HtmlParseFilters.java doesn't allow a filter to 
> add parse objects to the ParseResult object.
> A change to the HtmlParseFilter is needed which allows the filter to return 
> ParseResult . and ofcourse a change to  HtmlParseFilters .

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.