Re: [PATCH] xfs: drop experimental warning for FSDAX
在 2023/9/27 13:17, Shiyang Ruan 写道: 在 2023/9/27 11:38, Chandan Babu R 写道: On Tue, Sep 26, 2023 at 06:46:32 PM -0700, Darrick J. Wong wrote: On Wed, Sep 27, 2023 at 11:18:42AM +1000, Dave Chinner wrote: On Tue, Sep 26, 2023 at 07:55:19AM -0700, Darrick J. Wong wrote: On Thu, Sep 21, 2023 at 04:33:04PM +0800, Shiyang Ruan wrote: Hi, Any comments? I notice that xfs/55[0-2] still fail on my fakepmem machine: --- /tmp/fstests/tests/xfs/550.out 2023-09-23 09:40:47.839521305 -0700 +++ /var/tmp/fstests/xfs/550.out.bad 2023-09-24 20:00:23.4 -0700 @@ -3,7 +3,6 @@ Format and mount Create the original files Inject memory failure (1 page) Inject poison... -Process is killed by signal: 7 Inject memory failure (2 pages) Inject poison... -Process is killed by signal: 7 +Memory failure didn't kill the process (yes, rmap is enabled) Yes, I see the same failures, too. I've just been ignoring them because I thought that all the memory failure code was still not complete Oh, I bet we were supposed to have merged this https://lore.kernel.org/linux-xfs/20230828065744.1446462-1-ruansy.f...@fujitsu.com/ FYI, this one is in Andrew's mm-unstable tree: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git/commit/?h=mm-unstable&id=ff048e3e2d167927634a45f4f424338411a1c4e6 -- Thanks, Ruan. to complete the pmem media failure handling code. Should we (by which I mostly mean Shiyang) ask Chandan to merge these two patches for 6.7? I can add this patch into XFS tree for 6.7. But I will need Acks from Andrew Morton and Dan Williams. Thanks! And this patch[1] fixes these 3 cases (xfs/55[0-2]). Please add this one as well. [1]: https://lore.kernel.org/linux-xfs/20230913102942.601271-1-ruansy.f...@fujitsu.com -- Ruan.
Re: [PATCH] xfs: drop experimental warning for FSDAX
在 2023/9/27 11:38, Chandan Babu R 写道: On Tue, Sep 26, 2023 at 06:46:32 PM -0700, Darrick J. Wong wrote: On Wed, Sep 27, 2023 at 11:18:42AM +1000, Dave Chinner wrote: On Tue, Sep 26, 2023 at 07:55:19AM -0700, Darrick J. Wong wrote: On Thu, Sep 21, 2023 at 04:33:04PM +0800, Shiyang Ruan wrote: Hi, Any comments? I notice that xfs/55[0-2] still fail on my fakepmem machine: --- /tmp/fstests/tests/xfs/550.out 2023-09-23 09:40:47.839521305 -0700 +++ /var/tmp/fstests/xfs/550.out.bad2023-09-24 20:00:23.4 -0700 @@ -3,7 +3,6 @@ Format and mount Create the original files Inject memory failure (1 page) Inject poison... -Process is killed by signal: 7 Inject memory failure (2 pages) Inject poison... -Process is killed by signal: 7 +Memory failure didn't kill the process (yes, rmap is enabled) Yes, I see the same failures, too. I've just been ignoring them because I thought that all the memory failure code was still not complete Oh, I bet we were supposed to have merged this https://lore.kernel.org/linux-xfs/20230828065744.1446462-1-ruansy.f...@fujitsu.com/ to complete the pmem media failure handling code. Should we (by which I mostly mean Shiyang) ask Chandan to merge these two patches for 6.7? I can add this patch into XFS tree for 6.7. But I will need Acks from Andrew Morton and Dan Williams. Thanks! And this patch[1] fixes these 3 cases (xfs/55[0-2]). Please add this one as well. [1]: https://lore.kernel.org/linux-xfs/20230913102942.601271-1-ruansy.f...@fujitsu.com -- Ruan.
Re: [PATCH] xfs: drop experimental warning for FSDAX
On Tue, Sep 26, 2023 at 06:46:32 PM -0700, Darrick J. Wong wrote: > On Wed, Sep 27, 2023 at 11:18:42AM +1000, Dave Chinner wrote: >> On Tue, Sep 26, 2023 at 07:55:19AM -0700, Darrick J. Wong wrote: >> > On Thu, Sep 21, 2023 at 04:33:04PM +0800, Shiyang Ruan wrote: >> > > Hi, >> > > >> > > Any comments? >> > >> > I notice that xfs/55[0-2] still fail on my fakepmem machine: >> > >> > --- /tmp/fstests/tests/xfs/550.out 2023-09-23 09:40:47.839521305 -0700 >> > +++ /var/tmp/fstests/xfs/550.out.bad 2023-09-24 20:00:23.4 >> > -0700 >> > @@ -3,7 +3,6 @@ Format and mount >> > Create the original files >> > Inject memory failure (1 page) >> > Inject poison... >> > -Process is killed by signal: 7 >> > Inject memory failure (2 pages) >> > Inject poison... >> > -Process is killed by signal: 7 >> > +Memory failure didn't kill the process >> > >> > (yes, rmap is enabled) >> >> Yes, I see the same failures, too. I've just been ignoring them >> because I thought that all the memory failure code was still not >> complete > > Oh, I bet we were supposed to have merged this > > https://lore.kernel.org/linux-xfs/20230828065744.1446462-1-ruansy.f...@fujitsu.com/ > > to complete the pmem media failure handling code. Should we (by which I > mostly mean Shiyang) ask Chandan to merge these two patches for 6.7? > I can add this patch into XFS tree for 6.7. But I will need Acks from Andrew Morton and Dan Williams. -- Chandan
Re: [PATCH] xfs: drop experimental warning for FSDAX
On Wed, Sep 27, 2023 at 11:18:42AM +1000, Dave Chinner wrote: > On Tue, Sep 26, 2023 at 07:55:19AM -0700, Darrick J. Wong wrote: > > On Thu, Sep 21, 2023 at 04:33:04PM +0800, Shiyang Ruan wrote: > > > Hi, > > > > > > Any comments? > > > > I notice that xfs/55[0-2] still fail on my fakepmem machine: > > > > --- /tmp/fstests/tests/xfs/550.out 2023-09-23 09:40:47.839521305 -0700 > > +++ /var/tmp/fstests/xfs/550.out.bad2023-09-24 20:00:23.4 > > -0700 > > @@ -3,7 +3,6 @@ Format and mount > > Create the original files > > Inject memory failure (1 page) > > Inject poison... > > -Process is killed by signal: 7 > > Inject memory failure (2 pages) > > Inject poison... > > -Process is killed by signal: 7 > > +Memory failure didn't kill the process > > > > (yes, rmap is enabled) > > Yes, I see the same failures, too. I've just been ignoring them > because I thought that all the memory failure code was still not > complete Oh, I bet we were supposed to have merged this https://lore.kernel.org/linux-xfs/20230828065744.1446462-1-ruansy.f...@fujitsu.com/ to complete the pmem media failure handling code. Should we (by which I mostly mean Shiyang) ask Chandan to merge these two patches for 6.7? --D > -Dave. > -- > Dave Chinner > da...@fromorbit.com
Re: [PATCH] xfs: drop experimental warning for FSDAX
On Tue, Sep 26, 2023 at 07:55:19AM -0700, Darrick J. Wong wrote: > On Thu, Sep 21, 2023 at 04:33:04PM +0800, Shiyang Ruan wrote: > > Hi, > > > > Any comments? > > I notice that xfs/55[0-2] still fail on my fakepmem machine: > > --- /tmp/fstests/tests/xfs/550.out2023-09-23 09:40:47.839521305 -0700 > +++ /var/tmp/fstests/xfs/550.out.bad 2023-09-24 20:00:23.4 -0700 > @@ -3,7 +3,6 @@ Format and mount > Create the original files > Inject memory failure (1 page) > Inject poison... > -Process is killed by signal: 7 > Inject memory failure (2 pages) > Inject poison... > -Process is killed by signal: 7 > +Memory failure didn't kill the process > > (yes, rmap is enabled) Yes, I see the same failures, too. I've just been ignoring them because I thought that all the memory failure code was still not complete -Dave. -- Dave Chinner da...@fromorbit.com
[PATCH ndctl] ndctl/cxl/region: Report max size for region creation
When creating a region if the size exceeds the max an error is printed.
However, the max available space is not reported which makes it harder
to determine what is wrong.
Add the max size available to the output error.
Signed-off-by: Ira Weiny
---
cxl/region.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/cxl/region.c b/cxl/region.c
index bcd703956207..cb6a547990fb 100644
--- a/cxl/region.c
+++ b/cxl/region.c
@@ -623,8 +623,8 @@ static int create_region(struct cxl_ctx *ctx, int *count,
}
if (!default_size && size > max_extent) {
log_err(&rl,
- "%s: region size %#lx exceeds max available space\n",
- cxl_decoder_get_devname(p->root_decoder), size);
+ "%s: region size %#lx exceeds max available space
(%#lx)\n",
+ cxl_decoder_get_devname(p->root_decoder), size,
max_extent);
return -ENOSPC;
}
---
base-commit: a871e6153b11fe63780b37cdcb1eb347b296095c
change-id: 20230926-max-size-create-region-1f57ff3bc53c
Best regards,
--
Ira Weiny
Re: [PATCH] xfs: drop experimental warning for FSDAX
On Thu, Sep 21, 2023 at 04:33:04PM +0800, Shiyang Ruan wrote: > Hi, > > Any comments? I notice that xfs/55[0-2] still fail on my fakepmem machine: --- /tmp/fstests/tests/xfs/550.out 2023-09-23 09:40:47.839521305 -0700 +++ /var/tmp/fstests/xfs/550.out.bad2023-09-24 20:00:23.4 -0700 @@ -3,7 +3,6 @@ Format and mount Create the original files Inject memory failure (1 page) Inject poison... -Process is killed by signal: 7 Inject memory failure (2 pages) Inject poison... -Process is killed by signal: 7 +Memory failure didn't kill the process (yes, rmap is enabled) Not sure what that's about? --D > > > -- > Thanks, > Ruan. > > > 在 2023/9/15 14:38, Shiyang Ruan 写道: > > FSDAX and reflink can work together now, let's drop this warning. > > > > Signed-off-by: Shiyang Ruan > > --- > > fs/xfs/xfs_super.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c > > index 1f77014c6e1a..faee773fa026 100644 > > --- a/fs/xfs/xfs_super.c > > +++ b/fs/xfs/xfs_super.c > > @@ -371,7 +371,6 @@ xfs_setup_dax_always( > > return -EINVAL; > > } > > - xfs_warn(mp, "DAX enabled. Warning: EXPERIMENTAL, use at your own > > risk"); > > return 0; > > disable_dax:
