[jira] [Commented] (OAK-5454) Failed test: org.apache.jackrabbit.oak.plugins.blob.CachingDataStoreTest.zeroStagingCacheAddGetDelete
[ https://issues.apache.org/jira/browse/OAK-5454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15823580#comment-15823580 ] Amit Jain commented on OAK-5454: Potential fix with http://svn.apache.org/viewvc?rev=1778982&view=rev > Failed test: > org.apache.jackrabbit.oak.plugins.blob.CachingDataStoreTest.zeroStagingCacheAddGetDelete > - > > Key: OAK-5454 > URL: https://issues.apache.org/jira/browse/OAK-5454 > Project: Jackrabbit Oak > Issue Type: Bug > Components: blob >Reporter: Amit Jain >Assignee: Amit Jain > Fix For: 1.5.18 > > > Failed in build > https://builds.apache.org/job/Apache%20Jackrabbit%20Oak%20matrix/1367/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OAK-5455) Specify versions for maven plugins used in build for ensuring stable builds
[ https://issues.apache.org/jira/browse/OAK-5455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15823550#comment-15823550 ] Chetan Mehrotra commented on OAK-5455: -- Other updates suggested {noformat} [INFO] Require Maven 2.0.1 to use the following plugin updates: [INFO] maven-release-plugin . 2.0-beta-7 [INFO] [INFO] Require Maven 2.0.2 to use the following plugin updates: [INFO] maven-checkstyle-plugin . 2.1 [INFO] maven-javadoc-plugin 2.2 [INFO] maven-site-plugin 2.0-beta-7 [INFO] [INFO] Require Maven 2.0.4 to use the following plugin updates: [INFO] maven-project-info-reports-plugin . 2.0.1 [INFO] org.apache.rat:apache-rat-plugin 0.8 [INFO] [INFO] Require Maven 2.0.5 to use the following plugin updates: [INFO] org.codehaus.mojo:findbugs-maven-plugin . 1.2 [INFO] [INFO] Require Maven 2.0.6 to use the following plugin updates: [INFO] maven-checkstyle-plugin . 2.8 [INFO] maven-deploy-plugin ... 2.8.1 [INFO] maven-jar-plugin 2.4 [INFO] maven-javadoc-plugin 2.3 [INFO] maven-project-info-reports-plugin . 2.1.2 [INFO] maven-release-plugin . 2.0-beta-9 [INFO] maven-resources-plugin .. 2.6 [INFO] maven-site-plugin . 2.0.1 [INFO] maven-surefire-plugin . 2.4.3 [INFO] [INFO] Require Maven 2.0.7 to use the following plugin updates: [INFO] org.codehaus.mojo:findbugs-maven-plugin . 2.1 [INFO] [INFO] Require Maven 2.0.8 to use the following plugin updates: [INFO] maven-javadoc-plugin 2.4 [INFO] org.codehaus.mojo:findbugs-maven-plugin ... 2.3.1 [INFO] [INFO] Require Maven 2.0.9 to use the following plugin updates: [INFO] maven-compiler-plugin ... 3.1 [INFO] maven-failsafe-plugin .. 2.12 [INFO] maven-javadoc-plugin .. 2.8.1 [INFO] maven-release-plugin .. 2.2.2 [INFO] maven-surefire-plugin .. 2.17 [INFO] [INFO] Require Maven 2.1.0 to use the following plugin updates: [INFO] maven-project-info-reports-plugin ... 2.2 [INFO] maven-site-plugin . 2.1.1 [INFO] org.codehaus.mojo:findbugs-maven-plugin ... 2.3.3 [INFO] org.jacoco:jacoco-maven-plugin ... 0.6.3.201306030806 [INFO] [INFO] Require Maven 2.2.0 to use the following plugin updates: [INFO] maven-project-info-reports-plugin ... 2.6 [INFO] maven-site-plugin ... 3.0 [INFO] [INFO] Require Maven 2.2.1 to use the following plugin updates: [INFO] maven-checkstyle-plugin ... 2.9.1 [INFO] maven-compiler-plugin ... 3.3 [INFO] maven-deploy-plugin ... 2.8.2 [INFO] maven-javadoc-plugin 2.9 [INFO] maven-project-info-reports-plugin . 2.8.1 [INFO] maven-release-plugin .. 2.3.2 [INFO] maven-resources-plugin .. 2.7 [INFO] maven-site-plugin ... 3.1 [INFO] maven-surefire-plugin 2.19.1 [INFO] org.apache.rat:apache-rat-plugin ... 0.11 [INFO] org.codehaus.mojo:animal-sniffer-maven-plugin .. 1.15 [INFO] org.codehaus.mojo:findbugs-maven-plugin ... 2.5.5 [INFO] org.jacoco:jacoco-maven-plugin ... 0.7.6.201602180812 [INFO] [INFO] Require Maven 3.0 to use the following plugin updates: [INFO] maven-compiler-plugin . 3.5.1 [INFO] maven-project-info-reports-plugin ... 2.9 [INFO] maven-resources-plugin 3.0.1 [INFO] maven-scm-publish-plugin 1.1 [INFO] org.jacoco:jacoco-maven-plugin 0.7.8 [INFO] [INFO] Require Maven 3.0.1 to use the following plugin up
[jira] [Updated] (OAK-5455) Specify versions for maven plugins used in build for ensuring stable builds
[ https://issues.apache.org/jira/browse/OAK-5455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chetan Mehrotra updated OAK-5455: - Description: Running a check for plugin versions used in oak build {noformat} mvn versions:display-plugin-updates {noformat} leads to following warning {noformat} [INFO] The following plugin updates are available: [INFO] org.apache.felix:maven-scr-plugin .. 1.16.0 -> 1.21.0 [INFO] [WARNING] The following plugins do not have their version specified: [WARNING] maven-compiler-plugin .. 2.0.2 [WARNING] maven-deploy-plugin . (from super-pom) 2.4 [WARNING] maven-failsafe-plugin . 2.12.4 [WARNING] maven-jar-plugin . 2.1 [WARNING] maven-javadoc-plugin . 2.0 [WARNING] maven-release-plugin . (from super-pom) 2.0-beta-4 [WARNING] maven-resources-plugin ... 2.2 [WARNING] maven-surefire-plugin .. 2.4.2 [INFO] [WARNING] Project does not define minimum Maven version, default is: 2.0 [INFO] Plugins require minimum Maven version of: 3.0.5 [INFO] Note: the super-pom from Maven 3.3.9 defines some of the plugin [INFO] versions and may be influencing the plugins required minimum Maven [INFO] version. [INFO] [ERROR] Project does not define required minimum version of Maven. [ERROR] Update the pom.xml to contain [ERROR] [ERROR] 3.0.5 [ERROR] {noformat} As a fix we should # Specify version for all maven plugin in use # Specify minimum version of maven to be used (version used in CI is 3.2.1) # Configure enforcer plugin to ensure that in future no plugin is used without specifying the version [1] [1] http://maven.apache.org/enforcer/enforcer-rules/requirePluginVersions.html was: Running a check for plugin versions used in oak build {noformat} mvn versions:display-plugin-updates {noformat} leads to following warning {noformat} [INFO] The following plugin updates are available: [INFO] org.apache.felix:maven-scr-plugin .. 1.16.0 -> 1.21.0 [INFO] [WARNING] The following plugins do not have their version specified: [WARNING] maven-compiler-plugin .. 2.0.2 [WARNING] maven-deploy-plugin . (from super-pom) 2.4 [WARNING] maven-failsafe-plugin . 2.12.4 [WARNING] maven-jar-plugin . 2.1 [WARNING] maven-javadoc-plugin . 2.0 [WARNING] maven-release-plugin . (from super-pom) 2.0-beta-4 [WARNING] maven-resources-plugin ... 2.2 [WARNING] maven-surefire-plugin .. 2.4.2 [INFO] [WARNING] Project does not define minimum Maven version, default is: 2.0 [INFO] Plugins require minimum Maven version of: 3.0.5 [INFO] Note: the super-pom from Maven 3.3.9 defines some of the plugin [INFO] versions and may be influencing the plugins required minimum Maven [INFO] version. [INFO] [ERROR] Project does not define required minimum version of Maven. [ERROR] Update the pom.xml to contain [ERROR] [ERROR] 3.0.5 [ERROR] {noformat} As a fix we should # Specify version for all maven plugin in use # Specify minimum version of maven to be used # Configure enforcer plugin to ensure that in future no plugin is used without specifying the version [1] [1] http://maven.apache.org/enforcer/enforcer-rules/requirePluginVersions.html > Specify versions for maven plugins used in build for ensuring stable builds > --- > > Key: OAK-5455 > URL: https://issues.apache.org/jira/browse/OAK-5455 > Project: Jackrabbit Oak > Issue Type: Task > Components: parent >Reporter: Chetan Mehrotra > Fix For: 1.6 > > > Running a check for plugin versions used in oak build > {noformat} > mvn versions:display-plugin-updates > {noformat} > leads to following warning > {noformat} > [INFO] The following plugin updates are available: > [INFO] org.apache.felix:maven-scr-plugin .. 1.16.0 -> 1.21.0 > [INFO] > [WARNING] The following plugins do not have their version specified: > [WARNING] maven-compiler-plugin .. 2.0.2 > [WARNING] maven-deploy-plugin . (from super-pom) 2.4 > [WARNING] maven-failsafe-plugin . 2.12.4 > [WARNING] maven-jar-plugin . 2.1 > [WARNING] maven-javadoc-plugin .
[jira] [Updated] (OAK-5455) Specify versions for maven plugins used in build for ensuring stable builds
[ https://issues.apache.org/jira/browse/OAK-5455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chetan Mehrotra updated OAK-5455: - Summary: Specify versions for maven plugins used in build for ensuring stable builds (was: Specify versions for maven plugins used in build) > Specify versions for maven plugins used in build for ensuring stable builds > --- > > Key: OAK-5455 > URL: https://issues.apache.org/jira/browse/OAK-5455 > Project: Jackrabbit Oak > Issue Type: Task > Components: parent >Reporter: Chetan Mehrotra > Fix For: 1.6 > > > Running a check for plugin versions used in oak build > {noformat} > mvn versions:display-plugin-updates > {noformat} > leads to following warning > {noformat} > [INFO] The following plugin updates are available: > [INFO] org.apache.felix:maven-scr-plugin .. 1.16.0 -> 1.21.0 > [INFO] > [WARNING] The following plugins do not have their version specified: > [WARNING] maven-compiler-plugin .. 2.0.2 > [WARNING] maven-deploy-plugin . (from super-pom) 2.4 > [WARNING] maven-failsafe-plugin . 2.12.4 > [WARNING] maven-jar-plugin . 2.1 > [WARNING] maven-javadoc-plugin . 2.0 > [WARNING] maven-release-plugin . (from super-pom) 2.0-beta-4 > [WARNING] maven-resources-plugin ... 2.2 > [WARNING] maven-surefire-plugin .. 2.4.2 > [INFO] > [WARNING] Project does not define minimum Maven version, default is: 2.0 > [INFO] Plugins require minimum Maven version of: 3.0.5 > [INFO] Note: the super-pom from Maven 3.3.9 defines some of the plugin > [INFO] versions and may be influencing the plugins required minimum > Maven > [INFO] version. > [INFO] > [ERROR] Project does not define required minimum version of Maven. > [ERROR] Update the pom.xml to contain > [ERROR] > [ERROR] 3.0.5 > [ERROR] > {noformat} > As a fix we should > # Specify version for all maven plugin in use > # Specify minimum version of maven to be used > # Configure enforcer plugin to ensure that in future no plugin is used > without specifying the version [1] > [1] http://maven.apache.org/enforcer/enforcer-rules/requirePluginVersions.html -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OAK-5455) Specify versions for maven plugins used in build
Chetan Mehrotra created OAK-5455: Summary: Specify versions for maven plugins used in build Key: OAK-5455 URL: https://issues.apache.org/jira/browse/OAK-5455 Project: Jackrabbit Oak Issue Type: Task Components: parent Reporter: Chetan Mehrotra Fix For: 1.6 Running a check for plugin versions used in oak build {noformat} mvn versions:display-plugin-updates {noformat} leads to following warning {noformat} [INFO] The following plugin updates are available: [INFO] org.apache.felix:maven-scr-plugin .. 1.16.0 -> 1.21.0 [INFO] [WARNING] The following plugins do not have their version specified: [WARNING] maven-compiler-plugin .. 2.0.2 [WARNING] maven-deploy-plugin . (from super-pom) 2.4 [WARNING] maven-failsafe-plugin . 2.12.4 [WARNING] maven-jar-plugin . 2.1 [WARNING] maven-javadoc-plugin . 2.0 [WARNING] maven-release-plugin . (from super-pom) 2.0-beta-4 [WARNING] maven-resources-plugin ... 2.2 [WARNING] maven-surefire-plugin .. 2.4.2 [INFO] [WARNING] Project does not define minimum Maven version, default is: 2.0 [INFO] Plugins require minimum Maven version of: 3.0.5 [INFO] Note: the super-pom from Maven 3.3.9 defines some of the plugin [INFO] versions and may be influencing the plugins required minimum Maven [INFO] version. [INFO] [ERROR] Project does not define required minimum version of Maven. [ERROR] Update the pom.xml to contain [ERROR] [ERROR] 3.0.5 [ERROR] {noformat} As a fix we should # Specify version for all maven plugin in use # Specify minimum version of maven to be used # Configure enforcer plugin to ensure that in future no plugin is used without specifying the version [1] [1] http://maven.apache.org/enforcer/enforcer-rules/requirePluginVersions.html -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (OAK-5418) Test failure: TomcatIT.testTomcat()
[ https://issues.apache.org/jira/browse/OAK-5418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chetan Mehrotra resolved OAK-5418. -- Resolution: Fixed Fix Version/s: 1.5.18 Previous change should fix this issue. Would reopen if the issue is observed again for same cause > Test failure: TomcatIT.testTomcat() > --- > > Key: OAK-5418 > URL: https://issues.apache.org/jira/browse/OAK-5418 > Project: Jackrabbit Oak > Issue Type: Test > Components: continuous integration >Reporter: Hudson >Assignee: Chetan Mehrotra > Fix For: 1.5.18, 1.6 > > > Jenkins CI failure: > https://builds.apache.org/job/Apache%20Jackrabbit%20Oak%20matrix/ > The build Apache Jackrabbit Oak matrix/Ubuntu Slaves=ubuntu,jdk=JDK 1.7 > (latest),nsfixtures=DOCUMENT_NS,profile=unittesting #1357 has failed. > First failed run: [Apache Jackrabbit Oak matrix/Ubuntu Slaves=ubuntu,jdk=JDK > 1.7 (latest),nsfixtures=DOCUMENT_NS,profile=unittesting > #1357|https://builds.apache.org/job/Apache%20Jackrabbit%20Oak%20matrix/Ubuntu%20Slaves=ubuntu,jdk=JDK%201.7%20(latest),nsfixtures=DOCUMENT_NS,profile=unittesting/1357/] > [console > log|https://builds.apache.org/job/Apache%20Jackrabbit%20Oak%20matrix/Ubuntu%20Slaves=ubuntu,jdk=JDK%201.7%20(latest),nsfixtures=DOCUMENT_NS,profile=unittesting/1357/console] -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OAK-5418) Test failure: TomcatIT.testTomcat()
[ https://issues.apache.org/jira/browse/OAK-5418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chetan Mehrotra updated OAK-5418: - Issue Type: Test (was: Bug) > Test failure: TomcatIT.testTomcat() > --- > > Key: OAK-5418 > URL: https://issues.apache.org/jira/browse/OAK-5418 > Project: Jackrabbit Oak > Issue Type: Test > Components: continuous integration >Reporter: Hudson >Assignee: Chetan Mehrotra > Fix For: 1.5.18, 1.6 > > > Jenkins CI failure: > https://builds.apache.org/job/Apache%20Jackrabbit%20Oak%20matrix/ > The build Apache Jackrabbit Oak matrix/Ubuntu Slaves=ubuntu,jdk=JDK 1.7 > (latest),nsfixtures=DOCUMENT_NS,profile=unittesting #1357 has failed. > First failed run: [Apache Jackrabbit Oak matrix/Ubuntu Slaves=ubuntu,jdk=JDK > 1.7 (latest),nsfixtures=DOCUMENT_NS,profile=unittesting > #1357|https://builds.apache.org/job/Apache%20Jackrabbit%20Oak%20matrix/Ubuntu%20Slaves=ubuntu,jdk=JDK%201.7%20(latest),nsfixtures=DOCUMENT_NS,profile=unittesting/1357/] > [console > log|https://builds.apache.org/job/Apache%20Jackrabbit%20Oak%20matrix/Ubuntu%20Slaves=ubuntu,jdk=JDK%201.7%20(latest),nsfixtures=DOCUMENT_NS,profile=unittesting/1357/console] -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OAK-5418) Test failure: TomcatIT.testTomcat()
[ https://issues.apache.org/jira/browse/OAK-5418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15823540#comment-15823540 ] Chetan Mehrotra commented on OAK-5418: -- With commit 1778968 ensured that test uses a random port > Test failure: TomcatIT.testTomcat() > --- > > Key: OAK-5418 > URL: https://issues.apache.org/jira/browse/OAK-5418 > Project: Jackrabbit Oak > Issue Type: Bug > Components: continuous integration >Reporter: Hudson >Assignee: Chetan Mehrotra > Fix For: 1.6 > > > Jenkins CI failure: > https://builds.apache.org/job/Apache%20Jackrabbit%20Oak%20matrix/ > The build Apache Jackrabbit Oak matrix/Ubuntu Slaves=ubuntu,jdk=JDK 1.7 > (latest),nsfixtures=DOCUMENT_NS,profile=unittesting #1357 has failed. > First failed run: [Apache Jackrabbit Oak matrix/Ubuntu Slaves=ubuntu,jdk=JDK > 1.7 (latest),nsfixtures=DOCUMENT_NS,profile=unittesting > #1357|https://builds.apache.org/job/Apache%20Jackrabbit%20Oak%20matrix/Ubuntu%20Slaves=ubuntu,jdk=JDK%201.7%20(latest),nsfixtures=DOCUMENT_NS,profile=unittesting/1357/] > [console > log|https://builds.apache.org/job/Apache%20Jackrabbit%20Oak%20matrix/Ubuntu%20Slaves=ubuntu,jdk=JDK%201.7%20(latest),nsfixtures=DOCUMENT_NS,profile=unittesting/1357/console] -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OAK-5449) Cost calculation for one matching property restriction/sorting results in selection of wrong index
[ https://issues.apache.org/jira/browse/OAK-5449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chetan Mehrotra reassigned OAK-5449: Assignee: Chetan Mehrotra > Cost calculation for one matching property restriction/sorting results in > selection of wrong index > -- > > Key: OAK-5449 > URL: https://issues.apache.org/jira/browse/OAK-5449 > Project: Jackrabbit Oak > Issue Type: Bug > Components: lucene >Affects Versions: 1.4.10 >Reporter: Volker Schmidt >Assignee: Chetan Mehrotra > > The method IndexPlanner.getPlanBuilder() for Lucene indexes contains at the > end an algorithm that calculates a costPerEntryFactor. If there is no > restriction property or sort property the factor will be the same like for > one restriction property or sort property. > If there are two indexes for which the cost is calculated, the cost must not > be the same. E.g. if there is a large result set that can be sorted with one > index but not with the other index, the index that supports sorting should be > used. > The following code snippet: > if (costPerEntryFactor == 0) { > costPerEntryFactor = 1; > } > should be changed to something like this (assuming costPerEntryFactor will be > changed to double value and will be rounded after division at the end of the > method): > if (costPerEntryFactor == 1.0) { > // one matching restriction or sort property > costPerEntryFactor = 1.5; > } > else if (costPerEntryFactor == 0.0) { > // no matching restriction or sort property > costPerEntryFactor = 1.0; > } > Furthermore, since the found indexes are stored in a hashed collection, the > order of the index evaluation and the resulting index (when cost is the same > for more than one lucene based index) is non deterministic. This increases > the issue with the code above. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OAK-5449) Cost calculation for one matching property restriction/sorting results in selection of wrong index
[ https://issues.apache.org/jira/browse/OAK-5449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chetan Mehrotra updated OAK-5449: - Description: The method IndexPlanner.getPlanBuilder() for Lucene indexes contains at the end an algorithm that calculates a costPerEntryFactor. If there is no restriction property or sort property the factor will be the same like for one restriction property or sort property. If there are two indexes for which the cost is calculated, the cost must not be the same. E.g. if there is a large result set that can be sorted with one index but not with the other index, the index that supports sorting should be used. The following code snippet: if (costPerEntryFactor == 0) { costPerEntryFactor = 1; } should be changed to something like this (assuming costPerEntryFactor will be changed to double value and will be rounded after division at the end of the method): if (costPerEntryFactor == 1.0) { // one matching restriction or sort property costPerEntryFactor = 1.5; } else if (costPerEntryFactor == 0.0) { // no matching restriction or sort property costPerEntryFactor = 1.0; } Furthermore, since the found indexes are stored in a hashed collection, the order of the index evaluation and the resulting index (when cost is the same for more than one lucene based index) is non deterministic. This increases the issue with the code above. was: The method IndexPlanner.getPlanBuilder() for Lucene indexes contains at the end an algorithm that calculates a costPerEntryFactory. If there is no restriction property or sort property the factory will be the same like for one restriction property or sort property. If there are two indexes for which the cost is calculated, the cost must not be the same. E.g. if there is a large result set that can be sorted with one index but not with the other index, the index that supports sorting should be used. The following code snippet: if (costPerEntryFactor == 0) { costPerEntryFactor = 1; } should be changed to something like this (assuming costPerEntryFactor will be changed to double value and will be rounded after division at the end of the method): if (costPerEntryFactor == 1.0) { // one matching restriction or sort property costPerEntryFactor = 1.5; } else if (costPerEntryFactor == 0.0) { // no matching restriction or sort property costPerEntryFactor = 1.0; } Furthermore, since the found indexes are stored in a hashed collection, the order of the index evaluation and the resulting index (when cost is the same for more than one lucene based index) is non deterministic. This increases the issue with the code above. > Cost calculation for one matching property restriction/sorting results in > selection of wrong index > -- > > Key: OAK-5449 > URL: https://issues.apache.org/jira/browse/OAK-5449 > Project: Jackrabbit Oak > Issue Type: Bug > Components: lucene >Affects Versions: 1.4.10 >Reporter: Volker Schmidt > > The method IndexPlanner.getPlanBuilder() for Lucene indexes contains at the > end an algorithm that calculates a costPerEntryFactor. If there is no > restriction property or sort property the factor will be the same like for > one restriction property or sort property. > If there are two indexes for which the cost is calculated, the cost must not > be the same. E.g. if there is a large result set that can be sorted with one > index but not with the other index, the index that supports sorting should be > used. > The following code snippet: > if (costPerEntryFactor == 0) { > costPerEntryFactor = 1; > } > should be changed to something like this (assuming costPerEntryFactor will be > changed to double value and will be rounded after division at the end of the > method): > if (costPerEntryFactor == 1.0) { > // one matching restriction or sort property > costPerEntryFactor = 1.5; > } > else if (costPerEntryFactor == 0.0) { > // no matching restriction or sort property > costPerEntryFactor = 1.0; > } > Furthermore, since the found indexes are stored in a hashed collection, the > order of the index evaluation and the resulting index (when cost is the same > for more than one lucene based index) is non deterministic. This increases > the issue with the code above. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OAK-5426) Test failure: LuceneIndexQueryTest.sql2() query took too long
[ https://issues.apache.org/jira/browse/OAK-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chetan Mehrotra updated OAK-5426: - Description: Jenkins CI failure: https://builds.apache.org/job/Apache%20Jackrabbit%20Oak%20matrix/ The build Apache Jackrabbit Oak matrix/Ubuntu Slaves=ubuntu,jdk=JDK 1.7 (latest),nsfixtures=SEGMENT_MK,profile=unittesting #1359 has failed. First failed run: [Apache Jackrabbit Oak matrix/Ubuntu Slaves=ubuntu,jdk=JDK 1.7 (latest),nsfixtures=SEGMENT_MK,profile=unittesting #1359|https://builds.apache.org/job/Apache%20Jackrabbit%20Oak%20matrix/Ubuntu%20Slaves=ubuntu,jdk=JDK%201.7%20(latest),nsfixtures=SEGMENT_MK,profile=unittesting/1359/] [console log|https://builds.apache.org/job/Apache%20Jackrabbit%20Oak%20matrix/Ubuntu%20Slaves=ubuntu,jdk=JDK%201.7%20(latest),nsfixtures=SEGMENT_MK,profile=unittesting/1359/console] {noformat} java.lang.AssertionError: Query took too long: select a.[jcr:path] from [nt:base] as a left outer join [nt:base] as b on ischildnode(b, a) where name(b) = 'b' took 13790 ms at org.junit.Assert.fail(Assert.java:88) at org.apache.jackrabbit.oak.query.AbstractQueryTest.executeQuery(AbstractQueryTest.java:280) at org.apache.jackrabbit.oak.query.AbstractQueryTest.executeQuery(AbstractQueryTest.java:255) at org.apache.jackrabbit.oak.query.AbstractQueryTest.executeQuery(AbstractQueryTest.java:251) at org.apache.jackrabbit.oak.query.AbstractQueryTest.test(AbstractQueryTest.java:187) at org.apache.jackrabbit.oak.plugins.index.lucene.LuceneIndexQueryTest.sql2(LuceneIndexQueryTest.java:93) {noformat} was: Jenkins CI failure: https://builds.apache.org/job/Apache%20Jackrabbit%20Oak%20matrix/ The build Apache Jackrabbit Oak matrix/Ubuntu Slaves=ubuntu,jdk=JDK 1.7 (latest),nsfixtures=SEGMENT_MK,profile=unittesting #1359 has failed. First failed run: [Apache Jackrabbit Oak matrix/Ubuntu Slaves=ubuntu,jdk=JDK 1.7 (latest),nsfixtures=SEGMENT_MK,profile=unittesting #1359|https://builds.apache.org/job/Apache%20Jackrabbit%20Oak%20matrix/Ubuntu%20Slaves=ubuntu,jdk=JDK%201.7%20(latest),nsfixtures=SEGMENT_MK,profile=unittesting/1359/] [console log|https://builds.apache.org/job/Apache%20Jackrabbit%20Oak%20matrix/Ubuntu%20Slaves=ubuntu,jdk=JDK%201.7%20(latest),nsfixtures=SEGMENT_MK,profile=unittesting/1359/console] > Test failure: LuceneIndexQueryTest.sql2() query took too long > - > > Key: OAK-5426 > URL: https://issues.apache.org/jira/browse/OAK-5426 > Project: Jackrabbit Oak > Issue Type: Bug > Components: continuous integration, lucene >Affects Versions: 1.4.11 >Reporter: Hudson > Fix For: 1.4.14 > > > Jenkins CI failure: > https://builds.apache.org/job/Apache%20Jackrabbit%20Oak%20matrix/ > The build Apache Jackrabbit Oak matrix/Ubuntu Slaves=ubuntu,jdk=JDK 1.7 > (latest),nsfixtures=SEGMENT_MK,profile=unittesting #1359 has failed. > First failed run: [Apache Jackrabbit Oak matrix/Ubuntu Slaves=ubuntu,jdk=JDK > 1.7 (latest),nsfixtures=SEGMENT_MK,profile=unittesting > #1359|https://builds.apache.org/job/Apache%20Jackrabbit%20Oak%20matrix/Ubuntu%20Slaves=ubuntu,jdk=JDK%201.7%20(latest),nsfixtures=SEGMENT_MK,profile=unittesting/1359/] > [console > log|https://builds.apache.org/job/Apache%20Jackrabbit%20Oak%20matrix/Ubuntu%20Slaves=ubuntu,jdk=JDK%201.7%20(latest),nsfixtures=SEGMENT_MK,profile=unittesting/1359/console] > {noformat} > java.lang.AssertionError: Query took too long: select a.[jcr:path] from > [nt:base] as a > left outer join [nt:base] as b on ischildnode(b, a) > where name(b) = 'b' took 13790 ms > at org.junit.Assert.fail(Assert.java:88) > at > org.apache.jackrabbit.oak.query.AbstractQueryTest.executeQuery(AbstractQueryTest.java:280) > at > org.apache.jackrabbit.oak.query.AbstractQueryTest.executeQuery(AbstractQueryTest.java:255) > at > org.apache.jackrabbit.oak.query.AbstractQueryTest.executeQuery(AbstractQueryTest.java:251) > at > org.apache.jackrabbit.oak.query.AbstractQueryTest.test(AbstractQueryTest.java:187) > at > org.apache.jackrabbit.oak.plugins.index.lucene.LuceneIndexQueryTest.sql2(LuceneIndexQueryTest.java:93) > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OAK-5451) Make IndexTracker public to enable its use in non OSGi environment
[ https://issues.apache.org/jira/browse/OAK-5451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15823509#comment-15823509 ] Chetan Mehrotra commented on OAK-5451: -- Did a change with 1778966. Let me know if that meets your requirements > Make IndexTracker public to enable its use in non OSGi environment > -- > > Key: OAK-5451 > URL: https://issues.apache.org/jira/browse/OAK-5451 > Project: Jackrabbit Oak > Issue Type: Task > Components: lucene >Affects Versions: 1.4.10 >Reporter: Volker Schmidt >Assignee: Chetan Mehrotra >Priority: Trivial > Fix For: 1.4.13 > > > Class IndexTracker is a package protected class that must be passed as an > argument to LuceneIndexMBeanImpl. For OSGi environments the MBean > LuceneIndexMBeanImpl is registered by LuceneIndexProviderService that is > located in the same package like IndexTracker. For nin OSGi environments > LuceneIndexMBeanImpl cannot be used, since class IndexTracker is not > accessible (except by implementing workarounds). > Either class IndexTracker should be public or the constructor argument of > LuceneIndexMBeanImpl should be LuceneIndexProvider. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OAK-5451) Make IndexTracker public to enable its use in non OSGi environment
[ https://issues.apache.org/jira/browse/OAK-5451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chetan Mehrotra updated OAK-5451: - Issue Type: Task (was: Bug) > Make IndexTracker public to enable its use in non OSGi environment > -- > > Key: OAK-5451 > URL: https://issues.apache.org/jira/browse/OAK-5451 > Project: Jackrabbit Oak > Issue Type: Task > Components: lucene >Affects Versions: 1.4.10 >Reporter: Volker Schmidt >Assignee: Chetan Mehrotra >Priority: Trivial > Fix For: 1.4.13 > > > Class IndexTracker is a package protected class that must be passed as an > argument to LuceneIndexMBeanImpl. For OSGi environments the MBean > LuceneIndexMBeanImpl is registered by LuceneIndexProviderService that is > located in the same package like IndexTracker. For nin OSGi environments > LuceneIndexMBeanImpl cannot be used, since class IndexTracker is not > accessible (except by implementing workarounds). > Either class IndexTracker should be public or the constructor argument of > LuceneIndexMBeanImpl should be LuceneIndexProvider. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OAK-5451) Make IndexTracker public to enable its use in non OSGi environment
[ https://issues.apache.org/jira/browse/OAK-5451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chetan Mehrotra updated OAK-5451: - Summary: Make IndexTracker public to enable its use in non OSGi environment (was: Class IndexTracker should not be package protected since LuceneIndexMBeanImpl cannot be used in non OSGi configurations) > Make IndexTracker public to enable its use in non OSGi environment > -- > > Key: OAK-5451 > URL: https://issues.apache.org/jira/browse/OAK-5451 > Project: Jackrabbit Oak > Issue Type: Bug > Components: lucene >Affects Versions: 1.4.10 >Reporter: Volker Schmidt >Assignee: Chetan Mehrotra >Priority: Trivial > Fix For: 1.4.13 > > > Class IndexTracker is a package protected class that must be passed as an > argument to LuceneIndexMBeanImpl. For OSGi environments the MBean > LuceneIndexMBeanImpl is registered by LuceneIndexProviderService that is > located in the same package like IndexTracker. For nin OSGi environments > LuceneIndexMBeanImpl cannot be used, since class IndexTracker is not > accessible (except by implementing workarounds). > Either class IndexTracker should be public or the constructor argument of > LuceneIndexMBeanImpl should be LuceneIndexProvider. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OAK-5451) Class IndexTracker should not be package protected since LuceneIndexMBeanImpl cannot be used in non OSGi configurations
[ https://issues.apache.org/jira/browse/OAK-5451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15823499#comment-15823499 ] Chetan Mehrotra commented on OAK-5451: -- Fair enough! Would change the scope of this class then for next release from 1.4 branch > Class IndexTracker should not be package protected since LuceneIndexMBeanImpl > cannot be used in non OSGi configurations > --- > > Key: OAK-5451 > URL: https://issues.apache.org/jira/browse/OAK-5451 > Project: Jackrabbit Oak > Issue Type: Bug > Components: lucene >Affects Versions: 1.4.10 >Reporter: Volker Schmidt >Assignee: Chetan Mehrotra >Priority: Trivial > Fix For: 1.4.13 > > > Class IndexTracker is a package protected class that must be passed as an > argument to LuceneIndexMBeanImpl. For OSGi environments the MBean > LuceneIndexMBeanImpl is registered by LuceneIndexProviderService that is > located in the same package like IndexTracker. For nin OSGi environments > LuceneIndexMBeanImpl cannot be used, since class IndexTracker is not > accessible (except by implementing workarounds). > Either class IndexTracker should be public or the constructor argument of > LuceneIndexMBeanImpl should be LuceneIndexProvider. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (OAK-5230) AsyncIndexService should ensure that async lanes should confirm to naming convention
[ https://issues.apache.org/jira/browse/OAK-5230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15823496#comment-15823496 ] Chetan Mehrotra edited comment on OAK-5230 at 1/16/17 6:01 AM: --- [patch|^OAK-5230-v1.patch] for the same. [~alex.parvulescu] Please review. One thing to note - For property index reindex the checkpoint name is "async-reindex". Not sure if remove orphaned checkpoint logic in oak-run should account for this case was (Author: chetanm): [patch|^OAK-5230-v1.patch] for the same. [~alex.parvulescu] Please review > AsyncIndexService should ensure that async lanes should confirm to naming > convention > > > Key: OAK-5230 > URL: https://issues.apache.org/jira/browse/OAK-5230 > Project: Jackrabbit Oak > Issue Type: Task > Components: core >Reporter: Chetan Mehrotra >Assignee: Chetan Mehrotra >Priority: Minor > Fix For: 1.5.18, 1.6 > > Attachments: OAK-5230-v1.patch > > > OAK-4043 added support to remove unreferenced checkpoints. There it follows > convention that all async names end with {{async}} e.g. async, fulltext-async > etc > This convention must be enforced in > * AsyncIndexerService > * Oak#withAsyncIndexing(java.lang.String, long) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OAK-5230) AsyncIndexService should ensure that async lanes should confirm to naming convention
[ https://issues.apache.org/jira/browse/OAK-5230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chetan Mehrotra updated OAK-5230: - Attachment: OAK-5230-v1.patch [patch|^OAK-5230-v1.patch] for the same. [~alex.parvulescu] Please review > AsyncIndexService should ensure that async lanes should confirm to naming > convention > > > Key: OAK-5230 > URL: https://issues.apache.org/jira/browse/OAK-5230 > Project: Jackrabbit Oak > Issue Type: Task > Components: core >Reporter: Chetan Mehrotra >Assignee: Chetan Mehrotra >Priority: Minor > Fix For: 1.5.18, 1.6 > > Attachments: OAK-5230-v1.patch > > > OAK-4043 added support to remove unreferenced checkpoints. There it follows > convention that all async names end with {{async}} e.g. async, fulltext-async > etc > This convention must be enforced in > * AsyncIndexerService > * Oak#withAsyncIndexing(java.lang.String, long) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OAK-5451) Class IndexTracker should not be package protected since LuceneIndexMBeanImpl cannot be used in non OSGi configurations
[ https://issues.apache.org/jira/browse/OAK-5451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15823494#comment-15823494 ] Chetan Mehrotra commented on OAK-5451: -- That example would configure a bare minimum Lucene indexing support which would not give good performance as it does not enable Copy-on-read and copy-on-write feature support for index files. For getting the best performance it would be better to use the approach as explained in standalone example > Class IndexTracker should not be package protected since LuceneIndexMBeanImpl > cannot be used in non OSGi configurations > --- > > Key: OAK-5451 > URL: https://issues.apache.org/jira/browse/OAK-5451 > Project: Jackrabbit Oak > Issue Type: Bug > Components: lucene >Affects Versions: 1.4.10 >Reporter: Volker Schmidt >Assignee: Chetan Mehrotra >Priority: Trivial > Fix For: 1.4.13 > > > Class IndexTracker is a package protected class that must be passed as an > argument to LuceneIndexMBeanImpl. For OSGi environments the MBean > LuceneIndexMBeanImpl is registered by LuceneIndexProviderService that is > located in the same package like IndexTracker. For nin OSGi environments > LuceneIndexMBeanImpl cannot be used, since class IndexTracker is not > accessible (except by implementing workarounds). > Either class IndexTracker should be public or the constructor argument of > LuceneIndexMBeanImpl should be LuceneIndexProvider. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OAK-5441) Test failure: BasicServerTest.testServerOk() Address already in use
[ https://issues.apache.org/jira/browse/OAK-5441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15823491#comment-15823491 ] Chetan Mehrotra commented on OAK-5441: -- It does uses a random port via maven-build-helper-plugin. Looks like a race condition between time at which this port was detected free and when its used {noformat} [INFO] --- build-helper-maven-plugin:1.7:reserve-network-port (reserve-network-port) @ oak-run --- [INFO] Reserved port 54575 for jetty.http.port {noformat} > Test failure: BasicServerTest.testServerOk() Address already in use > --- > > Key: OAK-5441 > URL: https://issues.apache.org/jira/browse/OAK-5441 > Project: Jackrabbit Oak > Issue Type: Bug > Components: continuous integration, run >Reporter: Hudson > Fix For: 1.6 > > > Jenkins CI failure: > https://builds.apache.org/job/Apache%20Jackrabbit%20Oak%20matrix/ > The build Apache Jackrabbit Oak matrix/Ubuntu Slaves=ubuntu,jdk=JDK 1.8 > (latest),nsfixtures=DOCUMENT_RDB,profile=unittesting #1363 has failed. > First failed run: [Apache Jackrabbit Oak matrix/Ubuntu Slaves=ubuntu,jdk=JDK > 1.8 (latest),nsfixtures=DOCUMENT_RDB,profile=unittesting > #1363|https://builds.apache.org/job/Apache%20Jackrabbit%20Oak%20matrix/Ubuntu%20Slaves=ubuntu,jdk=JDK%201.8%20(latest),nsfixtures=DOCUMENT_RDB,profile=unittesting/1363/] > [console > log|https://builds.apache.org/job/Apache%20Jackrabbit%20Oak%20matrix/Ubuntu%20Slaves=ubuntu,jdk=JDK%201.8%20(latest),nsfixtures=DOCUMENT_RDB,profile=unittesting/1363/console] -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OAK-5454) Failed test: org.apache.jackrabbit.oak.plugins.blob.CachingDataStoreTest.zeroStagingCacheAddGetDelete
Amit Jain created OAK-5454: -- Summary: Failed test: org.apache.jackrabbit.oak.plugins.blob.CachingDataStoreTest.zeroStagingCacheAddGetDelete Key: OAK-5454 URL: https://issues.apache.org/jira/browse/OAK-5454 Project: Jackrabbit Oak Issue Type: Bug Components: blob Reporter: Amit Jain Assignee: Amit Jain Fix For: 1.5.18 Failed in build https://builds.apache.org/job/Apache%20Jackrabbit%20Oak%20matrix/1367/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (OAK-5453) Build Apache Jackrabbit Oak matrix/Ubuntu Slaves=ubuntu,jdk=JDK 1.8 (latest),nsfixtures=DOCUMENT_RDB,profile=integrationTesting #1368 failed
[ https://issues.apache.org/jira/browse/OAK-5453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chetan Mehrotra resolved OAK-5453. -- Resolution: Duplicate > Build Apache Jackrabbit Oak matrix/Ubuntu Slaves=ubuntu,jdk=JDK 1.8 > (latest),nsfixtures=DOCUMENT_RDB,profile=integrationTesting #1368 failed > > > Key: OAK-5453 > URL: https://issues.apache.org/jira/browse/OAK-5453 > Project: Jackrabbit Oak > Issue Type: Bug > Components: continuous integration >Reporter: Hudson > > Jenkins CI failure: > https://builds.apache.org/job/Apache%20Jackrabbit%20Oak%20matrix/ > The build Apache Jackrabbit Oak matrix/Ubuntu Slaves=ubuntu,jdk=JDK 1.8 > (latest),nsfixtures=DOCUMENT_RDB,profile=integrationTesting #1368 has failed. > First failed run: [Apache Jackrabbit Oak matrix/Ubuntu Slaves=ubuntu,jdk=JDK > 1.8 (latest),nsfixtures=DOCUMENT_RDB,profile=integrationTesting > #1368|https://builds.apache.org/job/Apache%20Jackrabbit%20Oak%20matrix/Ubuntu%20Slaves=ubuntu,jdk=JDK%201.8%20(latest),nsfixtures=DOCUMENT_RDB,profile=integrationTesting/1368/] > [console > log|https://builds.apache.org/job/Apache%20Jackrabbit%20Oak%20matrix/Ubuntu%20Slaves=ubuntu,jdk=JDK%201.8%20(latest),nsfixtures=DOCUMENT_RDB,profile=integrationTesting/1368/console] -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OAK-5453) Build Apache Jackrabbit Oak matrix/Ubuntu Slaves=ubuntu,jdk=JDK 1.8 (latest),nsfixtures=DOCUMENT_RDB,profile=integrationTesting #1368 failed
[ https://issues.apache.org/jira/browse/OAK-5453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15823471#comment-15823471 ] Chetan Mehrotra commented on OAK-5453: -- Failure in org.apache.jackrabbit.oak.segment.standby.StandbyTestIT.testSyncLoop > Build Apache Jackrabbit Oak matrix/Ubuntu Slaves=ubuntu,jdk=JDK 1.8 > (latest),nsfixtures=DOCUMENT_RDB,profile=integrationTesting #1368 failed > > > Key: OAK-5453 > URL: https://issues.apache.org/jira/browse/OAK-5453 > Project: Jackrabbit Oak > Issue Type: Bug > Components: continuous integration >Reporter: Hudson > > Jenkins CI failure: > https://builds.apache.org/job/Apache%20Jackrabbit%20Oak%20matrix/ > The build Apache Jackrabbit Oak matrix/Ubuntu Slaves=ubuntu,jdk=JDK 1.8 > (latest),nsfixtures=DOCUMENT_RDB,profile=integrationTesting #1368 has failed. > First failed run: [Apache Jackrabbit Oak matrix/Ubuntu Slaves=ubuntu,jdk=JDK > 1.8 (latest),nsfixtures=DOCUMENT_RDB,profile=integrationTesting > #1368|https://builds.apache.org/job/Apache%20Jackrabbit%20Oak%20matrix/Ubuntu%20Slaves=ubuntu,jdk=JDK%201.8%20(latest),nsfixtures=DOCUMENT_RDB,profile=integrationTesting/1368/] > [console > log|https://builds.apache.org/job/Apache%20Jackrabbit%20Oak%20matrix/Ubuntu%20Slaves=ubuntu,jdk=JDK%201.8%20(latest),nsfixtures=DOCUMENT_RDB,profile=integrationTesting/1368/console] -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (OAK-5445) Log the path of LuceneDoc while adding it to queue
[ https://issues.apache.org/jira/browse/OAK-5445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chetan Mehrotra resolved OAK-5445. -- Resolution: Fixed > Log the path of LuceneDoc while adding it to queue > -- > > Key: OAK-5445 > URL: https://issues.apache.org/jira/browse/OAK-5445 > Project: Jackrabbit Oak > Issue Type: Task >Reporter: Chetan Mehrotra >Assignee: Chetan Mehrotra >Priority: Minor > Fix For: 1.5.18, 1.6 > > > For Hybrid indexing case it would be good to log the path of LuceneDoc along > with size of queue at time of adding. This would help in seeing how much time > the doc spent in queue -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (OAK-5448) Aggregate logic should optimize for case where patterns do not include wildcard
[ https://issues.apache.org/jira/browse/OAK-5448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chetan Mehrotra resolved OAK-5448. -- Resolution: Fixed > Aggregate logic should optimize for case where patterns do not include > wildcard > --- > > Key: OAK-5448 > URL: https://issues.apache.org/jira/browse/OAK-5448 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: lucene >Reporter: Chetan Mehrotra >Assignee: Chetan Mehrotra > Fix For: 1.5.18, 1.6 > > Attachments: OAK-5448.patch > > > Aggregate logic in oak-lucene currently tries to apply matcher on each of the > child node of a modified parent node. This is required for those case where > pattern involves wild card like aggregating '\*/\*/\*' pattern. > However this performs poorly if the aggregate does not involve pattern. For > e.g. if we have defined a property definition for 'jcr:content/@status' for > nt:base > {noformat} > + indexRules >+ nt:base > + properties > + status > - name = "jcr:content/status" > - propertyIndex = true > {noformat} > For above definition current logic would try to apply the matcher for > 'jcr:content' on each of the child nodes. So if we have a folder have 1000 > entries it would read that many child nodes. > As a fix we should check if the aggregate path has wild card or not. if its > specific then aggregate logic should directly lookup child with given name -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (OAK-5451) Class IndexTracker should not be package protected since LuceneIndexMBeanImpl cannot be used in non OSGi configurations
[ https://issues.apache.org/jira/browse/OAK-5451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15823454#comment-15823454 ] Chetan Mehrotra edited comment on OAK-5451 at 1/16/17 4:37 AM: --- [~vschmidt] Changing the visibility of class is possible however I am interested in knowing how you are setting up Oak. As configuring Lucene setup programatically is tricky and one needs to know the code based quite a bit to get it right (OAK-5435 would try to simplify it) For non OSGi setup you can use the approach as demonstrated in [1] which would allow one to use Oak OSGi based setup support in non OSGi env. In such a case you would not need to configure IndexTracker directly [1] https://github.com/apache/jackrabbit-oak/tree/trunk/oak-examples/standalone was (Author: chetanm): [~vschmidt] Changing the visibility of class is not a problem however I am interested in knowing how you are setting up Oak. As configuring Lucene setup programatically is tricky and one needs to know the code based quite a bit to get it right (OAK-5435 would try to simplify it) For non OSGi setup you can use the approach as demonstrated in [1] which would allow one to use Oak OSGi based setup support in non OSGi env. In such a case you would not need to configure IndexTracker directly [1] https://github.com/apache/jackrabbit-oak/tree/trunk/oak-examples/standalone > Class IndexTracker should not be package protected since LuceneIndexMBeanImpl > cannot be used in non OSGi configurations > --- > > Key: OAK-5451 > URL: https://issues.apache.org/jira/browse/OAK-5451 > Project: Jackrabbit Oak > Issue Type: Bug > Components: lucene >Affects Versions: 1.4.10 >Reporter: Volker Schmidt >Assignee: Chetan Mehrotra >Priority: Trivial > Fix For: 1.4.13 > > > Class IndexTracker is a package protected class that must be passed as an > argument to LuceneIndexMBeanImpl. For OSGi environments the MBean > LuceneIndexMBeanImpl is registered by LuceneIndexProviderService that is > located in the same package like IndexTracker. For nin OSGi environments > LuceneIndexMBeanImpl cannot be used, since class IndexTracker is not > accessible (except by implementing workarounds). > Either class IndexTracker should be public or the constructor argument of > LuceneIndexMBeanImpl should be LuceneIndexProvider. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OAK-5451) Class IndexTracker should not be package protected since LuceneIndexMBeanImpl cannot be used in non OSGi configurations
[ https://issues.apache.org/jira/browse/OAK-5451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chetan Mehrotra updated OAK-5451: - Fix Version/s: 1.4.13 > Class IndexTracker should not be package protected since LuceneIndexMBeanImpl > cannot be used in non OSGi configurations > --- > > Key: OAK-5451 > URL: https://issues.apache.org/jira/browse/OAK-5451 > Project: Jackrabbit Oak > Issue Type: Bug > Components: lucene >Affects Versions: 1.4.10 >Reporter: Volker Schmidt >Assignee: Chetan Mehrotra >Priority: Trivial > Fix For: 1.4.13 > > > Class IndexTracker is a package protected class that must be passed as an > argument to LuceneIndexMBeanImpl. For OSGi environments the MBean > LuceneIndexMBeanImpl is registered by LuceneIndexProviderService that is > located in the same package like IndexTracker. For nin OSGi environments > LuceneIndexMBeanImpl cannot be used, since class IndexTracker is not > accessible (except by implementing workarounds). > Either class IndexTracker should be public or the constructor argument of > LuceneIndexMBeanImpl should be LuceneIndexProvider. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OAK-5451) Class IndexTracker should not be package protected since LuceneIndexMBeanImpl cannot be used in non OSGi configurations
[ https://issues.apache.org/jira/browse/OAK-5451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15823454#comment-15823454 ] Chetan Mehrotra commented on OAK-5451: -- [~vschmidt] Changing the visibility of class is not a problem however I am interested in knowing how you are setting up Oak. As configuring Lucene setup programatically is tricky and one needs to know the code based quite a bit to get it right (OAK-5435 would try to simplify it) For non OSGi setup you can use the approach as demonstrated in [1] which would allow one to use Oak OSGi based setup support in non OSGi env. In such a case you would not need to configure IndexTracker directly [1] https://github.com/apache/jackrabbit-oak/tree/trunk/oak-examples/standalone > Class IndexTracker should not be package protected since LuceneIndexMBeanImpl > cannot be used in non OSGi configurations > --- > > Key: OAK-5451 > URL: https://issues.apache.org/jira/browse/OAK-5451 > Project: Jackrabbit Oak > Issue Type: Bug > Components: lucene >Affects Versions: 1.4.10 >Reporter: Volker Schmidt >Assignee: Chetan Mehrotra >Priority: Trivial > > Class IndexTracker is a package protected class that must be passed as an > argument to LuceneIndexMBeanImpl. For OSGi environments the MBean > LuceneIndexMBeanImpl is registered by LuceneIndexProviderService that is > located in the same package like IndexTracker. For nin OSGi environments > LuceneIndexMBeanImpl cannot be used, since class IndexTracker is not > accessible (except by implementing workarounds). > Either class IndexTracker should be public or the constructor argument of > LuceneIndexMBeanImpl should be LuceneIndexProvider. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OAK-5210) Ability to resolve principal name from ExternalIdentityRef without IDP roundtrip
[ https://issues.apache.org/jira/browse/OAK-5210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15823337#comment-15823337 ] Tobias Bocanegra commented on OAK-5210: --- +1 patch looks good to me. > Ability to resolve principal name from ExternalIdentityRef without IDP > roundtrip > > > Key: OAK-5210 > URL: https://issues.apache.org/jira/browse/OAK-5210 > Project: Jackrabbit Oak > Issue Type: New Feature > Components: auth-external >Reporter: angela >Assignee: angela > Attachments: OAK-5210-initialdraft.patch > > > Currently the only way to reliably determine the principal name for a given > external identity is by calling {{ExternalIdentity.getPrincipalName()}}. This > also means that there is currently no way to resolve the principal name from > a given {{ExternalIdentityRef}}, without calling > {{ExternalIdentityProvider.getIdentity(ExternalIdentityRef)}}. > In the default sync mode a given identity-ref will always be resolved to the > associated identity once a given identity is up for (re)sync and thus the > identity resolution is part of the synchronization. On the other hand the > partial sync as provided by the {{DynamicSyncContext}} doesn't require the > resolution of group identities but only needs to be able to obtain the > principal name, which is needed to proper populate the subject upon > repository login (and for permission setup for those group principals). In > this setup it would be preferrable if the principal name could be resolved > from the {{ExternalIdentityRef}} without the intermediate identity resolution. > This aim of this issue is to discuss the different options on how to achieve > this improvement in a generic way that doesn't make any assumptions regarding > the relationship between {{ExternalIdentity.getId}}, > {{ExternalIdentity.getPrincipalName}} and {{ExternalIdentityRef.getId}}. > See also OAK-4930 and OAK-5200 for additional information. -- This message was sent by Atlassian JIRA (v6.3.4#6332)