[jira] [Commented] (OAK-6963) Build Jackrabbit Oak #988 failed
[ https://issues.apache.org/jira/browse/OAK-6963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16262920#comment-16262920 ] Hudson commented on OAK-6963: - Previously failing build now is OK. Passed run: [Jackrabbit Oak #1002|https://builds.apache.org/job/Jackrabbit%20Oak/1002/] [console log|https://builds.apache.org/job/Jackrabbit%20Oak/1002/console] > Build Jackrabbit Oak #988 failed > > > Key: OAK-6963 > URL: https://issues.apache.org/jira/browse/OAK-6963 > Project: Jackrabbit Oak > Issue Type: Bug > Components: continuous integration >Reporter: Hudson > > No description is provided > The build Jackrabbit Oak #988 has failed. > First failed run: [Jackrabbit Oak > #988|https://builds.apache.org/job/Jackrabbit%20Oak/988/] [console > log|https://builds.apache.org/job/Jackrabbit%20Oak/988/console] -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (OAK-6974) RDBDocumentSerializer: factor out columnProperties
Julian Reschke created OAK-6974: --- Summary: RDBDocumentSerializer: factor out columnProperties Key: OAK-6974 URL: https://issues.apache.org/jira/browse/OAK-6974 Project: Jackrabbit Oak Issue Type: Technical task Components: rdbmk Reporter: Julian Reschke Assignee: Julian Reschke ...because they might vary based on the table in the future. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OAK-4518) ConcurrentAddReferenceTest fails occasionally
[ https://issues.apache.org/jira/browse/OAK-4518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16262890#comment-16262890 ] Marcel Reutegger commented on OAK-4518: --- Merged into branches: - 1.4: http://svn.apache.org/r1816067 > ConcurrentAddReferenceTest fails occasionally > - > > Key: OAK-4518 > URL: https://issues.apache.org/jira/browse/OAK-4518 > Project: Jackrabbit Oak > Issue Type: Bug > Components: core, documentmk >Affects Versions: 1.4 >Reporter: Marcel Reutegger >Assignee: Marcel Reutegger >Priority: Minor > Labels: candidate_oak_1_0, candidate_oak_1_2 > Fix For: 1.5.6, 1.6.0, 1.4.19 > > Attachments: OAK-4518-test.patch > > > Occasional test failures have already been reported in OAK-1472, but it still > fails every now and > [then|https://travis-ci.org/apache/jackrabbit-oak/builds/140501786]. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OAK-4518) ConcurrentAddReferenceTest fails occasionally
[ https://issues.apache.org/jira/browse/OAK-4518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcel Reutegger updated OAK-4518: -- Labels: candidate_oak_1_0 candidate_oak_1_2 (was: candidate_oak_1_0 candidate_oak_1_2 candidate_oak_1_4) Fix Version/s: 1.4.19 > ConcurrentAddReferenceTest fails occasionally > - > > Key: OAK-4518 > URL: https://issues.apache.org/jira/browse/OAK-4518 > Project: Jackrabbit Oak > Issue Type: Bug > Components: core, documentmk >Affects Versions: 1.4 >Reporter: Marcel Reutegger >Assignee: Marcel Reutegger >Priority: Minor > Labels: candidate_oak_1_0, candidate_oak_1_2 > Fix For: 1.5.6, 1.6.0, 1.4.19 > > Attachments: OAK-4518-test.patch > > > Occasional test failures have already been reported in OAK-1472, but it still > fails every now and > [then|https://travis-ci.org/apache/jackrabbit-oak/builds/140501786]. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OAK-6973) Define public/internal packages
[ https://issues.apache.org/jira/browse/OAK-6973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16262842#comment-16262842 ] Marcel Reutegger commented on OAK-6973: --- E.g. something like the Guava [Beta|https://google.github.io/guava/releases/18.0/api/docs/com/google/common/annotations/Beta.html] annotation. > Define public/internal packages > --- > > Key: OAK-6973 > URL: https://issues.apache.org/jira/browse/OAK-6973 > Project: Jackrabbit Oak > Issue Type: Task >Reporter: Marcel Reutegger > Fix For: 1.8 > > > As part of the Oak modularization packages previously exported without a > version will at some point have to adhere to proper semantic versioning. See > also OAK-3919 and its sub-tasks. > Since some of those packages are not meant to be used outside of Oak, there > should be a mechanism to define which exported packages are public and which > are considered internal. While semantic versioning rules apply to both > categories, we may want to provide different guarantees/guidance to consumers > of those packages. E.g. increasing the major version of a package used only > by Oak has less impact compared to a major version increase of a 'public' > package used by many applications. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (OAK-6818) TokenAuthentication/TokenProviderImpl: cleanup expired tokens
[
https://issues.apache.org/jira/browse/OAK-6818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Deparvu resolved OAK-6818.
---
Resolution: Fixed
fixed with r1816064 also updated the docs. Angela please check if it looks good!
> TokenAuthentication/TokenProviderImpl: cleanup expired tokens
> -
>
> Key: OAK-6818
> URL: https://issues.apache.org/jira/browse/OAK-6818
> Project: Jackrabbit Oak
> Issue Type: New Feature
> Components: core, security
>Reporter: angela
>Assignee: angela
> Fix For: 1.8
>
> Attachments: OAK-6818-osgi-test.patch, OAK-6818.patch
>
>
> During token based authentication a given token node gets removed if it is
> found to have expired in the mean time:
> Extract from {{TokenAuthentication.validateCredentials(TokenCredentials)}} as
> it works today:
> {code}
>[...]
> if (tokenInfo.isExpired(loginTime)) {
> tokenInfo.remove();
> return false;
> }
>[...]
> {code}
> However, this doesn't cope with those cases where expired tokens are being
> left behind without ever being caught by cleanup (e.g. new token issued and
> never try to login with expired token). So, this issue is about an extension
> that would allow to somehow/somewhen cleanup those tokens during
> authentication. In order not to cause extra overhead to the login we should
> set a limit (e.g. number of token nodes) that would only trigger the cleanup
> every now and then and not doing it all the time.
> What also needs to be clarified/investigated: would cleanup only be triggered
> in case of a failure?
> cc: [~stillalex], [~tmueller], [~chetanm], [~asanso]
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OAK-6973) Define public/internal packages
[ https://issues.apache.org/jira/browse/OAK-6973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16262830#comment-16262830 ] Marcel Reutegger commented on OAK-6973: --- Potential solutions discussed offline: - Use annotations to mark Oak internal packages - Create a public Oak API jar containing only supported/public packages > Define public/internal packages > --- > > Key: OAK-6973 > URL: https://issues.apache.org/jira/browse/OAK-6973 > Project: Jackrabbit Oak > Issue Type: Task >Reporter: Marcel Reutegger > Fix For: 1.8 > > > As part of the Oak modularization packages previously exported without a > version will at some point have to adhere to proper semantic versioning. See > also OAK-3919 and its sub-tasks. > Since some of those packages are not meant to be used outside of Oak, there > should be a mechanism to define which exported packages are public and which > are considered internal. While semantic versioning rules apply to both > categories, we may want to provide different guarantees/guidance to consumers > of those packages. E.g. increasing the major version of a package used only > by Oak has less impact compared to a major version increase of a 'public' > package used by many applications. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (OAK-6973) Define public/internal packages
Marcel Reutegger created OAK-6973: - Summary: Define public/internal packages Key: OAK-6973 URL: https://issues.apache.org/jira/browse/OAK-6973 Project: Jackrabbit Oak Issue Type: Task Reporter: Marcel Reutegger Fix For: 1.8 As part of the Oak modularization packages previously exported without a version will at some point have to adhere to proper semantic versioning. See also OAK-3919 and its sub-tasks. Since some of those packages are not meant to be used outside of Oak, there should be a mechanism to define which exported packages are public and which are considered internal. While semantic versioning rules apply to both categories, we may want to provide different guarantees/guidance to consumers of those packages. E.g. increasing the major version of a package used only by Oak has less impact compared to a major version increase of a 'public' package used by many applications. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OAK-6221) Deprecate SecurityProviderImpl
[
https://issues.apache.org/jira/browse/OAK-6221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16262820#comment-16262820
]
angela commented on OAK-6221:
-
[~stillalex], doesn't the builder somehow duplicate the logic from
{{SecurityProviderRegistration}}. And wouldn't it be better to just keep that
in the test-packages? I admit that the patch is already getting huge and
merging it would make it even bigger... so maybe putting it in a test-only
environement in a first step would be better. wdyt? after all benchmarks also
are just some sort of tests aren't they?
> Deprecate SecurityProviderImpl
> --
>
> Key: OAK-6221
> URL: https://issues.apache.org/jira/browse/OAK-6221
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: core, security
>Reporter: Alex Deparvu
>Assignee: Alex Deparvu
>
> As agreed on OAK-6172, the {{SecurityProviderImpl}} should be deprecated in
> favor of the {{InternalSecurityProvider}}.
> This should also cover coming up with a way to use the new version in tests
> while we figure out OSGi testing setups.
> fyi [~anchela]
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (OAK-4518) ConcurrentAddReferenceTest fails occasionally
[ https://issues.apache.org/jira/browse/OAK-4518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcel Reutegger updated OAK-4518: -- Labels: candidate_oak_1_0 candidate_oak_1_2 candidate_oak_1_4 (was: ) > ConcurrentAddReferenceTest fails occasionally > - > > Key: OAK-4518 > URL: https://issues.apache.org/jira/browse/OAK-4518 > Project: Jackrabbit Oak > Issue Type: Bug > Components: core, documentmk >Affects Versions: 1.4 >Reporter: Marcel Reutegger >Assignee: Marcel Reutegger >Priority: Minor > Labels: candidate_oak_1_0, candidate_oak_1_2, candidate_oak_1_4 > Fix For: 1.5.6, 1.6.0 > > Attachments: OAK-4518-test.patch > > > Occasional test failures have already been reported in OAK-1472, but it still > fails every now and > [then|https://travis-ci.org/apache/jackrabbit-oak/builds/140501786]. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OAK-6963) Build Jackrabbit Oak #988 failed
[ https://issues.apache.org/jira/browse/OAK-6963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16262717#comment-16262717 ] Hudson commented on OAK-6963: - Previously failing build now is OK. Passed run: [Jackrabbit Oak #1001|https://builds.apache.org/job/Jackrabbit%20Oak/1001/] [console log|https://builds.apache.org/job/Jackrabbit%20Oak/1001/console] > Build Jackrabbit Oak #988 failed > > > Key: OAK-6963 > URL: https://issues.apache.org/jira/browse/OAK-6963 > Project: Jackrabbit Oak > Issue Type: Bug > Components: continuous integration >Reporter: Hudson > > No description is provided > The build Jackrabbit Oak #988 has failed. > First failed run: [Jackrabbit Oak > #988|https://builds.apache.org/job/Jackrabbit%20Oak/988/] [console > log|https://builds.apache.org/job/Jackrabbit%20Oak/988/console] -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (OAK-6342) Cost overrides for Lucene index not always working
[
https://issues.apache.org/jira/browse/OAK-6342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Mueller resolved OAK-6342.
-
Resolution: Cannot Reproduce
I can't currently reproduce the problem for "costPerExecution" and
"costPerEntry": those properties work as expected, if "refresh" is set to true.
The "weight" didn't have an impact in the cases I tested, but I think with the
recent changes for cost estimation, I don't think that's a problem even if this
doesn't work (not sure, maybe just my test case is wrong).
> Cost overrides for Lucene index not always working
> --
>
> Key: OAK-6342
> URL: https://issues.apache.org/jira/browse/OAK-6342
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: lucene, query
>Reporter: Thomas Mueller
>Assignee: Thomas Mueller
> Fix For: 1.8
>
>
> The cost overrides for the Lucene (compatVersion 2) index don't seem to work
> always. All features (costPerEntry, costPerExecution, entryCount which is
> undocumented) seem to be ignored for the query:
> {noformat}
> /jcr:root/replication//*[jcr:like(@sling:resourceType, "replication//%agent")]
> index rule:
> http://localhost:4502/oak:index/lucene/indexRules/nt:base/properties/resourceType.tidy.-1.json
> {
> "jcr:primaryType": "nt:unstructured",
> "propertyIndex": "true",
> "weight": "0",
> "name": "sling:resourceType"
> }
> cost for lucene-property[/oak:index/lucene] is 501.0
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Resolved] (OAK-6969) Reduce the responsibilities of CompactCommand in favour of Compact
[ https://issues.apache.org/jira/browse/OAK-6969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francesco Mari resolved OAK-6969. - Resolution: Fixed Fix Version/s: (was: 1.7.13) 1.7.12 Fixed at r1816056. > Reduce the responsibilities of CompactCommand in favour of Compact > -- > > Key: OAK-6969 > URL: https://issues.apache.org/jira/browse/OAK-6969 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: run, segment-tar >Reporter: Francesco Mari >Assignee: Francesco Mari > Fix For: 1.8, 1.7.12 > > > The offline compaction tool frontend has responsibilities that should be > moved to the backend. In particular, printing progress and error messages, > implementing logic based on the input parameters and the environment, and > choosing exit status codes should be implemented by the backend. > While CompactCommand was reasonable when both oak-segment and oak-segment-tar > coexisted, the current implementation violates responsibility and makes the > tool frontend needlessly complicated. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OAK-5927) Load excerpt lazily
[
https://issues.apache.org/jira/browse/OAK-5927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16262513#comment-16262513
]
Tommaso Teofili commented on OAK-5927:
--
[~chetanm] I think I may have a look at this in 3 or 4 weeks, so probably still
in time for 1.8, but I can't say for sure.
> Load excerpt lazily
> ---
>
> Key: OAK-5927
> URL: https://issues.apache.org/jira/browse/OAK-5927
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: lucene
>Reporter: Chetan Mehrotra
> Labels: performance
> Fix For: 1.8
>
>
> Currently LucenePropertyIndex loads the excerpt eagerly in batch as part of
> loadDocs call. The load docs batch size doubles starting from 50 (max 100k)
> as more data is read.
> We should look into ways to make the excerpt loaded lazily as and when caller
> ask for excerpt.
> Note that currently the excerpt are only loaded when query request for
> excerpt i.e. there is a not null property restriction for {{rep:excerpt}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OAK-6963) Build Jackrabbit Oak #988 failed
[ https://issues.apache.org/jira/browse/OAK-6963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16262471#comment-16262471 ] Hudson commented on OAK-6963: - Previously failing build now is OK. Passed run: [Jackrabbit Oak #1000|https://builds.apache.org/job/Jackrabbit%20Oak/1000/] [console log|https://builds.apache.org/job/Jackrabbit%20Oak/1000/console] > Build Jackrabbit Oak #988 failed > > > Key: OAK-6963 > URL: https://issues.apache.org/jira/browse/OAK-6963 > Project: Jackrabbit Oak > Issue Type: Bug > Components: continuous integration >Reporter: Hudson > > No description is provided > The build Jackrabbit Oak #988 has failed. > First failed run: [Jackrabbit Oak > #988|https://builds.apache.org/job/Jackrabbit%20Oak/988/] [console > log|https://builds.apache.org/job/Jackrabbit%20Oak/988/console] -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (OAK-6953) CacheLIRS cannot be disabled
[ https://issues.apache.org/jira/browse/OAK-6953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16260835#comment-16260835 ] Marcel Reutegger edited comment on OAK-6953 at 11/22/17 12:29 PM: -- Merged into branches: - 1.6: http://svn.apache.org/r1815930 - 1.4: http://svn.apache.org/r1815941 - 1.2: http://svn.apache.org/r1816012 - 1.0: http://svn.apache.org/r1816047 was (Author: mreutegg): Merged into branches: - 1.6: http://svn.apache.org/r1815930 - 1.4: http://svn.apache.org/r1815941 - 1.2: http://svn.apache.org/r1816012 > CacheLIRS cannot be disabled > > > Key: OAK-6953 > URL: https://issues.apache.org/jira/browse/OAK-6953 > Project: Jackrabbit Oak > Issue Type: Bug > Components: documentmk >Reporter: Marcel Reutegger >Assignee: Marcel Reutegger >Priority: Minor > Fix For: 1.8, 1.2.28, 1.0.40, 1.4.19, 1.7.12, 1.6.7 > > > The CacheLIRS cannot be disabled by setting the maxWeight to zero whereas the > Guava implementation can be disabled this way. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OAK-6953) CacheLIRS cannot be disabled
[ https://issues.apache.org/jira/browse/OAK-6953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcel Reutegger updated OAK-6953: -- Labels: (was: candidate_oak_1_0) Fix Version/s: 1.0.40 > CacheLIRS cannot be disabled > > > Key: OAK-6953 > URL: https://issues.apache.org/jira/browse/OAK-6953 > Project: Jackrabbit Oak > Issue Type: Bug > Components: documentmk >Reporter: Marcel Reutegger >Assignee: Marcel Reutegger >Priority: Minor > Fix For: 1.8, 1.2.28, 1.0.40, 1.4.19, 1.7.12, 1.6.7 > > > The CacheLIRS cannot be disabled by setting the maxWeight to zero whereas the > Guava implementation can be disabled this way. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OAK-6963) Build Jackrabbit Oak #988 failed
[ https://issues.apache.org/jira/browse/OAK-6963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16262371#comment-16262371 ] Hudson commented on OAK-6963: - Previously failing build now is OK. Passed run: [Jackrabbit Oak #999|https://builds.apache.org/job/Jackrabbit%20Oak/999/] [console log|https://builds.apache.org/job/Jackrabbit%20Oak/999/console] > Build Jackrabbit Oak #988 failed > > > Key: OAK-6963 > URL: https://issues.apache.org/jira/browse/OAK-6963 > Project: Jackrabbit Oak > Issue Type: Bug > Components: continuous integration >Reporter: Hudson > > No description is provided > The build Jackrabbit Oak #988 has failed. > First failed run: [Jackrabbit Oak > #988|https://builds.apache.org/job/Jackrabbit%20Oak/988/] [console > log|https://builds.apache.org/job/Jackrabbit%20Oak/988/console] -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OAK-6818) TokenAuthentication/TokenProviderImpl: cleanup expired tokens
[
https://issues.apache.org/jira/browse/OAK-6818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16262351#comment-16262351
]
angela commented on OAK-6818:
-
[~stillalex], oh... thanks.
for the record what we discussed just in private: we agreed that we want to
keep the threshold in order to avoid be able to somehow control the clean
despite the additional randomness that might cause questions about cleanup not
being triggered despite the treshold being reached.
do you want to commit the patch? I would then adjust the documentation at
http://jackrabbit.apache.org/oak/docs/security/authentication/token/default.html.
> TokenAuthentication/TokenProviderImpl: cleanup expired tokens
> -
>
> Key: OAK-6818
> URL: https://issues.apache.org/jira/browse/OAK-6818
> Project: Jackrabbit Oak
> Issue Type: New Feature
> Components: core, security
>Reporter: angela
>Assignee: angela
> Fix For: 1.8
>
> Attachments: OAK-6818-osgi-test.patch, OAK-6818.patch
>
>
> During token based authentication a given token node gets removed if it is
> found to have expired in the mean time:
> Extract from {{TokenAuthentication.validateCredentials(TokenCredentials)}} as
> it works today:
> {code}
>[...]
> if (tokenInfo.isExpired(loginTime)) {
> tokenInfo.remove();
> return false;
> }
>[...]
> {code}
> However, this doesn't cope with those cases where expired tokens are being
> left behind without ever being caught by cleanup (e.g. new token issued and
> never try to login with expired token). So, this issue is about an extension
> that would allow to somehow/somewhen cleanup those tokens during
> authentication. In order not to cause extra overhead to the login we should
> set a limit (e.g. number of token nodes) that would only trigger the cleanup
> every now and then and not doing it all the time.
> What also needs to be clarified/investigated: would cleanup only be triggered
> in case of a failure?
> cc: [~stillalex], [~tmueller], [~chetanm], [~asanso]
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OAK-6818) TokenAuthentication/TokenProviderImpl: cleanup expired tokens
[
https://issues.apache.org/jira/browse/OAK-6818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16262320#comment-16262320
]
Alex Deparvu commented on OAK-6818:
---
you can find here the updated version with the bench & new skip [0].
[0] https://github.com/apache/jackrabbit-oak/compare/trunk...stillalex:OAK-6818
> TokenAuthentication/TokenProviderImpl: cleanup expired tokens
> -
>
> Key: OAK-6818
> URL: https://issues.apache.org/jira/browse/OAK-6818
> Project: Jackrabbit Oak
> Issue Type: New Feature
> Components: core, security
>Reporter: angela
>Assignee: angela
> Fix For: 1.8
>
> Attachments: OAK-6818-osgi-test.patch, OAK-6818.patch
>
>
> During token based authentication a given token node gets removed if it is
> found to have expired in the mean time:
> Extract from {{TokenAuthentication.validateCredentials(TokenCredentials)}} as
> it works today:
> {code}
>[...]
> if (tokenInfo.isExpired(loginTime)) {
> tokenInfo.remove();
> return false;
> }
>[...]
> {code}
> However, this doesn't cope with those cases where expired tokens are being
> left behind without ever being caught by cleanup (e.g. new token issued and
> never try to login with expired token). So, this issue is about an extension
> that would allow to somehow/somewhen cleanup those tokens during
> authentication. In order not to cause extra overhead to the login we should
> set a limit (e.g. number of token nodes) that would only trigger the cleanup
> every now and then and not doing it all the time.
> What also needs to be clarified/investigated: would cleanup only be triggered
> in case of a failure?
> cc: [~stillalex], [~tmueller], [~chetanm], [~asanso]
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OAK-6818) TokenAuthentication/TokenProviderImpl: cleanup expired tokens
[
https://issues.apache.org/jira/browse/OAK-6818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16262298#comment-16262298
]
angela commented on OAK-6818:
-
[~stillalex], makes sense to me i will adjust the patch accordingly and we
can take it from there.
> TokenAuthentication/TokenProviderImpl: cleanup expired tokens
> -
>
> Key: OAK-6818
> URL: https://issues.apache.org/jira/browse/OAK-6818
> Project: Jackrabbit Oak
> Issue Type: New Feature
> Components: core, security
>Reporter: angela
>Assignee: angela
> Fix For: 1.8
>
> Attachments: OAK-6818-osgi-test.patch, OAK-6818.patch
>
>
> During token based authentication a given token node gets removed if it is
> found to have expired in the mean time:
> Extract from {{TokenAuthentication.validateCredentials(TokenCredentials)}} as
> it works today:
> {code}
>[...]
> if (tokenInfo.isExpired(loginTime)) {
> tokenInfo.remove();
> return false;
> }
>[...]
> {code}
> However, this doesn't cope with those cases where expired tokens are being
> left behind without ever being caught by cleanup (e.g. new token issued and
> never try to login with expired token). So, this issue is about an extension
> that would allow to somehow/somewhen cleanup those tokens during
> authentication. In order not to cause extra overhead to the login we should
> set a limit (e.g. number of token nodes) that would only trigger the cleanup
> every now and then and not doing it all the time.
> What also needs to be clarified/investigated: would cleanup only be triggered
> in case of a failure?
> cc: [~stillalex], [~tmueller], [~chetanm], [~asanso]
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OAK-6818) TokenAuthentication/TokenProviderImpl: cleanup expired tokens
[
https://issues.apache.org/jira/browse/OAK-6818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16262294#comment-16262294
]
Alex Deparvu commented on OAK-6818:
---
here's a way to reduce the conflicts based on the previous idea of throttling
the cleanup calls: {{uuid}} already provides some randomness we can reuse, so a
very simple idea is to only run it when {{uuid.charAt(0) < '4'}}. this reduces
the conflicts from around 2000 to around 350 in my tests.
> TokenAuthentication/TokenProviderImpl: cleanup expired tokens
> -
>
> Key: OAK-6818
> URL: https://issues.apache.org/jira/browse/OAK-6818
> Project: Jackrabbit Oak
> Issue Type: New Feature
> Components: core, security
>Reporter: angela
>Assignee: angela
> Fix For: 1.8
>
> Attachments: OAK-6818-osgi-test.patch, OAK-6818.patch
>
>
> During token based authentication a given token node gets removed if it is
> found to have expired in the mean time:
> Extract from {{TokenAuthentication.validateCredentials(TokenCredentials)}} as
> it works today:
> {code}
>[...]
> if (tokenInfo.isExpired(loginTime)) {
> tokenInfo.remove();
> return false;
> }
>[...]
> {code}
> However, this doesn't cope with those cases where expired tokens are being
> left behind without ever being caught by cleanup (e.g. new token issued and
> never try to login with expired token). So, this issue is about an extension
> that would allow to somehow/somewhen cleanup those tokens during
> authentication. In order not to cause extra overhead to the login we should
> set a limit (e.g. number of token nodes) that would only trigger the cleanup
> every now and then and not doing it all the time.
> What also needs to be clarified/investigated: would cleanup only be triggered
> in case of a failure?
> cc: [~stillalex], [~tmueller], [~chetanm], [~asanso]
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Resolved] (OAK-6257) Move the NodeStoreFixtureProvider support to oak-run-commons
[ https://issues.apache.org/jira/browse/OAK-6257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chetan Mehrotra resolved OAK-6257. -- Resolution: Fixed Fix Version/s: 1.7.12 Moved the package to oak-run-commons with 1816028 > Move the NodeStoreFixtureProvider support to oak-run-commons > > > Key: OAK-6257 > URL: https://issues.apache.org/jira/browse/OAK-6257 > Project: Jackrabbit Oak > Issue Type: Task > Components: run >Reporter: Chetan Mehrotra >Assignee: Chetan Mehrotra >Priority: Minor > Fix For: 1.8, 1.7.12 > > > OAK-6210 introduced a generic consistent way to construct NodeStore via cli > options. Those classes can be moved to oak-run-commons so that they can be > used in benchmark module -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OAK-6963) Build Jackrabbit Oak #988 failed
[ https://issues.apache.org/jira/browse/OAK-6963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16262239#comment-16262239 ] Hudson commented on OAK-6963: - Previously failing build now is OK. Passed run: [Jackrabbit Oak #998|https://builds.apache.org/job/Jackrabbit%20Oak/998/] [console log|https://builds.apache.org/job/Jackrabbit%20Oak/998/console] > Build Jackrabbit Oak #988 failed > > > Key: OAK-6963 > URL: https://issues.apache.org/jira/browse/OAK-6963 > Project: Jackrabbit Oak > Issue Type: Bug > Components: continuous integration >Reporter: Hudson > > No description is provided > The build Jackrabbit Oak #988 has failed. > First failed run: [Jackrabbit Oak > #988|https://builds.apache.org/job/Jackrabbit%20Oak/988/] [console > log|https://builds.apache.org/job/Jackrabbit%20Oak/988/console] -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (OAK-6970) IncludeIndexTest failure
[
https://issues.apache.org/jira/browse/OAK-6970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomek Rękawek resolved OAK-6970.
Resolution: Fixed
> IncludeIndexTest failure
>
>
> Key: OAK-6970
> URL: https://issues.apache.org/jira/browse/OAK-6970
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: upgrade
>Reporter: Marcel Reutegger
>Assignee: Tomek Rękawek
>Priority: Blocker
> Fix For: 1.2.28, 1.0.40
>
>
> After recent backports in oak-upgrade IncludeIndexTest fails on the 1.2 and
> 1.0 branch when a local MongoDB instance is running, otherwise the test is
> skipped.
> The underlying exception, hidden by the failed branch reset exception, is:
> {noformat}
> java.lang.IllegalArgumentException: Invalid name: null
> at
> org.apache.jackrabbit.oak.spi.state.AbstractNodeState.checkValidName(AbstractNodeState.java:61)
> at
> org.apache.jackrabbit.oak.plugins.memory.EmptyNodeState.getChildNode(EmptyNodeState.java:115)
> at
> org.apache.jackrabbit.oak.plugins.nodetype.TypeEditor.getEffectiveType(TypeEditor.java:284)
> at
> org.apache.jackrabbit.oak.plugins.nodetype.TypeEditor.(TypeEditor.java:101)
> at
> org.apache.jackrabbit.oak.plugins.nodetype.TypeEditorProvider.getRootEditor(TypeEditorProvider.java:113)
> at
> org.apache.jackrabbit.oak.upgrade.RepositoryUpgrade$2.getRootEditor(RepositoryUpgrade.java:633)
> at
> org.apache.jackrabbit.oak.spi.commit.CompositeEditorProvider.getRootEditor(CompositeEditorProvider.java:80)
> at
> org.apache.jackrabbit.oak.spi.commit.EditorHook.processCommit(EditorHook.java:53)
> at
> org.apache.jackrabbit.oak.upgrade.RepositoryUpgrade$LoggingCompositeHook.processCommit(RepositoryUpgrade.java:1077)
> at
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreBranch$Persisted$3.call(DocumentNodeStoreBranch.java:655)
> at
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreBranch$Persisted$3.call(DocumentNodeStoreBranch.java:652)
> at
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreBranch.withCurrentBranch(DocumentNodeStoreBranch.java:353)
> at
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreBranch.access$600(DocumentNodeStoreBranch.java:52)
> at
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreBranch$Persisted.merge(DocumentNodeStoreBranch.java:652)
> {noformat}
> I assume later branches and trunk are not affected because of
> https://svn.apache.org/r1673409 That change went into 1.3.0.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Resolved] (OAK-6971) Remove composite node store-related features from the oak-upgrade
[ https://issues.apache.org/jira/browse/OAK-6971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomek Rękawek resolved OAK-6971. Resolution: Fixed > Remove composite node store-related features from the oak-upgrade > - > > Key: OAK-6971 > URL: https://issues.apache.org/jira/browse/OAK-6971 > Project: Jackrabbit Oak > Issue Type: Task > Components: upgrade >Reporter: Tomek Rękawek >Assignee: Tomek Rękawek > Fix For: 1.8, 1.0.40, 1.4.19, 1.7.12, 1.6.7 > > > Following features were added to the oak-upgrade so it can be used to prepare > the composite node store repository: > * include-index > * fragment-paths > * exclude-fragments > However, since the InitialContentMigrator exists, oak-upgrade doesn't need to > be used for this purpose, so the features can be removed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OAK-6971) Remove composite node store-related features from the oak-upgrade
[ https://issues.apache.org/jira/browse/OAK-6971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomek Rękawek updated OAK-6971: --- Fix Version/s: 1.0.40 > Remove composite node store-related features from the oak-upgrade > - > > Key: OAK-6971 > URL: https://issues.apache.org/jira/browse/OAK-6971 > Project: Jackrabbit Oak > Issue Type: Task > Components: upgrade >Reporter: Tomek Rękawek >Assignee: Tomek Rękawek > Fix For: 1.8, 1.0.40, 1.4.19, 1.7.12, 1.6.7 > > > Following features were added to the oak-upgrade so it can be used to prepare > the composite node store repository: > * include-index > * fragment-paths > * exclude-fragments > However, since the InitialContentMigrator exists, oak-upgrade doesn't need to > be used for this purpose, so the features can be removed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (OAK-6971) Remove composite node store-related features from the oak-upgrade
[ https://issues.apache.org/jira/browse/OAK-6971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16262193#comment-16262193 ] Tomek Rękawek edited comment on OAK-6971 at 11/22/17 10:17 AM: --- Fixed: trunk: r1816015 1.6: r1816016 1.4: r1816021 1.2: r1816026 1.0: r1816027 was (Author: tomek.rekawek): Fixed: trunk: r1816015 1.6: r1816016 1.4: r1816021 1.2: r1816026 > Remove composite node store-related features from the oak-upgrade > - > > Key: OAK-6971 > URL: https://issues.apache.org/jira/browse/OAK-6971 > Project: Jackrabbit Oak > Issue Type: Task > Components: upgrade >Reporter: Tomek Rękawek >Assignee: Tomek Rękawek > Fix For: 1.8, 1.0.40, 1.4.19, 1.7.12, 1.6.7 > > > Following features were added to the oak-upgrade so it can be used to prepare > the composite node store repository: > * include-index > * fragment-paths > * exclude-fragments > However, since the InitialContentMigrator exists, oak-upgrade doesn't need to > be used for this purpose, so the features can be removed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (OAK-6971) Remove composite node store-related features from the oak-upgrade
[ https://issues.apache.org/jira/browse/OAK-6971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16262193#comment-16262193 ] Tomek Rękawek edited comment on OAK-6971 at 11/22/17 10:11 AM: --- Fixed: trunk: r1816015 1.6: r1816016 1.4: r1816021 1.2: r1816026 was (Author: tomek.rekawek): Fixed: trunk: r1816015 1.6: r1816016 1.4: r1816021 > Remove composite node store-related features from the oak-upgrade > - > > Key: OAK-6971 > URL: https://issues.apache.org/jira/browse/OAK-6971 > Project: Jackrabbit Oak > Issue Type: Task > Components: upgrade >Reporter: Tomek Rękawek >Assignee: Tomek Rękawek > Fix For: 1.8, 1.4.19, 1.7.12, 1.6.7 > > > Following features were added to the oak-upgrade so it can be used to prepare > the composite node store repository: > * include-index > * fragment-paths > * exclude-fragments > However, since the InitialContentMigrator exists, oak-upgrade doesn't need to > be used for this purpose, so the features can be removed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OAK-6971) Remove composite node store-related features from the oak-upgrade
[ https://issues.apache.org/jira/browse/OAK-6971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomek Rękawek updated OAK-6971: --- Fix Version/s: 1.4.19 > Remove composite node store-related features from the oak-upgrade > - > > Key: OAK-6971 > URL: https://issues.apache.org/jira/browse/OAK-6971 > Project: Jackrabbit Oak > Issue Type: Task > Components: upgrade >Reporter: Tomek Rękawek >Assignee: Tomek Rękawek > Fix For: 1.8, 1.4.19, 1.7.12, 1.6.7 > > > Following features were added to the oak-upgrade so it can be used to prepare > the composite node store repository: > * include-index > * fragment-paths > * exclude-fragments > However, since the InitialContentMigrator exists, oak-upgrade doesn't need to > be used for this purpose, so the features can be removed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (OAK-6971) Remove composite node store-related features from the oak-upgrade
[ https://issues.apache.org/jira/browse/OAK-6971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16262193#comment-16262193 ] Tomek Rękawek edited comment on OAK-6971 at 11/22/17 10:06 AM: --- Fixed: trunk: r1816015 1.6: r1816016 1.4: r1816021 was (Author: tomek.rekawek): Fixed: trunk: r1816015 1.6: r1816016 > Remove composite node store-related features from the oak-upgrade > - > > Key: OAK-6971 > URL: https://issues.apache.org/jira/browse/OAK-6971 > Project: Jackrabbit Oak > Issue Type: Task > Components: upgrade >Reporter: Tomek Rękawek >Assignee: Tomek Rękawek > Fix For: 1.8, 1.7.12, 1.6.7 > > > Following features were added to the oak-upgrade so it can be used to prepare > the composite node store repository: > * include-index > * fragment-paths > * exclude-fragments > However, since the InitialContentMigrator exists, oak-upgrade doesn't need to > be used for this purpose, so the features can be removed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (OAK-6972) DefaultIndexReader closes suggest directory multiple times
[
https://issues.apache.org/jira/browse/OAK-6972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chetan Mehrotra resolved OAK-6972.
--
Resolution: Fixed
Done with 1816019
> DefaultIndexReader closes suggest directory multiple times
> --
>
> Key: OAK-6972
> URL: https://issues.apache.org/jira/browse/OAK-6972
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: lucene
>Affects Versions: 1.7.11
>Reporter: Chetan Mehrotra
>Assignee: Chetan Mehrotra
>Priority: Minor
> Fix For: 1.8, 1.7.12
>
>
> With OAK-6895 DefaultIndexReader now closes CopyOnReadDirectory used for
> suggestor multiple times. This leads to exception later
> {noformat}
> 21.11.2017 13:53:52.750 *WARN* [oak-lucene-2162]
> org.apache.jackrabbit.oak.plugins.index.lucene.LuceneIndexProviderService
> Error occurred in asynchronous processing
> org.apache.lucene.store.AlreadyClosedException: this Directory is closed
> at
> org.apache.lucene.store.BaseDirectory.ensureOpen(BaseDirectory.java:66)
> at
> org.apache.lucene.store.FSDirectory.getDirectory(FSDirectory.java:338)
> at
> org.apache.jackrabbit.oak.plugins.index.lucene.directory.LocalIndexFile.getFSDir(LocalIndexFile.java:125)
> at
> org.apache.jackrabbit.oak.plugins.index.lucene.directory.LocalIndexFile.(LocalIndexFile.java:43)
> at
> org.apache.jackrabbit.oak.plugins.index.lucene.IndexCopier.deleteFile(IndexCopier.java:276)
> at
> org.apache.jackrabbit.oak.plugins.index.lucene.directory.CopyOnReadDirectory.removeDeletedFiles(CopyOnReadDirectory.java:315)
> at
> org.apache.jackrabbit.oak.plugins.index.lucene.directory.CopyOnReadDirectory.access$300(CopyOnReadDirectory.java:51)
> at
> org.apache.jackrabbit.oak.plugins.index.lucene.directory.CopyOnReadDirectory$2.run(CopyOnReadDirectory.java:278)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> {noformat}
> As a fix
> # Avoid closing the directory multiple times in DefaultIndexReader
> # Make CopyOnReadDirectory resilient to multiple close calls
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Created] (OAK-6972) DefaultIndexReader closes suggest directory multiple times
Chetan Mehrotra created OAK-6972:
Summary: DefaultIndexReader closes suggest directory multiple times
Key: OAK-6972
URL: https://issues.apache.org/jira/browse/OAK-6972
Project: Jackrabbit Oak
Issue Type: Bug
Components: lucene
Affects Versions: 1.7.11
Reporter: Chetan Mehrotra
Assignee: Chetan Mehrotra
Priority: Minor
Fix For: 1.8, 1.7.12
With OAK-6895 DefaultIndexReader now closes CopyOnReadDirectory used for
suggestor multiple times. This leads to exception later
{noformat}
21.11.2017 13:53:52.750 *WARN* [oak-lucene-2162]
org.apache.jackrabbit.oak.plugins.index.lucene.LuceneIndexProviderService Error
occurred in asynchronous processing
org.apache.lucene.store.AlreadyClosedException: this Directory is closed
at
org.apache.lucene.store.BaseDirectory.ensureOpen(BaseDirectory.java:66)
at
org.apache.lucene.store.FSDirectory.getDirectory(FSDirectory.java:338)
at
org.apache.jackrabbit.oak.plugins.index.lucene.directory.LocalIndexFile.getFSDir(LocalIndexFile.java:125)
at
org.apache.jackrabbit.oak.plugins.index.lucene.directory.LocalIndexFile.(LocalIndexFile.java:43)
at
org.apache.jackrabbit.oak.plugins.index.lucene.IndexCopier.deleteFile(IndexCopier.java:276)
at
org.apache.jackrabbit.oak.plugins.index.lucene.directory.CopyOnReadDirectory.removeDeletedFiles(CopyOnReadDirectory.java:315)
at
org.apache.jackrabbit.oak.plugins.index.lucene.directory.CopyOnReadDirectory.access$300(CopyOnReadDirectory.java:51)
at
org.apache.jackrabbit.oak.plugins.index.lucene.directory.CopyOnReadDirectory$2.run(CopyOnReadDirectory.java:278)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:745)
{noformat}
As a fix
# Avoid closing the directory multiple times in DefaultIndexReader
# Make CopyOnReadDirectory resilient to multiple close calls
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (OAK-5173) Path in uniqueness constraint violation exception is always the root
[
https://issues.apache.org/jira/browse/OAK-5173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Mueller updated OAK-5173:
Sprint: L15
> Path in uniqueness constraint violation exception is always the root
>
>
> Key: OAK-5173
> URL: https://issues.apache.org/jira/browse/OAK-5173
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: core, property-index
>Affects Versions: 1.4.10, 1.5.14
>Reporter: Alexander Klimetschek
>Assignee: Thomas Mueller
> Fix For: 1.8
>
>
> OAK-1997 added a (single) path to the uniqueness constraint exception message
> in the PropertyIndexEditor to point out where the duplicate came from, but it
> is always the root:
> {noformat}
> OakConstraint0030: Uniqueness constraint violated at path [/] for one of the
> property in [rep:externalId] having value xyz1234
> {noformat}
> That is because it [uses
> getPath()|https://github.com/apache/jackrabbit-oak/blob/3a88b23d51beae4798e9b29c4deaba81c81fb427/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/index/property/PropertyIndexEditor.java#L315-L318]
> of the index editor itself and the uniqueness check always [happens at the
> root
> level|https://github.com/apache/jackrabbit-oak/blob/3a88b23d51beae4798e9b29c4deaba81c81fb427/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/index/property/PropertyIndexEditor.java#L303]
> at the end.
> It probably has to read from the index to find out the 2 or more paths with
> the same property value (just printing one path is not enough information for
> duplicates).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (OAK-6342) Cost overrides for Lucene index not always working
[
https://issues.apache.org/jira/browse/OAK-6342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Mueller updated OAK-6342:
Sprint: L15
> Cost overrides for Lucene index not always working
> --
>
> Key: OAK-6342
> URL: https://issues.apache.org/jira/browse/OAK-6342
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: lucene, query
>Reporter: Thomas Mueller
>Assignee: Thomas Mueller
> Fix For: 1.8
>
>
> The cost overrides for the Lucene (compatVersion 2) index don't seem to work
> always. All features (costPerEntry, costPerExecution, entryCount which is
> undocumented) seem to be ignored for the query:
> {noformat}
> /jcr:root/replication//*[jcr:like(@sling:resourceType, "replication//%agent")]
> index rule:
> http://localhost:4502/oak:index/lucene/indexRules/nt:base/properties/resourceType.tidy.-1.json
> {
> "jcr:primaryType": "nt:unstructured",
> "propertyIndex": "true",
> "weight": "0",
> "name": "sling:resourceType"
> }
> cost for lucene-property[/oak:index/lucene] is 501.0
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (OAK-6971) Remove composite node store-related features from the oak-upgrade
[ https://issues.apache.org/jira/browse/OAK-6971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomek Rękawek updated OAK-6971: --- Fix Version/s: 1.6.7 > Remove composite node store-related features from the oak-upgrade > - > > Key: OAK-6971 > URL: https://issues.apache.org/jira/browse/OAK-6971 > Project: Jackrabbit Oak > Issue Type: Task > Components: upgrade >Reporter: Tomek Rękawek >Assignee: Tomek Rękawek > Fix For: 1.8, 1.7.12, 1.6.7 > > > Following features were added to the oak-upgrade so it can be used to prepare > the composite node store repository: > * include-index > * fragment-paths > * exclude-fragments > However, since the InitialContentMigrator exists, oak-upgrade doesn't need to > be used for this purpose, so the features can be removed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OAK-6971) Remove composite node store-related features from the oak-upgrade
[ https://issues.apache.org/jira/browse/OAK-6971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16262193#comment-16262193 ] Tomek Rękawek commented on OAK-6971: Fixed: trunk: r1816015 1.6: r1816016 > Remove composite node store-related features from the oak-upgrade > - > > Key: OAK-6971 > URL: https://issues.apache.org/jira/browse/OAK-6971 > Project: Jackrabbit Oak > Issue Type: Task > Components: upgrade >Reporter: Tomek Rękawek >Assignee: Tomek Rękawek > Fix For: 1.8, 1.7.12 > > > Following features were added to the oak-upgrade so it can be used to prepare > the composite node store repository: > * include-index > * fragment-paths > * exclude-fragments > However, since the InitialContentMigrator exists, oak-upgrade doesn't need to > be used for this purpose, so the features can be removed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OAK-6971) Remove composite node store-related features from the oak-upgrade
[ https://issues.apache.org/jira/browse/OAK-6971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomek Rękawek updated OAK-6971: --- Fix Version/s: 1.7.12 1.8 > Remove composite node store-related features from the oak-upgrade > - > > Key: OAK-6971 > URL: https://issues.apache.org/jira/browse/OAK-6971 > Project: Jackrabbit Oak > Issue Type: Task > Components: upgrade >Reporter: Tomek Rękawek >Assignee: Tomek Rękawek > Fix For: 1.8, 1.7.12 > > > Following features were added to the oak-upgrade so it can be used to prepare > the composite node store repository: > * include-index > * fragment-paths > * exclude-fragments > However, since the InitialContentMigrator exists, oak-upgrade doesn't need to > be used for this purpose, so the features can be removed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (OAK-6971) Remove composite node store-related features from the oak-upgrade
[ https://issues.apache.org/jira/browse/OAK-6971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomek Rękawek reassigned OAK-6971: -- Assignee: Tomek Rękawek > Remove composite node store-related features from the oak-upgrade > - > > Key: OAK-6971 > URL: https://issues.apache.org/jira/browse/OAK-6971 > Project: Jackrabbit Oak > Issue Type: Task > Components: upgrade >Reporter: Tomek Rękawek >Assignee: Tomek Rękawek > > Following features were added to the oak-upgrade so it can be used to prepare > the composite node store repository: > * include-index > * fragment-paths > * exclude-fragments > However, since the InitialContentMigrator exists, oak-upgrade doesn't need to > be used for this purpose, so the features can be removed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OAK-6970) IncludeIndexTest failure
[
https://issues.apache.org/jira/browse/OAK-6970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16262159#comment-16262159
]
Tomek Rękawek commented on OAK-6970:
[~mreutegg], you're right. I'll remove this feature from trunk and the branches
as a part of OAK-6971.
> IncludeIndexTest failure
>
>
> Key: OAK-6970
> URL: https://issues.apache.org/jira/browse/OAK-6970
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: upgrade
>Reporter: Marcel Reutegger
>Assignee: Tomek Rękawek
>Priority: Blocker
> Fix For: 1.2.28, 1.0.40
>
>
> After recent backports in oak-upgrade IncludeIndexTest fails on the 1.2 and
> 1.0 branch when a local MongoDB instance is running, otherwise the test is
> skipped.
> The underlying exception, hidden by the failed branch reset exception, is:
> {noformat}
> java.lang.IllegalArgumentException: Invalid name: null
> at
> org.apache.jackrabbit.oak.spi.state.AbstractNodeState.checkValidName(AbstractNodeState.java:61)
> at
> org.apache.jackrabbit.oak.plugins.memory.EmptyNodeState.getChildNode(EmptyNodeState.java:115)
> at
> org.apache.jackrabbit.oak.plugins.nodetype.TypeEditor.getEffectiveType(TypeEditor.java:284)
> at
> org.apache.jackrabbit.oak.plugins.nodetype.TypeEditor.(TypeEditor.java:101)
> at
> org.apache.jackrabbit.oak.plugins.nodetype.TypeEditorProvider.getRootEditor(TypeEditorProvider.java:113)
> at
> org.apache.jackrabbit.oak.upgrade.RepositoryUpgrade$2.getRootEditor(RepositoryUpgrade.java:633)
> at
> org.apache.jackrabbit.oak.spi.commit.CompositeEditorProvider.getRootEditor(CompositeEditorProvider.java:80)
> at
> org.apache.jackrabbit.oak.spi.commit.EditorHook.processCommit(EditorHook.java:53)
> at
> org.apache.jackrabbit.oak.upgrade.RepositoryUpgrade$LoggingCompositeHook.processCommit(RepositoryUpgrade.java:1077)
> at
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreBranch$Persisted$3.call(DocumentNodeStoreBranch.java:655)
> at
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreBranch$Persisted$3.call(DocumentNodeStoreBranch.java:652)
> at
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreBranch.withCurrentBranch(DocumentNodeStoreBranch.java:353)
> at
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreBranch.access$600(DocumentNodeStoreBranch.java:52)
> at
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreBranch$Persisted.merge(DocumentNodeStoreBranch.java:652)
> {noformat}
> I assume later branches and trunk are not affected because of
> https://svn.apache.org/r1673409 That change went into 1.3.0.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Created] (OAK-6971) Remove composite node store-related features from the oak-upgrade
Tomek Rękawek created OAK-6971: -- Summary: Remove composite node store-related features from the oak-upgrade Key: OAK-6971 URL: https://issues.apache.org/jira/browse/OAK-6971 Project: Jackrabbit Oak Issue Type: Bug Components: upgrade Reporter: Tomek Rękawek Following features were added to the oak-upgrade so it can be used to prepare the composite node store repository: * include-index * fragment-paths * exclude-fragments However, since the InitialContentMigrator exists, oak-upgrade doesn't need to be used for this purpose, so the features can be removed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OAK-6971) Remove composite node store-related features from the oak-upgrade
[ https://issues.apache.org/jira/browse/OAK-6971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomek Rękawek updated OAK-6971: --- Issue Type: Task (was: Bug) > Remove composite node store-related features from the oak-upgrade > - > > Key: OAK-6971 > URL: https://issues.apache.org/jira/browse/OAK-6971 > Project: Jackrabbit Oak > Issue Type: Task > Components: upgrade >Reporter: Tomek Rękawek > > Following features were added to the oak-upgrade so it can be used to prepare > the composite node store repository: > * include-index > * fragment-paths > * exclude-fragments > However, since the InitialContentMigrator exists, oak-upgrade doesn't need to > be used for this purpose, so the features can be removed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (OAK-6953) CacheLIRS cannot be disabled
[ https://issues.apache.org/jira/browse/OAK-6953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16260835#comment-16260835 ] Marcel Reutegger edited comment on OAK-6953 at 11/22/17 8:43 AM: - Merged into branches: - 1.6: http://svn.apache.org/r1815930 - 1.4: http://svn.apache.org/r1815941 - 1.2: http://svn.apache.org/r1816012 was (Author: mreutegg): Merged into branches: - 1.6: http://svn.apache.org/r1815930 - 1.4: http://svn.apache.org/r1815941 > CacheLIRS cannot be disabled > > > Key: OAK-6953 > URL: https://issues.apache.org/jira/browse/OAK-6953 > Project: Jackrabbit Oak > Issue Type: Bug > Components: documentmk >Reporter: Marcel Reutegger >Assignee: Marcel Reutegger >Priority: Minor > Labels: candidate_oak_1_0 > Fix For: 1.8, 1.2.28, 1.4.19, 1.7.12, 1.6.7 > > > The CacheLIRS cannot be disabled by setting the maxWeight to zero whereas the > Guava implementation can be disabled this way. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OAK-6953) CacheLIRS cannot be disabled
[ https://issues.apache.org/jira/browse/OAK-6953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcel Reutegger updated OAK-6953: -- Labels: candidate_oak_1_0 (was: candidate_oak_1_0 candidate_oak_1_2) Fix Version/s: 1.2.28 > CacheLIRS cannot be disabled > > > Key: OAK-6953 > URL: https://issues.apache.org/jira/browse/OAK-6953 > Project: Jackrabbit Oak > Issue Type: Bug > Components: documentmk >Reporter: Marcel Reutegger >Assignee: Marcel Reutegger >Priority: Minor > Labels: candidate_oak_1_0 > Fix For: 1.8, 1.2.28, 1.4.19, 1.7.12, 1.6.7 > > > The CacheLIRS cannot be disabled by setting the maxWeight to zero whereas the > Guava implementation can be disabled this way. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OAK-6970) IncludeIndexTest failure
[
https://issues.apache.org/jira/browse/OAK-6970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16262128#comment-16262128
]
Marcel Reutegger commented on OAK-6970:
---
Isn't the repository unusable anyway with this sidegrade configuration? IIUC
the test only copies over /libs and /apps and therefore does not copy the root
node. The target repository will not have the required properties on the root
node for a proper JCR, e.g. jcr:primaryType. Is this really intended?
> IncludeIndexTest failure
>
>
> Key: OAK-6970
> URL: https://issues.apache.org/jira/browse/OAK-6970
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: upgrade
>Reporter: Marcel Reutegger
>Assignee: Tomek Rękawek
>Priority: Blocker
> Fix For: 1.2.28, 1.0.40
>
>
> After recent backports in oak-upgrade IncludeIndexTest fails on the 1.2 and
> 1.0 branch when a local MongoDB instance is running, otherwise the test is
> skipped.
> The underlying exception, hidden by the failed branch reset exception, is:
> {noformat}
> java.lang.IllegalArgumentException: Invalid name: null
> at
> org.apache.jackrabbit.oak.spi.state.AbstractNodeState.checkValidName(AbstractNodeState.java:61)
> at
> org.apache.jackrabbit.oak.plugins.memory.EmptyNodeState.getChildNode(EmptyNodeState.java:115)
> at
> org.apache.jackrabbit.oak.plugins.nodetype.TypeEditor.getEffectiveType(TypeEditor.java:284)
> at
> org.apache.jackrabbit.oak.plugins.nodetype.TypeEditor.(TypeEditor.java:101)
> at
> org.apache.jackrabbit.oak.plugins.nodetype.TypeEditorProvider.getRootEditor(TypeEditorProvider.java:113)
> at
> org.apache.jackrabbit.oak.upgrade.RepositoryUpgrade$2.getRootEditor(RepositoryUpgrade.java:633)
> at
> org.apache.jackrabbit.oak.spi.commit.CompositeEditorProvider.getRootEditor(CompositeEditorProvider.java:80)
> at
> org.apache.jackrabbit.oak.spi.commit.EditorHook.processCommit(EditorHook.java:53)
> at
> org.apache.jackrabbit.oak.upgrade.RepositoryUpgrade$LoggingCompositeHook.processCommit(RepositoryUpgrade.java:1077)
> at
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreBranch$Persisted$3.call(DocumentNodeStoreBranch.java:655)
> at
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreBranch$Persisted$3.call(DocumentNodeStoreBranch.java:652)
> at
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreBranch.withCurrentBranch(DocumentNodeStoreBranch.java:353)
> at
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreBranch.access$600(DocumentNodeStoreBranch.java:52)
> at
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreBranch$Persisted.merge(DocumentNodeStoreBranch.java:652)
> {noformat}
> I assume later branches and trunk are not affected because of
> https://svn.apache.org/r1673409 That change went into 1.3.0.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (OAK-6970) IncludeIndexTest failure
[
https://issues.apache.org/jira/browse/OAK-6970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marcel Reutegger updated OAK-6970:
--
Fix Version/s: 1.0.40
Description:
After recent backports in oak-upgrade IncludeIndexTest fails on the 1.2 and 1.0
branch when a local MongoDB instance is running, otherwise the test is skipped.
The underlying exception, hidden by the failed branch reset exception, is:
{noformat}
java.lang.IllegalArgumentException: Invalid name: null
at
org.apache.jackrabbit.oak.spi.state.AbstractNodeState.checkValidName(AbstractNodeState.java:61)
at
org.apache.jackrabbit.oak.plugins.memory.EmptyNodeState.getChildNode(EmptyNodeState.java:115)
at
org.apache.jackrabbit.oak.plugins.nodetype.TypeEditor.getEffectiveType(TypeEditor.java:284)
at
org.apache.jackrabbit.oak.plugins.nodetype.TypeEditor.(TypeEditor.java:101)
at
org.apache.jackrabbit.oak.plugins.nodetype.TypeEditorProvider.getRootEditor(TypeEditorProvider.java:113)
at
org.apache.jackrabbit.oak.upgrade.RepositoryUpgrade$2.getRootEditor(RepositoryUpgrade.java:633)
at
org.apache.jackrabbit.oak.spi.commit.CompositeEditorProvider.getRootEditor(CompositeEditorProvider.java:80)
at
org.apache.jackrabbit.oak.spi.commit.EditorHook.processCommit(EditorHook.java:53)
at
org.apache.jackrabbit.oak.upgrade.RepositoryUpgrade$LoggingCompositeHook.processCommit(RepositoryUpgrade.java:1077)
at
org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreBranch$Persisted$3.call(DocumentNodeStoreBranch.java:655)
at
org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreBranch$Persisted$3.call(DocumentNodeStoreBranch.java:652)
at
org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreBranch.withCurrentBranch(DocumentNodeStoreBranch.java:353)
at
org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreBranch.access$600(DocumentNodeStoreBranch.java:52)
at
org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreBranch$Persisted.merge(DocumentNodeStoreBranch.java:652)
{noformat}
I assume later branches and trunk are not affected because of
https://svn.apache.org/r1673409 That change went into 1.3.0.
was:
After recent backports in oak-upgrade IncludeIndexTest fails on the 1.2 branch
when a local MongoDB instance is running, otherwise the test is skipped.
The underlying exception, hidden by the failed branch reset exception, is:
{noformat}
java.lang.IllegalArgumentException: Invalid name: null
at
org.apache.jackrabbit.oak.spi.state.AbstractNodeState.checkValidName(AbstractNodeState.java:61)
at
org.apache.jackrabbit.oak.plugins.memory.EmptyNodeState.getChildNode(EmptyNodeState.java:115)
at
org.apache.jackrabbit.oak.plugins.nodetype.TypeEditor.getEffectiveType(TypeEditor.java:284)
at
org.apache.jackrabbit.oak.plugins.nodetype.TypeEditor.(TypeEditor.java:101)
at
org.apache.jackrabbit.oak.plugins.nodetype.TypeEditorProvider.getRootEditor(TypeEditorProvider.java:113)
at
org.apache.jackrabbit.oak.upgrade.RepositoryUpgrade$2.getRootEditor(RepositoryUpgrade.java:633)
at
org.apache.jackrabbit.oak.spi.commit.CompositeEditorProvider.getRootEditor(CompositeEditorProvider.java:80)
at
org.apache.jackrabbit.oak.spi.commit.EditorHook.processCommit(EditorHook.java:53)
at
org.apache.jackrabbit.oak.upgrade.RepositoryUpgrade$LoggingCompositeHook.processCommit(RepositoryUpgrade.java:1077)
at
org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreBranch$Persisted$3.call(DocumentNodeStoreBranch.java:655)
at
org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreBranch$Persisted$3.call(DocumentNodeStoreBranch.java:652)
at
org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreBranch.withCurrentBranch(DocumentNodeStoreBranch.java:353)
at
org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreBranch.access$600(DocumentNodeStoreBranch.java:52)
at
org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreBranch$Persisted.merge(DocumentNodeStoreBranch.java:652)
{noformat}
I assume later branches and trunk are not affected because of
https://svn.apache.org/r1673409 That change went into 1.3.0.
> IncludeIndexTest failure
>
>
> Key: OAK-6970
> URL: https://issues.apache.org/jira/browse/OAK-6970
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: upgrade
>Reporter: Marcel Reutegger
>Assignee: Tomek Rękawek
>Priority: Blocker
> Fix For: 1.2.28, 1.0.40
>
>
> After recent backports in oak-upgrade IncludeIndexTest fails on the 1.2 and
> 1.0 branch when a local MongoDB instance is running, otherwise the test is
> skipped.
> The underlying exception, hidden by the failed branch reset exception,
[jira] [Created] (OAK-6970) IncludeIndexTest failure
Marcel Reutegger created OAK-6970:
-
Summary: IncludeIndexTest failure
Key: OAK-6970
URL: https://issues.apache.org/jira/browse/OAK-6970
Project: Jackrabbit Oak
Issue Type: Bug
Components: upgrade
Reporter: Marcel Reutegger
Assignee: Tomek Rękawek
Priority: Blocker
Fix For: 1.2.28
After recent backports in oak-upgrade IncludeIndexTest fails on the 1.2 branch
when a local MongoDB instance is running, otherwise the test is skipped.
The underlying exception, hidden by the failed branch reset exception, is:
{noformat}
java.lang.IllegalArgumentException: Invalid name: null
at
org.apache.jackrabbit.oak.spi.state.AbstractNodeState.checkValidName(AbstractNodeState.java:61)
at
org.apache.jackrabbit.oak.plugins.memory.EmptyNodeState.getChildNode(EmptyNodeState.java:115)
at
org.apache.jackrabbit.oak.plugins.nodetype.TypeEditor.getEffectiveType(TypeEditor.java:284)
at
org.apache.jackrabbit.oak.plugins.nodetype.TypeEditor.(TypeEditor.java:101)
at
org.apache.jackrabbit.oak.plugins.nodetype.TypeEditorProvider.getRootEditor(TypeEditorProvider.java:113)
at
org.apache.jackrabbit.oak.upgrade.RepositoryUpgrade$2.getRootEditor(RepositoryUpgrade.java:633)
at
org.apache.jackrabbit.oak.spi.commit.CompositeEditorProvider.getRootEditor(CompositeEditorProvider.java:80)
at
org.apache.jackrabbit.oak.spi.commit.EditorHook.processCommit(EditorHook.java:53)
at
org.apache.jackrabbit.oak.upgrade.RepositoryUpgrade$LoggingCompositeHook.processCommit(RepositoryUpgrade.java:1077)
at
org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreBranch$Persisted$3.call(DocumentNodeStoreBranch.java:655)
at
org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreBranch$Persisted$3.call(DocumentNodeStoreBranch.java:652)
at
org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreBranch.withCurrentBranch(DocumentNodeStoreBranch.java:353)
at
org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreBranch.access$600(DocumentNodeStoreBranch.java:52)
at
org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreBranch$Persisted.merge(DocumentNodeStoreBranch.java:652)
{noformat}
I assume later branches and trunk are not affected because of
https://svn.apache.org/r1673409 That change went into 1.3.0.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
