[jira] [Commented] (OAK-7897) Queries with OR simplified to IN shouldn't have alternative UNION query

2018-11-15 Thread Vikas Saurabh (JIRA)


[ 
https://issues.apache.org/jira/browse/OAK-7897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688795#comment-16688795
 ] 

Vikas Saurabh commented on OAK-7897:


[~tmueller], I understand why a flow of getting the query in description via 
{{QueryEngineImpl#parseQuery}} \[0] is giving original query with {{IN}} clause 
and an alternative {{UNION}} version. The situation is (I don't know if it's 
really an issue or not) is that {{parseQuery}} parses the query via 
{{SQL2Parser}} with {{init=false}} \[1]. This keeps the original query as is 
(with {{OR}} clause). This query when optimized for {{UNION}} indeed gives an 
alternate version. Both of these queries are then init-ed \[2].

If this issue is considered worth solving, then the only way I can think of is 
to initialize the query during parsing itself. That would result in original 
query to be converted with one with {{IN}} clause and hence the optimized query 
would not have a {{UNION}}.

All that said, I'm really not comfortable of why the code is the way it is 
currently. So, [~tmueller], it'd be great if you can pick this one up - it is 
way outside of my comfort zone.

\[0]: 
https://github.com/apache/jackrabbit-oak/blob/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/query/QueryEngineImpl.java#L144
\[1]: 
https://github.com/apache/jackrabbit-oak/blob/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/query/QueryEngineImpl.java#L174
\[2]: 
https://github.com/apache/jackrabbit-oak/blob/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/query/QueryEngineImpl.java#L219

> Queries with OR simplified to IN shouldn't have alternative UNION query
> ---
>
> Key: OAK-7897
> URL: https://issues.apache.org/jira/browse/OAK-7897
> Project: Jackrabbit Oak
>  Issue Type: Sub-task
>  Components: lucene
>Reporter: Vikas Saurabh
>Assignee: Vikas Saurabh
>Priority: Minor
>
> Queries like {noformat} SELECT [rep:facet(text)] FROM [nt:base] WHERE [name] 
> = 'Node1' OR [name] = 'Node2' {noformat} which would get simplified to {{IN}} 
> clause still weigh in cost of alternative query with {{UNION}}. We should 
> avoid that.
> /cc [~tmueller]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OAK-7887) [S3DataStore] HTTP 409 returned S3 in init() can cause init() failure

2018-11-15 Thread Matt Ryan (JIRA)


[ 
https://issues.apache.org/jira/browse/OAK-7887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688789#comment-16688789
 ] 

Matt Ryan commented on OAK-7887:


[~reschke] good callout - but I didn't see any message info, just the response 
code.  A message might have been included but wasn't put into the logs.

> [S3DataStore] HTTP 409 returned S3 in init() can cause init() failure
> -
>
> Key: OAK-7887
> URL: https://issues.apache.org/jira/browse/OAK-7887
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: blob-cloud
>Reporter: Matt Ryan
>Assignee: Matt Ryan
>Priority: Minor
> Attachments: OAK-7887.patch.1
>
>
> When running S3DataStore tests on Jenkins CI, about 10% of the tests failed 
> for the same reason:  a 409 error code returned from Amazon during the 
> {{init()}} method of {{S3Backend}}.  I suspect this is being caused by the 
> call to create the bucket if it doesn't already exist.
> To fix this we would need to implement some retry logic in the {{init()}} 
> call.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (OAK-7182) Make it possible to update Guava

2018-11-15 Thread Yogesh Upadhyay (JIRA)


[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688492#comment-16688492
 ] 

Yogesh Upadhyay edited comment on OAK-7182 at 11/15/18 6:38 PM:


Thank you [~reschke] we are blocked on this as well. Our new play plugin uses 
latest Guava version (maybe because of security issue) and our build is failing 
with latest version of jcr-oak. Let us know if we can help.


was (Author: yogeshupadhyay):
Thank you [~reschke] we are blocked on this as well. Our new play plugin the 
uses latest Guava version (maybe because of security issue) and our build is 
failing with latest version of jcr-oak. Let us know if we can help.

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Attachments: GuavaTests.java, OAK-7182-guava-21-3.diff, 
> OAK-7182-guava-21-4.diff, OAK-7182-guava-21.diff, OAK-7182-guava-23.6.1.diff, 
> guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OAK-7182) Make it possible to update Guava

2018-11-15 Thread Yogesh Upadhyay (JIRA)


[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688492#comment-16688492
 ] 

Yogesh Upadhyay commented on OAK-7182:
--

Thank you [~reschke] we are blocked on this as well. Our new play plugin the 
uses latest Guava version (maybe because of security issue) and our build is 
failing with latest version of jcr-oak. Let us know if we can help.

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Attachments: GuavaTests.java, OAK-7182-guava-21-3.diff, 
> OAK-7182-guava-21-4.diff, OAK-7182-guava-21.diff, OAK-7182-guava-23.6.1.diff, 
> guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OAK-7889) Build Jackrabbit Oak #1778 failed

2018-11-15 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/OAK-7889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688126#comment-16688126
 ] 

Hudson commented on OAK-7889:
-

Build is still failing.
Failed run: [Jackrabbit Oak 
#1793|https://builds.apache.org/job/Jackrabbit%20Oak/1793/] [console 
log|https://builds.apache.org/job/Jackrabbit%20Oak/1793/console]

> Build Jackrabbit Oak #1778 failed
> -
>
> Key: OAK-7889
> URL: https://issues.apache.org/jira/browse/OAK-7889
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: continuous integration
>Reporter: Hudson
>Priority: Major
>
> No description is provided
> The build Jackrabbit Oak #1778 has failed.
> First failed run: [Jackrabbit Oak 
> #1778|https://builds.apache.org/job/Jackrabbit%20Oak/1778/] [console 
> log|https://builds.apache.org/job/Jackrabbit%20Oak/1778/console]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (OAK-7900) Allow to spot User.disable with a new, dedicated UserAction

2018-11-15 Thread angela (JIRA)


 [ 
https://issues.apache.org/jira/browse/OAK-7900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

angela resolved OAK-7900.
-
   Resolution: Fixed
Fix Version/s: 1.9.12

Committed revision 1846652.

[~stillalex], [~chaotic], thanks a lot for reviewing. very much appreciated

> Allow to spot User.disable with a new, dedicated UserAction
> ---
>
> Key: OAK-7900
> URL: https://issues.apache.org/jira/browse/OAK-7900
> Project: Jackrabbit Oak
>  Issue Type: New Feature
>  Components: security-spi
>Reporter: angela
>Assignee: angela
>Priority: Major
> Fix For: 1.10, 1.9.12
>
> Attachments: OAK-7900.patch
>
>
> [~chaotic], as discussed off list we lack the ability to react to 
> {{User.disable(String)}} with the current {{AuthorizableAction}} interface, 
> while at the same time encouraging API consumers to disable users instead of 
> removing them.
> One use case for such a method would be deleting additional information 
> stored with the user account such as e.g. profile data, preferences, as soon 
> as the user gets disabled.
> Since extending {{AuthorizableAction}} would require a major bump of the 
> exported version, I would suggest to introduce a new {{UserAction}} 
> interface, providing that new method, in correspondance to {{GroupAction}}, 
> which covers group specific actions. And, in an ideal world 
> {{AuthorizableAction.onPasswordChange}} would also reside with {{UserAction}}.
> [~stillalex], wdyt?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OAK-7741) Token LoginModule flag to skip refreshing the token expiration

2018-11-15 Thread Davide Giannella (JIRA)


 [ 
https://issues.apache.org/jira/browse/OAK-7741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Davide Giannella updated OAK-7741:
--
Fix Version/s: 1.8.10

> Token LoginModule flag to skip refreshing the token expiration
> --
>
> Key: OAK-7741
> URL: https://issues.apache.org/jira/browse/OAK-7741
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: core, security
>Reporter: Alex Deparvu
>Assignee: Alex Deparvu
>Priority: Major
> Fix For: 1.10, 1.9.9, 1.6.15, 1.8.10
>
>
> There is currently no way to skip the login token refresh for a specific 
> login call.
> I would like to add a flag that, when enabled on the Credentials object will 
> allow the Token LM to not refresh the login token.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OAK-7885) Performance regression in FlatTreeUpdateTest

2018-11-15 Thread Davide Giannella (JIRA)


 [ 
https://issues.apache.org/jira/browse/OAK-7885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Davide Giannella closed OAK-7885.
-

Bulk close 1.9.11

> Performance regression in FlatTreeUpdateTest
> 
>
> Key: OAK-7885
> URL: https://issues.apache.org/jira/browse/OAK-7885
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: segment-tar
>Reporter: Michael Dürig
>Assignee: Michael Dürig
>Priority: Major
> Fix For: 1.10, 1.9.11
>
> Attachments: OAK-7885.patch
>
>
> Apparently the [fix|http://svn.apache.org/viewvc?rev=1845234=rev] for 
> OAK-7838 introduces a performance regression for {{FlatTreeUpdateTest}}:
> {noformat}
> # FlatTreeUpdateTest   C min 10% 50% 90% max  
>  N 
> rev 1845206    1    5732    5734    6062    7369    7404  
>     10
> rev 1845234    1   10213   10213   16431   20443   20443  
>  5
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OAK-7379) Lucene Index: per-column selectivity, assume 5 unique entries

2018-11-15 Thread Julian Reschke (JIRA)


 [ 
https://issues.apache.org/jira/browse/OAK-7379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-7379:

Fix Version/s: 1.9.0

> Lucene Index: per-column selectivity, assume 5 unique entries
> -
>
> Key: OAK-7379
> URL: https://issues.apache.org/jira/browse/OAK-7379
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: lucene, query
>Reporter: Thomas Mueller
>Assignee: Thomas Mueller
>Priority: Major
>  Labels: candidate_oak_1_8
> Fix For: 1.9.0, 1.10
>
>
> Currently, if a query has a property restriction of the form "property = x", 
> and the property is indexed in a Lucene property index, the estimated cost is 
> the index is the number of documents indexed for that property. This is a 
> very conservative estimate, it means all documents have the same value. So 
> the cost is relatively high for that index.
> In almost all cases, there are many distinct values for a property. Rarely 
> there are few values, or a skewed distribution where one value contains most 
> documents. But in almost all cases there are more than 5 distinct values.
> I think it makes sense to use 5 as the default value. It is still 
> conservative (cost of the index is high), but much better than now.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OAK-7886) Re-registering node type may corrupt registry

2018-11-15 Thread Davide Giannella (JIRA)


 [ 
https://issues.apache.org/jira/browse/OAK-7886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Davide Giannella closed OAK-7886.
-

Bulk close 1.9.11

> Re-registering node type may corrupt registry
> -
>
> Key: OAK-7886
> URL: https://issues.apache.org/jira/browse/OAK-7886
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: core
>Affects Versions: 1.0, 1.2, 1.4.0, 1.6.0, 1.8.0
>Reporter: Marcel Reutegger
>Assignee: Marcel Reutegger
>Priority: Major
>  Labels: candidate_oak_1_0, candidate_oak_1_2, candidate_oak_1_4, 
> candidate_oak_1_6, candidate_oak_1_8
> Fix For: 1.10, 1.9.11
>
> Attachments: OAK-7886.patch
>
>
> Re-registering an existing node type may corrupt the registry. This happens 
> for node types that are not mixins and do not extend from other primary types 
> (except for the implicit {{nt:base}}). After re-registering such a node type 
> the {{jcr:supertypes}} list does not have the {{nt:base}} anymore.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OAK-7892) LogCustomizer should support slf4j log levels

2018-11-15 Thread Davide Giannella (JIRA)


 [ 
https://issues.apache.org/jira/browse/OAK-7892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Davide Giannella closed OAK-7892.
-

Bulk close 1.9.11

> LogCustomizer should support slf4j log levels
> -
>
> Key: OAK-7892
> URL: https://issues.apache.org/jira/browse/OAK-7892
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: commons
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
>  Labels: candidate_oak_1_8
> Fix For: 1.10, 1.9.11
>
>
> It's unfortunate that in tests using {{LogCustomizer}}, we need to use 
> logback constants, although the rest of the system uses log4f.
> So, in {{LogCustomizerBuilder}}, support SLF4J log levels as well.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OAK-7613) Taking more time for iterating row of query Result which contain Facets

2018-11-15 Thread Davide Giannella (JIRA)


 [ 
https://issues.apache.org/jira/browse/OAK-7613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Davide Giannella closed OAK-7613.
-

Bulk close 1.9.11

> Taking more time for iterating row of query Result which contain Facets
> ---
>
> Key: OAK-7613
> URL: https://issues.apache.org/jira/browse/OAK-7613
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: lucene, query
>Reporter: Ayush Garg
>Assignee: Vikas Saurabh
>Priority: Major
> Fix For: 1.10, 1.9.11
>
>
> Let me explain with example
> xpath query 1 =*"//element(*, *nt:unstructured)[ (jcr:contains(., 'admin')) 
> ]"*
> xpath query 2=*"//element(, nt:unstructured)[(jcr:contains(., 'admin')) ] 
> /(rep:facet(jcr:title))"*
> I want to extract result on above constrain and facet on property jcr:title .
> Case 1: First execute query 1 and iterate rows of QueryResult for getting 
> ResultSet and then execute query 2 then extract facet using                 
> FacetResult class.
> Case 2:Execute only query 2 and  then iterate rows of QueryResult for getting 
> ResultSet and extract facet using FacetResult class.                     In 
> this case time taken should be less as compared to case 1 because in case 
> only query is executed. but case 2 is taking                       more time.
> In case 2 QueryResult ( getting on executing query 2)also contain facet 
> Result and for iterating rows it is taking very large time compared to case 1.
> Possible reason for this is that during iterating each row it also iterate 
> columns(that contain facetResult) so as size of facetResult increases time 
> for iterating row also increases.   
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OAK-7605) Giving multiple result when executing query (for a constraints with OR condition) for Facetextraction

2018-11-15 Thread Davide Giannella (JIRA)


 [ 
https://issues.apache.org/jira/browse/OAK-7605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Davide Giannella closed OAK-7605.
-

Bulk close 1.9.11

> Giving multiple result when executing query (for a constraints with OR 
> condition) for Facetextraction
> -
>
> Key: OAK-7605
> URL: https://issues.apache.org/jira/browse/OAK-7605
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: lucene, query
>Reporter: Ayush Garg
>Assignee: Vikas Saurabh
>Priority: Major
> Fix For: 1.10, 1.9.11
>
> Attachments: FacetOnORTest.java
>
>
> A Xpath query    
> {noformat}
> //*[( @test = 't1' or @name='Node1')] 
> /(rep:facet(text))/(rep:facet(test))/(rep:facet(name)) order by jcr:path
> {noformat}
> For testing this error run the test method "testFacetOnOR2()" in attached 
> java file.
> In this test method three node are created and properties are set to the 
> nodes.
> when this query runs it should give the result set of size 2. but it is 
> giving the result set of size 3
> Result set contain same nodepath(i.e node) 2 times as it is common in result 
> set of both constraints separately  i.e "@test='t1' " and "@name='Node1' " . 
> For more understanding please run the test method  "testFacetOnOR2()"  in 
> attached java file.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OAK-7877) Avoid unnecessary operations when logging read operations

2018-11-15 Thread Davide Giannella (JIRA)


 [ 
https://issues.apache.org/jira/browse/OAK-7877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Davide Giannella closed OAK-7877.
-

Bulk close 1.9.11

> Avoid unnecessary operations when logging read operations
> -
>
> Key: OAK-7877
> URL: https://issues.apache.org/jira/browse/OAK-7877
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: segment-tar
>Reporter: Francesco Mari
>Assignee: Francesco Mari
>Priority: Major
> Fix For: 1.10, 1.9.11
>
> Attachments: OAK-7877-01.patch
>
>
> The log statements introduced in {{CachingSegmentReader}} by OAK-7864 perform 
> multiple string concatenations even if that specific log is disabled. The log 
> statements should be executed only if the right log level has been enabled 
> for that logger.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OAK-7850) Indexes that don't support facets being queried should not participate in execution plan

2018-11-15 Thread Davide Giannella (JIRA)


 [ 
https://issues.apache.org/jira/browse/OAK-7850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Davide Giannella closed OAK-7850.
-

Bulk close 1.9.11

> Indexes that don't support facets being queried should not participate in 
> execution plan
> 
>
> Key: OAK-7850
> URL: https://issues.apache.org/jira/browse/OAK-7850
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: lucene
>Reporter: Vikas Saurabh
>Assignee: Vikas Saurabh
>Priority: Minor
> Fix For: 1.10, 1.9.11
>
>
> Currently we can have a case where a query with facets can be answered by an 
> index which can resolve all the constraints but don't have facets configured. 
> At times this index might even win the cost war even if there could be an 
> alternative index which might report to be more expensive but can answer the 
> facets.
> While it's not a good practice to have competing indexes, but index selection 
> could have been smarter anyway.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OAK-7608) Throw exception if all properties name are given wrong for faceting

2018-11-15 Thread Davide Giannella (JIRA)


 [ 
https://issues.apache.org/jira/browse/OAK-7608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Davide Giannella closed OAK-7608.
-

Bulk close 1.9.11

> Throw exception if all properties name are given wrong for faceting
> ---
>
> Key: OAK-7608
> URL: https://issues.apache.org/jira/browse/OAK-7608
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: lucene, query
>Reporter: Ayush Garg
>Assignee: Vikas Saurabh
>Priority: Major
> Fix For: 1.10, 1.9.11
>
>
> This can be treated as bug .
> When an Xpath query passed for faceting 
> Example: {noformat}"//*[jcr:contains(jc/@text, 'hello OR 
> hallo')]/(rep:facet(text))/(rep:facet(test)) | (rep:facet(name)) order by 
> jcr:path"{noformat}
> if all properties name on which faceting is to done are wrong property 
> name(i.e that doesn't exists ) it doesn't throw Exception and return the 
> result set.But if one or more is correct and one or more is wrong property 
> name it will throw exception 
> java.lang.RuntimeException: java.lang.IllegalArgumentException: invalid dim 
> "Wrong_Property_Name".
>  
> QueryManager should same behavior when a wrong propery passed for faceting



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OAK-7874) Upgrade docker-junit-rule to version 2.2.2

2018-11-15 Thread Davide Giannella (JIRA)


 [ 
https://issues.apache.org/jira/browse/OAK-7874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Davide Giannella closed OAK-7874.
-

Bulk close 1.9.11

> Upgrade docker-junit-rule to version 2.2.2
> --
>
> Key: OAK-7874
> URL: https://issues.apache.org/jira/browse/OAK-7874
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: parent
>Reporter: Francesco Mari
>Assignee: Francesco Mari
>Priority: Major
> Fix For: 1.10, 1.9.11
>
>
> The Docker client shipped with docker-junit-rule:2.1.0 seems not to be 
> compatible with the latest version of Docker CE (18.06.1-ce). Upgrading 
> docker-junit-rule to version 2.2.2 fixes the problem.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OAK-7873) Delete o.a.j.o.segment.util.RoleUtils

2018-11-15 Thread Davide Giannella (JIRA)


 [ 
https://issues.apache.org/jira/browse/OAK-7873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Davide Giannella closed OAK-7873.
-

Bulk close 1.9.11

> Delete o.a.j.o.segment.util.RoleUtils
> -
>
> Key: OAK-7873
> URL: https://issues.apache.org/jira/browse/OAK-7873
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: segment-tar
>Reporter: Francesco Mari
>Assignee: Francesco Mari
>Priority: Major
> Fix For: 1.10, 1.9.11
>
>
> {{o.a.j.o.segment.util.RoleUtils}} is unused and should be removed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OAK-7578) Update spotbugs plugin to 3.1.5

2018-11-15 Thread Alex Deparvu (JIRA)


 [ 
https://issues.apache.org/jira/browse/OAK-7578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Deparvu updated OAK-7578:
--
Labels: candidate_oak_1_0 candidate_oak_1_2 candidate_oak_1_4  (was: 
candidate_oak_1_6)

> Update spotbugs plugin to 3.1.5
> ---
>
> Key: OAK-7578
> URL: https://issues.apache.org/jira/browse/OAK-7578
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: parent
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Trivial
>  Labels: candidate_oak_1_0, candidate_oak_1_2, candidate_oak_1_4
> Fix For: 1.10, 1.9.5, 1.8.8, 1.6.16
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OAK-7578) Update spotbugs plugin to 3.1.5

2018-11-15 Thread Alex Deparvu (JIRA)


[ 
https://issues.apache.org/jira/browse/OAK-7578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687836#comment-16687836
 ] 

Alex Deparvu commented on OAK-7578:
---

1.6 branch: [r1846637|http://svn.apache.org/viewvc?rev=1846637=rev]

> Update spotbugs plugin to 3.1.5
> ---
>
> Key: OAK-7578
> URL: https://issues.apache.org/jira/browse/OAK-7578
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: parent
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Trivial
>  Labels: candidate_oak_1_0, candidate_oak_1_2, candidate_oak_1_4
> Fix For: 1.10, 1.9.5, 1.8.8, 1.6.16
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OAK-7578) Update spotbugs plugin to 3.1.5

2018-11-15 Thread Alex Deparvu (JIRA)


 [ 
https://issues.apache.org/jira/browse/OAK-7578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Deparvu updated OAK-7578:
--
Fix Version/s: 1.6.16

> Update spotbugs plugin to 3.1.5
> ---
>
> Key: OAK-7578
> URL: https://issues.apache.org/jira/browse/OAK-7578
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: parent
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Trivial
>  Labels: candidate_oak_1_0, candidate_oak_1_2, candidate_oak_1_4
> Fix For: 1.10, 1.9.5, 1.8.8, 1.6.16
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OAK-7368) update to findbugs version compatible with jdk 10

2018-11-15 Thread Alex Deparvu (JIRA)


[ 
https://issues.apache.org/jira/browse/OAK-7368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687831#comment-16687831
 ] 

Alex Deparvu commented on OAK-7368:
---

1.6 branch: [r1846636|http://svn.apache.org/viewvc?rev=1846636=rev]

> update to findbugs version compatible with jdk 10 
> --
>
> Key: OAK-7368
> URL: https://issues.apache.org/jira/browse/OAK-7368
> Project: Jackrabbit Oak
>  Issue Type: Task
>Reporter: Alex Deparvu
>Assignee: Julian Reschke
>Priority: Minor
>  Labels: candidate_oak_1_0, candidate_oak_1_2, candidate_oak_1_4
> Fix For: 1.10, 1.8.4, 1.9.3, 1.6.16
>
>
> Warnings running findbugs
> {noformat}
> [INFO] --- findbugs-maven-plugin:3.0.4:findbugs (findbugs) @ oak-commons ---
> [INFO] Fork Value is true
>  [java] Warning: Unknown version of Java
>  [java] edu.umd.cs.findbugs.JavaVersionException: Could not parse Java 
> version string: 10
>  [java] at edu.umd.cs.findbugs.JavaVersion.(JavaVersion.java:68)
>  [java] at 
> edu.umd.cs.findbugs.JavaVersion.(JavaVersion.java:44)
>  [java] at 
> edu.umd.cs.findbugs.DetectorFactory.isEnabledForCurrentJRE(DetectorFactory.java:248)
>  [java] at 
> edu.umd.cs.findbugs.FindBugs.isDetectorEnabled(FindBugs.java:256)
>  [java] at edu.umd.cs.findbugs.FindBugs2$3.choose(FindBugs2.java:906)
>  [java] at 
> edu.umd.cs.findbugs.plan.ExecutionPlan.build(ExecutionPlan.java:179)
>  [java] at 
> edu.umd.cs.findbugs.FindBugs2.createExecutionPlan(FindBugs2.java:935)
>  [java] at edu.umd.cs.findbugs.FindBugs2.execute(FindBugs2.java:241)
>  [java] at edu.umd.cs.findbugs.FindBugs.runMain(FindBugs.java:402)
>  [java] at edu.umd.cs.findbugs.FindBugs2.main(FindBugs2.java:1200)
> {noformat}
> it seems findbugs-maven-plugin 3.0.5 (latest release) does not fix this and I 
> couldn't find an open issue related to java 10.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OAK-7368) update to findbugs version compatible with jdk 10

2018-11-15 Thread Alex Deparvu (JIRA)


 [ 
https://issues.apache.org/jira/browse/OAK-7368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Deparvu updated OAK-7368:
--
Labels: candidate_oak_1_0 candidate_oak_1_2 candidate_oak_1_4  (was: 
candidate_oak_1_6)

> update to findbugs version compatible with jdk 10 
> --
>
> Key: OAK-7368
> URL: https://issues.apache.org/jira/browse/OAK-7368
> Project: Jackrabbit Oak
>  Issue Type: Task
>Reporter: Alex Deparvu
>Assignee: Julian Reschke
>Priority: Minor
>  Labels: candidate_oak_1_0, candidate_oak_1_2, candidate_oak_1_4
> Fix For: 1.10, 1.8.4, 1.9.3, 1.6.16
>
>
> Warnings running findbugs
> {noformat}
> [INFO] --- findbugs-maven-plugin:3.0.4:findbugs (findbugs) @ oak-commons ---
> [INFO] Fork Value is true
>  [java] Warning: Unknown version of Java
>  [java] edu.umd.cs.findbugs.JavaVersionException: Could not parse Java 
> version string: 10
>  [java] at edu.umd.cs.findbugs.JavaVersion.(JavaVersion.java:68)
>  [java] at 
> edu.umd.cs.findbugs.JavaVersion.(JavaVersion.java:44)
>  [java] at 
> edu.umd.cs.findbugs.DetectorFactory.isEnabledForCurrentJRE(DetectorFactory.java:248)
>  [java] at 
> edu.umd.cs.findbugs.FindBugs.isDetectorEnabled(FindBugs.java:256)
>  [java] at edu.umd.cs.findbugs.FindBugs2$3.choose(FindBugs2.java:906)
>  [java] at 
> edu.umd.cs.findbugs.plan.ExecutionPlan.build(ExecutionPlan.java:179)
>  [java] at 
> edu.umd.cs.findbugs.FindBugs2.createExecutionPlan(FindBugs2.java:935)
>  [java] at edu.umd.cs.findbugs.FindBugs2.execute(FindBugs2.java:241)
>  [java] at edu.umd.cs.findbugs.FindBugs.runMain(FindBugs.java:402)
>  [java] at edu.umd.cs.findbugs.FindBugs2.main(FindBugs2.java:1200)
> {noformat}
> it seems findbugs-maven-plugin 3.0.5 (latest release) does not fix this and I 
> couldn't find an open issue related to java 10.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OAK-7368) update to findbugs version compatible with jdk 10

2018-11-15 Thread Alex Deparvu (JIRA)


 [ 
https://issues.apache.org/jira/browse/OAK-7368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Deparvu updated OAK-7368:
--
Fix Version/s: 1.6.16

> update to findbugs version compatible with jdk 10 
> --
>
> Key: OAK-7368
> URL: https://issues.apache.org/jira/browse/OAK-7368
> Project: Jackrabbit Oak
>  Issue Type: Task
>Reporter: Alex Deparvu
>Assignee: Julian Reschke
>Priority: Minor
>  Labels: candidate_oak_1_0, candidate_oak_1_2, candidate_oak_1_4
> Fix For: 1.10, 1.8.4, 1.9.3, 1.6.16
>
>
> Warnings running findbugs
> {noformat}
> [INFO] --- findbugs-maven-plugin:3.0.4:findbugs (findbugs) @ oak-commons ---
> [INFO] Fork Value is true
>  [java] Warning: Unknown version of Java
>  [java] edu.umd.cs.findbugs.JavaVersionException: Could not parse Java 
> version string: 10
>  [java] at edu.umd.cs.findbugs.JavaVersion.(JavaVersion.java:68)
>  [java] at 
> edu.umd.cs.findbugs.JavaVersion.(JavaVersion.java:44)
>  [java] at 
> edu.umd.cs.findbugs.DetectorFactory.isEnabledForCurrentJRE(DetectorFactory.java:248)
>  [java] at 
> edu.umd.cs.findbugs.FindBugs.isDetectorEnabled(FindBugs.java:256)
>  [java] at edu.umd.cs.findbugs.FindBugs2$3.choose(FindBugs2.java:906)
>  [java] at 
> edu.umd.cs.findbugs.plan.ExecutionPlan.build(ExecutionPlan.java:179)
>  [java] at 
> edu.umd.cs.findbugs.FindBugs2.createExecutionPlan(FindBugs2.java:935)
>  [java] at edu.umd.cs.findbugs.FindBugs2.execute(FindBugs2.java:241)
>  [java] at edu.umd.cs.findbugs.FindBugs.runMain(FindBugs.java:402)
>  [java] at edu.umd.cs.findbugs.FindBugs2.main(FindBugs2.java:1200)
> {noformat}
> it seems findbugs-maven-plugin 3.0.5 (latest release) does not fix this and I 
> couldn't find an open issue related to java 10.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (OAK-7905) Update findbugs-maven-plugin on 1.6 branch

2018-11-15 Thread Alex Deparvu (JIRA)


 [ 
https://issues.apache.org/jira/browse/OAK-7905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Deparvu resolved OAK-7905.
---
Resolution: Duplicate

fixed by backport of OAK-7368 to 1.6 branch

> Update findbugs-maven-plugin on 1.6 branch
> --
>
> Key: OAK-7905
> URL: https://issues.apache.org/jira/browse/OAK-7905
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: parent
>Reporter: Alex Deparvu
>Priority: Minor
>
> Current findbugs-maven-plugin fails on maven 3.6.0:
> {noformat}
> > mvn clean verify -Ppedantic
> [ERROR] Failed to execute goal 
> org.codehaus.mojo:findbugs-maven-plugin:3.0.0:findbugs (findbugs) on project 
> oak-parent: Unable to parse configuration of mojo 
> org.codehaus.mojo:findbugs-maven-plugin:3.0.0:findbugs for parameter 
> pluginArtifacts: Cannot assign configuration entry 'pluginArtifacts' with 
> value '${plugin.artifacts}' of type 
> java.util.Collections.UnmodifiableRandomAccessList to property of type 
> java.util.ArrayList -> [Help 1]
> {noformat}
> it needs an update to at least 3.0.4 (3.0.5 is the latest released version).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OAK-7900) Allow to spot User.disable with a new, dedicated UserAction

2018-11-15 Thread Alex Deparvu (JIRA)


[ 
https://issues.apache.org/jira/browse/OAK-7900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687687#comment-16687687
 ] 

Alex Deparvu commented on OAK-7900:
---

good stuff [~anchela]! +1

> Allow to spot User.disable with a new, dedicated UserAction
> ---
>
> Key: OAK-7900
> URL: https://issues.apache.org/jira/browse/OAK-7900
> Project: Jackrabbit Oak
>  Issue Type: New Feature
>  Components: security-spi
>Reporter: angela
>Assignee: angela
>Priority: Major
> Fix For: 1.10
>
> Attachments: OAK-7900.patch
>
>
> [~chaotic], as discussed off list we lack the ability to react to 
> {{User.disable(String)}} with the current {{AuthorizableAction}} interface, 
> while at the same time encouraging API consumers to disable users instead of 
> removing them.
> One use case for such a method would be deleting additional information 
> stored with the user account such as e.g. profile data, preferences, as soon 
> as the user gets disabled.
> Since extending {{AuthorizableAction}} would require a major bump of the 
> exported version, I would suggest to introduce a new {{UserAction}} 
> interface, providing that new method, in correspondance to {{GroupAction}}, 
> which covers group specific actions. And, in an ideal world 
> {{AuthorizableAction.onPasswordChange}} would also reside with {{UserAction}}.
> [~stillalex], wdyt?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OAK-7780) Oak should compile & test on Java 12

2018-11-15 Thread Julian Reschke (JIRA)


[ 
https://issues.apache.org/jira/browse/OAK-7780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687682#comment-16687682
 ] 

Julian Reschke commented on OAK-7780:
-

New issue with Version 19 (2018/11/8): OAK-7906

> Oak should compile & test on Java 12
> 
>
> Key: OAK-7780
> URL: https://issues.apache.org/jira/browse/OAK-7780
> Project: Jackrabbit Oak
>  Issue Type: Epic
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Major
>
> (umbrella issue for tracking changes)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OAK-7906) StackOverFlowError SessionStatsTest.testInitStackTraceEnabledAfterOpeningManySessions with jdk-12

2018-11-15 Thread Julian Reschke (JIRA)
Julian Reschke created OAK-7906:
---

 Summary: StackOverFlowError 
SessionStatsTest.testInitStackTraceEnabledAfterOpeningManySessions with jdk-12
 Key: OAK-7906
 URL: https://issues.apache.org/jira/browse/OAK-7906
 Project: Jackrabbit Oak
  Issue Type: Bug
  Components: jcr
Affects Versions: 1.9.11
Reporter: Julian Reschke






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)